Re: post-review diff upload error on windows XP
I wanted execute svn diff recursively but found could not generate one. But now I found if i run svn diff from the svn root directory it handles all changes recursively. On Aug 9, 12:24 pm, Christian Hammond chip...@chipx86.com wrote: I'm not sure what you mean exactly. Is it not generating a diff with all files recursively, or is there some reason why doing it recursively isn't good enough?... read more » Are you using the post-review tool? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 9, 2010 at 12:21 AM, Chetan chetan@gmail.com wrote: I got reviewboard working for subversion including https. In svn diff we cannot generate recursive diff coz of which we may have to generate folder specific diffs. Is there a way around this? Thanks for the support. On Aug 5, 11:55 am, Christian Hammond chip...@chipx86.com wrote: As long as you have the $sitedir/data directory writable by the web server's user, you should be able to get https working. If you already had the repository entry in there from RB 1.0.x, go back to that repository and save it again. It should attempt to verify the certificate and then ask you for confirmation. If that data directory is writable, it will store it there and it should just work from then on read more » Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Aug 4, 2010 at 10:28 PM, Chetan chetan@gmail.com wrote: Thank a ton. Review board with svn is working for me. svn project is using just local protocol authentication like svn://prj and not on https. I still get errors for https projects. What are the steps to configure reviewboard to use with https configured svn projects? Once i have completed svn configiration will start to work on clearcase issue. You asked me to enable logging to debug clearcase issue, wer shud i enable it. Is it the same one under reviewboard- settinges- logging - enable logging option? On Aug 4, 9:33 am, Christian Hammond chip...@chipx86.com wrote: You'll need to use svn diff. TortoiseSVN's diffs aren't compatible read more » I strongly recommend using our post-review tool (part of RBTools) to create and update review requests, as it works around some problems in standard SVN diffs as well. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Aug 3, 2010 at 9:31 PM, Chetan chetan@gmail.com wrote: Is it a problem with the diff format? The date and time in diff output file is in Tue Jul 27 12:34:43 2010 format , I changed it to 2010-07-27 12:34:43 2010 format and uploaded but has not helped in sovling the issue. On Aug 2, 4:18 pm, Chetan chetan@gmail.com wrote: I have used TortoiseSVN diff and selected create unified diff option to create the diff in unified format. On Aug 2, 1:44 pm, Christian Hammond chip...@chipx86.com wrote: How did you generate the diff? It looks like the diff contains a date string instead of revision information read more » Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 2, 2010 at 1:11 AM, Chetan chetan@gmail.com wrote: I have changed the Traceback Switch to copy-and-paste view mode and pasting the errors. Environment: Request Method: POST Request URL:http://172.24.1.107/reviewboard_lgsi/r/new/ Django Version: 1.2.1 Python Version: 2.5.2 Installed Applications: ['django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.markup', 'django.contrib.sites', 'django.contrib.sessions', 'djblets.datagrid', 'djblets.feedview', 'djblets.log', 'djblets.siteconfig', 'djblets.util', 'djblets.webapi', 'reviewboard.accounts', 'reviewboard.admin', 'reviewboard.changedescs', 'reviewboard.diffviewer', 'reviewboard.iphone', 'reviewboard.notifications', 'reviewboard.reports', 'reviewboard.reviews', 'reviewboard.scmtools', 'reviewboard.webapi', 'django_evolution'] Installed Middleware: ('django.middleware.gzip.GZipMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.doc.XViewMiddleware',
cookies enabled issue.
Hi, Is there any work around to enable cookies to access reviewboard. The company security policy dosen't allow to enable the cookies. This might have been discussed in previous threads,I just need guidance on the apache config file where i can bypass the cookies must be anabled issue. Has anyone tried this? Any help on this will be appreciated. I'm using mod_python. Regards, Ranjan. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ClearCase and Reviewboard setup Continues...
Hi Karthik, I am facing the same upload diff hanging issue with post-review and webUI both. Any idea how to resolve this? My repository type is ClearCase and path is K:/ (clearcase drive). Please let me know how to resolve this issue. Regards, Shambhu. On Aug 11 2009, 11:15 am, Karthikeyan S karthikeyan1...@gmail.com wrote: I think I got it from here, http://sourceforge.net/projects/gnuwin32/files/patch/ Karthik On Thu, Aug 6, 2009 at 8:37 AM, jianquan bianjianq...@gmail.com wrote: hi Karthik where can i download the GNU-Patch.exe file? I meet the same issue as you. On Jul 22, 10:43 pm, Karthik karthikeyan1...@gmail.com wrote: ( I was not able to post it in the same thread, it always error encountered). Hi, I could post the diff into the review board server. It is no more hanging after considering Dan's suggestion(Changing the repository path to the drive). I was facing another issue after this. When I click to see the view-diff in the review request, I was getting following error. [Errno 2] No such file or directory: 'd:\\temp\\reviewboard.7px08a\ \tmpgjsi_l-new' Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 131, in patch f = open(newfile, r) IOError: [Errno 2] No such file or directory: 'd:\\temp\\reviewboard. 7px08a\\tmpgjsi_l-ne I had to install the GNU-Patch.exe and put it under apache webserver bin path to solve this issue. As of now, everything seems to be going fine till now!! :) Thanks, Karthik -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Email integration
I have no problem with someone writing this support, but it's not trivial to do correctly. It also requires a great deal of setup on the server to be able to intercept e-mails properly, and would I think be a support nightmare. We've decided for the time-being not to take on this work as part of Review Board. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 9, 2010 at 2:09 PM, Yang Zhang yanghates...@gmail.com wrote: Any plans for building fuller email integration, so that folks can reply to reviews from email and have discussions without needing to go back to the website? -- Yang Zhang http://yz.mit.edu/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue starting up reviewboard - Key Error
Looks like there's no PATH environment variable for your user. I haven't seen that problem before, but it should be fairly easy to fix. You'll basically need to have your Apache configuration set the environment variable to standard directories (/bin:/usr/bin:/usr/local/bin). I think if you use the SetEnv directive, it should filter down to the FastCGI binary, though I'm not 100% sure on that. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Aug 7, 2010 at 3:08 PM, Arun Saini asain...@gmail.com wrote: I am trying to install reviewboard. I finally got it setup using Apache +FasCGI - couldn't get mod_python to work in my environment. When I try to access the app, I get the 500 error. On enabling Debug, I see the following traceback Traceback: File /usr/local/lib/python2.7/site-packages/Django-1.2.1-py2.7.egg/ django/core/handlers/base.py in get_response 80. response = middleware_method(request) File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.0.9- py2.7.egg/reviewboard/admin/middleware.py in process_request 32. if (check_updates_required() and File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.0.9- py2.7.egg/reviewboard/admin/checks.py in check_updates_required 59. if not is_exe_in_path('patch'): File /usr/local/lib/python2.7/site-packages/Djblets-0.6.3-py2.7.egg/ djblets/util/filesystem.py in is_exe_in_path 44. for dir in os.environ['PATH'].split(os.pathsep): File /usr/local/lib/python2.7/UserDict.py in __getitem__ 23. raise KeyError(key) Exception Type: KeyError at / Exception Value: 'PATH' It seems to be something wrong with my environment but being new to Python, I cannot really figure this out. Any pointers are appreciated. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: rb-site and mysql socket
Hi, We go through Django for all the database connectivity, so we don't actually have much control over this. What socket should it be using? Can you show me the exact output when running rb-site? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 9, 2010 at 1:02 PM, freetonik freeto...@gmail.com wrote: Hello! rb-site script tries to use '/var/lib/mysql/mysql.sock' socket by default. I cannot figure out how to tell it to use another file? (I don't have root access, so I cannot create symlink from '/var/lib/ mysql/mysql.sock') Mysql's my.cnf file is configured, but python-mysql still doesn't care. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ClearCase and Reviewboard setup Continues...
Hi Karthik, I followed the link, but didn't get it working. I have put K:/ as drive letter. Regards, Shambhu. On Tue, Aug 10, 2010 at 1:16 PM, Karthikeyan S karthikeyan1...@gmail.comwrote: Hi Shambhu, Please look at the last mail sent by Dan Savilonis in the thread link given below, http://groups.google.com/group/reviewboard/browse_thread/thread/1a6124f46fd926a/5cc7b4f94af09873?lnk=gstq=karthik#5cc7b4f94af09873 Hope it helps. Thanks, Karthik On Tue, Aug 10, 2010 at 12:57 PM, Shambhu shambhu.1...@gmail.com wrote: Hi Karthik, I am facing the same upload diff hanging issue with post-review and webUI both. Any idea how to resolve this? My repository type is ClearCase and path is K:/ (clearcase drive). Please let me know how to resolve this issue. Regards, Shambhu. On Aug 11 2009, 11:15 am, Karthikeyan S karthikeyan1...@gmail.com wrote: I think I got it from here, http://sourceforge.net/projects/gnuwin32/files/patch/ Karthik On Thu, Aug 6, 2009 at 8:37 AM, jianquan bianjianq...@gmail.com wrote: hi Karthik where can i download the GNU-Patch.exe file? I meet the same issue as you. On Jul 22, 10:43 pm, Karthik karthikeyan1...@gmail.com wrote: ( I was not able to post it in the same thread, it always error encountered). Hi, I could post the diff into the review board server. It is no more hanging after considering Dan's suggestion(Changing the repository path to the drive). I was facing another issue after this. When I click to see the view-diff in the review request, I was getting following error. [Errno 2] No such file or directory: 'd:\\temp\\reviewboard.7px08a\ \tmpgjsi_l-new' Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 131, in patch f = open(newfile, r) IOError: [Errno 2] No such file or directory: 'd:\\temp\\reviewboard. 7px08a\\tmpgjsi_l-ne I had to install the GNU-Patch.exe and put it under apache webserver bin path to solve this issue. As of now, everything seems to be going fine till now!! :) Thanks, Karthik -- If linux doesn't have a solution, then u have a wrong problem. Shambhu Kumar Sharma 91-98864 91913 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Handling non-linear DVCS histories (git)
On 08/09/2010 02:32 PM, Yang Zhang wrote: I'm using reviewboard with git projects, and I'm interested in hearing how other folks are handling non-linear DVCS histories. Each commit may have one or two parents - for those with two, how does one generate a patch from that (if you do at all)? Thanks. I wrote a patch for git patchsets in post-review a long while ago: http://reviews.reviewboard.org/r/1472/ It got two ShipIt replies, but Christian opted not to push it upstream. I'm told there's a Google Summer of Code student working on improving the DVCS support, but I'm still using my patch for my project. Basically, my approach to git is to create a new branch from the upstream master and then cherry-pick commits onto it. Then I run my modified post-review command which auto-generates a separate review for each patch. It constructs the parent diff for each one after the first in the branch. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: rb-site and mysql socket
* Installing the site... Building site directories ... OK Building site configuration files ... OK Creating database ... Traceback (most recent call last): File /project/radio_ott/Python/bin/rb-site, line 7, in ? sys.exit( File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 1604, in main command.run() File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 1170, in run self.show_install_status() File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 1429, in show_install_status site.sync_database) File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 696, in step func() File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 332, in sync_database self.run_manage_command(syncdb, params) File /project/radio_ott/Python/lib/python2.4/site-packages/ ReviewBoard-1.5rc1-py2.4.egg/reviewboard/cmdline/rbsite.py, line 390, in run_manage_command execute_manager(reviewboard.settings, [__file__, cmd] + params) File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/__init__.py, line 438, in execute_manager utility.execute() File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/__init__.py, line 379, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/base.py, line 191, in run_from_argv self.execute(*args, **options.__dict__) File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/base.py, line 217, in execute self.validate() File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/base.py, line 245, in validate num_errors = get_validation_errors(s, app) File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/core/management/validation.py, line 86, in get_validation_errors connection.validation.validate_field(e, opts, f) File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/db/backends/mysql/validation.py, line 14, in validate_field db_version = self.connection.get_server_version() File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/db/backends/mysql/base.py, line 313, in get_server_version self.cursor() File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/db/backends/__init__.py, line 75, in cursor cursor = self._cursor() File /project/radio_ott/Python/lib/python2.4/site-packages/ Django-1.2.1-py2.4.egg/django/db/backends/mysql/base.py, line 297, in _cursor self.connection = Database.connect(**kwargs) File /project/radio_ott/Python/lib/python2.4/site-packages/PIL/ __init__.py, line 81, in Connect File /project/radio_ott/Python/lib/python2.4/site-packages/ MySQL_python-1.2.3-py2.4-linux-i686.egg/MySQLdb/connections.py, line 187, in __init__ _mysql_exceptions.OperationalError: (2002, Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (2)) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error creating review request using post-review
Hi Christian I managed to get it working as below (just in case these tips come handy for anyone else) My working env is 1) ReviewBoard 1.5 installed on RHEL4 with Python 2.4, Subversion 1.4 server, Apache 2.2, Django 1.2 2) Tortoise SVN Client on Windows (1.6) to access SVN over https only. (http: read-only) 3) Using review-on-commit.py hook from http://github.com/reviewboard/reviewboard/tree/master/contrib/tools to create review request upon commit 4) Reviewboard installed at http://server/reviewboard/ Modified the review-on-commit.py script and added 'HOME' : '/tmp' to the line env = {'LANG': 'en_US.UTF-8'} data = execute([os.path.join(POSTREVIEW_PATH, 'post-review')] + args, env = {'LANG': 'en_US.UTF-8', 'HOME': '/tmp'}) On Aug 10, 4:04 am, Christian Hammond chip...@chipx86.com wrote: What happens if you use a fully-qualified domain? Say, server.yourdomain.com. This sounds like a cookie storage issue. I don't believe Python's HTTP library stores cookies for non-fully-qualified domains, though I'd hope it would at least work for that session... Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 9, 2010 at 1:49 PM, ReviewBoard User lalitha.viswan...@gmail.com wrote: 1. ReviewBoard 1.5 2. Apache 2.2 3. SVN 1.4 4. Python 2.4 Am trying to post a review on a post-commit hook from subversion Running the below command /usr/bin/post-review --server=http://server/reviewboard/--repository- url=file:///var/svn/repositories/sandbox/ --username=svn '-- password=svn' '--submit-as=svn' '--revision-range=4493:4494' '-- publish' '--summary=testing reviewboard creation' '--description=(In [4494]) testing reviewboard creation' -d This is the output I get from post-review. svn info file:///var/svn/repositories/sandbox/ diff --version repository info: Path: file:///var/svn/repositories/sandbox, Base path: /, Supports changesets: False svn diff --diff-cmd=diff file:///var/svn/repositories/sandbox/@4493 file:///var/svn/repositories/sandbox/@4494 Looking for 'server/reviewboard/' cookie in /home/svn/.post-review-cookies.txt Cookie file loaded, but no cookie for this server == Review Board Login Required Enter username and password for Review Board athttp://server/reviewboard/ Logging in with username svn HTTP POSTing tohttp://server/reviewboard/api/json/accounts/login/: {'username': 'svn', 'password': '**'} Logged in. HTTP GETting /api/json/repositories/ HTTP GETting /api/json/repositories/1/info/ repository info: Path:https://server/svn/sandbox, Base path: /, Supports changesets: False Attempting to create review request onhttps://server/svn/sandboxfor None Submitting the review request as svn HTTP POSTing tohttp://server/reviewboard/api/json/reviewrequests/new/: {'repository_path': 'https://vhabosapp8/svn/sandbox', 'submit_as': 'sandbox'} Got API Error 103 (HTTP code 200): You are not logged in Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'err': {'msg': 'You are not logged in', 'code': 103}} == Review Board Login Required Enter username and password for Review Board athttp://server/reviewboard/ Logging in with username svn HTTP POSTing tohttp://server/reviewboard/api/json/accounts/login/: {'username': 'svn', 'password': '**'} Logged in. Attempting to create review request onhttps://server/svn/sandboxfor None Submitting the review request as svn HTTP POSTing tohttp://server/reviewboard/api/json/reviewrequests/new/: {'repository_path': 'https://server/svn/sandbox', 'submit_as': 'svn'} Got API Error 103 (HTTP code 200): You are not logged in Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'err': {'msg': 'You are not logged in', 'code': 103}} == Review Board Login Required Enter username and password for Review Board athttp://server/reviewboard/ Logging in with username svn HTTP POSTing tohttp://server/reviewboard/api/json/accounts/login/: {'username': 'svn', 'password': '**'} Logged in. Attempting to create review request onhttps://server/svn/sandboxfor None Submitting the review request as svn HTTP POSTing tohttp://server/reviewboard/api/json/reviewrequests/new/: {'repository_path': 'https://server/svn/sandbox', 'submit_as': 'svn'} Got API Error 103 (HTTP code 200): You are not logged in Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail', 'err': {'msg': 'You are not logged in', 'code': 103}} == Review Board Login Required Enter username and password for Review Board athttp://server/reviewboard/ Logging in with username svn HTTP POSTing tohttp://server/reviewboard/api/json/accounts/login/: {'username': 'svn', 'password': '**'} Logged in. Attempting to create review request onhttps://server/svn/sandboxfor None
Re: rb-site and mysql socket
and I want it to use the socket for mysql I've installed in custom folder: /project/blah-blah/mysql.sock On Aug 10, 4:11 am, Christian Hammond chip...@chipx86.com wrote: Hi, We go through Django for all the database connectivity, so we don't actually have much control over this. What socket should it be using? Can you show me the exact output when running rb-site? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Aug 9, 2010 at 1:02 PM, freetonik freeto...@gmail.com wrote: Hello! rb-site script tries to use '/var/lib/mysql/mysql.sock' socket by default. I cannot figure out how to tell it to use another file? (I don't have root access, so I cannot create symlink from '/var/lib/ mysql/mysql.sock') Mysql's my.cnf file is configured, but python-mysql still doesn't care. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Help with git configuration
Hi Yang, This actually brings up a good point. I don't think there currently is a 'better' solution. I hope Christian can perhaps chime in on this, since RB is using git itself. The conventional way to set this up is to configure the mirror url, but this assumes that the client fetch from a remote with the exact same path. This doesn't work well for a number of reasons since it might not even be cloned from the same server, or it might use implicit vs explicit ssh notation, or use a non-fqdn, etc. I think we need to address this somehow. On the post-review side, my thought was to add an option for .reviewboardrc to specify the 'repository url'. However, there clearly should be some improvement on the server side as well, as a fixed 'mirror' field just isn't good enough to comprehensively match a repository. Any thoughts on what we could do there? As for your second problem, post-review requires a non-bare repository as it tries to automatically determine the diff of your current work. You may want to try the revision-range option to explicitly set the revision range. I haven't confirmed that this will work in a bare repository, but it should be easy to make it if it doesn't. Dan On Aug 6, 5:48 pm, Yang Zhang yanghates...@gmail.com wrote: I'm trying to automate post-review to run on a git repository -- ideally on each commit (on the client side), but on each push (on the central repo) would do too if necessary. In both the following I ran git config reviewboard.urlhttps://dev/review/;. First I tried post-review on a client repo (also tried specifying --repository-url=/var/git/web.git, which is the local URL that the reviewboard web app knows): ~~~ $ post-review --revision-range=9405af7d9a75c17 03b88924021fc9f2677c4776b == HTTP Authentication Required Enter username and password for dev at dev Username: yang Password: There was an error creating this review request. The repository path ssh://dev/var/git/web.git is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please readhttp://www.reviewboard.org/docs/manual/dev/admin/management/repositor... ~~~ I thought about trying to set up a mirror URL in the reviewboard web app, but the URL might look different to each client. On the server, the repository is headless, resulting in this error: ~~~ $ post-review Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] fatal: Not a git repository (or any of the parent directories): .git ~~~ After Googling I foundhttp://gitorious.org/reviewboard/rbtools/blobs/master/scripts/git-pos... but it's broken out of date. There are more hacks I can try (e.g. having the post-commit hook temporarily munge the remote origin URL, or having the post-receive hook clone the git repository so that it has a head, then post-review-ing that), but surely there's a better way. Thanks in advance for any hints. -- Yang Zhanghttp://yz.mit.edu/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Handling non-linear DVCS histories (git)
My general workflow is to create a topic branch tracking one of the official branches on a remote server and let post-review detect the merge base. This generates a diff between the last state of that branch and my changes. I don't use RB for merge reviews. It would be good if we got an update on the GSOC git project. I thought the students were required to show progress... If it doesn't go anywhere, we definitely need to add some better handling for more distributed workflows. Dan On Aug 10, 7:59 am, Stephen Gallagher step...@gallagherhome.com wrote: On 08/09/2010 02:32 PM, Yang Zhang wrote: I'm using reviewboard with git projects, and I'm interested in hearing how other folks are handling non-linear DVCS histories. Each commit may have one or two parents - for those with two, how does one generate a patch from that (if you do at all)? Thanks. I wrote a patch for git patchsets in post-review a long while ago:http://reviews.reviewboard.org/r/1472/ It got two ShipIt replies, but Christian opted not to push it upstream. I'm told there's a Google Summer of Code student working on improving the DVCS support, but I'm still using my patch for my project. Basically, my approach to git is to create a new branch from the upstream master and then cherry-pick commits onto it. Then I run my modified post-review command which auto-generates a separate review for each patch. It constructs the parent diff for each one after the first in the branch. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Mercurial, Internal Server Error, RepoError...
On Aug 10, 2010, at 1:00 AM, Christian Hammond wrote: It sounds like the publickey method didn't work correctly. Are the files in data/.ssh/ owned by the web server's user, and contain the right permissions? Yes: r...@reviewboard:/var/www/reviewboard/data# ls -alrt total 12 drwxr-xr-x 3 www-data www-data 4096 Aug 9 18:18 . drwxr-xr-x 7 www-data www-data 4096 Aug 9 18:59 .. drwxr-xr-x 2 www-data www-data 4096 Aug 10 17:40 .ssh r...@reviewboard:/var/www/reviewboard/data/.ssh# ls -lrt total 12 -rw-r--r-- 1 www-data www-data 396 Aug 9 18:18 known_hosts -rw--- 1 www-data www-data 1743 Aug 9 18:54 id_rsa_ipstreet -rw-r--r-- 1 www-data www-data 80 Aug 9 21:45 config There was another issue we saw recently involving paramiko (the library we use to handle SSH connections), so we're trying to collect all the data we can. I'm ready, willing, and able to run tests or gather data for you. Tell me how I can help! John -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How long cache is stored. Can it be stored endlessly?
One of the issue for out team is having all review request broken if repository is moved. We wondered if it's possible to have cache stored forever and diff being showable even if repository is not accessible? (of course, without expand option). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How long cache is stored. Can it be stored endlessly?
I think what you really want is for moving the repository to not break anything. What exactly do you mean when you say it's moving? Is it the same repository but in a new location? Or are you doing new work on a new repository but keeping the old one around? You won't get persistent caching unless you're using something like a file-based cache (which is far less efficient than memcached), with an unlimited cache size. I still wouldn't recommend it, but you could do it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Aug 10, 2010 at 11:16 AM, sergius sergey.serg...@googlemail.comwrote: One of the issue for out team is having all review request broken if repository is moved. We wondered if it's possible to have cache stored forever and diff being showable even if repository is not accessible? (of course, without expand option). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Reviewboard - Add attachments feature
Hi, Once we post a review, we need to add in attachments sometimes along with the review (to include binary file/.dll files). Do we know when this feature will be implemented to RB to upload attachments ? Thanks, Sapna -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewboard - Add attachments feature
This is planned for 1.6. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Aug 10, 2010 at 2:07 PM, Sapna sapnavemp...@gmail.com wrote: Hi, Once we post a review, we need to add in attachments sometimes along with the review (to include binary file/.dll files). Do we know when this feature will be implemented to RB to upload attachments ? Thanks, Sapna -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewboard - Add attachments feature
Thanks Christian ! On Tue, Aug 10, 2010 at 2:17 PM, Christian Hammond chip...@chipx86.comwrote: This is planned for 1.6. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Aug 10, 2010 at 2:07 PM, Sapna sapnavemp...@gmail.com wrote: Hi, Once we post a review, we need to add in attachments sometimes along with the review (to include binary file/.dll files). Do we know when this feature will be implemented to RB to upload attachments ? Thanks, Sapna -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1754 in reviewboard: Ability to mark repository as hidden or inactive
Updates: Status: NotABug Comment #2 on issue 1754 by chipx86: Ability to mark repository as hidden or inactive http://code.google.com/p/reviewboard/issues/detail?id=1754 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1756 in reviewboard: Download Diff button doesn't download the diff file in Safari
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1756 by email.app: Download Diff button doesn't download the diff file in Safari http://code.google.com/p/reviewboard/issues/detail?id=1756 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.9 What's the URL of the page containing the problem? http://private/codereviews/r/1/ What steps will reproduce the problem? 1. View a review in Safari 5.0.1 on Mac OS X 10.6.4. 2. Click the Download Diff button. What is the expected output? What do you see instead? I expected Safari to download the diffs as a file, and not change the viewed page. Instead, the viewed page changes to http://private/codereviews/r/1/diff/raw/ , and the diffs are viewed as a text file in Safari. What operating system are you using? What browser? Mac OS X 10.6.4, Safari 5.0.1. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1757 in reviewboard: MySQL support on Mac OS X Server requires downloading the developer pieces
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1757 by email.app: MySQL support on Mac OS X Server requires downloading the developer pieces http://code.google.com/p/reviewboard/issues/detail?id=1757 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/admin/installation/linux/#id2 Describe the problem and any recommendations below. Using MySQL on Mac OS X Server requires that you install the development pieces first. Those can be found at http://opensource.apple.com/ under the particular OS version. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1758 in reviewboard: The Linux installation instructions also apply to Mac OS X Server
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1758 by email.app: The Linux installation instructions also apply to Mac OS X Server http://code.google.com/p/reviewboard/issues/detail?id=1758 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/admin/#administrationguide http://www.reviewboard.org/docs/manual/1.0/admin/installation/linux/ Describe the problem and any recommendations below. There should be some mention that the Linux instructions apply to Mac OS X Server as well. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1759 in reviewboard: Some Python modules are pre-installed on some OSes
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1759 by email.app: Some Python modules are pre-installed on some OSes http://code.google.com/p/reviewboard/issues/detail?id=1759 What's the URL of the page containing the problem? http://www.reviewboard.org/docs/manual/1.0/admin/installation/linux/ Describe the problem and any recommendations below. I was a little confused about just which packages I needed to download on Mac OS X Server. Maybe the command pydoc modules could be mentioned (or a better command to validate the installed modules/versions). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1760 in reviewboard: Security issue: media folder is opened for file browsing
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1760 by yerges: Security issue: media folder is opened for file browsing http://code.google.com/p/reviewboard/issues/detail?id=1760 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5 RC1 What's the URL of the page containing the problem? http://demo.reviewboard.org/media/ What steps will reproduce the problem? 1. Click http://demo.reviewboard.org/media/ 2. View file information which is usually secure What is the expected output? What do you see instead? EXPECTED: redirect to main page or HTTP Error 401 Unauthorized What operating system are you using? What browser? generic Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.