Re: Error uploading new diff: fatal: Not a git repository: 'None'
I just reproduced this while trying to use RB 1.5.2 with a custom
remote repository (git+ssh://).
By trial-and-error, it seems the 'None' error occurs if the Raw file
URL mask field is empty.
Is it correct to say there's no way to set up a git repository in
Review Board, if the git server is remote and you have no web-based
access to it?
Regards,
Chris
On Jan 26, 6:02 am, Christian Hammond chip...@chipx86.com wrote:
Honestly, I have no idea where None is coming from.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Jan 25, 2011 at 8:25 AM, mhoydis michael.hoy...@gmail.com wrote:
Sure. I think the notable clues here are...
Attempting to create review request on git@server:my_project.git for
None
and...
Error data: {u'fields': {u'path': [ufatal: Not a git repository:
'None'\n]}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}, u'deprecated': {u'in_version': u'1.5'}}
and...
ERROR:root:Error uploading new diff: fatal: Not a git repository:
'None'
-
What value is None referring to, here?
-Michael
On Jan 24, 7:11 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Michael,
Would you mind (privately, if you like) showing me the repository
configuration on the server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Jan 24, 2011 at 2:58 PM, mhoydis michael.hoy...@gmail.com
wrote:
Trying to use post-review with our custom git setup. My repository is
configured in ReviewBoard with the path being
git@server:my_project.git. I've setup the SSH key in ReviewBoard to
use that git URL, and confirmed that's working. ReviewBoard 1.6
alpha 0 (dev)
I'm running this command on my Mac desktop:
git config reviewboard.urlhttp://reviewboard.mydomain.com
post-review --parent=aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee --
revision-range=aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee:
1015d188c7d28c3b543b1e528ab34e8ee2a62cdf --guess-summary --guess-
description --publish --debug
-
This is the error I'm getting from post-review on my Mac desktop:
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
git svn --version
git config --get svn-remote.svn.url
git config --get branch.master.merge
git config --get branch.master.remote
git config remote.origin.url
repository info: Path: git@server:my_project.git, Base path: ,
Supports changesets: False
git config --get reviewboard.url
git log --pretty=format:%s
aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
git log --pretty=format:%s%n%n%b
aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
git diff --no-color --full-index
aa1c05d4bab33156cd3feaeb8ea6ed669eb92eee..1015d188c7d28c3b543b1e528ab34e8ee2a62cdf
Looking for 'reviewboard.mydomain.com /' cookie in
/Users/myuser/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on git@server:my_project.git
for
None
HTTP POSTing to
http://reviewboard.mydomain.com/api/json/reviewrequests/new/:
{'repository_path': 'git@server:my_project.git'}
Review request created
Attempting to set field 'summary' to 'Blah Blah #3135 - Blah blah
blah
yadayadaydada * blH, BAH, bah, New(template) added * blah written
for
model, controller(blah, hey), and New hey * Refactored component and
blah
authorization specs into seperate files * Added Administration
namespace'
for review request '48'
HTTP POSTing to
http://reviewboard.mydomain.com/api/json/reviewrequests/48/draft/set/:
{'summary': 'Blah Blah #3135 - Blah blah blah yadayadaydada * blH,
BAH,
bah, New(template) added * blah written for model, controller(blah,
hey),
and New hey * Refactored component and blah authorization specs into
seperate files * Added Administration namespace'}
Attempting to set field 'description' to 'Blah Blah #3135 - Blah
blah
blah yadayadaydada * blH, BAH, bah, New(template) added * blah
written
for model, controller(blah, hey), and New hey * Refactored component
and
blah authorization specs into seperate files * Added Administration
namespace' for review request '48'
HTTP POSTing to
http://reviewboard.mydomain.com/api/json/reviewrequests/48/draft/set/:
{'description': 'Blah Blah #3135 - Blah blah blah yadayadaydada *
blH,
BAH, bah, New(template) added * blah written for model,
controller(blah,
hey), and New hey * Refactored component and blah authorization specs
into
seperate files * Added
Re: Finding review request id in UI
You can see the ReviewID on the dashboard if you add that column, at least in 1.0 you can. Scott On Tue, Feb 1, 2011 at 4:24 PM, Henry Yei henry@gmail.com wrote: Hi, I'm starting to roll out ReviewBoard into our development process and am considering forcing a valid completed reviewboard request before a successful commit. Is there an option to show the ID in the UI where we can show the Review ID more prominently? It looks like the id is only reported when created via the postreview tool and if you inspect the URL. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Finding review request id in UI
Thanks for the tip. I'm still a little unfamiliar with the UI itself and completely missed that. is there a way to configure the default visible columns for all users? I wonder if 1.6 include the review ID in the search index? On Wed, Feb 2, 2011 at 6:20 AM, Scott Quesnelle scott.quesne...@gmail.comwrote: You can see the ReviewID on the dashboard if you add that column, at least in 1.0 you can. Scott On Tue, Feb 1, 2011 at 4:24 PM, Henry Yei henry@gmail.com wrote: Hi, I'm starting to roll out ReviewBoard into our development process and am considering forcing a valid completed reviewboard request before a successful commit. Is there an option to show the ID in the UI where we can show the Review ID more prominently? It looks like the id is only reported when created via the postreview tool and if you inspect the URL. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
Yeah, unfortunately, Git provides no way to access individual files from a remote repository without a full local clone, which is why the only two options are having that clone or accessing over gitweb or a similar service. We should definitely do better validation to make sure you can never enter a remote URL without the raw file mask. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 2, 2011 at 11:42 AM, Stephen Gallagher step...@gallagherhome.com wrote: On 02/02/2011 08:12 AM, Christopher Orr wrote: I just reproduced this while trying to use RB 1.5.2 with a custom remote repository (git+ssh://). By trial-and-error, it seems the 'None' error occurs if the Raw file URL mask field is empty. Is it correct to say there's no way to set up a git repository in Review Board, if the git server is remote and you have no web-based access to it? In that situation, I think what you would want to do is clone the git repository locally and use a cron job to keep it up to date with the remote repository. That's probably the only way around this. Or, if you have control of the remote repository, add a post-commit hook that notifies your clone to update itself (this would be less wasteful of network resources). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Finding review request id in UI
We will likely be making it possible to type in a review request ID and immediately get the review request in an auto-complete dropdown in the search box. There's no way to change the default columns for users. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 2, 2011 at 6:25 AM, Henry Yei henry@gmail.com wrote: Thanks for the tip. I'm still a little unfamiliar with the UI itself and completely missed that. is there a way to configure the default visible columns for all users? I wonder if 1.6 include the review ID in the search index? On Wed, Feb 2, 2011 at 6:20 AM, Scott Quesnelle scott.quesne...@gmail.com wrote: You can see the ReviewID on the dashboard if you add that column, at least in 1.0 you can. Scott On Tue, Feb 1, 2011 at 4:24 PM, Henry Yei henry@gmail.com wrote: Hi, I'm starting to roll out ReviewBoard into our development process and am considering forcing a valid completed reviewboard request before a successful commit. Is there an option to show the ID in the UI where we can show the Review ID more prominently? It looks like the id is only reported when created via the postreview tool and if you inspect the URL. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
Thanks for the confirmation. Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call git clone any time someone hits Upload diff? Chris On Feb 2, 10:18 pm, Christian Hammond chip...@chipx86.com wrote: Yeah, unfortunately, Git provides no way to access individual files from a remote repository without a full local clone, which is why the only two options are having that clone or accessing over gitweb or a similar service. We should definitely do better validation to make sure you can never enter a remote URL without the raw file mask. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Feb 2, 2011 at 11:42 AM, Stephen Gallagher step...@gallagherhome.com wrote: On 02/02/2011 08:12 AM, Christopher Orr wrote: I just reproduced this while trying to use RB 1.5.2 with a custom remote repository (git+ssh://). By trial-and-error, it seems the 'None' error occurs if the Raw file URL mask field is empty. Is it correct to say there's no way to set up a git repository in Review Board, if the git server is remote and you have no web-based access to it? In that situation, I think what you would want to do is clone the git repository locally and use a cron job to keep it up to date with the remote repository. That's probably the only way around this. Or, if you have control of the remote repository, add a post-commit hook that notifies your clone to update itself (this would be less wasteful of network resources). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2Bunsubscribe@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
On Feb 2, 10:47 pm, Christopher Orr ch...@orr.me.uk wrote: Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call git clone any time someone hits Upload diff? Oops, I meant git pull, not a full clone each time. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading new diff: fatal: Not a git repository: 'None'
Having Review Board manage the clone means adding new pieces of infrastructure for scheduling changes. At that point, you may as well use crontab. We don't want Review Board to do the pulls on demand, because you may end up with two requests happening at once, each causing a pull and generating conflicts. So it's something we basically need admins to handle themselves. The very easiest way is to get gitweb or something going. We're considering rolling our own little thing to stick on a server with a Git repository that Review Board will be able to know about and talk to in an effort to simplify a lot of this, but we're not there yet. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 2, 2011 at 1:47 PM, Christopher Orr ch...@orr.me.uk wrote: Thanks for the confirmation. Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call git clone any time someone hits Upload diff? Chris On Feb 2, 10:18 pm, Christian Hammond chip...@chipx86.com wrote: Yeah, unfortunately, Git provides no way to access individual files from a remote repository without a full local clone, which is why the only two options are having that clone or accessing over gitweb or a similar service. We should definitely do better validation to make sure you can never enter a remote URL without the raw file mask. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Feb 2, 2011 at 11:42 AM, Stephen Gallagher step...@gallagherhome.com wrote: On 02/02/2011 08:12 AM, Christopher Orr wrote: I just reproduced this while trying to use RB 1.5.2 with a custom remote repository (git+ssh://). By trial-and-error, it seems the 'None' error occurs if the Raw file URL mask field is empty. Is it correct to say there's no way to set up a git repository in Review Board, if the git server is remote and you have no web-based access to it? In that situation, I think what you would want to do is clone the git repository locally and use a cron job to keep it up to date with the remote repository. That's probably the only way around this. Or, if you have control of the remote repository, add a post-commit hook that notifies your clone to update itself (this would be less wasteful of network resources). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2Bunsubscribe@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP configuration
I'd be happy for someone with more knowledge and expertise with LDAP to step up and help get our LDAP configuration settings under control, provide better names, maybe some docs. Anyone want to help with that? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 28, 2011 at 8:43 AM, Rob rrom...@gmail.com wrote: I struggled a bit to make it work too, but here's what I finally used. I am running ReviewBoard on CentOS 5.2 under Apache/mod_python/Python 2.5.1/linux64. (The Python ldap module, linking to openldap libs I believe, is responsible for the actual connection.) LDAP server: ldap://serverhostname.example.com:389 LDAP base DN: dc=example,dc=com E-Mail Domain: leave blank E-mail LDAP attribute: mail Left Use TLS unchecked User Mask: ((objectclass=User) (mailNickname=%s)) - in our case, mailNickname is always the account name. I think 'sAMAccountName' is commonplace too. Basically extracts just the userid of the record. Our server requires a user to bind connect first, before doing the query. This is what Anonymous User Mask refers to (hint to RB authors: try renaming this field to something else?) For example, if 'jdoe' is the user I want to use for all lookups, on OU OrgUnit, you would put in: Anonymous User Mask: cn=jdoe,ou=OrgUnit,dc=example,dc=com Anonymous Password: ** -- just the password On Jan 28, 2:47 am, David courn...@gmail.com wrote: Hi, I am trying to get reviewboard authentificate through our LDAP infrastructure, but I cannot make it work (got the specified object does not exist). I don't know much about LDAP unfortunately, so I am not sure where the error lies. We got trac connecting to LDAP, but at the apache level, as followed: AuthName Company Name AuthLDAPURL ldap://x.x.x.x:389/ou=people,dc=x,dc=y,dc=z; AuthLDAPBindDN cn=admin,dc=x,dc=y,dc=z AuthLDAPBindPassword xx FWIW, I could not make it work using the python ldap library either: l = ldap.open(x.x.x.x:389) username = cn=admin,dc=x,dc=y,dc=z password = x l.simple_bind(username, password) # fails with (2, 'No such file or directory') -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Unable to login to RB Site as any user
Sucess ... With that change I was able to login into the Site. The AD authentification which was working earlier had been turned off due to the above setting. I turned it on and AD authentification started working. The AD name server were all in DNS name and not any IP Addresses. The logging was turned on. When I checked the log for the earlier attempts, it has printed nothing. There are repeated entries like : == Feb. 1, 2011 16:01:18 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 16:01:18 INFO Log file for Review Board v1.5.2 (PID 8901) Feb. 2, 2011 13:55:30 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 13:55:30 INFO Log file for Review Board v1.5.2 (PID 14739) 13:57:27 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 13:57:27 INFO Log file for Review Board v1.5.2 (PID 20021) 21:58:01 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 21:58:01 INFO Log file for Review Board v1.5.2 (PID 20026) Feb. 3, 2011 09:22:52 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 09:22:52 INFO Log file for Review Board v1.5.2 (PID 25530) 09:23:00 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 09:23:00 INFO Log file for Review Board v1.5.2 (PID 25529) 09:23:00 INFO Logging to /path/to/site/logs/reviewboard.log with a minimum level of DEBUG 09:23:00 INFO Log file for Review Board v1.5.2 (PID 25531) == I wonder what went wrong !!! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Cannot add repository with cvs ext in 1.5.2 on RHEL5
I managed to get some fixes working for rbssh for CVS. I have a couple other related bugs to fix, but you should see 1.5.3 probably by the end of the week. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 2, 2011 at 8:59 PM, praveen kumar kodaliprav...@gmail.comwrote: Hi Christian, Thanks for the work you are putting in to resolve this issue. I will downgrade to 1.5.1 and see how things will go. Thanks Praveen -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP configuration
1) Please try use Your data exactly in some other tool. I prefere Apache Directory Studio (http://directory.apache.org/studio/). Just use this same informations to connect with Your LDAP server 2) Maybe LDAP base dn need more specific place to start searching. Try to be more specific e.g. ou=OrgUnit,dc=example,dc=com 3) User mask: I use sAMAccountName as You said. If I remember well I also don't have (()()) just ()() (but for now I'm not sure). I know outer bracket is necessery but not in that case. Another thing. Isn't LDAP case sensitive? Should be objectClass ? 4) Try use this filter (replacing %s by Your username) and use as filter search in Apache Directory Studio 5) Try change format of UserMask to j...@orgunit.example.com The most important thing is 2) and if doesn't work 3) and 5). After that just try sniffing arround using Apache Directory Studio and just be careful about the details. On Thu, Feb 3, 2011 at 1:29 AM, Christian Hammond chip...@chipx86.com wrote: I'd be happy for someone with more knowledge and expertise with LDAP to step up and help get our LDAP configuration settings under control, provide better names, maybe some docs. Anyone want to help with that? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 28, 2011 at 8:43 AM, Rob rrom...@gmail.com wrote: I struggled a bit to make it work too, but here's what I finally used. I am running ReviewBoard on CentOS 5.2 under Apache/mod_python/Python 2.5.1/linux64. (The Python ldap module, linking to openldap libs I believe, is responsible for the actual connection.) LDAP server: ldap://serverhostname.example.com:389 LDAP base DN: dc=example,dc=com E-Mail Domain: leave blank E-mail LDAP attribute: mail Left Use TLS unchecked User Mask: ((objectclass=User) (mailNickname=%s)) - in our case, mailNickname is always the account name. I think 'sAMAccountName' is commonplace too. Basically extracts just the userid of the record. Our server requires a user to bind connect first, before doing the query. This is what Anonymous User Mask refers to (hint to RB authors: try renaming this field to something else?) For example, if 'jdoe' is the user I want to use for all lookups, on OU OrgUnit, you would put in: Anonymous User Mask: cn=jdoe,ou=OrgUnit,dc=example,dc=com Anonymous Password: ** -- just the password On Jan 28, 2:47 am, David courn...@gmail.com wrote: Hi, I am trying to get reviewboard authentificate through our LDAP infrastructure, but I cannot make it work (got the specified object does not exist). I don't know much about LDAP unfortunately, so I am not sure where the error lies. We got trac connecting to LDAP, but at the apache level, as followed: AuthName Company Name AuthLDAPURL ldap://x.x.x.x:389/ou=people,dc=x,dc=y,dc=z; AuthLDAPBindDN cn=admin,dc=x,dc=y,dc=z AuthLDAPBindPassword xx FWIW, I could not make it work using the python ldap library either: l = ldap.open(x.x.x.x:389) username = cn=admin,dc=x,dc=y,dc=z password = x l.simple_bind(username, password) # fails with (2, 'No such file or directory') -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository
Comment #7 on issue 1969 by chip...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 It won't accept it? What does it say? The path in the diff isn't saying that /myproject/trunk is the root, but that it's *in* the root. So, myproject is a subdirectory of the root. So it does look to me like /svn2 is the correct path. We need to figure out why it's not accepting that. Do you have some sort of complex ACL scheme for your SVN? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1968 in reviewboard: Trying to create a Bazaar repo returns: Unrecognised value for BZR_SSH environment variable: rbssh
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-High Milestone-Release1.5.x Component-SSH Comment #1 on issue 1968 by chip...@gmail.com: Trying to create a Bazaar repo returns: Unrecognised value for BZR_SSH environment variable: rbssh http://code.google.com/p/reviewboard/issues/detail?id=1968 Okay, regression in 1.5.2. Seems silly that they actually are limiting what can go in there. Looking into it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 387 in reviewboard: Error Control Characters not allowed
Comment #5 on issue 387 by spede...@gmail.com: Error Control Characters not allowed http://code.google.com/p/reviewboard/issues/detail?id=387 Using 1.5 and I too had to change diffutils.py. After that I didn't get the error anymore. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository
Comment #8 on issue 1969 by apsoftw...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 I am going to have to have some detailed conversations with the IT department. They did see some errors in the log last night: [Tue Feb 01 22:57:37 2011] [error] [client 10.1.1.16] Access denied: 'andyp' OPTIONS svn2:/ The error from the Web UI says this: Change repository Please correct the error below. * A repository was not found at the specified path. My assumption is that I have not been granted access to the root of SVN at this company. I only have access to the specific branch that I am on. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository
Comment #9 on issue 1969 by apsoftw...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 Configuration issue on my end. The solution was to have an account used that had access to the root of the project. It was confusing as I don't have permission at the root level (didn't know that), and the message was too generic to figure out what needed to change. Note that you might consider adding a link on how to find what the SVN root is supposed to be, to take away guesswork. svn info (on a source tree) gives the svn root needed. Thanks for your help! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1719 in reviewboard: post-review should support subversion changelists.
Comment #1 on issue 1719 by joedr...@gmail.com: post-review should support subversion changelists. http://code.google.com/p/reviewboard/issues/detail?id=1719 I made this change to help a friend out recently, which reuses the --label feature. This allows the normal usage of manually listing files to diff to continue to work, and offers an alternate path. It is used like this: post-review --label name_of_svn_changelist Seems to work great! Hope this helps someone. Attachments: svn_changelist_support.diff 1.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository
Comment #10 on issue 1969 by chip...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 Glad it works :) We do need more inline help. I think the docs cover what's needed to a degree. Either way, we'd need a separate bug report for that. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 387 in reviewboard: Error Control Characters not allowed
Updates: Status: Started Comment #6 on issue 387 by chip...@gmail.com: Error Control Characters not allowed http://code.google.com/p/reviewboard/issues/detail?id=387 Can you please submit a patch to http://reviews.reviewboard.org/? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files
Updates: Status: NeedInfo Comment #5 on issue 1670 by chip...@gmail.com: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 Are you sure it's UTF-8? We see people post actual UTF-8 all the time. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files
Comment #6 on issue 1670 by chip...@gmail.com: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 If someone can give us a change to our tree that reproduces this with post-review, that will greatly help. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1970 in reviewboard: postreview mangles repository path when protocol is part of path
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1970 by henry@gmail.com: postreview mangles repository path when protocol is part of path http://code.google.com/p/reviewboard/issues/detail?id=1970 What version are you running? RBTools 0.3 on ReviewBoard 1.5.1 What steps will reproduce the problem? 1. Create a CVS respository in ReviewBoard using :ext: 2. Checkout code from CVS respository where CVSROOT contains :ext: 3. Modify code and run post-review to generate review request. What is the expected output? What do you see instead? The expected output is a successful review request posted on ReviewBoard located at http://hyei6/reviewboard/ for the :ext:cvs-server:/cvsdev/test repository. [Fail output] hyei@hyei-desktop-linux:~/workspace/test_branch/testdir$ post-review --server=http://hyei6/reviewboard/; Password: == Review Board Login Required Enter username and password for Review Board at http://hyei6/reviewboard/ There was an error creating this review request. The repository path hyei-desktop-linux:exthyei-desktop-linux:cvs-serverhyei-desktop-linux:/cvsdev/test is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please read http://www.reviewboard.org/docs/manual/dev/admin/management/repositories What operating system are you using? What browser? Ubuntu 9.04 (64) Please provide any additional information below. I've attached a patch that fixes the issue for me. Instead of looking for the first colon, it looks for the last colon when attempting to replace the host name. Python 2.6.2 was used. Attachments: postreview.py.patch 371 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
