Re: Error while adding perforce 2012.2 repository to reviewboard 1.7.4
Hi David, I didnt get what you need, are you saying that my p4python is not build properly. if yes then can you please provide me steps which i can ran get it done. But i have used the RELNOTES.txt present in p4python.tar to build. Any pre-requiste i need to do to make p4python build with ssl support enable. -Chuck On Thu, Mar 14, 2013 at 5:42 AM, David Trowbridge trowb...@gmail.comwrote: Chuck, This seems to be missing most of the p4python build. In particular I'd like to see the output (and any output files) from the configure step. -David On Tue, Feb 26, 2013 at 1:53 AM, chuck j cjerry2...@gmail.com wrote: Thanks David, please find the attached log file for the below steps. do let me know if any thing is missing from my end, -Chuck On Tue, Feb 26, 2013 at 12:51 AM, David Trowbridge trowb...@gmail.comwrote: Can you get full logs of the output of all of those steps and attach them/pastebin them somewhere? -David On Wed, Feb 20, 2013 at 2:27 AM, chuck j cjerry2...@gmail.com wrote: Thanks David for responding my email. Here are the steps which i followed. My Linux box has el5 has following openssl package. openssl097a-0.9.7a-9.el5_2.1 openssl-devel-0.9.8e-12.el5 openssl097a-0.9.7a-9.el5_2.1 openssl-0.9.8e-12.el5 openssl-0.9.8e-12.el5 openssl-devel-0.9.8e-12.el5 To compile p4python, i need to have openssl 1.0.1 So i downloaded openssl 1.0.1c, ./config make make test make install Openssl gets installed at /usr/local/ssl location. I downloaded p4python and p4api from perforce.org site. python setup.py build --apidir /home/me/p4api --ssl /usr/local/ssl/lib python setup.py install Then i assume that p4python gets installed. I tested with the steps in python prompt import P4 p4 = P4.P4() p4.connect() Traceback (most recent call last): File stdin, line 1, in module File /usr/local/lib/python2.7/site -packages/P4.py, line 642, in connect P4API.P4Adapter.connect( self ) P4.P4Exception: [P4.connect()] Connect to server failed; check $P4PORT. SSL library must be at least version 1.0.1. Please let me know if you need any thing else. Regards, Chuck On Tue, Feb 19, 2013 at 6:25 AM, David Trowbridge trowb...@gmail.comwrote: Can you show me a log of exactly which commands you used to build and install p4python? -David On Wed, Feb 13, 2013 at 12:00 PM, chuck j cjerry2...@gmail.comwrote: Dear All, Its seems i have got some success while configuring ssl. Now that our perforce server is running on ssl I am try to add the repository, while doing so i am getting below error message. - *The specified Perforce port includes ssl:, but the p4python library was built without SSL support or the system library path is incorrect. * As we have not able to find rpm for RHEL 2.6 OpenSSL 1.0.1, we have to build openssl 1.0.1, which eventually got installed at /usr/local/ssl/bin/ /usr/local/ssl/ then we have build p4python with --ssl option. But its seems that still reviewboard reports about the above error message. Please help us know where to add the path of new build openssl library for which reviewboard server is looking for, if some pointer will be highly appreciated. -Chuck On Wed, Feb 13, 2013 at 7:24 AM, chuck j cjerry2...@gmail.comwrote: Does my p4 info output gave expected output. [root@svrrb1 works]# p4 info User name: chuckj Client name: svrrb1 Client host: svrrb1.na.software.com Client unknown. Current directory: /works Peer address: 182.16.43.144:42238 Client address: my ip address Server address: some ip:1666 Server root: /PFMETA/p4root Server date: 2013/02/12 01:09:47 -0800 PST Server uptime: 286:15:29 Server version: P4D/LINUX26X86_64/2012.2/50 (2013/01/18) Server encryption: encrypted Server cert expires: Jan 31 10:22:47 2015 GMT Server license: Software Corporation users (expires 2013/02/21) Server license-ip: some ip:1666 Case Handling: sensitive On Tuesday, February 12, 2013 4:49:40 PM UTC+5:30, chuck j wrote: Since i couldn't find openssl 1.0.1 rpm, I have to manually compile and build then install it to the default path, then later i have build p4python. root@svrrb1 p4python-2012.2.549493# python setup.py build --apidir /works/p4api-2012.2.585708/ --ssl /usr/local/ root@svrrb1 p4python-2012.2.549493# python setup.py install --apidir /works/p4api-2012.2.585708/ Assuming everything above working fine i test by providing below command line. import P4 p4 = P4.P4() p4.connect() Traceback (most recent call last): File stdin, line 1, in module File /usr/local/lib/python2.7/**site-packages/P4.py, line 642, in connect P4API.P4Adapter.connect( self ) P4.P4Exception: [P4.connect()] Connect to server failed; check $P4PORT. SSL library must be at least version 1.0.1. Does my P4Python is build with OpenSSL.1.0.1 libarary, What is missing in my setup? I know this is not the right forum for above queries but this
patch upload error message
Dear All, This is frustrating developer reporting every second day with patch not getting upload in reviewboard. can somebody help me resolve or tell me how to resolve such issue. Diff currently unavailable. *Error:* The patch to '//path/to/depot/file/bodypair_appregion.pcl' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uUq6zC' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uUq6zC/tmpYlQESK Hunk #3 FAILED at 2153. 1 out of 3 hunks FAILED -- saving rejects to file /tmp/reviewboard.uUq6zC/tmpYlQESK-new.rej Detailshttp://mscrb.mscsoftware.com/mscrb/r/45177/diff/# Traceback (most recent call last): File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.7.5-py2.7.egg/reviewboard/diffviewer/views.py, line 383, in view_diff_fragment file = get_requested_diff_file() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.7.5-py2.7.egg/reviewboard/diffviewer/views.py, line 309, in get_requested_diff_file Regards, Chuck -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with RBTools 0.5
No one will help? On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey rcdailey.li...@gmail.com wrote: I am getting the following error uploading my review from a Perforce changelist. This impedes my day to day work, so I hope that someone can help me quickly. The error I get while trying to run 'rbt post' is: CRITICAL:root:'ResourceList' object has no attribute 'upload_diff' I have only transitioned from review-board to RBT 0.5, most of the commands are the same so I am only invoking a different process. I am using Python 2.7.3 on Windows 7 x64. Here is the command I'm running: rbt post --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C Note that the previous command I used was: post-review %C --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword The post-review command always worked fine for me. I installed RBTools 0.5 using easy_install (logs below). Note that I run this as a custom tool in P4V, so %C actually maps to the Changelist number. $c maps to client name, $p is port, and so on. C:\Users\rdaileyeasy_install -U RBTools Searching for RBTools Reading http://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg Processing RBTools-0.5-py2.7.egg Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages Removing rbtools 0.4.1 from easy-install.pth file Adding RBTools 0.5 to easy-install.pth file Installing post-review-script.py script to C:\Python27\Scripts Installing post-review.exe script to C:\Python27\Scripts Installing post-review.exe.manifest script to C:\Python27\Scripts Installing rbt-script.py script to C:\Python27\Scripts Installing rbt.exe script to C:\Python27\Scripts Installing rbt.exe.manifest script to C:\Python27\Scripts Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg Processing dependencies for RBTools Finished processing dependencies for RBTools -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with RBTools 0.5
Hi Robert, What version of Review Board is there server running? Could you also provide the output of rbt post -d --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C The post-review script is still part of rbtools 0.5, so you can use that as a backup until we have this figured out. On Mar 29, 2013 11:01 AM, Robert Dailey rcdailey.li...@gmail.com wrote: No one will help? On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey rcdailey.li...@gmail.com wrote: I am getting the following error uploading my review from a Perforce changelist. This impedes my day to day work, so I hope that someone can help me quickly. The error I get while trying to run 'rbt post' is: CRITICAL:root:'ResourceList' object has no attribute 'upload_diff' I have only transitioned from review-board to RBT 0.5, most of the commands are the same so I am only invoking a different process. I am using Python 2.7.3 on Windows 7 x64. Here is the command I'm running: rbt post --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C Note that the previous command I used was: post-review %C --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword The post-review command always worked fine for me. I installed RBTools 0.5 using easy_install (logs below). Note that I run this as a custom tool in P4V, so %C actually maps to the Changelist number. $c maps to client name, $p is port, and so on. C:\Users\rdaileyeasy_install -U RBTools Searching for RBTools Reading http://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg Processing RBTools-0.5-py2.7.egg Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages Removing rbtools 0.4.1 from easy-install.pth file Adding RBTools 0.5 to easy-install.pth file Installing post-review-script.py script to C:\Python27\Scripts Installing post-review.exe script to C:\Python27\Scripts Installing post-review.exe.manifest script to C:\Python27\Scripts Installing rbt-script.py script to C:\Python27\Scripts Installing rbt.exe script to C:\Python27\Scripts Installing rbt.exe.manifest script to C:\Python27\Scripts Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg Processing dependencies for RBTools Finished processing dependencies for RBTools -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with RBTools 0.5
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient\gwclient.vcproj,
{933240B0-F445-49E7-AB25-7BAE6B3C458C}
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Release|Win32 = Release|Win32
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.ActiveCfg = Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.Build.0 = Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.ActiveCfg = Release|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.Build.0 = Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.ActiveCfg = Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.Build.0 = Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.ActiveCfg = Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.Build.0 = Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.ActiveCfg = Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.Build.0 = Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.ActiveCfg = Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.Build.0 = Release|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Debug|Win32.ActiveCfg = Debug|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Debug|Win32.Build.0 = Debug|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Release|Win32.ActiveCfg = Release|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Release|Win32.Build.0 = Release|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Debug|Win32.ActiveCfg = Debug|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Debug|Win32.Build.0 = Debug|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Release|Win32.ActiveCfg = Release|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Release|Win32.Build.0 = Release|Win32
- EndGlobalSection
- GlobalSection(SolutionProperties) = preSolution
- HideSolutionNode = FALSE
- EndGlobalSection
-EndGlobal
---
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/review-requests/
DEBUG:root:Making HTTP POST request to
http://reviewboard.corp.good.com/api/review-requests/
DEBUG:root:Making HTTP GET request to
post-review assuming a git repo in an svn checkout
Hello, We have some folks doing svn checkouts and commits inside of a local git repository. When running post-reivew, inside the svn checkout directory, it believes the changes to be in a git repository. We want it forced it to know about the svn check out and use the svn repository instead for reviews. It use to work by default in RBTools 0.3.4 but no longer in 0.4.3 which we just upgraded to. Thanks, -amac -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
block files to show in diff?
Hi all, In our project, the language PO files of the project are stored together with the project source in the same repo. The PO files' size are 1MB each, and we have 12 such PO files. Our process requires that the new strings going into PO files must be reviewed, so at least one of the PO files must be shown on the rev. board. The problem is, that although the diff itself is small (containing only the new strings), the total size of 12 x 1MB of these PO files cause performance problems. The best would be if reviewboard would support on-demand loading of the files when showing the diff -- i.e., until the user does not want to check the diff in a particular file, it should not load that file. The second best would be if I could block 11 out of the 12 files to not show up on the review board. I was thinking on playing with the binary flag of the files, but I need the textual merge inside the SCM, naturally. Do you have any idea how to handle this situation? We are using reviewboard with mercurial SCM. Thanks a lot, Ferenc -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review assuming a git repo in an svn checkout
Here is the debug info: [amacleod@amacleod-ld mcls]$ post-review --debug RBTools 0.4.3 Python 2.6.6 (r266:84292, Apr 11 2011, 15:50:32) [GCC 4.4.4 20100726 (Red Hat 4.4.4-13)] Running on Linux-2.6.32-131.4.1.el6.x86_64-x86_64-with-redhat-6.1-Santiago Home = /home/amacleod Current Directory = /home/amacleod/workspace/tools/mcls Checking the repository type. Errors shown below are mostly harmless. DEBUG:root:Checking for a Bazaar repository... DEBUG:root:Checking for a CVS repository... DEBUG:root:Checking for a ClearCase repository... DEBUG:root:Checking for a Git repository... DEBUG:root:Running: git rev-parse --git-dir DEBUG:root:Running: git config core.bare DEBUG:root:Running: git rev-parse --show-toplevel DEBUG:root:Running: git symbolic-ref -q HEAD DEBUG:root:Running: git config --get branch.master.merge DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.merge'] --- DEBUG:root:Running: git config --get branch.master.remote DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.remote'] --- DEBUG:root:Running: git config --get remote.origin.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url'] --- DEBUG:root:Running: git config --get remote.origin.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url'] --- DEBUG:root:repository info: Path: /home/amacleod/workspace/.git, Base path: , Supports changesets: False Finished checking the repository type. DEBUG:root:Running: git config --get reviewboard.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'reviewboard.url'] --- Unable to find a Review Board server for this source code tree. On Friday, March 29, 2013 11:43:23 AM UTC-7, Andrew MacLeod wrote: Hello, We have some folks doing svn checkouts and commits inside of a local git repository. When running post-reivew, inside the svn checkout directory, it believes the changes to be in a git repository. We want it forced it to know about the svn check out and use the svn repository instead for reviews. It use to work by default in RBTools 0.3.4 but no longer in 0.4.3 which we just upgraded to. Thanks, -amac -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: block files to show in diff?
Hi, What version of Review Board are you using? More recent versions should be a lot faster with larger files. Christian On Mar 29, 2013, at 7:28, ferenc.eng...@gmail.com wrote: Hi all, In our project, the language PO files of the project are stored together with the project source in the same repo. The PO files' size are 1MB each, and we have 12 such PO files. Our process requires that the new strings going into PO files must be reviewed, so at least one of the PO files must be shown on the rev. board. The problem is, that although the diff itself is small (containing only the new strings), the total size of 12 x 1MB of these PO files cause performance problems. The best would be if reviewboard would support on-demand loading of the files when showing the diff -- i.e., until the user does not want to check the diff in a particular file, it should not load that file. The second best would be if I could block 11 out of the 12 files to not show up on the review board. I was thinking on playing with the binary flag of the files, but I need the textual merge inside the SCM, naturally. Do you have any idea how to handle this situation? We are using reviewboard with mercurial SCM. Thanks a lot, Ferenc -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review assuming a git repo in an svn checkout
Drat I was afraid of that. And yes looking back at 0.3.4 it seems to check svn before git. Will look at modifying the source ordering of SCMCLIENTS then Thanks Christian, -amac On Friday, March 29, 2013 12:48:05 PM UTC-7, Christian Hammond wrote: Hi, RBTools looks for the type of repository by looping through the list of types and checking each. I guess at one point the order if this list must have changed. We're going to introduce an option in an upcoming RBTools 0.5.x release to allow you to specify the repository type directly instead of having to scan for it. Until then, the only options I have are to downgrade or to modify the source. Christian On Mar 29, 2013, at 12:25, Andrew MacLeod free...@gmail.com javascript: wrote: Here is the debug info: [amacleod@amacleod-ld mcls]$ post-review --debug RBTools 0.4.3 Python 2.6.6 (r266:84292, Apr 11 2011, 15:50:32) [GCC 4.4.4 20100726 (Red Hat 4.4.4-13)] Running on Linux-2.6.32-131.4.1.el6.x86_64-x86_64-with-redhat-6.1-Santiago Home = /home/amacleod Current Directory = /home/amacleod/workspace/tools/mcls Checking the repository type. Errors shown below are mostly harmless. DEBUG:root:Checking for a Bazaar repository... DEBUG:root:Checking for a CVS repository... DEBUG:root:Checking for a ClearCase repository... DEBUG:root:Checking for a Git repository... DEBUG:root:Running: git rev-parse --git-dir DEBUG:root:Running: git config core.bare DEBUG:root:Running: git rev-parse --show-toplevel DEBUG:root:Running: git symbolic-ref -q HEAD DEBUG:root:Running: git config --get branch.master.merge DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.merge'] --- DEBUG:root:Running: git config --get branch.master.remote DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.remote'] --- DEBUG:root:Running: git config --get remote.origin.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url'] --- DEBUG:root:Running: git config --get remote.origin.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url'] --- DEBUG:root:repository info: Path: /home/amacleod/workspace/.git, Base path: , Supports changesets: False Finished checking the repository type. DEBUG:root:Running: git config --get reviewboard.url DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'reviewboard.url'] --- Unable to find a Review Board server for this source code tree. On Friday, March 29, 2013 11:43:23 AM UTC-7, Andrew MacLeod wrote: Hello, We have some folks doing svn checkouts and commits inside of a local git repository. When running post-reivew, inside the svn checkout directory, it believes the changes to be in a git repository. We want it forced it to know about the svn check out and use the svn repository instead for reviews. It use to work by default in RBTools 0.3.4 but no longer in 0.4.3 which we just upgraded to. Thanks, -amac -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: patch upload error message
Hi, How are the diffs being generated? What type of repository? This is generally due to generating a diff incorrectly, so we should find out what's being done. Christian On Mar 29, 2013, at 2:13, chuck j cjerry2...@gmail.com wrote: Dear All, This is frustrating developer reporting every second day with patch not getting upload in reviewboard. can somebody help me resolve or tell me how to resolve such issue. Diff currently unavailable. Error: The patch to '//path/to/depot/file/bodypair_appregion.pcl' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.uUq6zC' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.uUq6zC/tmpYlQESK Hunk #3 FAILED at 2153. 1 out of 3 hunks FAILED -- saving rejects to file /tmp/reviewboard.uUq6zC/tmpYlQESK-new.rej Details Traceback (most recent call last): File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.7.5-py2.7.egg/reviewboard/diffviewer/views.py, line 383, in view_diff_fragment file = get_requested_diff_file() File /usr/local/lib/python2.7/site-packages/ReviewBoard-1.7.5-py2.7.egg/reviewboard/diffviewer/views.py, line 309, in get_requested_diff_file Regards, Chuck -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: block files to show in diff?
It's version 1.5.5, but I see no chance to upgrade it in the foreseeable future. Big company, slow company. :( The newer versions do not load the big files by default? On Friday, March 29, 2013 8:49:25 PM UTC+1, Christian Hammond wrote: Hi, What version of Review Board are you using? More recent versions should be a lot faster with larger files. Christian On Mar 29, 2013, at 7:28, ferenc...@gmail.com javascript: wrote: Hi all, In our project, the language PO files of the project are stored together with the project source in the same repo. The PO files' size are 1MB each, and we have 12 such PO files. Our process requires that the new strings going into PO files must be reviewed, so at least one of the PO files must be shown on the rev. board. The problem is, that although the diff itself is small (containing only the new strings), the total size of 12 x 1MB of these PO files cause performance problems. The best would be if reviewboard would support on-demand loading of the files when showing the diff -- i.e., until the user does not want to check the diff in a particular file, it should not load that file. The second best would be if I could block 11 out of the 12 files to not show up on the review board. I was thinking on playing with the binary flag of the files, but I need the textual merge inside the SCM, naturally. Do you have any idea how to handle this situation? We are using reviewboard with mercurial SCM. Thanks a lot, Ferenc -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: block files to show in diff?
They do load them, but there's a lot of optimizations around large files. RB should easily be able to handle multi-MB files. Christian On Mar 29, 2013, at 14:53, ferenc.eng...@gmail.com wrote: It's version 1.5.5, but I see no chance to upgrade it in the foreseeable future. Big company, slow company. :( The newer versions do not load the big files by default? On Friday, March 29, 2013 8:49:25 PM UTC+1, Christian Hammond wrote: Hi, What version of Review Board are you using? More recent versions should be a lot faster with larger files. Christian On Mar 29, 2013, at 7:28, ferenc...@gmail.com wrote: Hi all, In our project, the language PO files of the project are stored together with the project source in the same repo. The PO files' size are 1MB each, and we have 12 such PO files. Our process requires that the new strings going into PO files must be reviewed, so at least one of the PO files must be shown on the rev. board. The problem is, that although the diff itself is small (containing only the new strings), the total size of 12 x 1MB of these PO files cause performance problems. The best would be if reviewboard would support on-demand loading of the files when showing the diff -- i.e., until the user does not want to check the diff in a particular file, it should not load that file. The second best would be if I could block 11 out of the 12 files to not show up on the review board. I was thinking on playing with the binary flag of the files, but I need the textual merge inside the SCM, naturally. Do you have any idea how to handle this situation? We are using reviewboard with mercurial SCM. Thanks a lot, Ferenc -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2944 in reviewboard: Review creator should always have access to their own review
Updates: Status: Fixed Comment #1 on issue 2944 by trowb...@gmail.com: Review creator should always have access to their own review http://code.google.com/p/reviewboard/issues/detail?id=2944 This bug was fixed in 1.7.5 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
