Error while uploading diff

2013-04-02 Thread Neha
Hello Everyone, I have set Perforce as the repository for Review Board. I have created diffs in Perforce and when i'm trying to upload the diff in the Review Board through the 'New Review Request' option and then 'Update'- 'Upload Diff', its giving the error that the specified diff file is

Re: Error while uploading diff

2013-04-02 Thread David Trowbridge
How are you creating your diff? -David On Tue, Apr 2, 2013 at 5:46 AM, Neha cm.ne...@gmail.com wrote: Hello Everyone, I have set Perforce as the repository for Review Board. I have created diffs in Perforce and when i'm trying to upload the diff in the Review Board through the 'New Review

Re: Error while uploading diff

2013-04-02 Thread Neha
Creating diff in Perforce: In Perforce, I selected a file from workspace, and right clicked on it, then selected the 'diff against' option. This displays a 'Diff' dialog box with fields for 1st and 2nd path of files. After filling these fields I clicked the 'Diff' button. Uploading diff in

Re: Error while uploading diff

2013-04-02 Thread David Trowbridge
For Perforce, you'll have to use rbtools. Normal 'p4 diff' produces files that don't contain enough revision information. -David On Tue, Apr 2, 2013 at 11:06 AM, Neha cm.ne...@gmail.com wrote: Creating diff in Perforce: In Perforce, I selected a file from workspace, and right clicked on it,

Re: Error while uploading diff

2013-04-02 Thread Neha
Thanks David !! Actually I have tried installing RBTools by python setup.py. install, but there were some errors of missing packages. Now, I will try installing it again. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at

Re: Issue 2121 in reviewboard: post-review doesn't handle bad passwords nicely

2013-04-02 Thread reviewboard
Comment #3 on issue 2121 by chris.cl...@actian.com: post-review doesn't handle bad passwords nicely http://code.google.com/p/reviewboard/issues/detail?id=2121 This is the hack I'm using for older python machines: diff --git a/rbtools/postreview.py b/rbtools/postreview.py index

Re: Issue 2121 in reviewboard: post-review doesn't handle bad passwords nicely

2013-04-02 Thread reviewboard
Comment #4 on issue 2121 by chris.cl...@actian.com: post-review doesn't handle bad passwords nicely http://code.google.com/p/reviewboard/issues/detail?id=2121 This is the hack I'm using for older python machines: diff --git a/rbtools/postreview.py b/rbtools/postreview.py index