Error while uploading diff
Hello Everyone, I have set Perforce as the repository for Review Board. I have created diffs in Perforce and when i'm trying to upload the diff in the Review Board through the 'New Review Request' option and then 'Update'- 'Upload Diff', its giving the error that the specified diff file is empty. Please help. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Error while uploading diff
How are you creating your diff? -David On Tue, Apr 2, 2013 at 5:46 AM, Neha cm.ne...@gmail.com wrote: Hello Everyone, I have set Perforce as the repository for Review Board. I have created diffs in Perforce and when i'm trying to upload the diff in the Review Board through the 'New Review Request' option and then 'Update'- 'Upload Diff', its giving the error that the specified diff file is empty. Please help. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Error while uploading diff
Creating diff in Perforce: In Perforce, I selected a file from workspace, and right clicked on it, then selected the 'diff against' option. This displays a 'Diff' dialog box with fields for 1st and 2nd path of files. After filling these fields I clicked the 'Diff' button. Uploading diff in Review Board: After clicking the 'Create Review Request' button, I selected 'update' - 'upload diff ' which appears in the upper left corner. Then I chose the diff and parent diff from the Perforce workspace and uploaded it but the 'specified diff is empty' error occurs. What must be going wrong? Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Error while uploading diff
For Perforce, you'll have to use rbtools. Normal 'p4 diff' produces files that don't contain enough revision information. -David On Tue, Apr 2, 2013 at 11:06 AM, Neha cm.ne...@gmail.com wrote: Creating diff in Perforce: In Perforce, I selected a file from workspace, and right clicked on it, then selected the 'diff against' option. This displays a 'Diff' dialog box with fields for 1st and 2nd path of files. After filling these fields I clicked the 'Diff' button. Uploading diff in Review Board: After clicking the 'Create Review Request' button, I selected 'update' - 'upload diff ' which appears in the upper left corner. Then I chose the diff and parent diff from the Perforce workspace and uploaded it but the 'specified diff is empty' error occurs. What must be going wrong? Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Error while uploading diff
Thanks David !! Actually I have tried installing RBTools by python setup.py. install, but there were some errors of missing packages. Now, I will try installing it again. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2121 in reviewboard: post-review doesn't handle bad passwords nicely
Comment #3 on issue 2121 by chris.cl...@actian.com: post-review doesn't
handle bad passwords nicely
http://code.google.com/p/reviewboard/issues/detail?id=2121
This is the hack I'm using for older python machines:
diff --git a/rbtools/postreview.py b/rbtools/postreview.py
index df791aa..5323b9c 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -12,6 +12,11 @@ from optparse import OptionParser
import datetime
try:
+from cStringIO import StringIO as FakeFile
+except ImportError:
+from StringIO import StringIO as FakeFile
+
+try:
# setuptools from http://peak.telecommunity.com/
from pkg_resources import parse_version
except ImportError:
@@ -192,8 +197,19 @@ class
ReviewBoardHTTPBasicAuthHandler(urllib2.HTTPBasicAuthHandler):
if not self._retried:
self._retried = True
self.retried = 0
-response =
urllib2.HTTPBasicAuthHandler.retry_http_basic_auth(
-self, *args, **kwargs)
+try:
+response =
urllib2.HTTPBasicAuthHandler.retry_http_basic_auth(
+self, *args, **kwargs)
+except ValueError, e:
+# more than likely Python 2.4 client and
+# user used bad username/password
+if e.args[0] == AbstractDigestAuthHandler doesn't
know about Basic and sys.versio
+# See
http://code.google.com/p/reviewboard/issues/detail?id=2121
+# Hack to log a slightly more useful error message
+print 'ERROR: Suspect incorrect username and/or
password'
+fileptr = FakeFile('')
+raise urllib2.HTTPError(None, 401, None, None,
fileptr)
+raise
if response.code != 401:
self._retried = False
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2121 in reviewboard: post-review doesn't handle bad passwords nicely
Comment #4 on issue 2121 by chris.cl...@actian.com: post-review doesn't
handle bad passwords nicely
http://code.google.com/p/reviewboard/issues/detail?id=2121
This is the hack I'm using for older python machines:
diff --git a/rbtools/postreview.py b/rbtools/postreview.py
index df791aa..d8af51c 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -12,6 +12,11 @@ from optparse import OptionParser
import datetime
try:
+from cStringIO import StringIO as FakeFile
+except ImportError:
+from StringIO import StringIO as FakeFile
+
+try:
# setuptools from http://peak.telecommunity.com/
from pkg_resources import parse_version
except ImportError:
@@ -192,8 +197,18 @@ class
ReviewBoardHTTPBasicAuthHandler(urllib2.HTTPBasicAuthHandler):
if not self._retried:
self._retried = True
self.retried = 0
-response =
urllib2.HTTPBasicAuthHandler.retry_http_basic_auth(
-self, *args, **kwargs)
+try:
+response =
urllib2.HTTPBasicAuthHandler.retry_http_basic_auth(
+self, *args, **kwargs)
+except ValueError, e:
+if e.args[0] == AbstractDigestAuthHandler doesn't
know about Basic and sys.version_info = (2, 4) and sys.version_info (2,
5):
+# Python 2.4 client and user gave bad
username/password
+# Hack to log a slightly more useful error message
+# See
http://code.google.com/p/reviewboard/issues/detail?id=2121
+print 'ERROR: Suspect incorrect username and/or
password'
+fileptr = FakeFile('')
+raise urllib2.HTTPError(None, 401, None, None,
fileptr)
+raise
if response.code != 401:
self._retried = False
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
