Re: Review Board 1.6.18 and 1.7.12 released

2013-07-29 Thread Stephen Gallagher
On 07/28/2013 06:02 AM, Christian Hammond wrote:
 Hi everyone,
 
 We have a couple new releases tonight. Review Board 1.6.18 and 1.7.12
 focus on tightening security, and giving extension writers a couple new
 abilities to make their lives easier.
 
 It's late here, so I'm going to direct you to the news post for further
 information:
 
 http://www.reviewboard.org/news/2013/07/28/review-board-1-6-18-and-1-7-12-released/
 
 We also have a new guide on beefing up security for your file
 attachments. This is especially important for those of you with public
 installations, so please read it.
 
 http://support.beanbaginc.com/support/solutions/articles/110173-securing-file-attachments
 

Packages for Fedora 18, Fedora 19 and Red Hat Enterprise Linux 6 (and
clones) are now available for testing at
https://admin.fedoraproject.org/updates/ReviewBoard

They should appear in the 'updates-testing' or 'epel-testing' repository
mirrors within 48 hours, or they can be downloaded manually and tried
out from the link above. Please report any issues you discover with
these packages to https://bugzilla.redhat.com and the ReviewBoard component.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Having trouble setting up a GitHub (Private Organization) repository

2013-07-29 Thread Wei Dai
Thanks so much for the hint! Yes I never realized that it's the rbssh path.
For some reason it's in /usr/local/bin but not in /usr/bin.  sudo ln -s
/usr/local/bin/rbssh /usr/bin/rbssh did the trick. Thank you again!


On Mon, Jul 29, 2013 at 12:35 AM, Christian Hammond chip...@chipx86.comwrote:

 How did you install Review Board exactly?

 What OS/distro?

 Any special web server or virtualenv setup?

 If it's exactly the same error (please paste yours) then the PATH isn't
 set up to find the rbssh that was installed when installing Review Board.

 Christian

 --
 Christian Hammond - chip...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Fri, Jul 26, 2013 at 12:37 PM, Wei Dai wei...@google.com wrote:

 Hello, did you eventually figure out this problem? I also have exactly
 the same error log messages. Thanks!

 Dai Wei


 On Friday, May 4, 2012 7:29:13 AM UTC-4, Can Özmen wrote:

 I first tried adding the SSH key to my GitHub account and then as a
 deploy key to the private repo's account.

 Both fail with the same message:

 2012-05-04 14:24:39,977 - DEBUG - Switch to new keys ...
 2012-05-04 14:24:39,983 - DEBUG - Trying SSH key
 3e2bacb616553a8258f03dc1b70f3a**9c
 2012-05-04 14:24:40,204 - DEBUG - userauth is OK
 2012-05-04 14:24:40,818 - INFO - Authentication (publickey) successful!
 2012-05-04 14:24:40,912 - DEBUG - EOF in transport thread
 2012-05-04 14:24:40,936 - ERROR - Git: Failed to find valid repository
 ssh://g...@github.com/**PhonoClick/Pesto.githttp://g...@github.com/PhonoClick/Pesto.git:
 error: cannot run rbssh: No such file or directory
 fatal: unable to fork


 --
 Can Özmen

 On Friday, May 4, 2012 at 11:51 AM, Christian Hammond wrote:

 Do you have an SSH key configured and linked on that account? That could
 do it.

 If you check the Review Board log file, there may be more information.

 Christian

 --
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, May 4, 2012 at 1:24 AM, Can Özmen cano...@gmail.com wrote:

 I'm still getting the 'a repo was not found' error.

 Here's a screenshot showing how I fill the fields.

 Any other gotchas that I should be aware of?

 Thanks,
 Can.

 On Fri, May 4, 2012 at 11:10 AM, Christian Hammond chi...@chipx86.com
 wrote:
  Try setting your own username as the hosting owner before getting the
 token,
  and then switching to the organization after.
 
  We'll be deploying a version soon that switches to the new API.
 
  Christian
 
  --
  Christian Hammond - chi...@chipx86.com

  Review Board - http://www.reviewboard.org
  VMware, Inc. - http://www.vmware.com
 
 
 
  On Fri, May 4, 2012 at 12:11 AM, Can Özmen cano...@gmail.com wrote:
 
  But in the case of a private org that would make 'foo' the owner,
 which is
  the name of the organization.
 
  Then the 'Get your API Token' part asks for foo's password, which
 doesn't
  make sense since 'foo' is not an account that I can log-in with.
 
  --
  Can Özmen
 
  On Wednesday, May 2, 2012 at 9:34 PM, Christian Hammond wrote:
 
  The Project Name is the foo in foo.git. The owner field would be
 the
  account owning the repo. So, github.com/foo/bar.git would use foo
 as the
  owner and bar as the project.
 
  Christian
 
 
  On May 2, 2012, at 10:03, Can Özmen cano...@gmail.com wrote:
 
  Hi Christian  Dan,
 
  I'm on 1.6.6 and trying to set up a Private Org. Repo on Github.
 
  I've got an API token via the web interface. I've generated a key
 pair and
  uploaded the public part as a deploy key to the repo I want to
 connect to
  ((RB asked me to confirm the host afterwards)).
 
  But I'm getting the 'a repository was not found at the specified
 path.'
  error.
 
  In what format should I fill in the 'Project Name:' field and what
 logs
  should I check for more info.
 
  Thanks,
  Can.
 
  On Tuesday, April 17, 2012 8:33:23 PM UTC+3, Christian Hammond wrote:
 
  They've been nice enough to give Review Board an extension on the one
 API
  call we use, and are working on making the API token accessible
 somewhere
  until then. Said it may be a couple days.
 
  In the meantime, I'm making progress on v3 support, which will also
 come
  with a much easier repository setup process.
 
  Christian
 
 
  On Apr 17, 2012, at 10:03, Dan Z d...@modria.com wrote:
 
  I finally got a response from GitHub. Here is it:
 
  The API Token has been removed. We encourage all third  party
  applications to migrate to API v3. Please check our latest blog post
 for
  more details: 
  https://github.com/**blog/1090-github-api-moving-onhttps://github.com/blog/1090-github-api-moving-on
 **
 
  Pretty much, they've said, We're shutting down the v1 and v2 APIs on
 May
  1. Oh, and if you don't already have an API Token, then I guess for
 you, the
  APIs are shut down now. Brilliant.
 
  -- Dan
 
 
  --
  Want to help the Review Board project? Donate today at
  

post-review, git-svn and --parent

2013-07-29 Thread Alex Lewis
Hi,
  Please forgive me for raising this issue as I believe it has been raised 
a couple of times over the years but I didn't see a resolution to those 
issues and I'm seeing it with post-review 0.5.1. I hope you don't mind.

  I have the following branch setup...

  |- xxx (feature-x)
  |- xxx
  |- xxx
  |- yyy (develop)
  |- yyy
  |- zzz (master) (git-svn)

...where xxx, yyy and zzz are commits.

As far as I understand it, to post a review of just the changes introduced 
by feature-x excluding the changes introduced by develop I use the --parent 
flag set to develop. If I do this the command fails with an error about a 
NoneType (see debug output below). I believe the cause of the issue is that 
post-review tries to do a git svn find-rev on the yyy commits which aren't 
in SVN, so the find-rev returns nothing and post-review fails.

Am I doing the right with the parent flag and if I am is there any chance 
that post-review could support this case in the future?

I can work around this issue by creating a new branch from feature-x and 
rebasing that branch directly on master and raise the review from that 
branch without supplying the parent flag. Although this workaround exists 
the workflow is not ideal. Apologies if it's just me doing something stupid.

Thanks for your help.

Cheers,
Alex

(Please note I've changed some of the path values in the debug below to 
obfuscate private info)
 RBTools 0.5.1
 Python 2.7.4 (default, Apr 19 2013, 18:28:01) 
[GCC 4.7.3]
 Running on Linux-3.8.0-26-generic-x86_64-with-Ubuntu-13.04-raring
 Home = /home/alex
 Current Directory = /path/to/dev/dir
 Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/path/to/dev/dir' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git svn info
DEBUG:root:repository info: Path: http://someserver/svn/repo, Base path: 
/trunk, Supports changesets: False
 Finished checking the repository type.
 HTTP GETting api/info/
DEBUG:root:Running: git merge-base develop refs/heads/feature-x
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u 
develop
DEBUG:root:Running: git svn find-rev develop
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u 
5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop
DEBUG:root:Running: git svn find-rev 
5fe45c363bc8600ef727d0b4a441c8ed30e76c84
Traceback (most recent call last):
  File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.5.1', 'console_scripts', 'post-review')()
  File 
/usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/postreview.py,
 
line 1334, in main
if len(diff) == 0:
TypeError: object of type 'NoneType' has no len()

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: post-review, git-svn and --parent

2013-07-29 Thread Christian Hammond
This looks like a bug, and not something you're doing wrong.

Would you mind trying this with rbt-post instead of post-review (same 
arguments) and seeing what the failure case is?

rbt-post is the successor to post-review.

Christian


On Jul 29, 2013, at 8:48, Alex Lewis alex.lewis...@gmail.com wrote:

 Hi,
   Please forgive me for raising this issue as I believe it has been raised a 
 couple of times over the years but I didn't see a resolution to those issues 
 and I'm seeing it with post-review 0.5.1. I hope you don't mind.
 
   I have the following branch setup...
 
   |- xxx (feature-x)
   |- xxx
   |- xxx
   |- yyy (develop)
   |- yyy
   |- zzz (master) (git-svn)
 
 ...where xxx, yyy and zzz are commits.
 
 As far as I understand it, to post a review of just the changes introduced by 
 feature-x excluding the changes introduced by develop I use the --parent flag 
 set to develop. If I do this the command fails with an error about a 
 NoneType (see debug output below). I believe the cause of the issue is that 
 post-review tries to do a git svn find-rev on the yyy commits which aren't in 
 SVN, so the find-rev returns nothing and post-review fails.
 
 Am I doing the right with the parent flag and if I am is there any chance 
 that post-review could support this case in the future?
 
 I can work around this issue by creating a new branch from feature-x and 
 rebasing that branch directly on master and raise the review from that branch 
 without supplying the parent flag. Although this workaround exists the 
 workflow is not ideal. Apologies if it's just me doing something stupid.
 
 Thanks for your help.
 
 Cheers,
 Alex
 
 (Please note I've changed some of the path values in the debug below to 
 obfuscate private info)
  RBTools 0.5.1
  Python 2.7.4 (default, Apr 19 2013, 18:28:01) 
 [GCC 4.7.3]
  Running on Linux-3.8.0-26-generic-x86_64-with-Ubuntu-13.04-raring
  Home = /home/alex
  Current Directory = /path/to/dev/dir
  Checking the repository type. Errors shown below are mostly harmless.
 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Running: svn info --non-interactive
 DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
 svn: E155007: '/path/to/dev/dir' is not a working copy
 ---
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Running: git rev-parse --git-dir
 DEBUG:root:Running: git config core.bare
 DEBUG:root:Running: git rev-parse --show-toplevel
 DEBUG:root:Running: git symbolic-ref -q HEAD
 DEBUG:root:Running: git svn info
 DEBUG:root:repository info: Path: http://someserver/svn/repo, Base path: 
 /trunk, Supports changesets: False
  Finished checking the repository type.
  HTTP GETting api/info/
 DEBUG:root:Running: git merge-base develop refs/heads/feature-x
 DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u 
 develop
 DEBUG:root:Running: git svn find-rev develop
 DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u 
 5fe45c363bc8600ef727d0b4a441c8ed30e76c84..develop
 DEBUG:root:Running: git svn find-rev 5fe45c363bc8600ef727d0b4a441c8ed30e76c84
 Traceback (most recent call last):
   File /usr/local/bin/post-review, line 9, in module
 load_entry_point('RBTools==0.5.1', 'console_scripts', 'post-review')()
   File 
 /usr/local/lib/python2.7/dist-packages/RBTools-0.5.1-py2.7.egg/rbtools/postreview.py,
  line 1334, in main
 if len(diff) == 0:
 TypeError: object of type 'NoneType' has no len()
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.
  
  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Which version of Ubuntu is supported for latest 1.7.12 ReviewBoard release?

2013-07-29 Thread Kunjal
Chris, 

We are considering Ubuntu installation for latest upgrade to 1.7.12 
ReviewBoard release. 
Which Ubuntu version installation is supported for ReviewBoard? 

Thanks a lot
Kunjal


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.