Re: ReviewBoard server tips over about twice a week

2013-09-11 Thread Paul Fee
Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
the /server-status URL on your web server.  This should cause Apache httpd 
to provide a page that summarises the status of all its workers.  That may 
help you understand why you've got more httpd processes than expected.

Also, I've found the MaxRequestsPerChild directive to be useful on an 
installation of mine that would lock up occasionally.  Your config shows 
the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
that MaxRequestsPerChild is taking effect.  The config file contains a set 
of MPM tuning directives, duplicated for prefork and worker, make sure the 
required configuration is actually active.

-- 
Paul

On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: ReviewBoard server tips over about twice a week

2013-09-11 Thread Steve
Thanks Paul, that's helpful. We're using the prefork MPM.  Do you think 
4000 is too large a number for MaxRequetsPerChild?

--Steve

On Wednesday, September 11, 2013 2:15:35 AM UTC-7, Paul Fee wrote:

 Your httpd.conf suggests you've got mod_status enabled.  Therefore visit 
 the /server-status URL on your web server.  This should cause Apache httpd 
 to provide a page that summarises the status of all its workers.  That may 
 help you understand why you've got more httpd processes than expected.

 Also, I've found the MaxRequestsPerChild directive to be useful on an 
 installation of mine that would lock up occasionally.  Your config shows 
 the directive set to 4000 for the prefork MPM, but 0 (infinity) for the 
 worker MPM.  Check which MPM you're using (execute httpd -V) and ensure 
 that MaxRequestsPerChild is taking effect.  The config file contains a set 
 of MPM tuning directives, duplicated for prefork and worker, make sure the 
 required configuration is actually active.

 -- 
 Paul

 On Tuesday, September 10, 2013 11:36:59 PM UTC+1, Steve wrote:

 I see the 'server cache' information in the admin page.  It shows the 
 memory usage at around 150MB, so clearly 64MB was not enough. 
  Unfortunately, the load average once again climbed over 100 and I had 
 close to 200 apache processes running.  It's baffling.  Can you guide me on 
 how to limit the number of apache processes and threads?  I've attached the 
 apache httpd.conf file.

 Thanks Christian.

 --steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


listing all review groups and users within the group using a python script

2013-09-11 Thread Steve
I can list all RB users this way:

 from django.contrib.auth.models import User
 for user in User.objects.all():
print user

That correctly prints out all of my users. But the same doesn't work for 
Group

 from django.contrib.auth.models import Group
 for group in Group.objects.all():
print group
default reviewer

I have about 30 groups defined in RB, but I only get 'default reviewer'. 
 What I'd like to do is list out all the groups, or more specifically, for 
each group, list all the user in the group.  There's probably a set of 
django functions that will do that, but I'm having trouble finding them. 
 Can someone point me in the right direction?

Thanks

--Steve

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Liinux noob: Trouble with python-docutils dependency while installing ReviewBoard

2013-09-11 Thread Stephen Gallagher
Hmm, would you mind filing this as a bug on bugzilla.redhat.com? Looks like
a packaging issue rather than a ReviewBoard bug.

I'm on vacation until the 23rd, but I'll look into it when I get back.

In the meantime, what happens if you do:

yum clean all
yum install python-docutils

On Wednesday, September 11, 2013, Mark Addleman wrote:

 I'm trying to install ReviewBoard on RHEL.  I have installed the EPEL
 repository but yum install ReviewBoard returns
 Error: Package: ReviewBoard-1.7.13-2.el6.noarch (epel)
Requires: python-docutils
  You could try using --skip-broken to work around the problem
  You could try running: rpm -Va --nofiles --nodigest

 I'm a little loathe to install the python-docutils rpm directly since I'm
 a total Linux noob and I can't find one that's specific to RHEL.

 Any help would be appreciated.

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com javascript:_e({},
 'cvml', 'reviewboard%2bunsubscr...@googlegroups.com');.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: listing all review groups and users within the group using a python script

2013-09-11 Thread Steve
Better yet, is there a way to do this with the new RBTools 5.x API?

--Steve


On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for 
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'. 
  What I'd like to do is list out all the groups, or more specifically, for 
 each group, list all the user in the group.  There's probably a set of 
 django functions that will do that, but I'm having trouble finding them. 
  Can someone point me in the right direction?

 Thanks

 --Steve



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Liinux noob: Trouble with python-docutils dependency while installing ReviewBoard

2013-09-11 Thread Matthew Woehlke

On 2013-09-11 11:23, Mark Addleman wrote:

I'm trying to install ReviewBoard on RHEL.  I have installed the EPEL
repository but yum install ReviewBoard returns
Error: Package: ReviewBoard-1.7.13-2.el6.noarch (epel)
Requires: python-docutils
  You could try using --skip-broken to work around the problem
  You could try running: rpm -Va --nofiles --nodigest

I'm a little loathe to install the python-docutils rpm directly since I'm a
total Linux noob and I can't find one that's specific to RHEL.

Any help would be appreciated.


Huh. According to 
http://koji.fedoraproject.org/koji/packageinfo?packageID=3581, it never 
got built for EL6, even though it is built for every current version of 
Fedora and for EL5.


If you're stuck, you could try directly installing the EL5 version... or 
if you're *really* desparate, build your own from either the EL5 spec or 
whichever Fedora spec most closely matches EL6 (I forget offhand what 
that is).


I would definitely file a bug per Stephen's recommendation.

--
Matthew

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups reviewboard group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Liinux noob: Trouble with python-docutils dependency while installing ReviewBoard

2013-09-11 Thread Mark Addleman
I'm trying to install ReviewBoard on RHEL.  I have installed the EPEL 
repository but yum install ReviewBoard returns 
Error: Package: ReviewBoard-1.7.13-2.el6.noarch (epel)
   Requires: python-docutils
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

I'm a little loathe to install the python-docutils rpm directly since I'm a 
total Linux noob and I can't find one that's specific to RHEL.  

Any help would be appreciated.

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: listing all review groups and users within the group using a python script

2013-09-11 Thread Steve
This example is very helpful.  Thanks!

--Steve


On Wednesday, September 11, 2013 11:43:11 AM UTC-7, Steven MacLeod wrote:

 Yes, this can be done using the API. Assuming you have rbtools 5.x 
 installed, the following script should work. Modify for your desired 
 output. It should be noted that this will make a large number of HTTP 
 requests, and is not optimized.

 from rbtools.api.client import RBClient

 client = RBClient(http://your-rb-server-here)
 root = client.get_root()

 groups = root.get_groups()

 while True:
 for group in groups:
 print group.name
 users = group.get_users()

 while True:
 for user in users:
 print \t%s % user.username

 try:
 users = users.get_next()
 except StopIteration:
 break

 try:
 groups = groups.get_next()
 except StopIteration:
 break


 On Wed, Sep 11, 2013 at 12:46 PM, Steve seide...@gmail.com 
 javascript:wrote:

 Better yet, is there a way to do this with the new RBTools 5.x API?

 --Steve


 On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for 
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'. 
  What I'd like to do is list out all the groups, or more specifically, for 
 each group, list all the user in the group.  There's probably a set of 
 django functions that will do that, but I'm having trouble finding them. 
  Can someone point me in the right direction?

 Thanks

 --Steve

  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: listing all review groups and users within the group using a python script

2013-09-11 Thread Steven MacLeod
Yes, this can be done using the API. Assuming you have rbtools 5.x
installed, the following script should work. Modify for your desired
output. It should be noted that this will make a large number of HTTP
requests, and is not optimized.

from rbtools.api.client import RBClient

client = RBClient(http://your-rb-server-here)
root = client.get_root()

groups = root.get_groups()

while True:
for group in groups:
print group.name
users = group.get_users()

while True:
for user in users:
print \t%s % user.username

try:
users = users.get_next()
except StopIteration:
break

try:
groups = groups.get_next()
except StopIteration:
break


On Wed, Sep 11, 2013 at 12:46 PM, Steve seide.al...@gmail.com wrote:

 Better yet, is there a way to do this with the new RBTools 5.x API?

 --Steve


 On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'.
  What I'd like to do is list out all the groups, or more specifically, for
 each group, list all the user in the group.  There's probably a set of
 django functions that will do that, but I'm having trouble finding them.
  Can someone point me in the right direction?

 Thanks

 --Steve

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: listing all review groups and users within the group using a python script

2013-09-11 Thread David Trowbridge
And to address the initial approach:

django.contrib.auth.models.Group is for authentication groups, which we
don't use. If you want to use a management command, use this:

from reviewboard.reviews.models import Group

-David


On Wed, Sep 11, 2013 at 11:43 AM, Steven MacLeod ste...@smacleod.ca wrote:

 Yes, this can be done using the API. Assuming you have rbtools 5.x
 installed, the following script should work. Modify for your desired
 output. It should be noted that this will make a large number of HTTP
 requests, and is not optimized.

 from rbtools.api.client import RBClient

 client = RBClient(http://your-rb-server-here)
 root = client.get_root()

 groups = root.get_groups()

 while True:
 for group in groups:
 print group.name
 users = group.get_users()

 while True:
 for user in users:
 print \t%s % user.username

 try:
 users = users.get_next()
 except StopIteration:
 break

 try:
 groups = groups.get_next()
 except StopIteration:
 break


 On Wed, Sep 11, 2013 at 12:46 PM, Steve seide.al...@gmail.com wrote:

 Better yet, is there a way to do this with the new RBTools 5.x API?

 --Steve


 On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote:

 I can list all RB users this way:

  from django.contrib.auth.models import User
  for user in User.objects.all():
 print user

 That correctly prints out all of my users. But the same doesn't work for
 Group

  from django.contrib.auth.models import Group
  for group in Group.objects.all():
 print group
 default reviewer

 I have about 30 groups defined in RB, but I only get 'default reviewer'.
  What I'd like to do is list out all the groups, or more specifically, for
 each group, list all the user in the group.  There's probably a set of
 django functions that will do that, but I'm having trouble finding them.
  Can someone point me in the right direction?

 Thanks

 --Steve

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: remote git repository issue

2013-09-11 Thread David Trowbridge
It's converting the host:path syntax into URL syntax, which is why the
colon is going away.

The actual failure here seems to be error: cannot spawn rbssh: No such
file or directory. It sounds like the paths aren't set up properly.

Note also that using remote git *requires* that you use the raw file url
with a frontend like cgit or gitweb due to insufficiencies in git's remote
protocols. The admin docs explain how to set this up.

-David



On Tue, Sep 10, 2013 at 8:48 AM, Atif syedatifna...@gmail.com wrote:

 I am posting this issue again - Will greatly appreciate if someone can
 help me.
 I am trying to add git repository on a remote machine.

 Along with other info in Manage-Repositories-Add, I entered the
 following path for the remote repo: 10.10.94.4:
 /localhome/gitusers/username/reponame.git.
 However, I keep getting the error below:
 A repository was not found at the specified path.

 When I looked at the log, it shows the following error:
 2013-09-10 10:38:22,201 - DEBUG -  - Switch to new keys ...
 2013-09-10 10:38:22,217 - DEBUG -  - Trying SSH key
 7d5c466f04987b925e1ffddfa28a8c68
 2013-09-10 10:38:22,233 - DEBUG -  - userauth is OK
 2013-09-10 10:38:24,313 - INFO -  - Authentication (publickey) successful!
 2013-09-10 10:38:24,424 - DEBUG -  - EOF in transport thread
 2013-09-10 10:38:24,438 - ERROR -  - Git: Failed to find valid repository
 ssh://10.10.94.12/localhome/gitusers/username/reponame.git: error: cannot
 spawn rbssh: No such file or directory
 fatal: unable to fork

 Here are my questions:

1. Why is it giving the error?
2. Why does the path (see highlighted in green) in log error removes
semicolon in ssh path? I think that may be causing the issue.

 thanks in advance
 Atif

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Query on post-review using CLI

2013-09-11 Thread Varun Jain
Hi Team,

Currently post-review picks up the user info of the user running the 
command and he will be the owner (Submitter) of the Review Request created.
As is RB provides the --submit-as option to specify the username but 
expects the —username and —password field to be populated.
I wonder if there is a workaround to assign different reviewers, other the 
person running the command as  Review Owner so that it will be easier to 
manage the review requests generated? 


Thanks,
Varun

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2933 in reviewboard: Trim blank lines from the end (and beginning?) of review comments

2013-09-11 Thread reviewboard


Comment #3 on issue 2933 by trowb...@gmail.com: Trim blank lines from the  
end (and beginning?) of review comments

http://code.google.com/p/reviewboard/issues/detail?id=2933

Edward, I think we have a pending change up that already fixes this:  
https://reviews.reviewboard.org/r/4533/


Sorry about the miscommunication.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2933 in reviewboard: Trim blank lines from the end (and beginning?) of review comments

2013-09-11 Thread reviewboard


Comment #5 on issue 2933 by trowb...@gmail.com: Trim blank lines from the  
end (and beginning?) of review comments

http://code.google.com/p/reviewboard/issues/detail?id=2933

Ok, it sounds like Christian's change fixes rendering in on the page but  
doesn't strip extra whitespace from the text itself, which means that  
editing it again still has extra lines, and emails will have them. You're  
welcome to work on this if you want :)


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2933 in reviewboard: Trim blank lines from the end (and beginning?) of review comments

2013-09-11 Thread reviewboard


Comment #6 on issue 2933 by chip...@gmail.com: Trim blank lines from the  
end (and beginning?) of review comments

http://code.google.com/p/reviewboard/issues/detail?id=2933

Sorry for the confusion!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2933 in reviewboard: Trim blank lines from the end (and beginning?) of review comments

2013-09-11 Thread reviewboard


Comment #7 on issue 2933 by edwlee...@gmail.com: Trim blank lines from the  
end (and beginning?) of review comments

http://code.google.com/p/reviewboard/issues/detail?id=2933

Okay I'll work on this!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3089 in reviewboard: Cannot post review request using parent diff with git-svn

2013-09-11 Thread reviewboard

Status: New
Owner: trowb...@gmail.com
Labels: Type-Defect Priority-Medium Component-RBTools

New issue 3089 by trowb...@gmail.com: Cannot post review request using  
parent diff with git-svn

http://code.google.com/p/reviewboard/issues/detail?id=3089

This was reported via our support channel by Eddie Monge.

Our company uses a svn repo and I interact with it using git svn (easier  
branching). I will often make a branch, commit some code, post that code  
for review, and while I am waiting for the code to be reviewed, create some  
new commits (either in the same branch or a new branch based off that one).  
Is there a way to post those new commits without it showing the original  
commit that is already waiting for a review? It seems like it posts all the  
commits up until the last dcommit. I tried using the --parent=HEAD~1 but it  
doesn't seem to work with git svn


He tried with both 0.5 and 0.5.2 and neither works. The Review Board  
version is 1.5.4


post-review -do --summary=$SUMMARY --description=$DESCRIPTION  
--bugs=$BUG --branch=$BRANCH --testing-done=$TESTING --parent=HEAD~1  
-p




RBTools 0.5
Python 2.7.2 (default, Oct 11 2012, 20:14:37)

[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)]

Running on Darwin-12.4.0-x86_64-i386-64bit
Home = /Users/eddie
Current Directory = /Users/eddie/Sites/frontend
Checking the repository type. Errors shown below are mostly harmless.

DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git svn info
DEBUG:root:repository info: Path: svn://zob, Base path:  
/repo/trunk/apps/frontend, Supports changesets: False

Finished checking the repository type.
HTTP GETting api/info/

DEBUG:root:Running: git merge-base HEAD~1 refs/heads/2-p-sidebar
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u  
HEAD~1

DEBUG:root:Running: git svn find-rev HEAD~1
DEBUG:root:Running: git diff --no-color --no-prefix --no-ext-diff -r -u  
c2794c6490b6a87e96ca7f0d3806561d481ab029..HEAD~1
DEBUG:root:Running: git svn find-rev  
c2794c6490b6a87e96ca7f0d3806561d481ab029

Traceback (most recent call last):
  File /usr/local/bin/post-review, line 8, in module
load_entry_point('RBTools==0.5', 'console_scripts', 'post-review')()
  File build/bdist.macosx-10.8-intel/egg/rbtools/postreview.py, line  
1310, in main

TypeError: object of type 'NoneType' has no len()


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2933 in reviewboard: Trim blank lines from the end (and beginning?) of review comments

2013-09-11 Thread reviewboard


Comment #4 on issue 2933 by edwlee...@gmail.com: Trim blank lines from the  
end (and beginning?) of review comments

http://code.google.com/p/reviewboard/issues/detail?id=2933

No problem.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.