ReviewBoard n Eclipse Integration
Hi I had installed the Mylyn Reviews Connector: ReviewBoard and successfully added the repository. But when I right click on any project and go to Team, I cant find the option Create Review Request. I restarted eclipse too. Plz Help. Thanx -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Does ReviewBoard Installation support SSo using Google accounts?
On 09/01/2014 05:05 PM, David Trowbridge wrote: Ritu, This is not currently possible. -David On Mon, Sep 1, 2014 at 3:55 AM, Ritu Kamthan ritu.kamt...@clariontechnologies.co.in mailto:ritu.kamt...@clariontechnologies.co.in wrote: Hi All, We are trying to use ReviewBoard company wide for all projects. To get the easy conversion of people on RB, we want to know if ReviewBoard supports single sign on using Google account? If yes, where can I find pointers to make it enabled? Thanks for taking out time. Work is being done (outside of the core Review Board team) to add OpenID support to Review Board, which should work with https://developers.google.com/accounts/docs/OAuth2Login once it is complete. I wouldn't expect this to land before Review Board 2.1 though. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
rbt post not working with revision-range and other options in git for code already pushed to the remote
Hi , We are using git as Version Control and we are using the rbt tool for raising the review requests. Version info RBTools 0.6.2 git version 1.8.3.1 1. rbt post working fine for commits which are not pushed to remote. 2. But same fails when we try to raise review with already pushed code. Below are the various scenarios tried for this: 1. rbt post --guess-summary --guess-description --tracking-branch origin/master --revision-range= 986fb30aae..58184a45a --server Myreviewboradserver 2. rbt post R1..R2 --guess-summary --guess-description 3. rbt post R1..R2 --guess-summary --guess-description --parent=origin/master In all above cases, it is failing by saying the error message: Unable to find a Review Board server for this source code tree. But on the same working copy, if we generate review before pushing the commits to remote, it worked as expected: [srij@lccscm Demo]$ rbt post --guess-summary --guess-description --server http://xyz.com/ --debug RBTools 0.6.2 Python 2.7.5 (default, Nov 12 2013, 16:18:42) [GCC 4.8.2 20131017 (Red Hat 4.8.2-1)] Running on Linux-3.11.6-201.fc19.x86_64-x86_64-with-fedora-19-Schrödingerâs_Cat Home = /home/srij Current directory = /home/srij/gitlab/Demo Checking for a Subversion repository... Running: svn info --non-interactive Command exited with rc 1: ['svn', 'info', '--non-interactive'] svn: E155007: '/home/srij/gitlab/Demo' is not a working copy --- Checking for a Git repository... Running: git rev-parse --git-dir Running: git config core.bare Running: git rev-parse --show-toplevel Running: git symbolic-ref -q HEAD Running: git config --get branch.master.merge Running: git config --get branch.master.remote Running: git config --get remote.origin.url repository info: Path: g...@xyz.abc/Demo.git, Base path: , Supports changesets: False Making HTTP GET request to http://xyz.abc/api/ Making HTTP GET request to http://xyz.abc/api/info/ Running: git rev-parse refs/heads/master Running: git merge-base 30126f8c24bc30bc7c4f68b03a913f16ce4ed007 origin/master Running: git rev-parse 8a727c5917e783ca82a22a2bdbb7021ea1a05469 Running: git status --porcelain --untracked-files=no Running: git diff --no-color --full-index --ignore-submodules 8a727c5917e783ca82a22a2bdbb7021ea1a05469..30126f8c24bc30bc7c4f68b03a913f16ce4ed007 -M Running: git log --reverse --pretty=format:%s%n%n%b ^8a727c5917e783ca82a22a2bdbb7021ea1a05469 30126f8c24bc30bc7c4f68b03a913f16ce4ed007 Making HTTP GET request to http://xyz.abc/api/review-requests/ Making HTTP POST request to http://xyz.abc/api/review-requests/ Making HTTP GET request to http://xyz.abc/api/review-requests/422/diffs/ Making HTTP POST request to http://xyz.abc/api/review-requests/422/diffs/ Making HTTP GET request to http://xyz.abc/api/review-requests/422/draft/ Making HTTP PUT request to http://xyz.abc/api/review-requests/422/draft/ Review request #422 posted. http://xyz.abc/r/422/ http://xyz.abc/r/422/diff/ What is wrong with this? How can I raise review request for already commited code? Regds, Srinivas J -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 2.0.6 and Subversion - API Error 207.
Ok, figured that out:
ReviewBoard's Subversion repository configuration must point to the root of
the repository(see also
https://code.google.com/p/reviewboard/issues/detail?id=1969)
in my case it changing
https://fs.company.com/svn-proj/a/b/c/d
to
https://fs.company.com/svn-proj
fixed the issue
On Friday, August 29, 2014 3:25:23 PM UTC-4, Eugene wrote:
Read few posts about API Error 207, but still can't figure the problem
with my setup (this is a completely new RB installation for my company).
In the log below I replaced real path and file names with \a\b\c\d\e\f ...
I also verified that all svn commands shown in debug log work ok.
C:\svn-proj\a\b\c\drbt post -d --username name --password pass
--server https://reviewboard.company.com/ --repository Foo -I e\f\myfile.h
RBTools 0.6.2
Python 2.7.7 (default, Jun 1 2014, 14:21:57) [MSC v.1500 64 bit
(AMD64)]
Running on Windows-7-6.1.7601-SP1
Home = C:\Users\Eugene\AppData\Roaming
Current directory = C:\svn-proj\a\b\c\d
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: https://fs.company.com/svn-proj, Base path:
/a/b/c/d, Supports changesets: False
Making HTTP GET request to https://reviewboard.company.com/api/
Running: svn info --non-interactive
Running: diff --version
repository info: Path: https://fs.company.com/svn-proj, Base path:
/a/b/c/d, Supports changesets: False
Running: svn status --ignore-externals
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
e\f\myfile.h
Running: svn info e/f/myfile.h
Running: svn info e/f
Running: svn info e
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
e\f\myfile.h --no-diff-deleted
Running: svn info e/f/myfile.h
Running: svn info e/f/myfile.h
Running: svn info e/f/myfile.h
Making HTTP GET request to
https://reviewboard.company.com/api/review-requests/
Making HTTP POST request to
https://reviewboard.company.com/api/review-requests/
Making HTTP GET request to
https://reviewboard.company.com/api/review-requests/5/diffs/
Making HTTP POST request to
https://reviewboard.company.com/api/review-requests/5/diffs/
Got API Error 207 (HTTP code 400): The file was not found in the
repository.
Error data: {u'stat': u'fail', u'file': u'/a/b/c/d/e/f/myfile.h',
u'err': {u'msg': u'The file was not found in the repository.', u'code':
207}, u'revision': u'36504'}
Traceback (most recent call last):
File C:\Python27\Scripts\rbt-script.py, line 9, in module
load_entry_point('RBTools==0.6.2', 'console_scripts', 'rbt')()
File
C:\Python27\lib\site-packages\rbtools-0.6.2-py2.7.egg\rbtools\commands\main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
C:\Python27\lib\site-packages\rbtools-0.6.2-py2.7.egg\rbtools\commands\__init__.py,
line 416, in run_from_argv
exit_code = self.main(*args) or 0
File
C:\Python27\lib\site-packages\rbtools-0.6.2-py2.7.egg\rbtools\commands\post.py,
line 784, in main
submit_as=self.options.submit_as)
File
C:\Python27\lib\site-packages\rbtools-0.6.2-py2.7.egg\rbtools\commands\post.py,
line 551, in post_request
raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff
The file was not found in the repository. (HTTP 400, API Error 207)
Your review request still exists, but the diff is not attached.
https://reviewboard.company.com/r/5/
Repository Foo has the following URL (in the admin setup):
https://fs.company.com/svn-proj/a/b/c/d
I think on server side PySVN is used: based on server log:
18:44:59 INFO
- Using reviewboard.scmtools.svn.pysvn backend for SVN
Pls advise what else could be missing in the setup?
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Any plugin support for extracting review comments from Review Board tool to xl file?
Are you sure that's the correct database server? There are definitely tables. -David On Mon, Sep 1, 2014 at 9:04 PM, Rama krishna imr...@gmail.com wrote: Hi david, Thanks for the reply. Is there any possibilities extracting from back end data bases. I tried in as below I am able to connect to reviewboard data base, but after doing show tables it is displaying empty set please look below console details: = root@pv-test:~# mysql -u root -p Enter password: Welcome to the MySQL monitor. Commands end with ; or \g. Your MySQL connection id is 140 Server version: 5.5.37-0ubuntu0.12.04.1 (Ubuntu) Copyright (c) 2000, 2014, Oracle and/or its affiliates. All rights reserved. Oracle is a registered trademark of Oracle Corporation and/or its affiliates. Other names may be trademarks of their respective owners. Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. mysql show databases; ++ | Database | ++ | information_schema | | mysql | | performance_schema | | reviewboard| ++ 4 rows in set (0.05 sec) mysql use reviewboard; Database changed mysql show tables; Empty set (0.00 sec) mysql == On Monday, September 1, 2014 5:18:11 PM UTC+5:30, Rama krishna wrote: Hi All, I have successfully installed review board and I am using it now. Is there any plugin for extracting review comments from Review Board tool to xl file? *Setup environment Details:* *BitNami Review Board* https://www.google.co.in/url?sa=trct=jq=esrc=ssource=webcd=6cad=rjauact=8ved=0CDQQFjAFurl=http%3A%2F%2Fwiki.bitnami.com%2FApplications%2FBitNami_Review_Boardei=SUqVU9mGN4ONuASe6oDQDQusg=AFQjCNG5tGnCDuE3iRN9pZ2Ug-dOszdy5wsig2=4-xRP4zlD4F6Nd4AC0-5Sgbvm=bv.68445247,d.c2E Installed location: /opt/reviewboard-2.0.1-0 Mysql port : 3307 http port: 8081 Memcached Port: 11212 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Howto revert back to older version after running rb-site install
Reran rb-site install thinking install implied a cleaner configuration, no previous 1.7.27 history, but it really didn't work that way. Found that by deleting the mysql database the history was gone. Still trying to get the first site running so have no review data to loose. When I tried reverting back to the previous version think I should have created a new database name to start with. On Friday, August 29, 2014 7:33:42 PM UTC-5, David Trowbridge wrote: I'm confused. If you had a previous installation, why were you using 'rb-site install'? Upgrades should use 'rb-site upgrade' If easy_install with == isn't changing the active version, you can try deleting the 1.7.27 .egg directory from the python site-packages directory. On Fri, Aug 29, 2014 at 1:30 PM, Ran mm49...@gmail.com javascript: wrote: No luck. Yes I did create a seperate site directory for the 1.7.27, called it /var/www/review27, thats been deleted. ran easy_install with the command line 'easy_install ReviewBoard==1.7.6' then also ran 'rb-site install /var/www/reviewboard', then tried 'easy_install ReviewBoard-1.7.6-py2.6.egg' and 'rb-site install /var/www/reviewboard' Getting similar error, in that it still remembers 1.7.27: /var/www/review27/htdocs/media/uploaded/images is missing So same question, where is the path info of 1.7.27 version saved to? How does it keep remembering I had run easy_install on 1.7.27? thanks for helping. On Thursday, August 28, 2014 2:52:21 PM UTC-5, David Trowbridge wrote: Probably the issue is that your site-packages directory is pointing towards 1.7.27 as the latest. You should be able to run 'easy_install ReviewBoard==1.7.6' to fix that. Was 1.7.6 already set up with a different site directory? -David On Thu, Aug 28, 2014 at 7:34 AM, Ran mm49...@gmail.com wrote: Hello, I am trying to revert back to Reviewboard 1.7.6, I have both 1.7.6 and 1.7.27 installed and was able to swap between them until I ran rb-site install /var/www/reviewboard Now its stuck on page Review Board version mismatch and says to run rb-site upgrade Where is the history of version 1.7.27 stored so I can remove it. reviewboard: 1.7.6 rbtools: 0.5.0 python: 2.6 os: rhel 6 MySQL Thanks. -- Get the Review Board Power Pack at http://www.reviewboard.org/ powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: rbt post not working with revision-range and other options in git for code already pushed to the remote
It would be very helpful if you could give us the --debug output for the commands that fail (rather than the command that succeeds). -David On Tue, Sep 2, 2014 at 6:54 AM, Jillala Srinivas srinivasredd...@gmail.com wrote: Hi , We are using git as Version Control and we are using the rbt tool for raising the review requests. Version info RBTools 0.6.2 git version 1.8.3.1 1. rbt post working fine for commits which are not pushed to remote. 2. But same fails when we try to raise review with already pushed code. Below are the various scenarios tried for this: 1. rbt post --guess-summary --guess-description --tracking-branch origin/master --revision-range= 986fb30aae..58184a45a --server Myreviewboradserver 2. rbt post R1..R2 --guess-summary --guess-description 3. rbt post R1..R2 --guess-summary --guess-description --parent=origin/master In all above cases, it is failing by saying the error message: Unable to find a Review Board server for this source code tree. But on the same working copy, if we generate review before pushing the commits to remote, it worked as expected: [srij@lccscm Demo]$ rbt post --guess-summary --guess-description --server http://xyz.com/ --debug RBTools 0.6.2 Python 2.7.5 (default, Nov 12 2013, 16:18:42) [GCC 4.8.2 20131017 (Red Hat 4.8.2-1)] Running on Linux-3.11.6-201.fc19.x86_64-x86_64-with-fedora-19-Schrödingerâs_Cat Home = /home/srij Current directory = /home/srij/gitlab/Demo Checking for a Subversion repository... Running: svn info --non-interactive Command exited with rc 1: ['svn', 'info', '--non-interactive'] svn: E155007: '/home/srij/gitlab/Demo' is not a working copy --- Checking for a Git repository... Running: git rev-parse --git-dir Running: git config core.bare Running: git rev-parse --show-toplevel Running: git symbolic-ref -q HEAD Running: git config --get branch.master.merge Running: git config --get branch.master.remote Running: git config --get remote.origin.url repository info: Path: g...@xyz.abc/Demo.git, Base path: , Supports changesets: False Making HTTP GET request to http://xyz.abc/api/ Making HTTP GET request to http://xyz.abc/api/info/ Running: git rev-parse refs/heads/master Running: git merge-base 30126f8c24bc30bc7c4f68b03a913f16ce4ed007 origin/master Running: git rev-parse 8a727c5917e783ca82a22a2bdbb7021ea1a05469 Running: git status --porcelain --untracked-files=no Running: git diff --no-color --full-index --ignore-submodules 8a727c5917e783ca82a22a2bdbb7021ea1a05469..30126f8c24bc30bc7c4f68b03a913f16ce4ed007 -M Running: git log --reverse --pretty=format:%s%n%n%b ^8a727c5917e783ca82a22a2bdbb7021ea1a05469 30126f8c24bc30bc7c4f68b03a913f16ce4ed007 Making HTTP GET request to http://xyz.abc/api/review-requests/ Making HTTP POST request to http://xyz.abc/api/review-requests/ Making HTTP GET request to http://xyz.abc/api/review-requests/422/diffs/ Making HTTP POST request to http://xyz.abc/api/review-requests/422/diffs/ Making HTTP GET request to http://xyz.abc/api/review-requests/422/draft/ Making HTTP PUT request to http://xyz.abc/api/review-requests/422/draft/ Review request #422 posted. http://xyz.abc/r/422/ http://xyz.abc/r/422/diff/ What is wrong with this? How can I raise review request for already commited code? Regds, Srinivas J -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
If the last API request was to fetch the commits list, then it's not even trying to send the patch to the server. Trying to set up a repro case with your particular files won't help because it's a problem in the javascript before it ever actually deals with the file. Are you sure there are no errors in firebug? Try opening the panel before doing anything on the page. -David On Mon, Sep 1, 2014 at 11:07 PM, kovalyov...@gmail.com wrote: I don't see any error In network panel of firebug. Last row is http://localhost:8090/reviewboard/api/repositories/2/commits/?branch=Trunkapi_format=json and i'ts status is ok. Can You reproduce this error with my test case (using test.py and test.py.patch)? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard 2.0.6 hungs on new request with non latin symbols
I opened firebug network panel before making new request. There are no errors in firebug. I founded workaround - using Google Chrome instead of Firefox. Maybe it is firefox problem? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Any plugin support for extracting review comments from Review Board tool to xl file?
Hi David, How to check correct data base server? On Monday, September 1, 2014 5:18:11 PM UTC+5:30, Rama krishna wrote: Hi All, I have successfully installed review board and I am using it now. Is there any plugin for extracting review comments from Review Board tool to xl file? *Setup environment Details:* *BitNami Review Board* https://www.google.co.in/url?sa=trct=jq=esrc=ssource=webcd=6cad=rjauact=8ved=0CDQQFjAFurl=http%3A%2F%2Fwiki.bitnami.com%2FApplications%2FBitNami_Review_Boardei=SUqVU9mGN4ONuASe6oDQDQusg=AFQjCNG5tGnCDuE3iRN9pZ2Ug-dOszdy5wsig2=4-xRP4zlD4F6Nd4AC0-5Sgbvm=bv.68445247,d.c2E Installed location: /opt/reviewboard-2.0.1-0 Mysql port : 3307http port: 8081Memcached Port: 11212 -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3549 in reviewboard: AttibuteError when opening review with just filled in Note to Reviewers
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3549 by rasp...@gmail.com: AttibuteError when opening review with just filled in Note to Reviewers https://code.google.com/p/reviewboard/issues/detail?id=3549 What version are you running? ReviewBoard 2.0.6 and Note To Reviewers 1.0 What's the URL of the page containing the problem? https://server/r/45/ What steps will reproduce the problem? 1. I had a review open, posted with rbt and filled with description on the web site. 2. I published the review. 3. I clicked on code diff to report an issue. 4. I published the review. 5. I entered additional explanation in 'Note to reviewers' field. 6. I published the review. 7. The mail of change was sent. What is the expected output? What do you see instead? It should present updated review. Instead it generates a HTTP 500 error. It is impossible to open the review again since it always fails with HTTP 500. Disabling 'Note to Reviewers' extension brought the review back to life. Please note that I had used this extension before without such problems. What operating system are you using? What browser? I run Firefox 31 on Windows 7. Review Board server is hosted on a RedHatEnterpriseLinux 5.9 x86_64. Please provide any additional information below. When HTTP 500 is thrown, an exception is logged: 2014-09-02 15:28:54,825 - ERROR - - Exception thrown for user user at https://server:8081/r/45/ 'NoneType' object has no attribute 'strip' Traceback (most recent call last): File /path/to/reviewboard/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/core/handlers/base.py, line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/accounts/decorators.py, line 21, in _check return login_required(view_func)(*args, **kwargs) File /path/to/reviewboard/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/contrib/auth/decorators.py, line 22, in _wrapped_view return view_func(request, *args, **kwargs) File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/site/decorators.py, line 35, in _check return view_func(request, local_site=local_site, *args, **kwargs) File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py, line 660, in review_detail changedesc.fields_changed[field_id]) File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/fields.py, line 159, in get_change_entry_sections_h tml 'rendered_html': mark_safe(self.render_change_entry_html(info)), File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/fields.py, line 484, in render_change_entry_html old_value = render_markdown(old_value) File /path/to/reviewboard/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/markdown_utils.py, line 209, in render_markdown return markdown(text, **MARKDOWN_KWARGS) File /path/to/reviewboard/lib/python2.7/site-packages/Markdown-2.4.1-py2.7.egg/markdown/__init__.py, line 411, in markdown return md.convert(text) File /path/to/reviewboard/lib/python2.7/site-packages/Markdown-2.4.1-py2.7.egg/markdown/__init__.py, line 275, in convert if not source.strip(): AttributeError: 'NoneType' object has no attribute 'strip' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3549 in reviewboard: AttibuteError when opening review with just filled in Note to Reviewers
Updates: Status: Confirmed Labels: Milestone-Release2.0.x Comment #1 on issue 3549 by chip...@gmail.com: AttibuteError when opening review with just filled in Note to Reviewers https://code.google.com/p/reviewboard/issues/detail?id=3549 This will require a fix in Review Board. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
