Re: Issue 3719 in reviewboard: 2.0.12 fails to render tables in Markdown according to the Markdown reference guide
Comment #1 on issue 3719 by ran...@circularreasoning.com: 2.0.12 fails to render tables in Markdown according to the Markdown reference guide https://code.google.com/p/reviewboard/issues/detail?id=3719 I'm seeing this as well in 2.0.13. Server is linux. I'm running Firefox 38.0.5 in Windows 7 64 bit. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3895 in reviewboard: UnicodeDecodeError when posting reviews
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3895 by ali.kam...@visiercorp.com: UnicodeDecodeError when
posting reviews
https://code.google.com/p/reviewboard/issues/detail?id=3895
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools 0.7.3
What's the URL of the page containing the problem?
http://reviews.internal
What steps will reproduce the problem?
1. Setup a mercurial repository with two committed files: fileA and fileB.
Make sure fileA and fileB have some contents.
2. Remove fileA from the repository
3. Edit fileB and add a unicode copy right symbol:
//
// Copyright © [2010-2015] ...
//
4. Add a new *empty* file to the repository: fileC
4. Run rbt post
What is the expected output? What do you see instead?
I expect a review request to be posted, instead I get this error from rbt:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 476:
ordinal not in range(128)
What operating system are you using? What browser?
Windows 7, Mercurial 3.4.1
Please provide any additional information below.
When a new empty file is added rbt tries to add a custom string to the diff
so that the review contains the fact that a new empty file has been added:
mercurial.py:
for filename in added_empty_files:
if filename not in exclude_files:
diff += ('diff -r %s -r %s %s\n' ...
The problem is the left hand side (diff) is a unicode string in this case
because of the copyright symbol. Python generates a UnicodeDecodeError if
the right encoding is not set.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3896 in reviewboard: rss feed is broken
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3896 by thieu...@hotmail.com: rss feed is broken https://code.google.com/p/reviewboard/issues/detail?id=3896 What version are you running? 2.0.17 What's the URL of the page containing the problem? /admin/ and http://feeds.feedburner.com/ReviewBoardNews What steps will reproduce the problem? 1. Go to news page https://www.reviewboard.org/news/ . Latest news are displayed. 2. Got to admin page or rss feed page. The latest news displayed is Review Board 2.0.13 is released What is the expected output? What do you see instead? The rss feed shoud provide the latest news. What operating system are you using? What browser? Server installed on Ubuntu, tested with Chrome / IE. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3894 by ali.kam...@visiercorp.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? RBTools 0.7.3 What's the URL of the page containing the problem? http://reviews.internal What steps will reproduce the problem? 1. Create a mercurial repository with three committed files, fileA, fileB, and fileC. fileA and fileB must have some content, fileC must be empty. 2. Remove fileA. Edit contents of fileB. 3. rbt post What is the expected output? What do you see instead? I expected the posted review to only contain fileA and fileB. The posted review contains fileC as well. What operating system are you using? What browser? Windows 7, Mercurial 3.4.1 Please provide any additional information below. The problem is RBT tries to locate newly added empty files by running two commands: base_files = hg locate -r base tip_empty_files = hg locate -r tip set:size(0) newly_added_empty_files = tip_empty_files - base_files In Windows hg locate -r base returns the following: folder1/subfolder1/fileA.txt folder2/subfolder2/fileB.txt folder1/subfolder3/fileC.txt where as hg locate -r tip set:size(0) returns: folder1\subfolder3\fileC.txt Note that the first command uses a forward slash as path separator, the second uses backslash as path separator. When calculating the set difference fileC.txt doesn't match and rbt posts it as a newly added file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Comment #1 on issue 3894 by ali.kam...@visiercorp.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 Patch submitted: https://reviews.reviewboard.org/r/7443/diff/1#index_header -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Comment #2 on issue 3894 by trowb...@gmail.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 Issue 3556 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: email issue on RB group vs people
If there's no mailing list configured, and emails to users added directly get through but those to group members don't, it's possible that people's clients/e-mail filter rules/spam detection are messing up on cc vs. to. If there's a group assigned and a user, the group members will be cc'd and the user will be in the to field. E-mail addressing and sending is very well tested, and the problem almost always is on the receiving side rather than the sending side. -David On Sun, Jun 21, 2015 at 4:17 PM, MoonWalker daniel.cabrera...@gmail.com wrote: hi David, a) Yes is empty, no spaces b) Yes I am sure, nobody on any group gets any email from RB. Not sure if this is related or not, but I had to migrate the RB DB from one server to a new one. The only issue that I noticed post migration is related to email. Also if I user request to reset his email RB wont sent any email :-( cheers On Saturday, June 20, 2015 at 8:29:58 AM UTC+10, David Trowbridge wrote: a) you're sure it's empty? no whitespace in there? b) you're sure everyone is a member of that group? -David On Thu, Jun 18, 2015 at 7:18 PM, MoonWalker daniel.c...@gmail.com wrote: it is empty On Friday, June 19, 2015 at 12:12:44 PM UTC+10, David Trowbridge wrote: Please check the group configuration and check that the mailing list field is empty. -David On Thu, Jun 18, 2015 at 6:02 PM MoonWalker daniel.c...@gmail.com wrote: David, I setup the mail server (Settings - Email - EMail Server - Mail Server). I was under the impression that once that I establish the members of a group, RB will send an email to all the group members, but that is not the case. I have to add them to the People to have the expected result. Do I need to configure anything else on RB ? On Friday, June 19, 2015 at 10:14:18 AM UTC+10, David Trowbridge wrote: Does the group have a mailing list configured? If so, e-mail to that group will be sent only to the list and not to the group members. -David On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.c...@gmail.com wrote: I have noticed this issue since several versions, not sure if this is a know issue or something else in my configuration, but basically in Reviewers I need to add each team member to People, because if I add the group they wont receive any email. not sure why. All these people are part of the same group, but still not email. BTW I am using the latest RB version -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com.
Issue 3897 in reviewboard: Perforce descriptions submitted via rbt post with GUESS_FIELDS enabled are incorrectly parsed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3897 by buck.a...@gmail.com: Perforce descriptions submitted via rbt post with GUESS_FIELDS enabled are incorrectly parsed https://code.google.com/p/reviewboard/issues/detail?id=3897 What version are you running? ReviewBoard 2.0.13 RBTools 0.7.4 p4 command-line client version P4/LINUX26X86_64/2012.1/473528 (2012/05/31) Perforce server version P4D/LINUX26X86_64/2014.1/963489 (2014/11/18) What's the URL of the page containing the problem? https://reviewboard.example.com/api/review-requests/xx/draft/ What steps will reproduce the problem? 1. Compose a new Perforce change, including a description. Ensure that the description has a few custom fields (e.g. Testing Done:). 2. Post the change to ReviewBoard with `-g auto` or `-g yes`: $ rbt post -g auto CLN 3. Navigate to the review draft page. Note that the change description includes the Testing Done field that should have been parsed into the Testing Done box. The Testing Done box is empty when it should contain the contents of the Testing Done field. What is the expected output? What do you see instead? Expected output: change description (including first-line summary) in the Description text entry. Testing Done field in the Testing Done text entry. Example of expected output for the description field: = Change description summary Change description verbose description = Actual output: change description (with first-line summary removed) in the description box, along with the Testing Done field after it, as well as other fields present that are usually parsed out. The Testing Done box is empty. Example of actual output for the description box: = Change description verbose description Testing Done: [testing done field contents] Reviewed by: [reviewed by field contents] Review URL: [review URL field contents] = For completeness, here is the entirety of the Perforce description of the faux change used for the above two examples: = Change description summary Change description verbose description Testing Done: [testing done field contents] Reviewed by: [reviewed by field contents] Review URL: [review URL field contents] = What operating system are you using? What browser? Linux. Firefox. Please provide any additional information below. The default behavior is a regression from RBTools 0.5.x, which handled Perforce changes correctly. I would somewhat expect `-g yes` to no-op on Perforce repos (since I believe the change description is unconditionally fetched directly from the Perforce server by the ReviewBoard server), and `-g auto` should definitely no-op in this case. I also don't really expect the change description to update when `-g no` is passed, but knowing how the Perforce support works, I'm not really surprised it does either (and don't consider this a bug). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3898 in reviewboard: Enable Markdown checkbox isn't reset when RBTools uploads a new plaintext change description
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3898 by buck.a...@gmail.com: Enable Markdown checkbox isn't reset when RBTools uploads a new plaintext change description https://code.google.com/p/reviewboard/issues/detail?id=3898 What version are you running? ReviewBoard 2.0.13 RBTools 0.7.4 (also reproduces with RBTools 0.5.2) What's the URL of the page containing the problem? https://reviewboard.example.com/api/review-requests/xx/draft/ What steps will reproduce the problem? 1. In your ReviewBoard account settings, uncheck Always use Markdown for text fields and save the settings. 2. Post (but do not publish) a new review using command-line RBTools, including a description. 3. Check the Enable Markdown box on the review description. Press OK. 4. Publish the review. 5. Post a new revision of the review using command-line RBTools, including an updated description. 6. View the review description. Note that even though the description was updated by RBTools, the Enable Markdown checkbox is still checked. What is the expected output? What do you see instead? The Enable Markdown checkbox should have been reset to unchecked to match the user's profile settings and type of the uploaded text. What operating system are you using? What browser? Linux. Firefox. Please provide any additional information below. Always use Markdown for text fields seems to determine the initial state of the Enable Markdown checkbox on text fields but doesn't do anything beyond that. In this case, I was attempting to disable it to avoid ReviewBoard's behavior of escaping Markdown found in uploaded change descriptions. It might be better to instead: Always use Markdown for text fields: This option should behave as it already does (i.e. set the initial state of the Enable Markdown checkbox on text fields). Add an additional Convert non-Markdown review descriptions to Markdown (enable Markdown escaping) sub-option below Always use Markdown for text fields. Any time a change description is uploaded by RBTools to the server, do the following: 1) If the change description is Markdown (i.e. `--markdown` was passed to `rbt post`), check the Enable Markdown checkbox and update the description with the verbatim text received. 2) If the change description is plain text and the Convert non-Markdown review descriptions to Markdown option is enabled, perform Markdown escaping on the change description, check the Enable Markdown checkbox and update the description with the escaped text. 3) If the change description is plain text and the Convert non-Markdown review descriptions to Markdown option is not enabled, uncheck the Enable Markdown checkbox and update the description with the verbatim text received. This allows authoring Markdown descriptions without having to explicitly specify `--markdown` to `rbt post`, and also allows users to disable Markdown conversion/escaping entirely. It also ensures that the Enable Markdown option on the Description field always matches the actual type of the text uploaded by RBTools (or at least what type RBTools thinks it is). If you don't want to add a new option to toggle conversion, then I'd still like to see the state of the Enable Markdown checkbox clobbered by the text type of newly uploaded descriptions. It makes no sense to preserve the existing type when the text is being replaced entirely by `rbt post`. Since RBTools already tells the server the type, it shouldn't be using the user's settings to infer what they want instead of setting the checkbox to the correct value. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard SVN add repository server certificate issuer is not trusted
Hello~ I can't find the folder /home/user/.subversion/auth/svn.ssl.server/ on the step 2. Can you tell me the full path? Is it based on tortioseSVN installed root path, or what? Thanks. 在 2015年4月14日星期二 UTC+8上午5:43:11，Lucas Araujo Manfrim写道： Hello my friends, I spent a lot of time with this stupid problem in ReviewBoard today, and finally got it doing the following: What worked for me was 1. command svn list https repository URL 2. access the folder /home/user/.subversion/auth/svn.ssl.server/ 3. copy the certificate (the file with lots of numbers and letters) to /var/www/reviewboard/data/.subversion/auth/svn.ssl.server/ 4. change the owner of the file to www-data 5. restart the apache http server. A lot of time lost with an action that should be documented at the reviewboard's site. If you are running reviewboard as root (my case), step 4 is not necessary. I really hope this helps you guys. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Hi Christian, It wasn't a browser cache issue as the incorrect results were visible after switch between multiple browsers (using independent browser caches), therefore the problem must have been on the server. I tried to reproduce this again today, but wasn't able to - you could take that as good news ;) When I previously saw the bug, the review was created with 2.0.15 and then continued to have more diff sets added after the server had been upgraded to 2.0.17. I don't know whether that aspect is relevant. Anyway, I'll keep an eye on this and if I can reproduce it reliably I'll let you know. In the mean time, ignore this bug report. Thanks, Paul On Saturday, June 20, 2015 at 3:16:14 AM UTC+1, Christian Hammond wrote: Hi Paul, Thanks for reporting this. I went through our caching code, and I'm not really sure why this is happening off-hand. Were you able to fix this by clearing your browser cache, or did you have to restart memcached? Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Paul Fee paul@gmail.com javascript: Reply: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Date: June 18, 2015 at 9:45:59 AM To: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Subject: Re: Review Board 2.0.16 is released, with security fixes and more Hi Christian, I'm seeing some buggy behaviour around the caching of diffs. It looks like a server side problem as the buggy diff content persists even if I reload with CTRL-F5 or switch browsers (e.g. firefox to chromium). Steps to reproduce: 1. Change some code, I happen to be using SVN. 2. Upload diff to existing review. $ rbt post -r XXX svn_changelist 3. View the draft interdiff, all it ok at this point. 4. Change the code some more without publishing draft changes. 5. Upload diff again, should change content of draft diff. $ rbt post -r XXX svn_changelist 6. View the draft interdiff - BUG - diff content on web page is from first upload, changes from second rbt post are not displayed. From the 2.0.16 release notes, If a diff has already been viewed once, by anyone, it will be quicker to retrieve and display.. I suspect the draft is being cached. A blunt fix could be to avoid caching diffs for drafts. A better fix would be to invalidate caches for draft diffs when a new diffset is uploaded. Hopefully those steps are clear enough for you to reproduce the issue. Let me know if you need more information. Thanks, Paul -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reset password issue
The password reset is just presentation on top of django's implementation. I believe the decision to not show an error is an intentional one to prevent people from getting information about the registered users on the system by issuing lots of password resets. -David On Sun, Jun 21, 2015 at 4:23 PM, MoonWalker daniel.cabrera...@gmail.com wrote: This seems like a bug in the reset password mechanism on the latest RB version. I tried to reset my password and I had some typos in my email, but RB board did not complain about a valid email address, so I tried to introduce a random set of strings with a @ and RB is happy, but no complains . -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3895 in reviewboard: UnicodeDecodeError when posting reviews
Comment #1 on issue 3895 by ali.kam...@visiercorp.com: UnicodeDecodeError when posting reviews https://code.google.com/p/reviewboard/issues/detail?id=3895 Patch submitted: https://reviews.reviewboard.org/r/7442/diff/1/#index_header -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Unable to add repository to ReviewBoard
Hi, I try to modify the file D:\Bitnami\reviewboard-2.0.15-0\apps\reviewboard\rb-sites\reviewboard\data\.subversion\servers, add a line as below: ssl-authority-files = auth/svn.ssl.server/server.pem Then I copy the server.pem file from my VisualSVN Server's path D:\Program Files\VisualSVN Server\certs\server.pem to the path D:\Bitnami\reviewboard-2.0.15-0\apps\reviewboard\rb-sites\reviewboard\data\.subversion\auth\svn.ssl.server\, and I restart the reviewboard apache. I try again to add a repository and click the save button, reviewboard reponse a new error information as below: Unable to connect to a repository at URL '' https://XXX.XXX.XXX.XXX/svn/project https://xxx.xxx.xxx.xxx/svn/project'' Invalid config: unable to load certificate file 'auth\svn.ssl.server\server.pem' So I think maybe I should get the SVN Server's auth file (some file like the server.pem), and add it to the reviewboard path above. But I don't know how to get this auth file. Can you give me more advise? Thanks. ageha67 在 2015年6月18日星期四 UTC+8上午4:30:47，Christian Hammond写道： Hi, It sounds like your SSL certificate is expecting to serve one domain, but is being accessed as a different domain. You'll need to use the one specified for the SSL certificate. That is, if the cert is for svnserver.mydomain.com, and you're configuring Review Board to access it as just svnserver or svnserver.mydomain or some-other-name, it won't work, and you will need to use svnserver.mydomain.com instead. Not knowing the domain you're using or the repository configuration, I can't really be of too much assistance with specifics there. I hope that helps, though. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: ageha67 xiaoxi...@gmail.com javascript: Reply: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Date: June 16, 2015 at 11:13:34 PM To: revie...@googlegroups.com javascript: revie...@googlegroups.com javascript: Subject: Unable to add repository to ReviewBoard Hi All, I setup the Review Board 2.0.15 on Window (Bitnami Version) and I can checkout my code at my computer(use https). My SVN server is setuped on another PC. When I add repository using https, I get blow error : Unable to connect to a repository at URL 'https://XXX.XXX.XXX.XXX/svn/project' OPTIONS of 'https://XXX.XXX.XXX.XXX/svn/project': Server certificate verification failed: certificate issued for a different hostname, issuer is not trusted (https://XXX.XXX.XXX.XXX) Please help me! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue 3899 in reviewboard: New Feature: User can edit the comment
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3899 by liping.huang2...@gmail.com: New Feature: User can edit the comment https://code.google.com/p/reviewboard/issues/detail?id=3899 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 2.0.13 Currently user can add comment to the review request, but after user post the comment, the comment cannot edit anymore, please add the edit feature for the comments. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
