Hi Christian, It wasn't a browser cache issue as the incorrect results were visible after switch between multiple browsers (using independent browser caches), therefore the problem must have been on the server.
I tried to reproduce this again today, but wasn't able to - you could take that as good news ;) When I previously saw the bug, the review was created with 2.0.15 and then continued to have more diff sets added after the server had been upgraded to 2.0.17. I don't know whether that aspect is relevant. Anyway, I'll keep an eye on this and if I can reproduce it reliably I'll let you know. In the mean time, ignore this bug report. Thanks, Paul On Saturday, June 20, 2015 at 3:16:14 AM UTC+1, Christian Hammond wrote: > > Hi Paul, > > Thanks for reporting this. I went through our caching code, and I'm not > really sure why this is happening off-hand. Were you able to fix this by > clearing your browser cache, or did you have to restart memcached? > > Christian > > -- > Christian Hammond - chri...@beanbaginc.com <javascript:> > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -----Original Message----- > From: Paul Fee <paul....@gmail.com <javascript:>> > Reply: revie...@googlegroups.com <javascript:> <revie...@googlegroups.com > <javascript:>>> > Date: June 18, 2015 at 9:45:59 AM > To: revie...@googlegroups.com <javascript:> <revie...@googlegroups.com > <javascript:>>> > Subject: Re: Review Board 2.0.16 is released, with security fixes and > more > > > Hi Christian, > > > > I'm seeing some buggy behaviour around the caching of diffs. It looks > like > > a server side problem as the buggy diff content persists even if I > reload > > with CTRL-F5 or switch browsers (e.g. firefox to chromium). > > > > Steps to reproduce: > > > > 1. Change some code, I happen to be using SVN. > > 2. Upload diff to existing review. > > $ rbt post -r XXX svn_changelist > > 3. View the draft interdiff, all it ok at this point. > > 4. Change the code some more without publishing draft changes. > > 5. Upload diff again, should change content of draft diff. > > $ rbt post -r XXX svn_changelist > > 6. View the draft interdiff - BUG - diff content on web page is from > first > > upload, changes from second "rbt post" are not displayed. > > > > From the 2.0.16 release notes, "If a diff has already been viewed once, > by > > anyone, it will be quicker to retrieve and display.". I suspect the > draft > > is being cached. A blunt fix could be to avoid caching diffs for drafts. > > A better fix would be to invalidate caches for draft diffs when a new > > diffset is uploaded. > > > > Hopefully those steps are clear enough for you to reproduce the issue. > Let > > me know if you need more information. > > > > Thanks, > > Paul > > > > -- > > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > > Happy user? Let us know! https://www.reviewboard.org/users/ > > --- > > You received this message because you are subscribed to the Google > Groups "reviewboard" > > group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com <javascript:>. > > For more options, visit https://groups.google.com/d/optout. > > > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
