--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4617/
--
New update by jhominal
For Beanbag, Inc. > Review Board > Ticket #4617
Hi,
I'm testing the setExtraData in this way now (also to simply the code
demonstration here)
In reviewboard/static/rb/js/views/reviewDialogView.es6.js, method
"_saveReview". I added/modified 2 lines inside the 1st block f of
funcQueue('reviewForm').add:
I can confirm that when updating rbstopwatch to use setExtraData() followed
by a save(), it works properly. I'd need to see what your code and the data
from the browser looks like to figure out what's going wrong.
Christian
On Thu, Dec 14, 2017 at 12:31 PM, Christian Hammond <
Sorry, I realize rbstopwatch isn't using setExtraData, but rather setting
extraData manually. I'm going to toy with the code here, see if I can
reproduce the problem.
Christian
On Thu, Dec 14, 2017 at 12:29 PM, Christian Hammond <
christ...@beanbaginc.com> wrote:
> Hi,
>
> Can you show me your
Hi,
Can you show me your code that both sets this and then saves the review,
along with what the browser is reporting being sent to and received from
the server? (Full headers and payloads would help.)
rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed
that, setExtraData
Hi Peter,
The LDAP code hasn't changed between the releases. When logging in via LDAP
for the first time, a local User entry is created with details coming from
LDAP, but those details aren't re-queried from LDAP later, so a user that
existed in 2.5.17 should have the same details as one in
That's such an annoying problem. Chrome has removed all ability to prevent
that from happening. We're going to need to consider some alternative to
password fields...
As for where to look, there's https://hellosplat.com/s/beanbag/tickets/ (or
https://www.reviewboard.org/bugs/, which redirects
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4610/
--
New update by Misery
For Beanbag, Inc. > Review Board > Ticket #4610
"Possibly related but it seems that comments on existing reviews aren't
generating emails." - Disregard this, chrome remembering my
Username/Password was autopopulating those fields in the email settings
page which got picked up when I saved something else. My bad.
On Thursday, 14 December
Sorry to be so noisy Christian, I'm now seeing problems with gravatar
sourced images. The switch to v3x has moved to use a srcset which makes
sense but the actual links being used have changed.
At a wild guess it looks like it's related to ldap use, possibly different
fields being used to
Hi Christian,
No problem, that's the price of progress. Is there somewhere else I should
be looking for these known bugs before reporting them and adding noise?
Possibly related but it seems that comments on existing reviews aren't
generating emails.
Thanks,
Peter
On Thursday, 14 December
Hi,
I'm getting desperate after hours' searching/trying... One of our
extensions doesn't work now in RVB3.0 because previous setExtraData method
doesn't work anymore for review model.
In my implementation, I wrote one RB.ReviewDialogHook javascript hook with
one customized view. And I would
12 matches
Mail list logo
