404 when adding line comment

2009-09-23 Thread Pv
\__init__.py, line 87, in get_object_or_404 raise Http404('No %s matches the given query.' % queryset.model._meta.object_name) Http404: No FileDiff matches the given query. The diff was uploaded via the post-review tool. Pv --~--~-~--~~~---~--~~ You received

Re: 404 when adding line comment

2009-09-23 Thread Pv
and used the admin to view the review request draft to change I got a 500 error. Once published I can admin the non-draft review just fine. Pv On Sep 23, 5:05 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Yep, this is the right mailing list. So first of all, did you mean to install

easy_install rbtools on py26?

2009-10-29 Thread Pv
and that simplejson is for legacy support on 2.5 2.4. So why does easy_install rbtools want to install simplejson? Thanks! Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http

RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type

2009-10-29 Thread Pv
of the error, but the code of post-review looks like it should ignore this. Am I doing something wrong? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http

Re: RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type

2009-10-29 Thread Pv
Duh! This is a diff problem that I ran in to before...fixing now. Pv On Oct 29, 10:43 am, Pv p...@swooby.com wrote: I am doing a post-commit review on a teammate's checked in C# code on an SVN server. I run: post-review -d --revision-range=24506 And I get the following output: svn info

Re: RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type

2009-10-29 Thread Pv
Opened 1378 Pv On Oct 29, 11:34 am, Christian Hammond chip...@chipx86.com wrote: Glad you figured it out. We need to check for that and fail gracefully. Would you mind filing a bug so we can track it for the release? Christian -- Christian Hammond - chip...@chipx86.com Review Board

How to post-commit review a first time checkin?

2009-10-29 Thread Pv
I am using the following command to do a post-commit review on a first time checkin: post-review -d --revision-range=24506 Obviously, I am not specifying a from:to range, but since this is a first time checking any earlier from svn rev # wouldn't exist in the newly created path. The [debug]

Re: easy_install rbtools on py26?

2009-11-03 Thread Pv
Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Oct 29, 2009 at 10:37 AM, Pv p...@swooby.com wrote: I had ActivePython 2.6 installed and installed ezsetup for py26 (on a x64 Windows 2K8 Server). I then tried easy_install rbtools and it failed when

Re: post-review error: WindowsError: [Error 2] The system cannot find the file specified

2009-11-07 Thread Pv
I ran in to the same thing and opened a bug to make a missing diff binary a friendlier message. Pv On Nov 6, 10:24 pm, Akhilesh akhileshjo...@gmail.com wrote: After a lot of troubleshooting I found the problem: diff.exe was not present in the PATH. On Nov 6, 2:57 pm, Akhilesh akhileshjo

Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
I've fought this one all day while setting up a new RB server. Server: W2K3, Apache2.2, Python25, plus all of the other required trimmings. I have installed 2 other RB servers [on XP] and hadn't seen this problem before. I install the server and can log in and create users and change other

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
Running dev version does same thing; it immediately quits. The output is: Running dependency checks (set DEBUG=False to turn this off)... Warning: p4python (=07.3) not found. Perforce integration will not work. Warning: hg not found. Mercurial integration will not work. Warning: PyLucene (with

Re: Can't create/edit repo w/ 20091110 nightly build

2009-11-10 Thread Pv
Well, I cleaned my W2K3 Server's Python25 directory and reinstalled all required modules and things started to work fine. I inherited the machine, and I guess it was in a dirty state. :( All is good now! Pv --~--~-~--~~~---~--~~ Want to help the Review Board

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-23 Thread Pv
NOTE: If I manually browse to my reviewboard server and upload the diff it accepts it no problem. I am not doing anything to intentionally encode these files beyond the default VS2K8 encoding. Pv On Feb 23, 4:20 pm, Pv p...@swooby.com wrote: I have installed a fresh copy of Win7 x64 and VS2K8

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-24 Thread Pv
1.1 alpha 2 (dev) I am pretty sure this aborts in RBTools itself before it ever gets to the server. Again, a manual upload of the diff file to the server works fine. Pv On Feb 23, 5:27 pm, Christian Hammond chip...@chipx86.com wrote: Hi Pv, Which version of Review Board is this? Christian

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
in to the problem w/ default encoding I have tried saving the culprit files w/ various other encodings, but nothing seems to make post-review happy. Pv On Feb 24, 4:55 pm, Pv p...@swooby.com wrote: 1.1 alpha 2 (dev) I am pretty sure this aborts in RBTools itself before it ever gets

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
Yes, I just commented that out and the upload was successful. Pv On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com wrote: On Thursday 25 February 2010 01:55:42 Pv wrote: I am pretty sure this aborts in RBTools itself before it ever gets to the server. Again, a manual upload

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
It should have been: return content_type, content.encode('utf-8', 'ignore') Pv On Feb 25, 12:43 pm, Pv p...@swooby.com wrote: Yes, I just commented that out and the upload was successful. Pv On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com wrote: On Thursday 25

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
be. Pv On Feb 25, 12:48 pm, Pv p...@swooby.com wrote: It should have been:         return content_type, content.encode('utf-8', 'ignore') Pv On Feb 25, 12:43 pm, Pv p...@swooby.com wrote: Yes, I just commented that out and the upload was successful. Pv On Feb 25, 12:25 pm, Thilo

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-02-25 Thread Pv
codecs.utf_8_decode(input, errors, True) UnicodeDecodeError: 'utf8' codec can't decode bytes in position 5-6: unexpected end of data u = unicode(s, 'utf8', 'ignore') u u'La Pe' u = unicode(s, 'utf8', 'replace') u u'La Pe\ufffd' Pv -- Want to help the Review Board project? Donate today

Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1

2010-03-03 Thread Pv
rectangle around the initial BOM chars. The existence of BOM chars is normal and should be gracefully/silently ignored. A red box indicates to me an error/warning of some sort. If the BOM differs between the two files then that should be gracefully indicated. Pv On Feb 26, 11:13 am, Christian Hammond