Re: [Question] Why Doesn't the perforce project appear in reviews?
You are correct :) Downloading all patches and filter by them is what i do today, but it's a lot of patches to download in vain and a concept of projects/components as a meta field for reviews could have helped in this usecase. I guess my usecase isn't common enough for a change this big though. Another jenkins-reviewbot plugin user suggested adding a regex query for the Review Board API to solve this (return only reviews with files that answer a certain regex for their path/name). Does that sound reasonable as a feature request for Review Board? Thanks! On Sunday, October 4, 2015 at 6:14:39 PM UTC+3, David Trowbridge wrote: > > I'm guessing from your other email that you're at VMware. In that case, > the branch name is parsed out of the changeset description using some > custom code (which includes the "merge to" lines). Perforce generally does > not force a //depot/branch/project layout, so it's not something that we at > Review Board can assume. > > It's also not guaranteed that a patch which is posted for review won't > touch multiple "projects", or even multiple "branches" given that layout. > I'd suggest downloading the patch, checking the file names within, and > using that to figure out what needs to be synced (theoretically you'd > already need to do that to get the version of each file to patch). > > -David > On Sun, Oct 4, 2015 at 8:06 AM Yair Yogev <pro...@gmail.com > > wrote: > >> I'm using the jenkins-reviewbot plugin to fetch reviews of a specific >> project, apply the review diff, run tests and post the result in >> reviewboard. >> The problem is that we can only fetch reviews by perforce server >> (repository) and branch, but the project name isn't stored in any review >> field. >> >> Is there a reason for that? it seems that for perforce, rbtools could >> fill the project just as it fills the branch name*. >> >> Thanks >> >> * I'm assuming the project name is always the level above the branch (is >> that wrong? i know that for svn it can be different) >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Old rbtools - Updating reviews from git overrides fields, ignoring newlines
We use an old version or rbtools, but a new version of reviewboard. It would be great to know if these issues are something we might get rid of by updating the rbtools. 1. When doing post-review (yes, we still use that) of a git commit, the description that appear in reviewboard will be just one long line, ignoring the newlines entered during commit. 2. When updating the same review using "post-review COMMIT_HASH -r REVIEW_NUM" it will override the current values of the review (description & summary), unlike the behavior in perforce where only the diff is updated. I think that our rbtools are as old as 0.5.2 (!). Were the issues above known in that version? is it fixed today? I'm describing our current rbtools with hesitation since I'm not completely sure if it went though any customizations. I'm assuming not, but both David and Christian might know better although they probably last seen it in 2013 :) Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[Question] Why Doesn't the perforce project appear in reviews?
I'm using the jenkins-reviewbot plugin to fetch reviews of a specific project, apply the review diff, run tests and post the result in reviewboard. The problem is that we can only fetch reviews by perforce server (repository) and branch, but the project name isn't stored in any review field. Is there a reason for that? it seems that for perforce, rbtools could fill the project just as it fills the branch name*. Thanks * I'm assuming the project name is always the level above the branch (is that wrong? i know that for svn it can be different) -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Old rbtools - Updating reviews from git overrides fields, ignoring newlines
Thanks for the info David! On Sunday, October 4, 2015 at 6:18:11 PM UTC+3, David Trowbridge wrote: > > post-review at VMware does have some significant modifications (which we > don't have much knowledge of), especially for git. Neither of those issues > sound familiar to me. You can definitely try 'rbt post' / 'ruby post -g' > using a modern rbtools and see if it works for you. > > -David > On Sun, Oct 4, 2015 at 8:06 AM Yair Yogev <pro...@gmail.com > > wrote: > >> We use an old version or rbtools, but a new version of reviewboard. >> It would be great to know if these issues are something we might get rid >> of by updating the rbtools. >> >> 1. When doing post-review (yes, we still use that) of a git commit, the >> description that appear in reviewboard will be just one long line, ignoring >> the newlines entered during commit. >> 2. When updating the same review using "post-review COMMIT_HASH -r >> REVIEW_NUM" it will override the current values of the review (description >> & summary), unlike the behavior in perforce where only the diff is updated. >> >> >> I think that our rbtools are as old as 0.5.2 (!). Were the issues above >> known in that version? is it fixed today? >> >> I'm describing our current rbtools with hesitation since I'm not >> completely sure if it went though any customizations. I'm assuming not, but >> both David and Christian might know better although they probably last seen >> it in 2013 :) >> >> >> Thanks! >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [Question] Why Doesn't the perforce project appear in reviews?
Alright. Thought it might be reasonable since there is already such search for default reviewers (file regex in https://www.reviewboard.org/docs/manual/dev/admin/configuration/default-reviewers/ ) On Monday, October 5, 2015 at 12:31:38 AM UTC+3, David Trowbridge wrote: > > Querying diffs by regex isn't feasible (the diff table can have tens of > millions of rows). What you can do is assign review requests to a group by > regex with a default reviewer and then query review requests by target > group. > > -David > On Sun, Oct 4, 2015 at 8:43 AM Yair Yogev <pro...@gmail.com > > wrote: > >> You are correct :) >> Downloading all patches and filter by them is what i do today, but it's a >> lot of patches to download in vain and a concept of projects/components as >> a meta field for reviews could have helped in this usecase. I guess my >> usecase isn't common enough for a change this big though. >> >> Another jenkins-reviewbot plugin user suggested adding a regex query for >> the Review Board API to solve this (return only reviews with files that >> answer a certain regex for their path/name). Does that sound reasonable as >> a feature request for Review Board? >> >> Thanks! >> >> On Sunday, October 4, 2015 at 6:14:39 PM UTC+3, David Trowbridge wrote: >> >>> I'm guessing from your other email that you're at VMware. In that case, >>> the branch name is parsed out of the changeset description using some >>> custom code (which includes the "merge to" lines). Perforce generally does >>> not force a //depot/branch/project layout, so it's not something that we at >>> Review Board can assume. >>> >>> It's also not guaranteed that a patch which is posted for review won't >>> touch multiple "projects", or even multiple "branches" given that layout. >>> I'd suggest downloading the patch, checking the file names within, and >>> using that to figure out what needs to be synced (theoretically you'd >>> already need to do that to get the version of each file to patch). >>> >>> -David >>> >> On Sun, Oct 4, 2015 at 8:06 AM Yair Yogev <pro...@gmail.com> wrote: >>> >> I'm using the jenkins-reviewbot plugin to fetch reviews of a specific >>>> project, apply the review diff, run tests and post the result in >>>> reviewboard. >>>> The problem is that we can only fetch reviews by perforce server >>>> (repository) and branch, but the project name isn't stored in any review >>>> field. >>>> >>>> Is there a reason for that? it seems that for perforce, rbtools could >>>> fill the project just as it fills the branch name*. >>>> >>>> Thanks >>>> >>>> * I'm assuming the project name is always the level above the branch >>>> (is that wrong? i know that for svn it can be different) >>>> >>>> -- >>>> Supercharge your Review Board with Power Pack: >>>> https://www.reviewboard.org/powerpack/ >>>> Want us to host Review Board for you? Check out RBCommons: >>>> https://rbcommons.com/ >>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to reviewboard...@googlegroups.com. >>> >>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> -David >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -David -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
