Reviewboard 1.7.6 and Adding Comments to a file Attachment

2014-02-26 Thread Chad Peterson
Hello,

We have recently started running 1.7.6 and have found that only the 
original author and anyone with the [ Request | Request Review | Can Change 
Review Request] permission are allowed to add comments to an attachment 
(we're reviewing a word doc).

Is this intended behavior? In other words, is it envisioned that only the 
author of the review request is supposed to be able to add comments to an 
attachment?

Thanks!
-Chad




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


File Attachment Comments - Intended Behavior

2014-02-26 Thread Chad Peterson
Hello all,

We're currently running RB 1.7.6 and we're seeing that the only people who 
can add comments to a file attachment are super users and the person who 
created the review request. Our group thinks that having reviewers adding 
comments (and issues) to an attachment would be useful.

After some digging, adding comments to an attachment appears tied to 
permission [reviews | review request | Can edit review request].

It would seem that the intent was to only all reviews on attachments, and 
not comments.  Are we simply wanting to use RB in an unintended way? Or is 
there a bug or changed behavior in later RB releases?

Many thanks in advance,
-Chad

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: File Attachment Comments - Intended Behavior

2014-02-26 Thread Chad Peterson
Yeah, it's on a published review request.  
 
We see the comment button next to the attachment, but when we click it, 
nothing happens. Unless you're a Superuser, created the request 
yourself, or have the Can Edit review request permission set.
 
 Honestly, i would have expected [ reviews | file attachment comment | Can 
Add file attachment comment] to have some effect, but it didn't make a 
difference.
 
The behavior seemed completely odd to me too.  We'll see if we can get to a 
newer version of ReviewBoard. I'll leave out the rant of how we just got 
this new version... 
 
Cheers for the prompt feedback though. If I learn any more, I'll be sure to 
report back.


On Wednesday, February 26, 2014 2:11:11 PM UTC-6, Christian Hammond wrote:

 Hi Chad, 

 That permission doesn't impact the ability to comment at all. Are you sure 
 the review request's draft is published?

 1.7.6 is also very old. It's possible there was some bug that has since 
 been fixed. Certainly, the behavior you describe is not how it's supposed 
 to be.

 Christian

  -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org 
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, Feb 25, 2014 at 12:43 PM, Chad Peterson 
 chad.m@gmail.comjavascript:
  wrote:

 Hello all,

 We're currently running RB 1.7.6 and we're seeing that the only people 
 who can add comments to a file attachment are super users and the person 
 who created the review request. Our group thinks that having reviewers 
 adding comments (and issues) to an attachment would be useful.

 After some digging, adding comments to an attachment appears tied to 
 permission [reviews | review request | Can edit review request].

 It would seem that the intent was to only all reviews on attachments, 
 and not comments.  Are we simply wanting to use RB in an unintended way? Or 
 is there a bug or changed behavior in later RB releases?

 Many thanks in advance,
 -Chad

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Statistics Extensions

2013-05-24 Thread Chad Peterson
Hello,

What ever came of the statistics extension that was being worked on a 
couple/few years ago?  Is it available in some location for the current 
ReviewBoard release?

Thanks!
-Chad


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Audit facility?

2012-01-05 Thread Chad Peterson
If you need only a simple history of reviews, navigate All Review 
Requests and click on Show Submitted and you'll see the entire list of 
all reviews open and closed.

If your audit is going to require more advanced stuff, then currently you'd 
have to accomplish this through some other means.  Accessing the SQL 
database where ReviewBoard was configured to populate its tables would 
probably be required.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard publish model results in large quantity of email traffic

2011-06-30 Thread Chad Peterson
Hello!

I have a group of about 12 developers who have used ReviewBoard for the past 
three months. In general, they are really pleased and believe it is a much 
better tool for source code review than the tool it replaces, which was 
heavyweight and didn't really support software.

One of the team members asked me if there was a way to limit the number of 
emails they are receiving.  Here is the scenario that can flood their 
inboxes:

1) A developer creates a review, and publishes it
2) Four reviewers create a review, and publish (4 emails generated)
3) The developer goes back and responds to each review, with comments, and 
must push PUBLISH for each review. 4 emails pushed to every developer.

So, I'm wondering, short of turning off email notifications, is there 
something that we can do to limit the number of emails being sent out?  Are 
we misusing or otherwise misconfiguring the tool?

If there's nothing we can do, is there anything on the roadmap to allow 
email fine tuning (such as, only sending the comment back to the author of 
the review to which you're responding?)

Thanks!
Chad

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Swtiched to https but email still links to http

2011-03-11 Thread Chad Peterson
This is hopefully a simple question and answer.

My site was initially setup http://.  I switched it to http*s*://.  All if 
fine and dandy, but the emails generated to users are still pointing to 
http://.

Can anyone point me in the right direction for what I must tweak to get the 
emails pointing to the https:// flavor of my ReviewBoard instance?

I didn't see it in any of the flat files, so potentially it's in the SQL 
tables?

Thanks!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Swtiched to https but email still links to http

2011-03-11 Thread Chad Peterson
Way too simple. I was making that way harder than it was.

Cheers!

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en