Re: Way to send branch review in subversion?

2011-02-03 Thread D Krueger
Are you trying to do the diff against the latest trunk or the trunk
when the branch occurred?

On Feb 3, 10:13 am, Jan Koprowski jan.koprow...@gmail.com wrote:
 Hi,

   I've been poking around in post-review code but I still can't figure it
 out - is there way to send review for whole branch in subversion? Branch I
 mean /branches/my-feature directory in repository and everything in it. Diff
 will be between this and /trunk dir. Something like this.

 Greetings from Poland
 --
 Jan Koprowski

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Way to send branch review in subversion?

2011-02-03 Thread D Krueger
There isn't any support in post-review for Subversion diffs on
separate branches. The only place in the code (that I'm familiar with)
that does a diff between two URLs in the repository is in
SVNClient.diff_between_revisions(). You could probably use that as a
model to add a diff_between_branches() that you could call from
SVNClient.diff() when options.branch is defined.

On Feb 3, 2:05 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
 I think about this scenario:

 1. Developer make branche
 2. Developer make changes on the branch
 3. Developer merge latest trunk to branch
 4. Developer run post-review --tracking-branch my-feature
 5. post-review check is branch svnlook propget svn:mergeinfo
 containe svnlook youngest revision of trunk
 6. If not raise error and ask about merging to latest trunk
 7. If contain make diff between /branches/my-feature and /trunk

 I'm not sure this is fine but ... I think it is fine :)





 On Thu, Feb 3, 2011 at 7:27 PM, D Krueger dekr...@gmail.com wrote:
  Are you trying to do the diff against the latest trunk or the trunk
  when the branch occurred?

  On Feb 3, 10:13 am, Jan Koprowski jan.koprow...@gmail.com wrote:
  Hi,

    I've been poking around in post-review code but I still can't figure it
  out - is there way to send review for whole branch in subversion? Branch I
  mean /branches/my-feature directory in repository and everything in it. 
  Diff
  will be between this and /trunk dir. Something like this.

  Greetings from Poland
  --
  Jan Koprowski

  --
  Want to help the Review Board project? Donate today 
  athttp://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to 
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group 
  athttp://groups.google.com/group/reviewboard?hl=en

 --



  Jan Koprowski- Hide quoted text -

 - Show quoted text -- Hide quoted text -

 - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.

2011-01-04 Thread D Krueger
There is definitely a problem involving mod_wsgi, Python, and
extensions
built with MSVC.

See the question Why do no Python DLLs built with MSVC load with
mod_wsgi?
that's on Stack Overflow:
http://stackoverflow.com/questions/3706293/why-do-no-python-dlls-built-with-msvc-load-with-mod-wsgi

The author there worked around by installing a pycrypto built with
MinGW.

On Jan 4, 10:38 am, mandrake mt02c...@gmail.com wrote:
 Ok, I reinstalled the cryptolibrary and ran the tests using setup.py
 test, ALL OK. I ran the tests with lowest trust level as well, no
 diff (runas /trustlevel:0x2 ...).
 So I figured it might be a user privilege thing, so I tried running
 the apache service as administrator, but there was no difference.

 This is seriously annoying.

 On 4 Jan, 16:10, mandrake mt02c...@gmail.com wrote:



  Ok, I've traced the problem to the Crypto library:

  [Tue Jan 04 16:00:22 2011] [error]   File C:\\Python27\\lib\\site-
  packages\\reviewboard-1.5.1-py2.7.egg\\reviewboard\\diffviewer\
  \forms.py, line 9, in module
  [Tue Jan 04 16:00:22 2011] [error]     from
  reviewboard.diffviewer.diffutils import DEFAULT_DIFF_COMPAT_VERSION
  [Tue Jan 04 16:00:22 2011] [error]   File C:\\Python27\\lib\\site-
  packages\\reviewboard-1.5.1-py2.7.egg\\reviewboard\\diffviewer\
  \diffutils.py, line 30, in module
  [Tue Jan 04 16:00:22 2011] [error]     from reviewboard.scmtools.core
  import PRE_CREATION, HEAD
  [Tue Jan 04 16:00:22 2011] [error]   File C:\\Python27\\lib\\site-
  packages\\reviewboard-1.5.1-py2.7.egg\\reviewboard\\scmtools\
  \core.py, line 5, in module
  [Tue Jan 04 16:00:22 2011] [error]     from reviewboard.scmtools
  import sshutils
  [Tue Jan 04 16:00:22 2011] [error]   File C:\\Python27\\lib\\site-
  packages\\reviewboard-1.5.1-py2.7.egg\\reviewboard\\scmtools\
  \sshutils.py, line 5, in module
  [Tue Jan 04 16:00:22 2011] [error]     import paramiko
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \paramiko\\__init__.py, line 69, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \paramiko\\transport.py, line 32, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \paramiko\\util.py, line 32, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \paramiko\\common.py, line 98, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \paramiko\\rng.py, line 23, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Util\\randpool.py, line 30, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Random\\__init__.py, line 28, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Random\\OSRNG\\__init__.py, line 34, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Random\\OSRNG\\nt.py, line 28, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Random\\OSRNG\\winrandom.py, line 7, in module
  [Tue Jan 04 16:00:22 2011] [error]   File build\\bdist.win32\\egg\
  \Crypto\\Random\\OSRNG\\winrandom.py, line 6, in __bootstrap__
  [Tue Jan 04 16:00:22 2011] [error] ImportError: DLL load failed: The
  specified module could not be found.

  I will try to find out more..

  On 12 Dec 2010, 12:50, Dan birb...@gmail.com wrote:

   Have you found solution to this problem,
   I have the same problem now.

   Could anyone give some hints?
   Any help will be highly appreciated.

   On Dec 1, 3:59 am, Travis dahlke.tra...@gmail.com wrote:

Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?

[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]   File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]   File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]     raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.- Hide quoted text -

 - 

Re: Upgrade problem 1.0.5 to 1.5 RC2

2010-10-04 Thread D Krueger
The carriage returns in the settings fields of django_project_version
were indeed the problem. I converted all cr/lf pairs to lf and the
upgrade worked perfectly.

Thanks for the help.

On Oct 1, 4:52 pm, D Krueger dekr...@gmail.com wrote:
 I've tracked down the source of the problem, but I don't know of a
 solution (if there is one).

 I invoked rb-site on the test site we created when first testing
 1.0.5.
 It worked perfectly.

 So I started using pdb to investigate where rb-site was failing on our
 standard site, which led me to:
   django_evolution/management/__init__.py(54)evolution()-None -
   old_proj_sig = pickle.loads(str(latest_version.signature))

 Then I investigated the differences in the signature values in
 django_project_version for the working and non-working
 installations. The non-working one had ^M after every line because it
 had been migrated from a Windows server.

 My suspicion is that the signature pickled by the Windows server isn't
 compatible with the Linux server. Is that a possbility?

 I'm at a loss as to how to proceed. Any help would be much appreciated
 (as is the help already given).

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade problem 1.0.5 to 1.5 RC2

2010-10-01 Thread D Krueger
I've tracked down the source of the problem, but I don't know of a
solution (if there is one).

I invoked rb-site on the test site we created when first testing
1.0.5.
It worked perfectly.

So I started using pdb to investigate where rb-site was failing on our
standard site, which led me to:
  django_evolution/management/__init__.py(54)evolution()-None -
  old_proj_sig = pickle.loads(str(latest_version.signature))

Then I investigated the differences in the signature values in
django_project_version for the working and non-working
installations. The non-working one had ^M after every line because it
had been migrated from a Windows server.

My suspicion is that the signature pickled by the Windows server isn't
compatible with the Linux server. Is that a possbility?

I'm at a loss as to how to proceed. Any help would be much appreciated
(as is the help already given).

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Upgrade problem 1.0.5 to 1.5 RC2

2010-09-30 Thread D Krueger
I'm trying to upgrade my ReviewBoard installation from 1.0.5 to 1.5
RC2. The installation works fine. When I attempt to execute rb-site
upgrade, it fails.

The errors are:
[!] Unable to execute the manager command syncdb: No module named
fields

[!] Unable to execute the manager command evolve: No module named
fields


This is on Fedora 10 with Django 1.1.1.

I then tried to upgrade from 1.0.5 to 1.0.9, but received the same
errors.

Any ideas?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade problem 1.0.5 to 1.5 RC2

2010-09-30 Thread D Krueger
On Sep 30, 4:38 pm, Christian Hammond chip...@chipx86.com wrote:
 How did you install Review Board?

I used easy_install to do the installation.

 What version of Djblets do you have installed?

The installation upgraded Djblets to 0.6.4.


 On Thu, Sep 30, 2010 at 8:23 AM, D Krueger dekr...@gmail.com wrote:
  I'm trying to upgrade my ReviewBoard installation from 1.0.5 to 1.5
  RC2. The installation works fine. When I attempt to execute rb-site
  upgrade, it fails.

  The errors are:
  [!] Unable to execute the manager command syncdb: No module named
     fields

  [!] Unable to execute the manager command evolve: No module named
     fields

  This is on Fedora 10 with Django 1.1.1.

  I then tried to upgrade from 1.0.5 to 1.0.9, but received the same
  errors.

  Any ideas?

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -

 - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade problem 1.0.5 to 1.5 RC2

2010-09-30 Thread D Krueger
The full output is:
Upgrading Review Board from 1.0.5 to 1.5 RC2
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.

[!] Unable to execute the manager command syncdb: No module named
fields



On Sep 30, 5:27 pm, Christian Hammond chip...@chipx86.com wrote:
 What happens if you `rb-site manage /path/to/site syncdb` ? Can you see a
 full backtrace?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com



 On Thu, Sep 30, 2010 at 2:05 PM, D Krueger dekr...@gmail.com wrote:
  On Sep 30, 4:38 pm, Christian Hammond chip...@chipx86.com wrote:
   How did you install Review Board?

  I used easy_install to do the installation.

   What version of Djblets do you have installed?

  The installation upgraded Djblets to 0.6.4.

   On Thu, Sep 30, 2010 at 8:23 AM, D Krueger dekr...@gmail.com wrote:
I'm trying to upgrade my ReviewBoard installation from 1.0.5 to 1.5
RC2. The installation works fine. When I attempt to execute rb-site
upgrade, it fails.

The errors are:
[!] Unable to execute the manager command syncdb: No module named
   fields

[!] Unable to execute the manager command evolve: No module named
   fields

This is on Fedora 10 with Django 1.1.1.

I then tried to upgrade from 1.0.5 to 1.0.9, but received the same
errors.

Any ideas?

--
Want to help the Review Board project? Donate today at
   http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  reviewboard%2bunsubscr...@googlegr­oups.com
For more options, visit this group at
   http://groups.google.com/group/reviewboard?hl=en-Hide quoted text -

   - Show quoted text -

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -

 - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade problem 1.0.5 to 1.5 RC2

2010-09-30 Thread D Krueger
I'm sorry, I must be missing something. Here is what I did and the
output produced:

$ sudo rb-site manage /srv/rb/review syncdb
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.

[!] Unable to execute the manager command syncdb: No module named
fields
$

I apologize for being dense. I just don't understand where I erred.


On Sep 30, 6:20 pm, Christian Hammond chip...@chipx86.com wrote:
 It needs to be the command I pasted. Running just rb-site won't help to
 debug it.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com



 On Thu, Sep 30, 2010 at 3:06 PM, D Krueger dekr...@gmail.com wrote:
  The full output is:
  Upgrading Review Board from 1.0.5 to 1.5 RC2
  There are unapplied evolutions for diffviewer.
  There are unapplied evolutions for reviews.
  There are unapplied evolutions for scmtools.

  [!] Unable to execute the manager command syncdb: No module named
     fields

  On Sep 30, 5:27 pm, Christian Hammond chip...@chipx86.com wrote:
   What happens if you `rb-site manage /path/to/site syncdb` ? Can you see a
   full backtrace?

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.reviewboard.org
   VMware, Inc. -http://www.vmware.com

   On Thu, Sep 30, 2010 at 2:05 PM, D Krueger dekr...@gmail.com wrote:
On Sep 30, 4:38 pm, Christian Hammond chip...@chipx86.com wrote:
 How did you install Review Board?

I used easy_install to do the installation.

 What version of Djblets do you have installed?

The installation upgraded Djblets to 0.6.4.

 On Thu, Sep 30, 2010 at 8:23 AM, D Krueger dekr...@gmail.com
  wrote:
  I'm trying to upgrade my ReviewBoard installation from 1.0.5 to 1.5
  RC2. The installation works fine. When I attempt to execute
  rb-site
  upgrade, it fails.

  The errors are:
  [!] Unable to execute the manager command syncdb: No module named
     fields

  [!] Unable to execute the manager command evolve: No module named
     fields

  This is on Fedora 10 with Django 1.1.1.

  I then tried to upgrade from 1.0.5 to 1.0.9, but received the same
  errors.

  Any ideas?

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  reviewboard%2bunsubscr...@googlegr­oups.com
reviewboard%2bunsubscr...@googlegr­oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en-Hidequoted text -

 - Show quoted text -

--
Want to help the Review Board project? Donate today at
   http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  reviewboard%2bunsubscr...@googlegr­oups.com
For more options, visit this group at
   http://groups.google.com/group/reviewboard?hl=en-Hide quoted text -

   - Show quoted text -

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr­oups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en- Hide quoted text -

 - Show quoted text -

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en