Re: Review Board Ticket #4708: Please make update emails more concise.

2018-06-28 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4708/
--

New update by solarmist
For Beanbag, Inc. > Review Board > Ticket #4708


Reply:

Fair enough.  I agree. Just passing on a user request.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4708: Please make update emails more concise.

2018-06-27 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4708/
--

New ticket #4708 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Enhancement


--
Please make update emails more concise.
==

# What version are you running?
N/A

# What's the URL of the page this enhancement relates to, if any?
N/A

# Describe the enhancement and the motivation for it.
Review Board includes the entire first email - the rounded rectangles with the 
RB description & general summary - in every single follow-up email. This 
creates a lot of needless verbosity and wasted scrolling when reading through 
RB email threads. The URL to the RB at the top of each email is about the only 
additional info I ever want (beyond the comment replies), and can be used if 
for some reason folks need a reminder of what the RB's e.g. description is (and 
can't, for some reason, just scroll up the thread in their email client).

# What operating system are you using? What browser?
N/A

# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4643: Automatic markdown generation fails to correctly exclude trailing .s from urls

2018-02-05 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4643/
--

New ticket #4643 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Screen Shot 2018-02-05 at 10.29.00 AM.png
   

 * Screen Shot 2018-02-05 at 10.29.09 AM.png
   



--
Automatic markdown generation fails to correctly exclude trailing .s from urls
==

# What version are you running?
We found this on 2.5.6.1, but it also occurs on demo.reviewboard.org (3.0.3 
alpha 0 (dev)

# What's the URL of the page containing the problem?


# What steps will reproduce the problem?
See image attachments.


# What is the expected output? What do you see instead?
The . should be excluded when the link is generated.

# What operating system are you using? What browser?


# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4486: Requests 2.12.1 breaks diff viewer and review creation

2017-06-30 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4486/
--

New update by solarmist
For Beanbag, Inc. > Review Board > Ticket #4486


Reply:

While looking into some unit tests using httpretty and requests we started 
running into issues where the tests started failing on newer versions requests. 
 After much digging the newest code on github has a fix for it.  This may give 
some clues to what's going on with reviewboard or at least a workaround.

https://github.com/gabrielfalcao/HTTPretty/commit/70af1f8cf925ef50cb5e72212fb0aa46e1451dc3

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4532: Long comment hover at the end of a diff causes flickering

2017-03-16 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4532/
--

New ticket #4532 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * rb_rave_small.mov
   



--
Long comment hover at the end of a diff causes flickering
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
In the diff view of an review request

# What steps will reproduce the problem?
1. Attached video
2. 
3. 


# What is the expected output? What do you see instead?


# What operating system are you using? What browser?
Mac os using Chrome

# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4531: RBTools uses multiple requests to create and publish a review causing submit-as to fail to fully create reviews.

2017-03-16 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4531/
--

New ticket #4531 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
RBTools uses multiple requests to create and publish a review causing submit-as 
to fail to fully create reviews.
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
N/A

# What steps will reproduce the problem?
1. Create a user 'blah'
2. Give blah permission "reviews | review request | Can submit as another user"
3. rbtools post --submit-as USERNAME
4. View review request in Review Board


# What is the expected output? What do you see instead?
A completely empty review is created with no diff. And RBTools errors out when 
trying to do those steps.  

We expect to be able to fully create a review with only the "Can submit as 
another user" permission.

# What operating system are you using? What browser?
RHEL 6.6 and Mac OS

# Please provide any additional information below.
We have an automated account that should be able to create fully populated 
including attachments reviews as another user and publish that review, but once 
it is posted (either draft or published) that automated user should no longer 
be able to modify that review.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4486: Requests 2.12.1 breaks diff viewer and review creation

2016-11-17 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4486/
--

New update by solarmist
For Beanbag, Inc. > Review Board > Ticket #4486


Reply:

Our git server is on a seperate server and runs on ruby, I don't think it's 
related.

This is the actual url that is being called via ajax 
https://{host}/r/783636/diff/1/download/16909959/orig/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4486: Requests 2.12.1 breaks diff viewer and review creation

2016-11-17 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4486/
--

New update by solarmist
For Beanbag, Inc. > Review Board > Ticket #4486


Reply:

Once the "bad" version of requests is installed just trying to view a diff 
threw the exception.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4486: Requests 2.12.1 breaks diff viewer and review creation

2016-11-17 Thread Joshua Olson 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4486/
--

New ticket #4486 by solarmist
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Requests 2.12.1 breaks diff viewer and review creation
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
https://{host}/r/766501/diff/1/fragment/16437945/?index=0&1473715156_format=json
https://{host}/r/766501/diff/1#index_header

# What steps will reproduce the problem?
1. Install RB 2.5.6.1 using requests 2.11.1
2. Upgrade requests to 2.12.1
3. ...
4. Profit?


# What is the expected output? What do you see instead?
The expected output is a side by side diff.

Unexpected error fetching file from 
http://{git_host}/tools/lipy-scm/blobs/raw/2e179a6739158e3fdb6ea3d0950c92d42334b141/{path}/scm/svn.py:
 



 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.





 Please try again, and if you still have trouble,
 contact support.

# What operating system are you using? What browser?
Linux

# Please provide any additional information below.
Traceback (most recent call last):
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/views.py",
 line 275, in get
response = renderer.render_to_response(request)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/renderers.py",
 line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/renderers.py",
 line 74, in render_to_string
large_data=True)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 295, in cache_memoize
compress_large_data))
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 292, in 
lambda: [lookup_callable()],
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/renderers.py",
 line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/renderers.py",
 line 87, in render_to_string_uncached
request=request)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
 line 429, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/chunk_generator.py",
 line 772, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/chunk_generator.py",
 line 110, in get_chunks
large_data=True)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 295, in cache_memoize
compress_large_data))
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 292, in 
lambda: [lookup_callable()],
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/chunk_generator.py",
 line 109, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/chunk_generator.py",
 line 778, in get_chunks_uncached
self.encoding_list)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
 line 198, in get_original_file
request=request)
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/scmtools/models.py",
 line 359, in get_file
large_data=True)[0]
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 295, in cache_memoize
compress_large_data))
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/djblets/cache/backend.py",
 line 292, in 
lambda: [lookup_callable()],
  File 
"/export/apps/reviewboard/lib/python2.6/site-packages/reviewboard/scmtools/models.py",
 line 358, in 
request)],
  File

Re: Can't get RB 2.5 to see the css file for rbmotd.

2016-09-08 Thread Joshua Olson 
I figured it out.  I needed to clear rbmotd from the extensions table then 
it stopped looking in the htdocs/static/ext for the css files.

On Wednesday, September 7, 2016 at 7:53:25 PM UTC-7, Joshua Olson wrote:
>
> Looking closer none of the extensions installed their static assets in 
> htdocs/static/ext.
>
> On Wednesday, September 7, 2016 at 7:40:00 PM UTC-7, Joshua Olson wrote:
>>
>> I figured it out.  It wasn't getting copied to 
>> /export/apps/reviewboard/site/htdocs/static/ext/rbmotd.extension.MotdExtension/
>>
>> Any ideas why that wouldn't be getting setup properly?
>>
>> On Wednesday, September 7, 2016 at 7:35:32 PM UTC-7, Joshua Olson wrote:
>>>
>>> I downloaded everything using pip install --download, except for rbmotd 
>>> which I downloaded the egg directly and scp'ed all the files manually to 
>>> the server.
>>>
>>> I have a server that isn't connected to the internet and I've installed 
>>> 2.5.6.1 (but I did do a load of our prod data to the DB and just did a DB 
>>> upgrade) and everything works fine except the rbmotd won't use the 
>>> precompiled css files or the less files.
>>>
>>> Is there a step I'm missing?
>>>
>>> Cheers,
>>> Josh
>>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can't get RB 2.5 to see the css file for rbmotd.

2016-09-07 Thread Joshua Olson 
Looking closer none of the extensions installed their static assets in 
htdocs/static/ext.

On Wednesday, September 7, 2016 at 7:40:00 PM UTC-7, Joshua Olson wrote:
>
> I figured it out.  It wasn't getting copied to 
> /export/apps/reviewboard/site/htdocs/static/ext/rbmotd.extension.MotdExtension/
>
> Any ideas why that wouldn't be getting setup properly?
>
> On Wednesday, September 7, 2016 at 7:35:32 PM UTC-7, Joshua Olson wrote:
>>
>> I downloaded everything using pip install --download, except for rbmotd 
>> which I downloaded the egg directly and scp'ed all the files manually to 
>> the server.
>>
>> I have a server that isn't connected to the internet and I've installed 
>> 2.5.6.1 (but I did do a load of our prod data to the DB and just did a DB 
>> upgrade) and everything works fine except the rbmotd won't use the 
>> precompiled css files or the less files.
>>
>> Is there a step I'm missing?
>>
>> Cheers,
>> Josh
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can't get RB 2.5 to see the css file for rbmotd.

2016-09-07 Thread Joshua Olson 
I figured it out.  It wasn't getting copied to 
/export/apps/reviewboard/site/htdocs/static/ext/rbmotd.extension.MotdExtension/

Any ideas why that wouldn't be getting setup properly?

On Wednesday, September 7, 2016 at 7:35:32 PM UTC-7, Joshua Olson wrote:
>
> I downloaded everything using pip install --download, except for rbmotd 
> which I downloaded the egg directly and scp'ed all the files manually to 
> the server.
>
> I have a server that isn't connected to the internet and I've installed 
> 2.5.6.1 (but I did do a load of our prod data to the DB and just did a DB 
> upgrade) and everything works fine except the rbmotd won't use the 
> precompiled css files or the less files.
>
> Is there a step I'm missing?
>
> Cheers,
> Josh
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Can't get RB 2.5 to see the css file for rbmotd.

2016-09-07 Thread Joshua Olson 
I downloaded everything using pip install --download, except for rbmotd 
which I downloaded the egg directly and scp'ed all the files manually to 
the server.

I have a server that isn't connected to the internet and I've installed 
2.5.6.1 (but I did do a load of our prod data to the DB and just did a DB 
upgrade) and everything works fine except the rbmotd won't use the 
precompiled css files or the less files.

Is there a step I'm missing?

Cheers,
Josh

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Standing up multiple web servers for reviewboard

2016-06-20 Thread Joshua Olson 
Great, thank you David.

On Monday, June 20, 2016 at 1:00:02 PM UTC-7, David Trowbridge wrote:
>
> Everything important is wrapped in database transactions, so there's no 
> issue with concurrency between servers (there's already lots of concurrency 
> between different processes on a single server). As long as uploaded files 
> is shared across the servers (either via S3 or something like NFS), it 
> should be just fine. If you use SSH keys to connect to your repositories 
> you'll either need to hand-copy them to each web server or use Power Pack.
>
> -David
>
> On Mon, Jun 20, 2016 at 12:57 PM Joshua Olson <joshua...@gmail.com 
> > wrote:
>
>> The reason I ask is because in the past I have heard there were concerns 
>> about data integrity if two people work working on the same review on 
>> different web server instances.
>>
>>
>> On Tuesday, June 14, 2016 at 10:59:31 AM UTC-7, Joshua Olson wrote:
>>>
>>> We have a fully multi-server review board instance with a separate web 
>>> server, memcached server, and DB server and now we'd like to a add 
>>> redundant web front end (RB instance) to our setup, keeping the same DB and 
>>> memcached for now.
>>>
>>> Are there any issues or concerns with doing this?  Other than as 
>>> mentioned in the optimization docs about making sure that the site/data and 
>>> site/htdocs/media dirs are properly replicated.
>>>
>>> Cheers,
>>> Joshua Olson
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Standing up multiple web servers for reviewboard

2016-06-20 Thread Joshua Olson 
The reason I ask is because in the past I have heard there were concerns 
about data integrity if two people work working on the same review on 
different web server instances.

On Tuesday, June 14, 2016 at 10:59:31 AM UTC-7, Joshua Olson wrote:
>
> We have a fully multi-server review board instance with a separate web 
> server, memcached server, and DB server and now we'd like to a add 
> redundant web front end (RB instance) to our setup, keeping the same DB and 
> memcached for now.
>
> Are there any issues or concerns with doing this?  Other than as mentioned 
> in the optimization docs about making sure that the site/data and 
> site/htdocs/media dirs are properly replicated.
>
> Cheers,
> Joshua Olson
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.