Re: Incremental Review Problem
Thanks for your reply. We are using CVS version control here. On Thursday, 5 February 2015 04:30:40 UTC+5:30, David Trowbridge wrote: It would help us to provide some advice if you told us what version control system you're using. If you're using a traditional system like SVN or Perforce, most people like to use git or hg as a frontend to allow them to keep separate things separate. -David On Mon Feb 02 2015 at 8:58:03 AM Nitin Agrawal your...@gmail.com javascript: wrote: Hi, Here is one problem I am facing in handling an incremental review request. Below are the steps: 1) I, as a developer, raised a review request of one of my task-1 completed. 2) After raising the review request, I am doing two things. a) Waiting for review comments b) Also continuing my development on task-2. (Just for the information, I have to incorporate those review comments changes which received in 48 hours of raising the review request.) 3) Now suppose, I completed my development of task-2 in 48 hours. Also I have incorporated the changes related to the review comments received in those 48 hours. 4) With all set, now I am planning to raise a review request on same review ID created in step 1. 5) I update the diff (please mind that new diff will contain the review comments changes along with new code for task-2). 6) The problem here is, when as a reviewer I am reviewing the diff, I have a plethora of code which contains the review comments changes along with new development of task-2. But as a reviewer I was expecting: a) A separate review request containing only the review comments changes. b) A separate review request containing only the new development of task-2. Therefore it becomes very hard for the reviewer to verify the code and to give Ship it!. Please mind that as a developer I am not halting my development therefore I can not do back and forth (maintain a local file and upload the changes only related to review comments separately and for task-2 separately) due to time constraints. Is there anything wrong in the process which I am following or it is just not possible inside review board for handle this kind of scenario? Please help me in this regard. Thanks in Advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Incremental Review Problem
Thanks for the reply. We are using CVS version control here. Thanks On Monday, 2 February 2015 16:14:54 UTC+5:30, Nitin Agrawal wrote: Hi, Here is one problem I am facing in handling an incremental review request. Below are the steps: 1) I, as a developer, raised a review request of one of my task-1 completed. 2) After raising the review request, I am doing two things. a) Waiting for review comments b) Also continuing my development on task-2. (Just for the information, I have to incorporate those review comments changes which received in 48 hours of raising the review request.) 3) Now suppose, I completed my development of task-2 in 48 hours. Also I have incorporated the changes related to the review comments received in those 48 hours. 4) With all set, now I am planning to raise a review request on same review ID created in step 1. 5) I update the diff (please mind that new diff will contain the review comments changes along with new code for task-2). 6) The problem here is, when as a reviewer I am reviewing the diff, I have a plethora of code which contains the review comments changes along with new development of task-2. But as a reviewer I was expecting: a) A separate review request containing only the review comments changes. b) A separate review request containing only the new development of task-2. Therefore it becomes very hard for the reviewer to verify the code and to give Ship it!. Please mind that as a developer I am not halting my development therefore I can not do back and forth (maintain a local file and upload the changes only related to review comments separately and for task-2 separately) due to time constraints. Is there anything wrong in the process which I am following or it is just not possible inside review board for handle this kind of scenario? Please help me in this regard. Thanks in Advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Previous review comments after updating diff
Thanks for your reply.If possible, please include this in the future releases. On Thursday, 5 February 2015 04:28:57 UTC+5:30, David Trowbridge wrote: Hi, This is currently not supported. We've done a fair amount of investigation into what it would take to display old comments on new versions of the diff, and it's a very difficult problem to do well. We'll continue thinking about this, but for the time being, you'll just have to go back and forth -David On Mon Feb 02 2015 at 8:58:02 AM Nitin Agrawal your...@gmail.com javascript: wrote: Hi, Here I am facing a problem as a reviewer. Below are the steps (Problem is in Step 8): 1) Suppose one review request comes to me (Reviewer 1) for review. 2) I have reviewed the code and gave some comments on suppose line numbers X, Y, Z. 3) Second reviewer (Reviewer 2) also gave the comments on same file but different line numbers A, B, C. (In our organization, one review can go to multiple reviewers.) 4) Now the developer of the code, incorporated the changes related to review comments of both Reviewer 1 and Reviewer 2. 5) After that the developer updates the diff on same review ID and publish it. 6) After publishing, a mail comes to me (Reviewer 1) and I open the link of review board provided in that mail. 7) When the page opens, I click on View Diff link on the top right corner to see the diff. 8) The problem here is, I am not able to see the comments given by me (in step 2) on View Diff page. Although I can see the diff but not able to see the review comments therefore I am not able to find out whether the developer has made the changes what I wanted or something different (as I am not able to see my comments). 9) For proper reviewing the changes, what I am doing right now is doing Back and Forth. Means I am reading line numbers and my comments from my previous review mail and verifying in the current diff which is very time consuming and boring. Here what I want to understand that are below changes possible inside review board to make a reviewer's life easier ? 1) As I mentioned in step 8, is it possible to show the my (Reviewer 1's) review comments in the current diff? 2) If above is possible, please also show review comments by Reviewer 2 but with different color so that Reviewer 1 and Reviewer 2 can check only their corresponding comments. Thanks in Advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Incremental Review Problem
Hi, Here is one problem I am facing in handling an incremental review request. Below are the steps: 1) I, as a developer, raised a review request of one of my task-1 completed. 2) After raising the review request, I am doing two things. a) Waiting for review comments b) Also continuing my development on task-2. (Just for the information, I have to incorporate those review comments changes which received in 48 hours of raising the review request.) 3) Now suppose, I completed my development of task-2 in 48 hours. Also I have incorporated the changes related to the review comments received in those 48 hours. 4) With all set, now I am planning to raise a review request on same review ID created in step 1. 5) I update the diff (please mind that new diff will contain the review comments changes along with new code for task-2). 6) The problem here is, when as a reviewer I am reviewing the diff, I have a plethora of code which contains the review comments changes along with new development of task-2. But as a reviewer I was expecting: a) A separate review request containing only the review comments changes. b) A separate review request containing only the new development of task-2. Therefore it becomes very hard for the reviewer to verify the code and to give Ship it!. Please mind that as a developer I am not halting my development therefore I can not do back and forth (maintain a local file and upload the changes only related to review comments separately and for task-2 separately) due to time constraints. Is there anything wrong in the process which I am following or it is just not possible inside review board for handle this kind of scenario? Please help me in this regard. Thanks in Advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Previous review comments after updating diff
Hi, Here I am facing a problem as a reviewer. Below are the steps (Problem is in Step 8): 1) Suppose one review request comes to me (Reviewer 1) for review. 2) I have reviewed the code and gave some comments on suppose line numbers X, Y, Z. 3) Second reviewer (Reviewer 2) also gave the comments on same file but different line numbers A, B, C. (In our organization, one review can go to multiple reviewers.) 4) Now the developer of the code, incorporated the changes related to review comments of both Reviewer 1 and Reviewer 2. 5) After that the developer updates the diff on same review ID and publish it. 6) After publishing, a mail comes to me (Reviewer 1) and I open the link of review board provided in that mail. 7) When the page opens, I click on View Diff link on the top right corner to see the diff. 8) The problem here is, I am not able to see the comments given by me (in step 2) on View Diff page. Although I can see the diff but not able to see the review comments therefore I am not able to find out whether the developer has made the changes what I wanted or something different (as I am not able to see my comments). 9) For proper reviewing the changes, what I am doing right now is doing Back and Forth. Means I am reading line numbers and my comments from my previous review mail and verifying in the current diff which is very time consuming and boring. Here what I want to understand that are below changes possible inside review board to make a reviewer's life easier ? 1) As I mentioned in step 8, is it possible to show the my (Reviewer 1's) review comments in the current diff? 2) If above is possible, please also show review comments by Reviewer 2 but with different color so that Reviewer 1 and Reviewer 2 can check only their corresponding comments. Thanks in Advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
