Re: Diff is not showing for some of the files
Hi Everyone It looks the difference file is created under /tmp directory, But diff is not showing Review Board UI. I tried it manually using below command. still same problem. $ cat test.diff | rbt post --diff-filename=- --bugs-closed=966513 Review request #275 posted. *http://pharb.com/r/275/ <http://pharb.aus.stglabs.ibm.com/r/275/>* *http://pharb.cm/r/275/diff/* I am not seeing any difference, I was getting same error Below is the error details from Review board Please help me to resolve this ??? Revision delta test.sh 1.9 71haes_r721 New Change There was an error displaying this diff. The patch to 'test.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Myriaw' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support <http://pharb.aus.stglabs.ibm.com/support/>. Details <http://pharb.aus.stglabs.ibm.com/r/275/diff/#> Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py", line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/reviews/views.py", line 1088, in create_renderer *args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py", line 328, in create_renderer self.diff_file = self._get_requested_diff_file() File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/views.py", line 369, in _get_requested_diff_file request=self.request) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 373, in populate_diff_chunks chunks = generator.get_chunks() File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 153, in get_chunks large_data=True) File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.9-py2.7.egg/djblets/cache/backend.py", line 109, in cache_memoize data = lookup_callable() File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 152, in lambda: list(self._get_chunks_uncached()), File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 160, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 201, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 139, in patch 'output': stderr, Exception: The patch to 'test.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Myriaw' for debugging purposes. `patch` returned: On Monday, July 20, 2015 at 10:48:24 AM UTC+5:30, vijay bhaskar reddy Yalamuri wrote: > > Hi Team, > > Can any one help me resolve the below problem ? > > Regards > Vijay > > On Tuesday, July 14, 2015 at 11:34:42 AM UTC+5:30, vijay bhaskar reddy > Yalamuri wrote: >> >> Hi Review board team, >> >> I have been using review board quite long time and I am facing some >> strange issue while viewing the diff for some files. >> >> I have some files with the names like " >> src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh" and >> "src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh" >> >> When I try to view the difference from review board, I am getting below >> errors. Other files which are not in this path, it is showing properly. >> only problem with the above files, I have some other files which are in the >> same directory and with similar names, Same error with these files. Please >> help me on this. >> >> There was an error displaying this diff. >> >> The patch to 'src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh' >> didn't apply cleanly. The temporary files have been left in >> '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: >> >> This may be a bug in the software, a temporary outage, or an issue with >> the format of your diff. >> >> Please try again, and if you still have trouble, contact support >> <http://pharb.aus.stglabs.ibm.com/supp
Re: Diff is not showing for some of the files
Hi Team, Can any one help me resolve the below problem ? Regards Vijay On Tuesday, July 14, 2015 at 11:34:42 AM UTC+5:30, vijay bhaskar reddy Yalamuri wrote: Hi Review board team, I have been using review board quite long time and I am facing some strange issue while viewing the diff for some files. I have some files with the names like src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh and src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh When I try to view the difference from review board, I am getting below errors. Other files which are not in this path, it is showing properly. only problem with the above files, I have some other files which are in the same directory and with similar names, Same error with these files. Please help me on this. There was an error displaying this diff. The patch to 'src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. There was an error displaying this diff. The patch to src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. Regards Vijay -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Diff is not showing for some of the files
Hi Team, Thanks for your reply. I have gone through the file which are generated for the diff. But I didn't see any errors in those diff files.Everything looks fine. I have just added a new line with test, so corresponding to that automatically version will be changed. Same is shown in the diff as well. Can you check below data and find out anything is wrong here ? @pharb:/tmp/reviewboard.f29gLJ# diff tmpYgaW6A tmpYgaW6A-new 5c5 # 61test_r713 src/43test/lib/ksh93/group/KLIB_group_delete_test.sh 1.7 --- # 61test_r713 src/43test/lib/ksh93/group/KLIB_group_delete_test.sh 1.7.1.1 16c16 # @(#)88 1.7 src/43test/lib/ksh93/group/KLIB_group_delete_test.sh, group.assist, 61test_r713 5/14/13 14:52:54 --- # @(#)88 1.7.1.1 src/43test/lib/ksh93/group/KLIB_group_delete_test.sh, group.assist, 61test_r713 7/9/15 00:51:36 73c73 : version=1.7, src/43test/lib/ksh93/group/KLIB_group_delete_test.sh, group.assist, 61test_r713 --- : version=1.7.1.1, src/43test/lib/ksh93/group/KLIB_group_delete_test.sh, group.assist, 61test_r713 185a186 test root@pharb:/tmp/reviewboard.f29gLJ# ls KLIB_group_delete_test.sh.diff tmpYgaW6A tmpYgaW6A-new tmpYgaW6A-new.rej root@pharb:/tmp/reviewboard.f29gLJ# cat tmpYgaW6A-new.rej --- .KLIB_group_delete_test.sh 2015-07-09 02:06:26.635043692 -0500 +++ KLIB_group_delete_test.sh 2015-07-09 02:06:27.219043672 -0500 @@ -29,9 +29,9 @@ =head1 VERSION - Version Number: 1.7 + Version Number: 1.7.1.1 Last Extracted: 7/9/15 02:08:19 - Last Changed:5/14/13 14:52:54 + Last Changed:7/9/15 00:51:36 Path, Component, Release(, Level): src/43test/lib/ksh93/group/KLIB_group_delete_test.sh, group.assist, 61test_r713 Regards Vijay On Tuesday, July 14, 2015 at 11:34:42 AM UTC+5:30, vijay bhaskar reddy Yalamuri wrote: Hi Review board team, I have been using review board quite long time and I am facing some strange issue while viewing the diff for some files. I have some files with the names like src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh and src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh When I try to view the difference from review board, I am getting below errors. Other files which are not in this path, it is showing properly. only problem with the above files, I have some other files which are in the same directory and with similar names, Same error with these files. Please help me on this. There was an error displaying this diff. The patch to 'src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. There was an error displaying this diff. The patch to src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. Regards Vijay -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Diff is not showing for some of the files
Hi Review board team, I have been using review board quite long time and I am facing some strange issue while viewing the diff for some files. I have some files with the names like src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh and src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh When I try to view the difference from review board, I am getting below errors. Other files which are not in this path, it is showing properly. only problem with the above files, I have some other files which are in the same directory and with similar names, Same error with these files. Please help me on this. There was an error displaying this diff. The patch to 'src/43test/lib/ksh93/testgroup/KLIB_group_modify_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. There was an error displaying this diff. The patch to src/43test/lib/ksh93/testgroupKLIB_group_add_log.sh' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.f29gLJ' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support http://pharb.aus.stglabs.ibm.com/support/. Regards Vijay -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Test program to get the list of the files which are dropped to review board
Hi Review board team I am writing a test program to find out is there any change of diff files after posting the review request. I thought first I will get the list of files which are posted to the review board and get the corresponding time stamp and compare this time stamp with original defect file timestamp. I tried to get the list of diff files using many diff api's , but all the api are not giving proper count. I have dropped 5 files, but it always giving only 2 files. url = '/api/review-requests/%s/diffs/' % review_id datareviews = rb_server.api_get( url ) Could you please help me how to get the list of diff files and it's corresponding file timestamp from the review board ? Thanks for understanding in advance. Regards Vijay -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Test program to get the list of the files which are dropped to review board
Hi Team, Thanks for your reply. I just need to find out for corresponding review request, what are the files are associated. I tried below program to find out the files list. But it always give me wrong count. Can you tell me is there any other way to get the proper list of diff file names ? RB Tool version: 0.6.2 Review board version: 2.0.6 url = '/api/review-requests/%s/diffs/' % review_id datareviews = rb_server.api_get( url ) length=len(datareviews['review_request']['diffs']) filelink = datareviews['review_request']['diffs'][length-1]['links']['files']['href'] print filelink filelink = filelink[filelink.find(api):len(filelink)] filelink = filelink.rstrip() print filelink is:+filelink filedata = rb_server.api_get ( filelink ) print filedata print filedata['files'][0]['source_file'] Regards Vijay On Tuesday, July 14, 2015 at 1:46:55 PM UTC+5:30, vijay bhaskar reddy Yalamuri wrote: Hi Review board team I am writing a test program to find out is there any change of diff files after posting the review request. I thought first I will get the list of files which are posted to the review board and get the corresponding time stamp and compare this time stamp with original defect file timestamp. I tried to get the list of diff files using many diff api's , but all the api are not giving proper count. I have dropped 5 files, but it always giving only 2 files. url = '/api/review-requests/%s/diffs/' % review_id datareviews = rb_server.api_get( url ) Could you please help me how to get the list of diff files and it's corresponding file timestamp from the review board ? Thanks for understanding in advance. Regards Vijay -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Regarding review comments and it's details after review is over
Hi Every one,
I would to like bring my few of doubts to this group. Please help me on
this.
1) I need to get all the review comments in one shot and print it on the
console or a file. Please provide me sample snippet for this.
I tried to use this below API, But I couldn't get any details.
/api/review-requests/{review_request_id}/reviews/,
I tried get function to get the details, But I didn't get any details.
I think there is some other way to get those review comments.
https://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/review-list/
If one one is having sample snippet , plz provide me the same.
2) From the link
https://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/review-diff-comment-list/#webapi2.0-review-diff-comment-list-resource;
this is also used to get the comments.
Even I thought of using this, but this API requires to arguments, But I
have only request request id what is the other argument review-id ?
API:
/api/review-requests/{review_request_id}/reviews/{review_id}/diff-comments/
Please provide me code snippet for this as well on how to use this and get
the diff comments.
sample snippet which I am using :
url1 = '/api/review-requests/19/reviews/19/diff-comments/'
Here I have used review id and review request id same, But I don't
know why 2 args.
datareviews1 = rb_server.api_get( url1 )
print datareviews1
I got some data, but doesn't have review comments.
Thanks for helping me in advance!!!
Regards
Vijay
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
