Re: Review Request not published

2012-05-16 Thread Geert Linders
Hi Christian,

I attached the headers and data for a publish and for a discard. I used 
the Live http headers and httpfox add-on for iceweasel to capture them.

Hope that helps.


Cheers - Geert

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=enhttp://nzchswreviews.au.ivc/api/review-requests/4310/reviews/draft/?api_format=json

GET /api/review-requests/4310/reviews/draft/?api_format=json HTTP/1.1
Host: nzchswreviews.au.ivc
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16)
Accept: application/json, text/javascript, */*
Accept-Language: en,en-us;q=0.5
Accept-Encoding: true
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
X-Requested-With: XMLHttpRequest
Referer: http://nzchswreviews.au.ivc/r/4310/
Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True
If-Modified-Since: Wed, 16 May 2012 19:51:13 GMT

HTTP/1.1 301 MOVED PERMANENTLY
Date: Wed, 16 May 2012 19:52:16 GMT
Server: Apache/2.2.20 (Ubuntu)
Content-Language: en-us
Expires: Wed, 16 May 2012 19:52:16 GMT
Vary: Accept,Cookie,Accept-Language
Cache-Control: max-age=0
Content-Length: 14
Last-Modified: Wed, 16 May 2012 19:52:16 GMT
Location: http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: application/vnd.reviewboard.org.review-draft+json
--
http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json

GET /api/review-requests/4310/reviews/6631/?api_format=json HTTP/1.1
Host: nzchswreviews.au.ivc
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16)
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en,en-us;q=0.5
Accept-Encoding: true
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: http://nzchswreviews.au.ivc/r/4310/
Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True
If-Modified-Since: Wed, 16 May 2012 02:21:52 GMT

HTTP/1.1 304 NOT MODIFIED
Date: Wed, 16 May 2012 19:52:16 GMT
Server: Apache/2.2.20 (Ubuntu)
Connection: Keep-Alive
Keep-Alive: timeout=5, max=99
Expires: Wed, 16 May 2012 19:52:16 GMT
Cache-Control: max-age=0
Vary: Accept,Cookie,Accept-Language,Accept-Encoding
--
http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/draft/?api_format=json

GET /api/review-requests/4310/reviews/draft/?api_format=json HTTP/1.1
Host: nzchswreviews.au.ivc
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16)
Accept: application/json, text/javascript, */*
Accept-Language: en,en-us;q=0.5
Accept-Encoding: true
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
X-Requested-With: XMLHttpRequest
Referer: http://nzchswreviews.au.ivc/r/4310/
Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True
If-Modified-Since: Wed, 16 May 2012 19:52:16 GMT

HTTP/1.1 301 MOVED PERMANENTLY
Date: Wed, 16 May 2012 19:52:46 GMT
Server: Apache/2.2.20 (Ubuntu)
Content-Language: en-us
Expires: Wed, 16 May 2012 19:52:46 GMT
Vary: Accept,Cookie,Accept-Language
Cache-Control: max-age=0
Content-Length: 14
Last-Modified: Wed, 16 May 2012 19:52:46 GMT
Location: http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: application/vnd.reviewboard.org.review-draft+json
--
http://nzchswreviews.au.ivc/api/review-requests/4310/reviews/6631/?api_format=json

GET /api/review-requests/4310/reviews/6631/?api_format=json HTTP/1.1
Host: nzchswreviews.au.ivc
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/2008 Iceweasel/3.5.16 (like Firefox/3.5.16)
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en,en-us;q=0.5
Accept-Encoding: true
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Referer: http://nzchswreviews.au.ivc/r/4310/
Cookie: rbsessionid=f63f634a35eb85f86e939f2d791ca43a; csrftoken=397c8540a69626cc3c3b077e4e921446; collapsediffs=True
If-Modified-Since: Wed, 16 May 2012 02:21:52 GMT

HTTP/1.1 304 NOT MODIFIED
Date: Wed, 16 May 2012 19:52:46 GMT

Re: Review Request not published

2012-05-16 Thread Christian Hammond
Hi Geert,

Hmmm so the publish.data and discard.data is what the addon is showing
what's coming back from the server? Because if so, there's something very
wrong here. That's XML data, and we're requesting JSON. I wonder if you
could install Firebug and reproduce just to make sure that's not some bug
with those addons not preserving the ?api_format=json.

If those are indeed what you're getting back, we'll need to figure out how
this is possibly happening.

Are you in any way behind a proxy? Is Review Board in the exception list? I
wouldn't expect a proxy to strip these arguments, but just something to
check.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, May 16, 2012 at 1:02 PM, Geert Linders glind...@dynamiccontrols.com
 wrote:

 Hi Christian,

 I attached the headers and data for a publish and for a discard. I
 used the Live http headers and httpfox add-on for iceweasel to capture
 them.

 Hope that helps.


 Cheers - Geert

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Request not published

2012-05-16 Thread Geert Linders
Hi Christian,

I upgraded my Iceweasel to install Firebug. Now after the upgrade the 
problem has gone away, so I can't produce the logs you want anymore. Sorry 
about that.

Is there anything else I can do for you to help?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Request not published

2012-05-16 Thread Christian Hammond
Hi Geert,

I wondered about that. I imagine there was some bug with Iceweasel causing
that. Based on the Firefox version it claimed to be based off of, it's
below our minimum supported browser requirements anyway. So if it works
now, awesome :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, May 16, 2012 at 4:36 PM, Geert Linders glind...@dynamiccontrols.com
 wrote:

 Hi Christian,

 I upgraded my Iceweasel to install Firebug. Now after the upgrade the
 problem has gone away, so I can't produce the logs you want anymore. Sorry
 about that.

 Is there anything else I can do for you to help?

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Request not published

2012-05-15 Thread Christian Hammond
Hi,

It shouldn't be confused under those cases.

If you have Chrome or a modern Firefox, it would really help to see the
network transfer information on that request. That is, the HTTP request and
response headers and payload. Both should offer a tab in their script
developer UI for showing network transfers, and you should be able to dig
in and see exactly what was sent and received.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, May 15, 2012 at 9:41 PM, Geert Linders glind...@dynamiccontrols.com
 wrote:

 Hi Christian,

 I have the same problem when I try to publish or discard a review on a
 particular review. I'm using RB 1.6.4.1. The server logs don't show
 anything when the fault happens (I've set it to DEBUG level). That makes
 sense because the response is 200 OK, which means success in HTTP world.

 I added two screen shots. The first rb_flt1.png shows the response after I
 click on Publish or Discard. The second rb_flt2.png shows the error
 detail.

 I did the same on another review: That worked fine, it saved my changes
 without complaining. It seems as if this particular review is corrupt
 somewhere. Could RB become confused if two people are reviewing at the same
 time i.e. both have a pending review?

 I can't reset the server now because it's running in a production
 environment and is constantly being used.

 Cheers - Geert

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en