Re: Extended Ship it feature, Defaults for diff base path

2009-01-27 Thread Christian Hammond
On Mon, Jan 26, 2009 at 3:23 AM, Sebastian Kurfuerst sebastian.kurfue...@gmail.com wrote: Hey Christian, thanks for your super-fast response! Right now, we don't have anything in the code to enforce policies such as requiring two ship its before you can close out a review request. Since

Re: Extended Ship it feature, Defaults for diff base path

2009-01-26 Thread Christian Hammond
Hi Sebastian. On Mon, Jan 26, 2009 at 2:37 AM, Sebastian Kurfuerst sebastian.kurfue...@gmail.com wrote: Hello Reviewboard Developers! We at the TYPO3 Project are currently evaluating ReviewBoard for our patch workflow. As far as I see it, I am really impressed! There are just minor

Re: Extended Ship it feature, Defaults for diff base path

2009-01-26 Thread Sebastian Kurfuerst
Hey Christian, thanks for your super-fast response! Right now, we don't have anything in the code to enforce policies such as requiring two ship its before you can close out a review request. Since Review Board doesn't actually commit reviews, we can't enforce anything like that. Yep, that

RE: Extended Ship it feature, Defaults for diff base path

2009-01-26 Thread Paul Scott
Sebastian, OK. Currently, we have a mailing list for posting patches to, and as said, we require two +1s - at least one from a core developer. Now, many patches are still lying around as it sometimes takes a lot of time to review complicated changes. Currently, it is basically impossible to