Re: ReviewBoard General Inquiries
hi, i did a workaround for this one. i actually created a dummy repository and just dumped the files there. everytime i generate a diff the whole file is included. so it is as if i actually uploaded a file but in reality i just added the file to a repository and used the diff that it generated. thanks for your help! carlo On Tue, May 26, 2009 at 4:19 AM, Christian Hammond chip...@chipx86.comwrote: Hi Carlo, Jeff has a good summary of the diff part of this. I want to just reaffirm that we work with diffs but post-review is your good friend. Some people have requested being able to just upload files and not use a code repository, but it's not a high priority for us. Someone would have to do a lot of work to make it happen and so far I haven't seen too many cases where it's really beneficial over just storing them in an SVN repository or something. Either way, the end result is that you'll see the files in their entirety (collapsed to show changed regions by default, but you can expand to see the entire file) and you'll see the changes between them. We don't support commenting by e-mail. We've considered this and there's a feature request filed for it, but it's tricky to get right in all cases, and it's not something we personally plan to work on. However, much of Review Board is provided by third party contributors scratching an itch, so if someone wanted to work on it and provided a good implementation that handled reviews by e-mail, we'll certainly consider it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 10:57 AM, Carlo Camerino cmcamer...@gmail.comwrote: Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
ReviewBoard General Inquiries
Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard General Inquiries
I'm not really sure why this is an issue, but all uploads to reviewboard are via diff. If you use the post-review tool, you never have to see/touch/smell the diff at all, you just deal with the review, and your VCS's revision specs. Even though you're uploading a diff, reviewboard goes out to your VCS, pulls out the whole file, and hilights the areas which have changed. I think that answers your question as I understand it; if you're asking whether you can review existing files(like reviewing your whole codebase), check the archives of this list... Christian has covered that a few times, and it's very possible to do with post-review. -- Jeff O|||O 2009/5/25 Carlo Camerino cmcamer...@gmail.com Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard General Inquiries
Hi Carlo, Jeff has a good summary of the diff part of this. I want to just reaffirm that we work with diffs but post-review is your good friend. Some people have requested being able to just upload files and not use a code repository, but it's not a high priority for us. Someone would have to do a lot of work to make it happen and so far I haven't seen too many cases where it's really beneficial over just storing them in an SVN repository or something. Either way, the end result is that you'll see the files in their entirety (collapsed to show changed regions by default, but you can expand to see the entire file) and you'll see the changes between them. We don't support commenting by e-mail. We've considered this and there's a feature request filed for it, but it's tricky to get right in all cases, and it's not something we personally plan to work on. However, much of Review Board is provided by third party contributors scratching an itch, so if someone wanted to work on it and provided a good implementation that handled reviews by e-mail, we'll certainly consider it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 10:57 AM, Carlo Camerino cmcamer...@gmail.comwrote: Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
