Re: Submitting patches, subversion post-review support for already committed revisions
Hi, Same problem here with RB 1.6.11. When posting a review request with revistion that includes renaming some files i get this: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n' Any news here? W dniu środa, 9 grudnia 2009 23:01:28 UTC+1 użytkownik Lyndon Washington napisał: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review request with post-review I get the following error: Failed to execute command: ['svn', 'info', 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java'] ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] Cheers, -Lyndon- Lyndon Washington On Thu, Dec 3, 2009 at 11:42 AM, Jason Felice jason.m...@gmail.comjavascript: wrote: On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chi...@chipx86.comjavascript: wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. OK, that worked. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? I tried what I got from easy_install -U RBTools, when that wouldn't work, I tried git HEAD. My ReviewBoard install reports 1.0.5.1... weird because I thought I installed the alpha because I need SVN https support, and I have successfully used SVN https repositories. Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. C:\workspace\xpay-corepost-review --debug --revision-range 4665:4666 svn info repository info: Path: https://dtvsource/svn/xpay, Base path: /trunk/xpay-core-1.2, Supports changesets: False svn propget reviewboard:url C:\workspace\xpay-core svn diff --diff-cmd=diff -r 4665:4666 svn info src/dev/testapp/emulator/nio/TaskResolver.java Failed to execute command: ['svn', 'info', 'src/dev/testapp/emulator/nio/TaskResolver.java'] [svn: 'src\\dev\\testapp\\emulator\\nio\\TaskResolver.java' is not under version control\n] TaskResolver.java was renamed to EmulatorResolver.java in the named commit. By the way, I was initially confused because I didn't realize that you could use post-review to do pre-commit review, might I suggest renaming the tool to something like rb-submit? I tried submitting the output of svn diff, but I was sure that wasn't going to work, since there isn't enough information in the diff for anyone to apply it when a rename is involved! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Submitting patches, subversion post-review support for already committed revisions
I've run into this recently, not with post-review so much as with the IDEA plugin (http://code.google.com/p/idea-reviewboard/). We're using RB 1.0.5.1 and a 1.6 revision of Subversion. In our case, we substantially reorganized our Subversion tree, and then I branched the code twice more. So the svn log of a particular file looks like this: (Assume HEAD = r155) 151 Created feature branch from project branch 150 Created project branch from trunk 149 Moved folder as part of reorg (this was large, going from a /top-level/project/trunk|tags|branches structure to /new-top-level/trunk|tags|branches/projects ) 140 File edited to fix defect. In this scenario, the last time the file was actually changed was r140; everything since then is a copy from a prior location. If we run post-review, the diff is created and lists r155, or at least the HEAD rev at the last time the file was updated in the working copy, as the current revision, and RB accepts it with no problem. If we run the IDEA plugin (which we changed to give us a copy of the diff), it lists Revision 140, the last revision when the file was edited. The IDEA plugin then gives us a popup with the error message, Error from server: The file was not found in the repository., which I assume comes back from ReviewBoard. We tried to manually attach the diff generated by the plugin to a review request using the RB web interface, and RB apparently rejected it; it said Uploading file, and then came back to the upload screen without either adding the diff to the request, or giving us an error message. If we changed the revision number in the exact same diff to 155, the upload worked properly. So, we have a couple questions to ask: 1. Why, apparently, is ReviewBoard not resolving the earlier revision of the file properly? 2. Why is the IDEA plugin giving the older revision number, and do we have a way to make it give the current one? I realize this question is beyond the official scope of this group, and I'm not even sure if the plugin's author is subscribed here. Thanks very much for any help anyone can give me. - Mark From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Wednesday, December 09, 2009 7:32 PM To: reviewboard@googlegroups.com Subject: Re: Submitting patches, subversion post-review support for already committed revisions It seems that this broke at some point. I've been meaning to look into it but haven't really had the time lately. I believe it's due to us being a little more smart now with SVN diffs and going through trying to grab info on the affected files. We need to handle the moves/renames properly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 9, 2009 at 2:01 PM, Lyndon Washington hoshp...@crazy-code.com wrote: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review request with post-review I get the following error: Failed to execute command: ['svn', 'info', 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory. java'] ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory .java: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] Cheers, -Lyndon- Lyndon Washington On Thu, Dec 3, 2009 at 11:42 AM, Jason Felice jason.m.fel...@gmail.com wrote: On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. OK, that worked. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? I tried what I got from easy_install -U RBTools, when that wouldn't work, I tried git HEAD. My ReviewBoard install reports 1.0.5.1... weird because I thought I installed the alpha because I need SVN https support, and I have successfully used SVN https repositories. Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. C:\workspace\xpay-corepost-review --debug --revision-range 4665:4666 svn info repository info: Path: https://dtvsource/svn/xpay, Base path: /trunk/xpay-core-1.2, Supports changesets: False svn propget reviewboard:url C:\workspace\xpay-core svn diff --diff-cmd=diff -r 4665:4666 svn info src/dev/testapp/emulator/nio/TaskResolver.java
Re: Submitting patches, subversion post-review support for already committed revisions
On Wed, Dec 9, 2009 at 5:01 PM, Lyndon Washington hoshp...@crazy-code.com wrote: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review request with post-review I get the following error: Failed to execute command: ['svn', 'info', 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java'] ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] I've gotten it in my mind to try to troubleshoot this, but it might be a day or three before I have a chance. And I don't really know the code (but it doesn't seem to be really hard to grok). -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Submitting patches, subversion post-review support for already committed revisions
It seems that this broke at some point. I've been meaning to look into it but haven't really had the time lately. I believe it's due to us being a little more smart now with SVN diffs and going through trying to grab info on the affected files. We need to handle the moves/renames properly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 9, 2009 at 2:01 PM, Lyndon Washington hoshp...@crazy-code.comwrote: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review request with post-review I get the following error: Failed to execute command: ['svn', 'info', 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java'] ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory.java: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] Cheers, -Lyndon- Lyndon Washington On Thu, Dec 3, 2009 at 11:42 AM, Jason Felice jason.m.fel...@gmail.comwrote: On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. OK, that worked. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? I tried what I got from easy_install -U RBTools, when that wouldn't work, I tried git HEAD. My ReviewBoard install reports 1.0.5.1... weird because I thought I installed the alpha because I need SVN https support, and I have successfully used SVN https repositories. Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. C:\workspace\xpay-corepost-review --debug --revision-range 4665:4666 svn info repository info: Path: https://dtvsource/svn/xpay, Base path: /trunk/xpay-core-1.2, Supports changesets: False svn propget reviewboard:url C:\workspace\xpay-core svn diff --diff-cmd=diff -r 4665:4666 svn info src/dev/testapp/emulator/nio/TaskResolver.java Failed to execute command: ['svn', 'info', 'src/dev/testapp/emulator/nio/TaskResolver.java'] [svn: 'src\\dev\\testapp\\emulator\\nio\\TaskResolver.java' is not under version control\n] TaskResolver.java was renamed to EmulatorResolver.java in the named commit. By the way, I was initially confused because I didn't realize that you could use post-review to do pre-commit review, might I suggest renaming the tool to something like rb-submit? I tried submitting the output of svn diff, but I was sure that wasn't going to work, since there isn't enough information in the diff for anyone to apply it when a rename is involved! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Submitting patches, subversion post-review support for already committed revisions
On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. OK, that worked. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? I tried what I got from easy_install -U RBTools, when that wouldn't work, I tried git HEAD. My ReviewBoard install reports 1.0.5.1... weird because I thought I installed the alpha because I need SVN https support, and I have successfully used SVN https repositories. Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. C:\workspace\xpay-corepost-review --debug --revision-range 4665:4666 svn info repository info: Path: https://dtvsource/svn/xpay, Base path: /trunk/xpay-core-1.2, Supports changesets: False svn propget reviewboard:url C:\workspace\xpay-core svn diff --diff-cmd=diff -r 4665:4666 svn info src/dev/testapp/emulator/nio/TaskResolver.java Failed to execute command: ['svn', 'info', 'src/dev/testapp/emulator/nio/TaskResolver.java'] [svn: 'src\\dev\\testapp\\emulator\\nio\\TaskResolver.java' is not under version control\n] TaskResolver.java was renamed to EmulatorResolver.java in the named commit. By the way, I was initially confused because I didn't realize that you could use post-review to do pre-commit review, might I suggest renaming the tool to something like rb-submit? I tried submitting the output of svn diff, but I was sure that wasn't going to work, since there isn't enough information in the diff for anyone to apply it when a rename is involved! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Submitting patches, subversion post-review support for already committed revisions
Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 7:04 PM, Jason Felice jason.m.fel...@gmail.comwrote: First, I tried to submit a patch to reviewboard's reviewboard, but it is behaving strangely. It won't accept a standard diff -u or a git diff --cached. Second, there is conflicting info on whether subversion post-commit reviews are supported with post-review. I'm having problems submitting subversion diffs with file renames in them and using post-review for committed revisions with files in them. What's going on? Thanks... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
