Re: Issue 2446 in reviewboard: Permissions problem after re-open
Updates: Status: Fixed Comment #3 on issue 2446 by trowb...@gmail.com: Permissions problem after re-open http://code.google.com/p/reviewboard/issues/detail?id=2446 Fixed in release-1.7.x (b0500a8). Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2874 in reviewboard: Reviewboard 1.7.2 requires pytz-2012j
Updates: Status: Fixed Comment #3 on issue 2874 by trowb...@gmail.com: Reviewboard 1.7.2 requires pytz-2012j http://code.google.com/p/reviewboard/issues/detail?id=2874 Fixed in release-1.7.x (107ce3e). Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2252 in reviewboard: Revision/interdiff selection UI is confusing
Updates: Summary: Revision/interdiff selection UI is confusing Comment #8 on issue 2252 by trowb...@gmail.com: Revision/interdiff selection UI is confusing http://code.google.com/p/reviewboard/issues/detail?id=2252 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2874 in reviewboard: Reviewboard 1.7.2 requires pytz-2012j
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #2 on issue 2874 by trowb...@gmail.com: Reviewboard 1.7.2 requires pytz-2012j http://code.google.com/p/reviewboard/issues/detail?id=2874 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1854 in reviewboard: Download raw diff cached - need to manually refresh to update
Updates: Status: Fixed Comment #2 on issue 1854 by trowb...@gmail.com: Download raw diff cached - need to manually refresh to update http://code.google.com/p/reviewboard/issues/detail?id=1854 This is fixed in modern versions. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2895 in reviewboard: Cant cerate a reviewboard account, gives no error
Updates: Status: ThirdParty Comment #1 on issue 2895 by chip...@gmail.com: Cant cerate a reviewboard account, gives no error http://code.google.com/p/reviewboard/issues/detail?id=2895 You'll have to contact the sysadmins for codereview.secondlife.com. We provide support for Review Board itself, and a standard Review Board install should take you to your dashboard, logged in. Sorry I can't do more. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2895 in reviewboard: Cant cerate a reviewboard account, gives no error
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2895 by brett.mu...@murf.net: Cant cerate a reviewboard account, gives no error http://code.google.com/p/reviewboard/issues/detail?id=2895 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? What's the URL of the page containing the problem? https://codereview.secondlife.com/account/register/ What steps will reproduce the problem? 1. try and create an account 2. thats it, the screen reloads with the password empty, and no error message What is the expected output? What do you see instead? "well done you have created an account for reviewboard" or somesuch What operating system are you using? What browser? Mac osx Lion, chrome Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2891 in reviewboard: Add "ship it" column in Dashboard
Updates: Status: Fixed Comment #2 on issue 2891 by trowb...@gmail.com: Add "ship it" column in Dashboard http://code.google.com/p/reviewboard/issues/detail?id=2891 There's also the "My Comments" column, which will include a check-mark in it if you've personally given the review request a ship-it. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2893 in reviewboard: Any help reviewing moves of code between files?
Updates: Status: Confirmed Labels: Component-DiffViewer Comment #1 on issue 2893 by trowb...@gmail.com: Any help reviewing moves of code between files? http://code.google.com/p/reviewboard/issues/detail?id=2893 We'd like to expand the moved-lines detection to work across files, but there's a lot of computation overhead that will require some sort of queuing/background-process system. Thanks for the report! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2894 in reviewboard: Archive reviews
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2894 by berto...@gmail.com: Archive reviews http://code.google.com/p/reviewboard/issues/detail?id=2894 What version are you running? 1.7.4 What's the URL of the page this enhancement relates to, if any? /dashboard/ Describe the enhancement and the motivation for it. A user should be able to archive a review. This would hide the review from the dashboard until there is further activity on it. There would be many benefits to this feature. 1) Keep the dashboard clean of reviews that don't require my attention. If I put in review comments, I don't want to see the review again until my comments are addressed. 2) Ignore irrelevant review requests. Especially with groups, you can get bombarded with review requests that you don't intend to take action on. 3) Hide old reviews. If reviews get tabled, sometimes indefinitely, they clutter up the dashboard until they are addressed months or sometimes even years later. Please provide any additional information below. See bug 1691 and bug 1453, comment 6 for more detail and previous discussions. Bug 1453 was closed suggesting that the "my comments" box fixes this, but I feel that's not a complete solution. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2893 in reviewboard: Any help reviewing moves of code between files?
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 2893 by ryan.bea...@gmail.com: Any help reviewing moves of code
between files?
http://code.google.com/p/reviewboard/issues/detail?id=2893
What version are you running?
1.6.13
What's the URL of the page this enhancement relates to, if any?
https://reviewboard/r/12321/diff/
Describe the enhancement and the motivation for it.
Suppose I'm looking at a diff where someone moves 10 lines from fileA.c to
fileB.c. I'd like to look at sections of those files side by side, so that
I can make sure nothing changed during the move.
It'd be cool if I could, for example, select a chunk from left column
("Revision X") and a chunk from the right column ("New Change"), and then
have RB render an instant side-by-side diff between the two.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Issue 2892 in reviewboard: New 4.3 RBTools path posting method is broken
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2892 by faller.g...@gmail.com: New 4.3 RBTools path posting
method is broken
http://code.google.com/p/reviewboard/issues/detail?id=2892
What version are you running?
RBTools 0.4.3
What's the URL of the page containing the problem?
The post-review failed
What steps will reproduce the problem?
1.post-review a path-diff style diff with Perforce source control
post-review //Depot/path/file.cpp@chgn1,@chgn2
What is the expected output? What do you see instead?
I wanted to post it, but it gives a traceback:
Traceback (most recent call last):
File "c:\Program Files (x86)\Python27\Scripts\post-review-script.py",
line 8,
in
load_entry_point('RBTools==0.4.3', 'console_scripts', 'post-review')()
File "c:\Program Files
(x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\postreview.py",
line 1308, in main
diff, parent_diff = tool.diff(args)
File "c:\Program Files
(x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\clients\perforce.py",
line 284, in diff
return self._path_diff(args)
File "c:\Program Files
(x86)\Python27\lib\site-packages\rbtools-0.4.3-py2.7.egg\rbtools\clients\perforce.py",
line 408, in _path_diff
ignore_unmodified=True)
TypeError: _do_diff() takes at least 7 arguments (7 given)
What operating system are you using? What browser?
Win7
Please provide any additional information below.
The error is in the Perforce.py in the _path_diff method: the
new_depot_path parameter is not created and not given to the _do_diff
method.
See the _changenum_diff method, where it is created and given to the
_do_diff.
A quick fix is to pass an empty string as the new fifth parameter of the
_do_diff at the end of the _path_diff. It will work at least if there is no
file move in the change.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 477 in reviewboard: Per reviewer email control
Comment #22 on issue 477 by plevn...@gmail.com: Per reviewer email control http://code.google.com/p/reviewboard/issues/detail?id=477 In addition to the fine-grained control, I'd like email notifications to be sent (optionally) on issues being dropped, fixed, or reopened. The email should be sent to parties commenting on the issue other than oneself. Also, on the fine grained control, it would be nice for the admin to configure default values for the users. Users should then configure what they want to see as there might be an interest for an author to see more or less email than a reviewer. So, two notification profiles might be needed per user. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2891 in reviewboard: Add "ship it" column in Dashboard
Comment #1 on issue 2891 by rajas...@gmail.com: Add "ship it" column in Dashboard http://code.google.com/p/reviewboard/issues/detail?id=2891 This is already in place, just click on the pencil icon in the dashboard page and check the "Ship it" box. This should show the reviews that have shipits and also the number of ship-its it got. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2446 in reviewboard: Permissions problem after re-open
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #2 on issue 2446 by trowb...@gmail.com: Permissions problem after re-open http://code.google.com/p/reviewboard/issues/detail?id=2446 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
