Issue 646 in reviewboard: postreview script diff command options -urNp do not work on Solaris. gdiff required

2008-09-14 Thread codesite-noreply
Issue 646: postreview script diff command options -urNp do not work on Solaris. gdiff required http://code.google.com/p/reviewboard/issues/detail?id=646 Comment #1 by threebredagardens: Slight modification required in my suggested code ostype = execute ('uname -s').strip() need to use -s

Issue 647 in reviewboard: Error return value of _prepare_draft unused in webapi/json.py

2008-09-15 Thread codesite-noreply
Issue 647: Error return value of _prepare_draft unused in webapi/json.py http://code.google.com/p/reviewboard/issues/detail?id=647 Comment #1 by chipx86: Silly me, I was thinking we were calling ReviewRequestDraft.objects.create, but we're instead calling the static ReviewRequestDraft.create.

Issue 632 in reviewboard: Save comment and save review draft behave differently

2008-09-14 Thread codesite-noreply
Issue 632: Save comment and save review draft behave differently http://code.google.com/p/reviewboard/issues/detail?id=632 Comment #1 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Labels: -Priority-Medium Priority-Low Component-DiffViewer -- You

Issue 333 in reviewboard: Have diff summary field in upload diff.

2008-09-14 Thread codesite-noreply
Issue 333: Have diff summary field in upload diff. http://code.google.com/p/reviewboard/issues/detail?id=333 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Started -- You received this message because you are listed in the owner or

Issue 551 in reviewboard: Can't publish or discard comments in one review

2008-09-14 Thread codesite-noreply
Issue 551: Can't publish or discard comments in one review http://code.google.com/p/reviewboard/issues/detail?id=551 Comment #1 by trowbrds: I know it's a bit of a pain, but could you install firebug and get a traceback for this error? It's hard to know what's going wrong. Issue attribute

Issue 587 in reviewboard: Cannot discard draft

2008-09-14 Thread codesite-noreply
Issue 587: Cannot discard draft http://code.google.com/p/reviewboard/issues/detail?id=587 Comment #1 by trowbrds: I know it's a bit of a pain, but can you install firebug and get a traceback for this error? Thanks Issue attribute updates: Status: NeedInfo Labels:

Issue 591 in reviewboard: Please Add Group *SchemaChanges

2008-09-14 Thread codesite-noreply
Issue 591: Please Add Group *SchemaChanges http://code.google.com/p/reviewboard/issues/detail?id=591 Comment #2 by trowbrds: It's been a month with no answer. Closing out for now. If you can provide the needed information, we'll reopen and get this taken care of. Issue attribute updates:

Issue 568 in reviewboard: TIME_ZONE description URL in settings_local.py.tmpl points to unhelpful page

2008-09-14 Thread codesite-noreply
Issue 568: TIME_ZONE description URL in settings_local.py.tmpl points to unhelpful page http://code.google.com/p/reviewboard/issues/detail?id=568 Comment #1 by trowbrds: Fixed in SVN r1501. Thanks! Issue attribute updates: Status: Fixed -- You received this message because you are

Issue 648 in reviewboard: Comment in unchanged code appears, but not clickable

2008-09-15 Thread codesite-noreply
Issue 648: Comment in unchanged code appears, but not clickable http://code.google.com/p/reviewboard/issues/detail?id=648 New issue report by javamaxster: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? What steps will

Issue 649 in reviewboard: Make it obvious that the file list is incomplete for reviews that span multiple pages

2008-09-15 Thread codesite-noreply
Issue 649: Make it obvious that the file list is incomplete for reviews that span multiple pages http://code.google.com/p/reviewboard/issues/detail?id=649 New issue report by adsouza: What's the URL of the page this enhancement relates to, if any?

Issue 650 in reviewboard: security is too permissive for public sites.

2008-09-16 Thread codesite-noreply
Issue 650: security is too permissive for public sites. http://code.google.com/p/reviewboard/issues/detail?id=650 Comment #1 by chipx86: If you go into the Settings, you can disable anonymous access to the site, blocking out everybody who doesn't have an account. Issue attribute updates:

Issue 650 in reviewboard: security is too permissive for public sites.

2008-09-16 Thread codesite-noreply
Issue 650: security is too permissive for public sites. http://code.google.com/p/reviewboard/issues/detail?id=650 Comment #2 by [EMAIL PROTECTED]: thanks for your quick reply! i'm just a user not the admin, so i didn't know about those settings. -- You received this message because you are

Issue 649 in reviewboard: Make it obvious that the file list is incomplete for reviews that span multiple pages

2008-09-17 Thread codesite-noreply
Issue 649: Make it obvious that the file list is incomplete for reviews that span multiple pages http://code.google.com/p/reviewboard/issues/detail?id=649 Comment #1 by trowbrds: I don't think this is actually a problem. It was particularly confusing on Carmen's review because both the first

Issue 655 in reviewboard: File listing should indicate the type of change

2008-09-17 Thread codesite-noreply
Issue 655: File listing should indicate the type of change http://code.google.com/p/reviewboard/issues/detail?id=655 New issue report by karthik.murthy: *NOTE: If you have a patch, please submit it to http://reviews.review-board.org/ What's the URL of the page this enhancement relates to, if

Issue 655 in reviewboard: File listing should indicate the type of change

2008-09-18 Thread codesite-noreply
Issue 655: File listing should indicate the type of change http://code.google.com/p/reviewboard/issues/detail?id=655 Comment #2 by chipx86: I'd like to include this type of information, though it won't happen until 1.5 at the earliest. Issue attribute updates: Labels: -Type-Defect

Issue 652 in reviewboard: Mails are not sent when user is in the CC

2008-09-18 Thread codesite-noreply
Issue 652: Mails are not sent when user is in the CC http://code.google.com/p/reviewboard/issues/detail?id=652 Comment #1 by chipx86: That patch will add to the BCC list. We need to find out why CC is failing. On the e-mails, are you actually seeing the right e-mail addresses on the Cc line?

Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2008-09-18 Thread codesite-noreply
Issue 394: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Comment #7 by chipx86: Can you please provide this as a diff on http://reviews.review-board.org/ ? Issue attribute updates: Labels:

Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2008-09-18 Thread codesite-noreply
Issue 394: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Comment #8 by torsten.flatter: Done: http://reviews.review-board.org/r/555/ -- You received this message because you are listed in the

Issue 652 in reviewboard: Mails are not sent when user is in the CC

2008-09-18 Thread codesite-noreply
Issue 652: Mails are not sent when user is in the CC http://code.google.com/p/reviewboard/issues/detail?id=652 Comment #3 by dimitar.kamenov: With your last commit(r1509) it looks fixed. So I don't have to attach you e-mail headers as you request. Just to comment that CC was in the e-mail, but

Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.

2008-09-18 Thread codesite-noreply
Issue 658: Error : The patch to 'filepath' didn't apply cleanly. http://code.google.com/p/reviewboard/issues/detail?id=658 New issue report by sudarsan: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem?

Issue 659 in reviewboard: Highlight trailing spaces in diff view

2008-09-19 Thread codesite-noreply
Issue 659: Highlight trailing spaces in diff view http://code.google.com/p/reviewboard/issues/detail?id=659 Comment #2 by chipx86: We already highlight trailing whitespace, though it is for some reason broken on that review request. I'll look into it. It's likely due to the browser not

Issue 659 in reviewboard: Highlight trailing spaces in diff view

2008-09-19 Thread codesite-noreply
Issue 659: Highlight trailing spaces in diff view http://code.google.com/p/reviewboard/issues/detail?id=659 Comment #3 by cordahi: See also issue 419 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust

Issue 553 in reviewboard: If base diff path is missing for new review, path to diff disappears

2008-09-20 Thread codesite-noreply
Issue 553: If base diff path is missing for new review, path to diff disappears http://code.google.com/p/reviewboard/issues/detail?id=553 Comment #3 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Labels: -Priority-Medium Priority-Low -- You received

Issue 493 in reviewboard: Scands causes Internal Server Error

2008-09-22 Thread codesite-noreply
Issue 493: Scands causes Internal Server Error http://code.google.com/p/reviewboard/issues/detail?id=493 Comment #6 by trowbrds: Closing because the needed information was not provided. If you can reproduce this and get a traceback, please add a comment and we'll reopen the bug. Issue

Issue 508 in reviewboard: Can't post diffs containing 8-bit (non-ascii) characters

2008-09-22 Thread codesite-noreply
Issue 508: Can't post diffs containing 8-bit (non-ascii) characters http://code.google.com/p/reviewboard/issues/detail?id=508 Comment #6 by trowbrds: Assuming fixed in django. Issue attribute updates: Status: Fixed -- You received this message because you are listed in the owner or

Issue 577 in reviewboard: Exception Type: DoesNotExist at /reviewboard/r/22/publish/

2008-09-23 Thread codesite-noreply
Issue 577: Exception Type: DoesNotExist at /reviewboard/r/22/publish/ http://code.google.com/p/reviewboard/issues/detail?id=577 Comment #2 by trowbrds: Closing because the requested information has not been provided. If this is still a problem and you can supply the needed information, please

Issue 665 in reviewboard: Link to diff between revisions is broken

2008-09-23 Thread codesite-noreply
Issue 665: Link to diff between revisions is broken http://code.google.com/p/reviewboard/issues/detail?id=665 New issue report by castano: What's the URL of the page containing the problem? http://maki/r/25/diff/1/#index_header What steps will reproduce the problem? 1. Add two revisions to a

Issue 586 in reviewboard: Publishing draft of comment shows error.

2008-09-23 Thread codesite-noreply
Issue 586: Publishing draft of comment shows error. http://code.google.com/p/reviewboard/issues/detail?id=586 Comment #2 by castano: We are having the same issue. The error is displayed, however the comments are actually added. The error happens when 'function submitReplyDraft(review_id)' is

Issue 586 in reviewboard: Publishing draft of comment shows error.

2008-09-23 Thread codesite-noreply
Issue 586: Publishing draft of comment shows error. http://code.google.com/p/reviewboard/issues/detail?id=586 Comment #3 by castano: The same error is produced when publishing comments through the diff view. The following message appears next to the publish button in the comment popup

Issue 667 in reviewboard: Cannot mark item with a start when in list

2008-09-24 Thread codesite-noreply
Issue 667: Cannot mark item with a start when in list http://code.google.com/p/reviewboard/issues/detail?id=667 Comment #1 by todor.hr: start in the subject line to be read as *STAR* -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Issue 668 in reviewboard: View Diff reports FileNotFound due to incorrect revision

2008-09-24 Thread codesite-noreply
Issue 668: View Diff reports FileNotFound due to incorrect revision http://code.google.com/p/reviewboard/issues/detail?id=668 New issue report by [EMAIL PROTECTED]: What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Create a patch file 2. Create a

Issue 668 in reviewboard: View Diff reports FileNotFound due to incorrect revision

2008-09-24 Thread codesite-noreply
Issue 668: View Diff reports FileNotFound due to incorrect revision http://code.google.com/p/reviewboard/issues/detail?id=668 Comment #1 by chipx86: Have you tried this using post-review? Does it still fail? We recently fixed an issue like this in post-review. -- You received this message

Issue 586 in reviewboard: Publishing draft of comment shows error.

2008-09-24 Thread codesite-noreply
Issue 586: Publishing draft of comment shows error. http://code.google.com/p/reviewboard/issues/detail?id=586 Comment #4 by castano: This seems to have something to do with the email settings not setup properly. If the mail server returns an error, then the client doesn't display a meaningful

Issue 668 in reviewboard: View Diff reports FileNotFound due to incorrect revision

2008-09-25 Thread codesite-noreply
Issue 668: View Diff reports FileNotFound due to incorrect revision http://code.google.com/p/reviewboard/issues/detail?id=668 Comment #2 by [EMAIL PROTECTED]: Thanks for the reply - but I don't know what post-review is Is it a separate tool from reviewboard, or an option within reviewboard?

Issue 666 in reviewboard: view diff causes Error - cvs.py

2008-09-25 Thread codesite-noreply
Issue 666: view diff causes Error - cvs.py http://code.google.com/p/reviewboard/issues/detail?id=666 Comment #4 by drgiri: Is there any way we need to change the stuatus as assigned or info supplied ? I do not see any way to effect such a change ? TIA. drgiri -- You received this message

Issue 670 in reviewboard: Add ability to have required and optional reviewers

2008-09-25 Thread codesite-noreply
Issue 670: Add ability to have required and optional reviewers http://code.google.com/p/reviewboard/issues/detail?id=670 New issue report by ciaomary: Describe the enhancement and the motivation for it. This would allow multiple reviewers of your code, but puts pressure on those people who would

Issue 671 in reviewboard: Email Reminder (Nag) Feature for open review requests

2008-09-25 Thread codesite-noreply
Issue 671: Email Reminder (Nag) Feature for open review requests http://code.google.com/p/reviewboard/issues/detail?id=671 New issue report by ciaomary: Some developers end up with so many reviews that they slip off their radar. Others have mentioned that now you don’t have someone coming to

Issue 671 in reviewboard: Email Reminder (Nag) Feature for open review requests

2008-09-25 Thread codesite-noreply
Issue 671: Email Reminder (Nag) Feature for open review requests http://code.google.com/p/reviewboard/issues/detail?id=671 Comment #1 by trowbrds: Duplicate of issue 221. Issue attribute updates: Status: Duplicate -- You received this message because you are listed in the owner or CC

Issue 666 in reviewboard: view diff causes Error - cvs.py

2008-09-25 Thread codesite-noreply
Issue 666: view diff causes Error - cvs.py http://code.google.com/p/reviewboard/issues/detail?id=666 Comment #5 by trowbrds: It's something the group admins have access to, but isn't open to regular users. Issue attribute updates: Status: Accepted Owner: chipx86 -- You

Issue 672 in reviewboard: Reviewers (Groups/People) cannot be edited on draft

2008-09-25 Thread codesite-noreply
Issue 672: Reviewers (Groups/People) cannot be edited on draft http://code.google.com/p/reviewboard/issues/detail?id=672 Comment #1 by trowbrds: You got automatically logged out. Click the Login link at the top right of the page. Issue attribute updates: Status: UserError -- You

Issue 672 in reviewboard: Reviewers (Groups/People) cannot be edited on draft

2008-09-25 Thread codesite-noreply
Issue 672: Reviewers (Groups/People) cannot be edited on draft http://code.google.com/p/reviewboard/issues/detail?id=672 Comment #3 by trowbrds: This is bizarre. We haven't changed the code running on reviewboard.eng in quite some time. What happens if you shift+reload on the page? Issue

Issue 450 in reviewboard: Include an offset on file numbers in paginated diffviewer page

2008-09-27 Thread codesite-noreply
Issue 450: Include an offset on file numbers in paginated diffviewer page http://code.google.com/p/reviewboard/issues/detail?id=450 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Started Owner: trowbrds -- You received this

Issue 676 in reviewboard: post-review fails when uploading diff

2008-09-27 Thread codesite-noreply
Issue 676: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 New issue report by lukatmyshu: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? post-review command line tool What

Issue 645 in reviewboard: post-review.py: handle_renames incorrectly mangles '--' lines for SVN

2008-09-28 Thread codesite-noreply
Issue 645: post-review.py: handle_renames incorrectly mangles '--' lines for SVN http://code.google.com/p/reviewboard/issues/detail?id=645 Comment #3 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New -- You received this message because you

Issue 659 in reviewboard: Highlight trailing spaces in diff view

2008-09-28 Thread codesite-noreply
Issue 659: Highlight trailing spaces in diff view http://code.google.com/p/reviewboard/issues/detail?id=659 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New -- You received this message because you are listed in the owner or CC

Issue 392 in reviewboard: automatically save fields in the edit state when publishing

2008-09-28 Thread codesite-noreply
Issue 392: automatically save fields in the edit state when publishing http://code.google.com/p/reviewboard/issues/detail?id=392 Comment #9 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New -- You received this message because you are listed

Issue 334 in reviewboard: Error: Unable to retrieve list of comments: Internal Server Error

2008-09-28 Thread codesite-noreply
Issue 334: Error: Unable to retrieve list of comments: Internal Server Error http://code.google.com/p/reviewboard/issues/detail?id=334 Comment #10 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New Owner: --- -- You received this

Issue 657 in reviewboard: Show Review Id Number

2008-09-28 Thread codesite-noreply
Issue 657: Show Review Id Number http://code.google.com/p/reviewboard/issues/detail?id=657 Comment #3 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New -- You received this message because you are listed in the owner or CC fields of this

Issue 368 in reviewboard: Provide a user manual for Review Board

2008-09-28 Thread codesite-noreply
Issue 368: Provide a user manual for Review Board http://code.google.com/p/reviewboard/issues/detail?id=368 Comment #5 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed in the owner or

Issue 392 in reviewboard: automatically save fields in the edit state when publishing

2008-09-28 Thread codesite-noreply
Issue 392: automatically save fields in the edit state when publishing http://code.google.com/p/reviewboard/issues/detail?id=392 Comment #10 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are

Issue 503 in reviewboard: Add a link on the dashboard to view submitted review requests

2008-09-28 Thread codesite-noreply
Issue 503: Add a link on the dashboard to view submitted review requests http://code.google.com/p/reviewboard/issues/detail?id=503 Comment #3 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are

Issue 618 in reviewboard: Return a sane response for API calls when Review Board is not set up properly.

2008-09-28 Thread codesite-noreply
Issue 618: Return a sane response for API calls when Review Board is not set up properly. http://code.google.com/p/reviewboard/issues/detail?id=618 Comment #2 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this

Issue 657 in reviewboard: Show Review Id Number

2008-09-28 Thread codesite-noreply
Issue 657: Show Review Id Number http://code.google.com/p/reviewboard/issues/detail?id=657 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Started Owner: trowbrds -- You received this message because you are listed in the

Issue 599 in reviewboard: Unable to modify user information when NIS credentials used

2008-09-28 Thread codesite-noreply
Issue 599: Unable to modify user information when NIS credentials used http://code.google.com/p/reviewboard/issues/detail?id=599 Comment #8 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Started Owner: trowbrds -- You received this

Issue 599 in reviewboard: Unable to modify user information when NIS credentials used

2008-09-28 Thread codesite-noreply
Issue 599: Unable to modify user information when NIS credentials used http://code.google.com/p/reviewboard/issues/detail?id=599 Comment #9 by trowbrds: Fixed in SVN r1514. Note that this fix will only apply to new users. You may want to use the django shell to call set_unusable_password() on

Issue 489 in reviewboard: [ ] DON'T SHIP IT button

2008-09-28 Thread codesite-noreply
Issue 489: [ ] DON'T SHIP IT button http://code.google.com/p/reviewboard/issues/detail?id=489 Comment #10 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed in the owner or CC fields of

Issue 546 in reviewboard: Post-review dosn't like apostrophe's

2008-09-28 Thread codesite-noreply
Issue 546: Post-review dosn't like apostrophe's http://code.google.com/p/reviewboard/issues/detail?id=546 Comment #3 by trowbrds: It looks like this wasn't a normal apostrophe, it was some sort of funky smart quote. What encoding is your system using? -- You received this message because

Issue 589 in reviewboard: Opera: Review location issue

2008-09-28 Thread codesite-noreply
Issue 589: Opera: Review location issue http://code.google.com/p/reviewboard/issues/detail?id=589 Comment #3 by trowbrds: I can't reproduce this. What version of Opera are you using? -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Issue 647 in reviewboard: Error return value of _prepare_draft unused in webapi/json.py

2008-09-28 Thread codesite-noreply
Issue 647: Error return value of _prepare_draft unused in webapi/json.py http://code.google.com/p/reviewboard/issues/detail?id=647 Comment #2 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: New Owner: --- -- You received this message

Issue 589 in reviewboard: Opera: Review location issue

2008-09-29 Thread codesite-noreply
Issue 589: Opera: Review location issue http://code.google.com/p/reviewboard/issues/detail?id=589 Comment #4 by mailswami: 9.52. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue

Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request

2008-09-29 Thread codesite-noreply
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #7 by trowbrds: After discussing this with Christian, I'm going to say that we're not going to change this behavior. If you change

Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request

2008-09-29 Thread codesite-noreply
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #8 by amordkov: Please note that, as per comment #2, the title of the bug should be Posting a new diff against a changeset for

Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request

2008-09-29 Thread codesite-noreply
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #9 by chipx86: I may be changing Discard down the road but that's just a label. It's not the same as deleting (admins actually have

Issue 581 in reviewboard: Dashboard defaults to Incoming Reviews, not last viewed box

2008-09-29 Thread codesite-noreply
Issue 581: Dashboard defaults to Incoming Reviews, not last viewed box http://code.google.com/p/reviewboard/issues/detail?id=581 Comment #2 by trowbrds: Keeping state like this is tricky unless we plumb it through the views somehow. It's really easy for things to get weird if you're working

Issue 598 in reviewboard: Enhancement: Editing the people field to add reviewers should look at both the user id and First/Last names

2008-09-29 Thread codesite-noreply
Issue 598: Enhancement: Editing the people field to add reviewers should look at both the user id and First/Last names http://code.google.com/p/reviewboard/issues/detail?id=598 Comment #2 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status:

Issue 581 in reviewboard: Dashboard defaults to Incoming Reviews, not last viewed box

2008-09-29 Thread codesite-noreply
Issue 581: Dashboard defaults to Incoming Reviews, not last viewed box http://code.google.com/p/reviewboard/issues/detail?id=581 Comment #3 by chipx86: Or just store a cookie and return the appropriate view based on that value, making it work like a query parameter. -- You received this

Issue 677 in reviewboard: post-review can

2008-09-29 Thread codesite-noreply
Issue 677: post-review can http://code.google.com/p/reviewboard/issues/detail?id=677 Comment #7 by chipx86: Mind posting it on http://reviews.review-board.org/ ? Issue attribute updates: Status: Confirmed -- You received this message because you are listed in the owner or CC fields

Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request

2008-09-29 Thread codesite-noreply
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #10 by amordkov: I think it's not uncommon for a developer to want to really 'discard' diffs that they had uploaded, so that

Issue 672 in reviewboard: Reviewers (Groups/People) cannot be edited on draft

2008-09-30 Thread codesite-noreply
Issue 672: Reviewers (Groups/People) cannot be edited on draft http://code.google.com/p/reviewboard/issues/detail?id=672 Comment #10 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: NotABug -- You received this message because you are listed in

Issue 472 in reviewboard: HGTool does not support git style diff

2008-09-30 Thread codesite-noreply
Issue 472: HGTool does not support git style diff http://code.google.com/p/reviewboard/issues/detail?id=472 Comment #5 by al.yazdi: Why not taking the most recent revision then (tip)? I don't see any reason of posting a diff that does not apply on the most recent revision ... BTW, Mercurial

Issue 677 in reviewboard: CVSClient in post-review is particularly fragile with respect to qualified domains

2008-10-01 Thread codesite-noreply
Issue 677: CVSClient in post-review is particularly fragile with respect to qualified domains http://code.google.com/p/reviewboard/issues/detail?id=677 Comment #13 by skip.montanaro: Thanks, that worked. It was just the base diff path I couldn't figure out. I just published a patch:

Issue 640 in reviewboard: Admin-Settings-General-Site Settings-Server adds an extra slash to the end of the url.

2008-10-02 Thread codesite-noreply
Issue 640: Admin-Settings-General-Site Settings-Server adds an extra slash to the end of the url. http://code.google.com/p/reviewboard/issues/detail?id=640 Comment #1 by skip.montanaro: I encounter the same behavior. All generated URLs have an extra slash and are thus invalid. -- You

Issue 614 in reviewboard: Very poor performance with diffs against large files

2008-10-02 Thread codesite-noreply
Issue 614: Very poor performance with diffs against large files http://code.google.com/p/reviewboard/issues/detail?id=614 Comment #2 by ciaomary: We're having this same issue with large diffs. (we use perforce). CPU is at 100% for a few minutes. -- You received this message because you are

Issue 678 in reviewboard: Failed patch results in Python traceback for diff

2008-10-02 Thread codesite-noreply
Issue 678: Failed patch results in Python traceback for diff http://code.google.com/p/reviewboard/issues/detail?id=678 New issue report by Thomas.D.Marshall: What's the URL of the page containing the problem? r/#/diff/1/ What steps will reproduce the problem? 1. Submit a review request with

Issue 678 in reviewboard: Failed patch results in Python traceback for diff

2008-10-02 Thread codesite-noreply
Issue 678: Failed patch results in Python traceback for diff http://code.google.com/p/reviewboard/issues/detail?id=678 Comment #1 by Thomas.D.Marshall: On further inspection, the diff itself seems to be inaccessible and a new Python traceback is displayed for every attempt to access it. This

Issue 679 in reviewboard: Update ReviewBoard to be compatible with official Perforce P4Python API

2008-10-02 Thread codesite-noreply
Issue 679: Update ReviewBoard to be compatible with official Perforce P4Python API http://code.google.com/p/reviewboard/issues/detail?id=679 New issue report by ciaomary: ReviewBoard just released it's first officially supported P4Python API (2008.1). Release notes here:

Issue 680 in reviewboard: reviewboard does not complain about python-ldap not being available

2008-10-03 Thread codesite-noreply
Issue 680: reviewboard does not complain about python-ldap not being available http://code.google.com/p/reviewboard/issues/detail?id=680 New issue report by ramez.hanna: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? all

Issue 679 in reviewboard: Update ReviewBoard to be compatible with official Perforce P4Python API

2008-10-03 Thread codesite-noreply
Issue 679: Update ReviewBoard to be compatible with official Perforce P4Python API http://code.google.com/p/reviewboard/issues/detail?id=679 Comment #2 by ciaomary: It looks like ReviewBoard is using the Public Depot version rather than official release that just came out. See the release

Issue 679 in reviewboard: Update ReviewBoard to be compatible with official Perforce P4Python API

2008-10-03 Thread codesite-noreply
Issue 679: Update ReviewBoard to be compatible with official Perforce P4Python API http://code.google.com/p/reviewboard/issues/detail?id=679 Comment #3 by ciaomary: I updated my code and the older references are no longer in the code. (I still have one reference to 'import p4' but it is in a

Issue 679 in reviewboard: Update ReviewBoard to be compatible with official Perforce P4Python API

2008-10-03 Thread codesite-noreply
Issue 679: Update ReviewBoard to be compatible with official Perforce P4Python API http://code.google.com/p/reviewboard/issues/detail?id=679 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: NotABug -- You received this message

Issue 681 in reviewboard: djblets.auth.util.internal_login has a bug

2008-10-05 Thread codesite-noreply
Issue 681: djblets.auth.util.internal_login has a bug http://code.google.com/p/reviewboard/issues/detail?id=681 New issue report by august.tu: What steps will reproduce the problem? 1. login as user a 2. not log out,just log in as user b again 3. then you'll see a exception about session's keys

Issue 497 in reviewboard: Easy to forget to save/publish comments

2008-10-05 Thread codesite-noreply
Issue 497: Easy to forget to save/publish comments http://code.google.com/p/reviewboard/issues/detail?id=497 Comment #5 by chipx86: These are being addressed in my UI rewrite. Issue attribute updates: Status: Started Owner: chipx86 -- You received this message because you are

Issue 555 in reviewboard: multiple-line selection in a diff doesn't work when selecting upwards

2008-10-06 Thread codesite-noreply
Issue 555: multiple-line selection in a diff doesn't work when selecting upwards http://code.google.com/p/reviewboard/issues/detail?id=555 Comment #2 by chipx86: This is fixed in my UI rewrite. Issue attribute updates: Status: Started Owner: chipx86 -- You received this

Issue 624 in reviewboard: Can't add inline comments from diff view discussion tab

2008-10-06 Thread codesite-noreply
Issue 624: Can't add inline comments from diff view discussion tab http://code.google.com/p/reviewboard/issues/detail?id=624 Comment #2 by chipx86: My UI rewrite makes it a little more clear how to respond to a comment, which should in a way satisfy this bug. Essentially, existing comments

Issue 495 in reviewboard: I want a To Me column in the Incoming reviews page

2008-10-06 Thread codesite-noreply
Issue 495: I want a To Me column in the Incoming reviews page http://code.google.com/p/reviewboard/issues/detail?id=495 Comment #4 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed in

Issue 522 in reviewboard: svn copy causes problems

2008-10-06 Thread codesite-noreply
Issue 522: svn copy causes problems http://code.google.com/p/reviewboard/issues/detail?id=522 Comment #4 by trowbrds: With SVN, it's very hard (if not impossible) to tell the difference between a file that has a broken copy and a file which is uploaded from the web UI with the wrong base

Issue 583 in reviewboard: ReviewBoard does not verify patch when uploading

2008-10-06 Thread codesite-noreply
Issue 583: ReviewBoard does not verify patch when uploading http://code.google.com/p/reviewboard/issues/detail?id=583 Comment #1 by trowbrds: Some things are always checked during upload, but most things aren't. This hasn't actually changed at all. Still, verifying that the patch is good when

Issue 583 in reviewboard: ReviewBoard does not verify patch when uploading

2008-10-06 Thread codesite-noreply
Issue 583: ReviewBoard does not verify patch when uploading http://code.google.com/p/reviewboard/issues/detail?id=583 Comment #2 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed in

Issue 602 in reviewboard: Show the 'basedir' on the review request page

2008-10-06 Thread codesite-noreply
Issue 602: Show the 'basedir' on the review request page http://code.google.com/p/reviewboard/issues/detail?id=602 Comment #2 by trowbrds: I don't really think it's a useful piece of information. All it tells you is what directory someone was in when they ran `svn diff` (or equivalent). This

Issue 614 in reviewboard: Very poor performance with diffs against large files

2008-10-06 Thread codesite-noreply
Issue 614: Very poor performance with diffs against large files http://code.google.com/p/reviewboard/issues/detail?id=614 Comment #3 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed

Issue 682 in reviewboard: Cannot login after fresh install under apache http.

2008-10-06 Thread codesite-noreply
Issue 682: Cannot login after fresh install under apache http. http://code.google.com/p/reviewboard/issues/detail?id=682 New issue report by [EMAIL PROTECTED]: I tried the latest svn version and followed the wiki Getting Started steps to install all necessary stuff. I setup reviewboard to work

Issue 297 in reviewboard: Show selected diff chunk in a better way

2008-10-06 Thread codesite-noreply
Issue 297: Show selected diff chunk in a better way http://code.google.com/p/reviewboard/issues/detail?id=297 Comment #5 by chipx86: Got this working in my UI rewrite. Issue attribute updates: Status: Started Owner: chipx86 -- You received this message because you are listed

Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box

2008-10-06 Thread codesite-noreply
Issue 401: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Comment #3 by chipx86: Making the UIs configurable makes it a pain to maintain, document and support. After careful consideration,

Issue 555 in reviewboard: multiple-line selection in a diff doesn't work when selecting upwards

2008-10-06 Thread codesite-noreply
Issue 555: multiple-line selection in a diff doesn't work when selecting upwards http://code.google.com/p/reviewboard/issues/detail?id=555 Comment #3 by chipx86: (No comment was entered for this change.) Issue attribute updates: Labels: Milestone-Release1.0 Usability

Issue 681 in reviewboard: djblets.auth.util.internal_login has a bug

2008-10-07 Thread codesite-noreply
Issue 681: djblets.auth.util.internal_login has a bug http://code.google.com/p/reviewboard/issues/detail?id=681 Comment #1 by trowbrds: Fixed in djblets SVN r11890. Thanks! Issue attribute updates: Status: Fixed -- You received this message because you are listed in the owner or CC

Issue 682 in reviewboard: Cannot login after fresh install under apache http.

2008-10-07 Thread codesite-noreply
Issue 682: Cannot login after fresh install under apache http. http://code.google.com/p/reviewboard/issues/detail?id=682 Comment #2 by [EMAIL PROTECTED]: I tried with version 1.0.0 final and have the same issue. -- You received this message because you are listed in the owner or CC fields of

Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box

2008-10-07 Thread codesite-noreply
Issue 401: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Comment #5 by chipx86: The key difference with the popup window is that we get intelligently place it initially but give users the

Issue 685 in reviewboard: Allow user to change Email functionality

2008-10-08 Thread codesite-noreply
Issue 685: Allow user to change Email functionality http://code.google.com/p/reviewboard/issues/detail?id=685 New issue report by rlogel: We have Review Board configured to send email when changes happen. It is a little annoying that a user still gets and email for changes that they make. It

Issue 551 in reviewboard: Can't publish or discard comments in one review

2008-10-08 Thread codesite-noreply
Issue 551: Can't publish or discard comments in one review http://code.google.com/p/reviewboard/issues/detail?id=551 Comment #3 by trowbrds: In that case, I'm going to close this out. If anyone encounters this again and can get us some more detailed failure information, please add a comment

Issue 624 in reviewboard: Can't add inline comments from diff view discussion tab

2008-10-09 Thread codesite-noreply
Issue 624: Can't add inline comments from diff view discussion tab http://code.google.com/p/reviewboard/issues/detail?id=624 Comment #3 by gmueller: I have several comments about this workflow, which is confusing a lot of people. First, I don't think there should be a Review and Discussion

  1   2   3   4   5   6   7   8   9   10   >