Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2014-11-24 Thread reviewboard


Comment #27 on issue 831 by trowb...@gmail.com: Can't leave comments before  
you publish your own newly created review request

https://code.google.com/p/reviewboard/issues/detail?id=831

Issue 3679 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2014-01-20 Thread reviewboard

Updates:
Labels: -Milestone-Release1.8

Comment #26 on issue 831 by trowb...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2013-10-26 Thread reviewboard


Comment #25 on issue 831 by j.dufrai...@gmail.com: Can't leave comments  
before you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

A very simple work around i have used is to assign just yourself as the  
reviewer.


You can then just publish it, this notify only you.
You can then add comments, new diffs even.
When you are happy it is in a state to be distributed to others, update the  
reviewer to be the intended reviewer instead.


Maybe not the nicest way, but perfectly functional in the situation i  
encountered.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2012-11-23 Thread reviewboard

Updates:
Labels: -Milestone-Release1.7 Milestone-Release1.8

Comment #24 on issue 831 by trowb...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-04-27 Thread reviewboard


Comment #23 on issue 831 by trowb...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 2087 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-04-16 Thread reviewboard


Comment #22 on issue 831 by replical...@gmail.com: Can't leave comments  
before you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Wecome to me Webiste:

http://www.handbagshopping.org   handbags for sale
http://www.sunglassesshopping.org   designer sunglasses
http://www.mbtshoesshopping.com   cheap mbt
http://www.christianlouboutinonline.net   christian louboutin discount
http://www.ghdstraightenerssale.com   ghd mk4
http://www.tiffanyjewelleryshop.org   tiffany necklace
http://www.shoppinglouisvuitton.org   louis vuitton wallet
http://www.chanelbagonline.net   chanel shop
http://www.christianlouboutinshopping.org   discount christian louboutin
http://www.maccosmeticsshop.org   mac palette eyeshadow
http://www.guccigucci.org gucci bags

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-01-30 Thread reviewboard

Updates:
Status: Confirmed
Labels: -Type-Defect Type-Enhancement Milestone-Release1.7

Comment #21 on issue 831 by chip...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

You're right. There's many people who want it, and I'm perfectly fine with  
it. Nobody has provided a patch for this, and while that's not a  
prerequisite for getting this in, please understand that there are lot of  
tickets and a lot of e-mails asking for all sorts of things, and we're only  
two people working full-time on this.


I would like to see this done at this point, and maybe we can get it into  
some release at some point soon (1.7 is the soonest I can imagine doing it  
unless someone sends us a patch). But please realize we're not selectively  
ignoring this patch. We just have to prioritize, and unfortunately that  
always means someone ends up not being happy or feels we're prioritizing  
incorrectly.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-01-27 Thread reviewboard


Comment #20 on issue 831 by cro...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

I think the sheer number of duplicate merges on this issue show it's  
important to a lot of users. It's been two years (exactly!), can we work on  
a solution instead of arguing the merits?


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-09-25 Thread reviewboard


Comment #19 on issue 831 by trowbrds: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1811 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-09-24 Thread reviewboard


Comment #18 on issue 831 by sameeralam69: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

it is good effort to demonstrate the way that help to understand

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-09-16 Thread reviewboard


Comment #17 on issue 831 by ben.hollis: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Whichever way it ends up working, if you can't comment on an unpublished  
review it should either not allow you to try or put up an informative  
message, not an error.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-09-16 Thread reviewboard


Comment #16 on issue 831 by trowbrds: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1816 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-09-09 Thread reviewboard


Comment #15 on issue 831 by chipx86: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1804 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-06-15 Thread reviewboard


Comment #14 on issue 831 by AaronJSherman: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Since my issue 1686 was marked as a dup of this, let me cover what I think  
are the extras from that request that would pertain, here:


Leaving comments on my own review is primarily useful, I think, because of  
the desire to leave notes to the other reviewers. As such, the marker for  
such comments should definitely be visually distinct and the UI should make  
it clear that it's not just another reviewer commenting on the same section  
of code.


Also, a list of links to the notes under the description would really help  
to emphasize their importance to the reviewers.




--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2010-06-15 Thread reviewboard


Comment #13 on issue 831 by trowbrds: Can't leave comments before you  
publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1686 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-08-23 Thread codesite-noreply


Comment #10 on issue 831 by allyourcode: Can't leave comments before you  
publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

re http://code.google.com/p/reviewboard/issues/detail?id=831#c7";>comment
7, by chipx86:

Alot of the RB-specific concepts you mention don't mean a whole lot to  
users. All I
know is that I want to be able to add comments before letting other people  
view my
changes. Other people on this thread have mentioned good reasons for having  
this. For
me, the reason is that I want to help reviewers understand the my changes.  
Depending
on how familiar a reviewer is with the code that that's been touched, it  
can be
pretty difficult to just dive right into a set of changes. Comments would  
serve as
valuable guideposts, explaining why each change is necessary, and how each  
fits in
with the rest of the changes.

I can see your point about the case where a user is working on a draft, has  
added
some comments, and discovers that she wants to replace the diff that's  
she's already
uploaded with another one. I'm not totally sure how to solve that, but it  
seems like
a separate issue. Doesn't the same thing come up when someone goes through  
the flow
that you suggest (ie publish -> add self-comments -> solicit reviews from  
others)?
Suppose I've added some self-comments to a published review, and I discover  
that I
made a mistake (eg a few files were not included). When I upload my new  
diff, won't
my previous comments not be associated with the new diff?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-08-22 Thread codesite-noreply


Comment #9 on issue 831 by trowbrds: Can't leave comments before you  
publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1265 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-27 Thread codesite-noreply


Comment #8 on issue 831 by devli...@buzzardsoft.com: Can't leave comments  
before you publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

For reasons #1-#3, I can't really comment much on the technical or design  
merits that prevent the original request from being implemented.  I guess I  
would only say that given a
legitimate use-case for allowing pre-review of a diff (and a suitable  
demand for implementation of that use-case), it seems like the technical  
issues can be overcome and may well
make the project better.  Clearly this isn't going to happen right away,  
but IMO it's worth consideration (or I wouldn't be posting here :-)).

Re: "4) You can already review your own diffs, as long as you do it after  
you publish!"

The issue with this is that if you publish your diff with email  
notification, there's a race of sorts between when you are finished with  
your self-review and when others might respond to
your review.  This is clearly not optimal.  If you realize that your  
changes aren't up to snuff (i.e. you want to throw out your review) or you  
haven't provided key guidance in review
comments, you've wasted your reviewers time.

That leads to a workaround which is - again - not optimal: Assign yourself  
as the reviewer for your diff and publish it.  A review email will be  
sent.  Review your changes, leave
comments, etc.  When you are done, change the reviewer to the real list of  
reviewers.  This appears to send out a new review email.




--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-25 Thread codesite-noreply


Comment #7 on issue 831 by chipx86: Can't leave comments before you publish  
your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

When I said we shouldn't allow it, I meant we should disable commenting on  
draft
diffs to satisfy the bug. Yes, I agree that it would be nice to be able to  
review a
draft diff, but there are problems with this:

1) A draft diff has no revision and no place in a review request's diff  
history.

This means it works quite a bit differently from published diffs, and we'd  
need to
special-case more code and possibly add URL mappings in the diff viewer and  
webapi
just for this case, which clients (including the JavaScript code in the  
diff viewer)
would have to conditionally use. There may also be migration issues for the  
review
after publishing a review request.

2) We'd need to decide what publishing a review against an unpublished diff  
means.

Do we publish a review automatically with a review request? No, as it may  
not be
finished yet. So instead we need to know that a review has been published  
but is not
meant to be shown.

This would require that our code be updated to allow for handling reviews  
of this
type. Reusing the "public" state for a review isn't good enough, because  
you don't
necessarily want publishing a review request to publish this type of review
automatically.

So now we have to add this new state, and migrate over the review's type  
when the
review request is published, meaning the review request now needs to have  
more
control over reviews, complicating things quite a bit.

3) Showing reviews against unpublished diffs doesn't make sense.

Even with the above state tracking and such, it doesn't make any sense for  
another
user to see a review against an unpublished diff. They can't view the diff  
yet, so
all they could see is the context in the review. We also would need to now
special-case e-mail, the API results, etc.

Really, it's just too early. What if you begin a review on your own code,  
writing
detailed explanations and then, as you're reviewing, realize you've screwed  
up on the
diff? You'd need to upload a new diff and redo the review. We can't just  
migrate your
existing comments over, because they may not make sense anymore in context.  
We
decided long ago not to even attempt going that route when reviewing  
another person's
diffs, and the reasons still apply for reviewing your own draft diffs.

4) You can already review your own diffs, as long as you do it after you  
publish!

Go over your diff if you want, but then when you're sure this is the diff  
you want
the world to see, publish it. Then go and review it and give notes on  
things you want
people to know about. The end goal is to give people a list of things you  
noticed in
your diff, and the best time to do that is when the diff is available for  
them to
see. It saves a lot of complexity in the product and in the interaction.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-25 Thread codesite-noreply


Comment #6 on issue 831 by kbcmdba: Can't leave comments before you publish  
your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

I disagree with Christian.  Commenting on your own posting is a good way of  
doing
self-review.  There are times when I need to look through my own changes  
allowing
ReviewBoard to help me.  This results in cases where it's easier to look at  
my own
changes, especially when considering large diffs.  In that type of  
situation, I may
post a comment noting that I saw a problem and have already fixed it but  
won't
re-post an updated review until I get more feedback from others.  This  
saves other
reviewers time.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-25 Thread codesite-noreply


Comment #5 on issue 831 by kbcmdba: Can't leave comments before you publish  
your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

I disagree with Christian.  Commenting on your own posting is a good way of  
doing
self-review.  There are times when I need to look through my own changes  
allowing
ReviewBoard to help me.  This results in cases where it's easier to look at  
my own
changes, especially when considering large diffs.  In that type of  
situation, I may
post a comment noting that I saw a problem and have already fixed it but  
won't
re-post an updated review until I get more feedback from others.  This  
saves other
reviewers time.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-22 Thread codesite-noreply


Comment #4 on issue 831 by devli...@buzzardsoft.com: Can't leave comments  
before you publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

I agree that there's a use case for adding comments before publishing a  
review.  The main one is to provide
guidance to reviewers who may not be familiar with the code, or with the  
reasons that you made a particular
change.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-19 Thread codesite-noreply


Comment #3 on issue 831 by andreas.kloeckner: Can't leave comments before  
you publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

In Issue 1053, Christian commented that comments should just not be allowed  
in this
situation. I do think there's a use case for these comments. Maybe a first  
review
could be created automatically to harbor these?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-05-18 Thread codesite-noreply


Comment #2 on issue 831 by trowbrds: Can't leave comments before you  
publish your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1124 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-04-21 Thread codesite-noreply


Comment #1 on issue 831 by chipx86: Can't leave comments before you publish  
your own newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831

Issue 1053 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2009-01-26 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 831 by mkoebele: Can't leave comments before you publish your own  
newly created review request
http://code.google.com/p/reviewboard/issues/detail?id=831


What steps will reproduce the problem?
1. create a new review request by uploading a diff, don't publish it yet
2. view the diff and add a comment, hit "Save"
3. You will get an error message at the top:

"Error:
undefined 404 Not Found

Please try again later. If this continues to happen, please report it to
your administrator."

4. Now publish the review. The comments will be lost.

What is the expected output? What do you see instead?
Would it be at all possible that those comments are stored?


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---