Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #24 on issue 2916 by chip...@gmail.com: Review Board does not respect line endings https://code.google.com/p/reviewboard/issues/detail?id=2916 This bug has moved to https://hellosplat.com/s/beanbag/tickets/2916/. Please post any updates there. You can use your existing Google login. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #23 on issue 2916 by prog...@gmail.com: Review Board does not respect line endings https://code.google.com/p/reviewboard/issues/detail?id=2916 I think issue 3198 is another duplicate of this issue This issue issue affect me too- i need the patch to preserve the original CRLFs to be able to cleanly apply the patches. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #22 on issue 2916 by trowb...@gmail.com: Review Board does not respect line endings https://code.google.com/p/reviewboard/issues/detail?id=2916 Issue 3672 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #21 on issue 2916 by ja...@jasonantman.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 I'm being bitten by this issue as well, and it's a real pain when trying to wrap automation around ReviewBoard (i.e. a Jenkins job that has a git commit hash, and tries to make sure the current diff against master matches the one that was shipped). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #20 on issue 2916 by davidpfa...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Our current release process is to merge the approved patch into /trunk, and this issue creates extra steps when merging the downloaded patch. I use 'svn patch' to apply the patch file, which works without errors, but all of the newly inserted lines, as well as the surrounding 'context' lines are converted to unix-style line-endings. I then need to use either unix2dos or Eclipse "File -> Convert Line Delimiters To -> Windows" to fix the line-endings before committing the changes. RB should preserve the uploaded patch without modifications. If it needs a normalized version of the patch for internal processing, it should probably create a working copy. If storage space is a concern, you might also consider deleting the working copies when the review is closed, re-creating them as needed from the original assets if the review is re-opened. You might also be able to short-cut the creation of the working copy of the original patch file is already in the correct format. Thank you for your time, -David Farrell -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #19 on issue 2916 by inebriec...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.14 has this issue as well... -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #17 on issue 2916 by javawiz...@opengroove.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.9 also has this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #16 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 What version of the RB is planned to include this patch? Version 1.7.7.1 does not contain its. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #15 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 It would be nice. Thanks for your answers. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #14 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Yes. Patches are typically done against the current trunk, we can check with reviewboard developers if this can be backported to 1.6.x branch -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #13 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 I see. That is your patch is only suitable for the 1.7 tree? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #12 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Just verified that its not in 1.6.16 either, You would need to be on the 1.7 tree to have that change. The stripping of the newlines is what makes the difference. With my patch on 1.7 tree, it would work because the strip takes care of removing the newlines before the regex parsing happens, but with 1.6.x, since the regex looks like for a line ending with "revision ()" it fails because windows styled line endings have a \r\n tacked after the "revision ()". -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #11 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 We running 1.6.16 Everything works fine with patches that contains unix line endings or unix line endings+windows line endings. But gives the error if the patch contains only windows line endings. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #10 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Are you running 1.6.15? I can see that the string is stripped (which should remove the newlines) before the regex is applied (failing the regex throws the error you mentioned), but the strip is not in the 1.6.15 branch, only on master (1.7 or above). You might want to try it on a 1.7 reviewboard to see if its still a problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #9 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Hi, Sorry about that. I will try this on a windows box. I created a patch on linux and ran a "todos" to convert it to a windows styled patch (with CRLF line ending), uploading this worked fine. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #8 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Some problem detected with this patch. Unable to add patch with windows line endings (CRLF). Trying to add such patch gives the following error: "Unable to parse diff revision header '(revision NNN) '" NNN - revision number. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #7 on issue 2916 by vsavc...@productengine.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Tested the patch, works well. Thank a lot! Looking forward to seeing it in a release. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #6 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 How we can apply this patch? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #5 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Posted a patch for this at http://reviews.reviewboard.org/r/3970/. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #4 on issue 2916 by chip...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Perhaps... Line endings in general are a real problem in diffs, because not only do you have \n and \r\n to deal with, but some things will stupidly give you \r\r\n and other mixtures. If that change passes all unit tests, then I'm okay shipping it and seeing if there's fallout. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #3 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Chris/David, Would it work if we make DiffParser class init do a data.splitlines(True) instead of data.splitlines(), which will keep the line-endings intact(instead of stripping it as it does now and the code manually tacking a \n at the end). We would then have to manipulate the patch method in diffutils.py to strip the line-endings in a way that patch can understand. That way, the data stored in filediffdata remains the same as what the user uploaded, and can be downloaded as such. Maybe Im over-simplifying this issue but thought Id check with you guys before I start on this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #2 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 We test the latest version of RB (1.7.6). It exposes the same problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #1 on issue 2916 by guilhem@mines-paris.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 We are seeing exactly the same problem, in the MySQL group of Oracle. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.