Small improvement on shipit count

2009-06-18 Thread Sebastien Douche
Hi, here we use a different shipit counting : we count only the number of shipit where the timestamp is more recent than last diff. The goal is to see shipit only for the last diff, shipit on precious diff is not relevant. Christian, what do you think about that? -- Sebastien Douche

Re: Small improvement on shipit count

2009-06-18 Thread Eduardo Felipe
Sorry about me getting into the thread but that does sounds interesting, as the current shipit count can be misleading. It could be made a setting, IMHO, as some people with legacy reviews won't like to see their shipit count suddenly decrease. But I can see how this can improve the review

Re: Small improvement on shipit count

2009-06-18 Thread Sebastien Douche
On Thu, Jun 18, 2009 at 17:57, Eduardo Felipeeduardofelip...@gmail.com wrote: Sorry about me getting into the thread but that does sounds interesting, as the current shipit count can be misleading. Exaclty, you have shipit on old diff, not on the new. Do you have a patch? In the file

Re: Small improvement on shipit count

2009-06-18 Thread Christian Hammond
We're waiting until 1.5 to change any of this. We want to introduce a concept of policy that allows for specifying rules like this, but until then, we really don't want to change this logic, as different companies handle this differently. For example, some people want to see this only since the

Re: Small improvement on shipit count

2009-06-18 Thread Eduardo Felipe
Well, that actually is part of my Google Summer of Code project for ReviewBoard, hehehe. []s Edu Felipe On Thu, Jun 18, 2009 at 5:18 PM, Christian Hammondchip...@chipx86.com wrote: We're waiting until 1.5 to change any of this. We want to introduce a concept of policy that allows for

Plans for upcoming 1.0 release party

2009-06-18 Thread Christian Hammond
Hi everyone, We're planning to release Review Board 1.0 this Saturday. It's been in development a long time and I know everyone's eager to see it finally ship. David and I have been working on this for a bit over 2 years now, and decided we must celebrate with a release party. We'd like to

Issue 1174 in reviewboard: All the reviews broke after upgrade from RC1 to RC2.

2009-06-18 Thread codesite-noreply
Comment #2 on issue 1174 by manjunath.shiva: All the reviews broke after upgrade from RC1 to RC2. http://code.google.com/p/reviewboard/issues/detail?id=1174 Yes, I ran that and restarted Apache and also memcache. -- You received this message because you are listed in the owner or CC fields

Issue 1174 in reviewboard: All the reviews broke after upgrade from RC1 to RC2.

2009-06-18 Thread codesite-noreply
Updates: Status: Fixed Owner: chipx86 Comment #7 on issue 1174 by chipx86: All the reviews broke after upgrade from RC1 to RC2. http://code.google.com/p/reviewboard/issues/detail?id=1174 Sorry that blocked you, but glad we got it figured out fast! I've committed the fix, so

Issue 1174 in reviewboard: All the reviews broke after upgrade from RC1 to RC2.

2009-06-18 Thread codesite-noreply
Comment #9 on issue 1174 by manjunath.shiva: All the reviews broke after upgrade from RC1 to RC2. http://code.google.com/p/reviewboard/issues/detail?id=1174 Hi, I just want to let you know that on my test PC running XP, I need to make one more change to fix this issue. In the line 138

Issue 1082 in reviewboard: rb-site not working on Windows

2009-06-18 Thread codesite-noreply
Updates: Status: Fixed Labels: Milestone-Release1.0 Comment #13 on issue 1082 by chipx86: rb-site not working on Windows http://code.google.com/p/reviewboard/issues/detail?id=1082 I meant to close this, but yes, it's fixed in RC3. -- You received this message because you are

Issue 1176 in reviewboard: Installing with Mod Python

2009-06-18 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Component-Docs New issue 1176 by jgeewax: Installing with Mod Python http://code.google.com/p/reviewboard/issues/detail?id=1176 What's the URL of the page containing the problem?