Re: Review Board 1.0.4 released

2009-10-05 Thread Terry Zhong
Thanks for the reply, here comes my environment: Debian 5.0 Django 1.1 release tarball from official site. Review Board 1.0.4 tarball from official site. Djblets and others pulled automatically by Review Board. I feel really strange because reviews is the only page which has this problem,

Re: Review Board 1.0.4 released

2009-10-05 Thread Terry Zhong
Oops, missed something. Yes, I did rb-site upgrade, including a manual evolve which rb-site suggests me to. Yes, I did restarted Apache. The default sorting order is not an issue. I just want to say that both paging and sorting is not working for reviews admin site along, clicking pages or title

Testers wanted for new SSH/HTTPS repository support

2009-10-05 Thread Christian Hammond
Hi everyone, One of the biggest problems we've noticed from new users is that various repositories require SSH or HTTPS (in the case of Subversion) access, and that we had no support for this, requiring instead that users set up a dedicated read-only HTTP repository. Tonight I've committed code

Re: Uploading a internally generated diff file

2009-10-05 Thread Sujith
Thanks for the post-review link. This seems to be really useful I'll go through it and let you know in case of further problems. Another thing which I wanted to implement is to add a new button on new-review-request page and write a python function that would execute on its click. Can you

Re: Uploading a internally generated diff file

2009-10-05 Thread Christian Hammond
Well, you'd have to become familiar with the Django templates (not a ton of work), and how Django handles forms. Then you'd have to write custom code in our form for whatever you're looking to do. The templates are in reviewboard/templates/reviews, and the form code is in

Re: Problem creating new review request on reviews.review-board.org

2009-10-05 Thread smat
Christian, Thanks for information about the --full-index option. The good news is that the previous error no longer occurs. The bad news is that there is now an int argument required error in its place. I would use post-review, unfortunately the machine I am working on is behind a firewall and

Re: Problem creating new review request on reviews.review-board.org

2009-10-05 Thread Christian Hammond
Where is this error? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Oct 5, 2009 at 5:28 PM, smat g...@cictec.com wrote: Christian, Thanks for information about the --full-index option. The

Re: Problem creating new review request on reviews.review-board.org

2009-10-05 Thread smat
The error was at my end - I had selected the wrong patch file (not the newly created --full-index diff). The review request is now successfully submitted. Cheers, Solomon -- Solomon Matthews Systems Engineer Australian Centre for Field Robotics The University of Sydney On Oct 6, 1:04 pm,

Issue 267 in reviewboard: Review Board should indicate whether the patch applies against HEAD

2009-10-05 Thread codesite-noreply
Updates: Summary: Review Board should indicate whether the patch applies against HEAD Comment #4 on issue 267 by trowbrds: Review Board should indicate whether the patch applies against HEAD http://code.google.com/p/reviewboard/issues/detail?id=267 (No comment was entered for this

Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions

2009-10-05 Thread codesite-noreply
Comment #13 on issue 147 by trowbrds: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 1316 has been merged into this issue. -- You received this message because you are listed in the owner or CC

Issue 816 in reviewboard: Adding a review from a directory other than where the file to review exists cause error.

2009-10-05 Thread codesite-noreply
Updates: Status: Fixed Comment #5 on issue 816 by trowbrds: Adding a review from a directory other than where the file to review exists cause error. http://code.google.com/p/reviewboard/issues/detail?id=816 post-review with SVN can take file arguments now, even for remote

Issue 1328 in reviewboard: Maintenance For Code Review Standards

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #1 on issue 1328 by trowbrds: Maintenance For Code Review Standards http://code.google.com/p/reviewboard/issues/detail?id=1328 I've been thinking about this, and I don't think there's any way we can do it which will scale to the standards used in a

Issue 311 in reviewboard: Interdiff includes changes from other changesets

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #5 on issue 311 by trowbrds: Interdiff includes changes from other changesets http://code.google.com/p/reviewboard/issues/detail?id=311 We've thought about this long and hard (since interdiffs were implemented), and there's really no way around it.

Issue 655 in reviewboard: File listing does not differentiate between new and branch/integrate

2009-10-05 Thread codesite-noreply
Updates: Status: Duplicate Mergedinto: 1066 Comment #6 on issue 655 by trowbrds: File listing does not differentiate between new and branch/integrate http://code.google.com/p/reviewboard/issues/detail?id=655 The description over in bug 1066 is a little bit more complete. --

Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)

2009-10-05 Thread codesite-noreply
Comment #4 on issue 1066 by trowbrds: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 Issue 655 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this

Issue 638 in reviewboard: Show the Perforce filetype for files in a changeset.

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #2 on issue 638 by trowbrds: Show the Perforce filetype for files in a changeset. http://code.google.com/p/reviewboard/issues/detail?id=638 I think that these are so rare and esoteric that if they're important, they should just be called out in the

Issue 732 in reviewboard: include 'cvs rdiff' commands and urls to a cvsweb diff in automatically generated emails

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #2 on issue 732 by trowbrds: include 'cvs rdiff' commands and urls to a cvsweb diff in automatically generated emails http://code.google.com/p/reviewboard/issues/detail?id=732 Ehh. We have download diff already, which does the same thing. -- You

Issue 953 in reviewboard: Hg SCMTool doesn't support old mercurial installs

2009-10-05 Thread codesite-noreply
Updates: Summary: Hg SCMTool doesn't support old mercurial installs Comment #3 on issue 953 by trowbrds: Hg SCMTool doesn't support old mercurial installs http://code.google.com/p/reviewboard/issues/detail?id=953 (No comment was entered for this change.) -- You received this message

Issue 1238 in reviewboard: Support collaborative coding

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #2 on issue 1238 by trowbrds: Support collaborative coding http://code.google.com/p/reviewboard/issues/detail?id=1238 For now I'm going to say no; this workflow is pretty unusual. If we get more requests for this we'll start to think about how this

Issue 1276 in reviewboard: Customized highlighting comments similar to //TODO:

2009-10-05 Thread codesite-noreply
Updates: Status: ThirdParty Comment #1 on issue 1276 by trowbrds: Customized highlighting comments similar to //TODO: http://code.google.com/p/reviewboard/issues/detail?id=1276 These highlights come from pygments. -- You received this message because you are listed in the owner or CC

Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation

2009-10-05 Thread codesite-noreply
Updates: Status: NeedInfo Comment #1 on issue 1343 by chipx86: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 I know very little about DKIM, but am

Issue 445 in reviewboard: Add command-line apply-diff script

2009-10-05 Thread codesite-noreply
Comment #8 on issue 445 by trowbrds: Add command-line apply-diff script http://code.google.com/p/reviewboard/issues/detail?id=445 Issue 1319 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this

Issue 1342 in reviewboard: Suggestion: Autocreate DIFF file by Checkout Path

2009-10-05 Thread codesite-noreply
Updates: Status: WontFix Comment #4 on issue 1342 by trowbrds: Suggestion: Autocreate DIFF file by Checkout Path http://code.google.com/p/reviewboard/issues/detail?id=1342 This sort of integration is really, really hard to do in a generic way, and introduces a lot of moving pieces.

Issue 1340 in reviewboard: Patch fails to generate diff on server when the source file does not end with newline char

2009-10-05 Thread codesite-noreply
Updates: Status: Fixed Comment #1 on issue 1340 by trowbrds: Patch fails to generate diff on server when the source file does not end with newline char http://code.google.com/p/reviewboard/issues/detail?id=1340 Fixed in rbtools 3b21dce. Thanks! -- You received this message because

Issue 1339 in reviewboard: post-review errors with [Errno 2] No such file or directory

2009-10-05 Thread codesite-noreply
Updates: Status: Fixed Labels: -Type-Support Type-Defect Component-SCMTools Milestone-Release1.1 Comment #3 on issue 1339 by chipx86: post-review errors with [Errno 2] No such file or directory http://code.google.com/p/reviewboard/issues/detail?id=1339 Fixed on master in

Issue 693 in reviewboard: ability to attach a comment when clicking [Submitted]

2009-10-05 Thread codesite-noreply
Comment #4 on issue 693 by trowbrds: ability to attach a comment when clicking [Submitted] http://code.google.com/p/reviewboard/issues/detail?id=693 Issue 268 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or

Issue 268 in reviewboard: Submitted reviews should include the date the review was submitted

2009-10-05 Thread codesite-noreply
Updates: Status: Duplicate Mergedinto: 693 Comment #6 on issue 268 by trowbrds: Submitted reviews should include the date the review was submitted http://code.google.com/p/reviewboard/issues/detail?id=268 When we fix bug 693, this will come with it. -- You received this

Issue 693 in reviewboard: ability to attach a comment when clicking [Submitted]

2009-10-05 Thread codesite-noreply
Comment #5 on issue 693 by trowbrds: ability to attach a comment when clicking [Submitted] http://code.google.com/p/reviewboard/issues/detail?id=693 As listed in bug 268, we should mark the date in the submitted entry in the history, even if no comment was added. -- You received this

Issue 720 in reviewboard: Editing an existing comment can change which lines it referred to

2009-10-05 Thread codesite-noreply
Updates: Status: Fixed Comment #2 on issue 720 by trowbrds: Editing an existing comment can change which lines it referred to http://code.google.com/p/reviewboard/issues/detail?id=720 I haven't seen this in a long time, actually. Assuming it got fixed with one of our many comment

Issue 1336 in reviewboard: reviewboard 500 error

2009-10-05 Thread codesite-noreply
Comment #2 on issue 1336 by markbroehm: reviewboard 500 error http://code.google.com/p/reviewboard/issues/detail?id=1336 Started seeing the same exact error today. What version are you running? 1.0 What's the URL of the page containing the problem? when publishing a comment

Issue 1336 in reviewboard: reviewboard 500 error

2009-10-05 Thread codesite-noreply
Comment #3 on issue 1336 by chipx86: reviewboard 500 error http://code.google.com/p/reviewboard/issues/detail?id=1336 1.0, or something newer? The newer versions log more information to the log files. Did you set DEBUG = True, or Debug = True? The latter will not work. -- You received this

Issue 1336 in reviewboard: reviewboard 500 error

2009-10-05 Thread codesite-noreply
Comment #4 on issue 1336 by markbroehm: reviewboard 500 error http://code.google.com/p/reviewboard/issues/detail?id=1336 it's DEBUG = True i'm going to try and get the latest version installed tonight, i saw there is better logging as of 1.0.2. Is it possible to install 1.0.2 specifically

Issue 1344 in reviewboard: Wrong inline highligthing

2009-10-05 Thread codesite-noreply
Updates: Status: NotABug Comment #1 on issue 1344 by trowbrds: Wrong inline highligthing http://code.google.com/p/reviewboard/issues/detail?id=1344 This is actually correct. Inter-diff highlighting works within single lines, not across wrapped paragraphs. -- You received this message