Re: Error uploading new diff: fatal: Not a git repository: 'None'

2011-02-02 Thread Christopher Orr
I just reproduced this while trying to use RB 1.5.2 with a custom remote repository (git+ssh://). By trial-and-error, it seems the 'None' error occurs if the Raw file URL mask field is empty. Is it correct to say there's no way to set up a git repository in Review Board, if the git server is

Re: Finding review request id in UI

2011-02-02 Thread Scott Quesnelle
You can see the ReviewID on the dashboard if you add that column, at least in 1.0 you can. Scott On Tue, Feb 1, 2011 at 4:24 PM, Henry Yei henry@gmail.com wrote: Hi, I'm starting to roll out ReviewBoard into our development process and am considering forcing a valid completed reviewboard

Re: Finding review request id in UI

2011-02-02 Thread Henry Yei
Thanks for the tip. I'm still a little unfamiliar with the UI itself and completely missed that. is there a way to configure the default visible columns for all users? I wonder if 1.6 include the review ID in the search index? On Wed, Feb 2, 2011 at 6:20 AM, Scott Quesnelle

Re: Error uploading new diff: fatal: Not a git repository: 'None'

2011-02-02 Thread Christian Hammond
Yeah, unfortunately, Git provides no way to access individual files from a remote repository without a full local clone, which is why the only two options are having that clone or accessing over gitweb or a similar service. We should definitely do better validation to make sure you can never

Re: Finding review request id in UI

2011-02-02 Thread Christian Hammond
We will likely be making it possible to type in a review request ID and immediately get the review request in an auto-complete dropdown in the search box. There's no way to change the default columns for users. Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Error uploading new diff: fatal: Not a git repository: 'None'

2011-02-02 Thread Christopher Orr
Thanks for the confirmation. Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call git clone any time someone hits Upload diff? Chris On

Re: Error uploading new diff: fatal: Not a git repository: 'None'

2011-02-02 Thread Christopher Orr
On Feb 2, 10:47 pm, Christopher Orr ch...@orr.me.uk wrote: Is there any chance of an option that just allows the full local clone to be done over git (if the user says that's fine)? Or would that be too strenuous on Review Board, as it would (presumably) have to call git clone any time someone

Re: Error uploading new diff: fatal: Not a git repository: 'None'

2011-02-02 Thread Christian Hammond
Having Review Board manage the clone means adding new pieces of infrastructure for scheduling changes. At that point, you may as well use crontab. We don't want Review Board to do the pulls on demand, because you may end up with two requests happening at once, each causing a pull and generating

Re: LDAP configuration

2011-02-02 Thread Christian Hammond
I'd be happy for someone with more knowledge and expertise with LDAP to step up and help get our LDAP configuration settings under control, provide better names, maybe some docs. Anyone want to help with that? Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: Unable to login to RB Site as any user

2011-02-02 Thread Prashant
Sucess ... With that change I was able to login into the Site. The AD authentification which was working earlier had been turned off due to the above setting. I turned it on and AD authentification started working. The AD name server were all in DNS name and not any IP Addresses. The logging was

Re: Cannot add repository with cvs ext in 1.5.2 on RHEL5

2011-02-02 Thread Christian Hammond
I managed to get some fixes working for rbssh for CVS. I have a couple other related bugs to fix, but you should see 1.5.3 probably by the end of the week. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On

Re: LDAP configuration

2011-02-02 Thread Jan Koprowski
1) Please try use Your data exactly in some other tool. I prefere Apache Directory Studio (http://directory.apache.org/studio/). Just use this same informations to connect with Your LDAP server 2) Maybe LDAP base dn need more specific place to start searching. Try to be more specific e.g.

Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository

2011-02-02 Thread reviewboard
Comment #7 on issue 1969 by chip...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 It won't accept it? What does it say? The path in the diff isn't saying that /myproject/trunk is the root, but that it's *in*

Re: Issue 1968 in reviewboard: Trying to create a Bazaar repo returns: Unrecognised value for BZR_SSH environment variable: rbssh

2011-02-02 Thread reviewboard
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-High Milestone-Release1.5.x Component-SSH Comment #1 on issue 1968 by chip...@gmail.com: Trying to create a Bazaar repo returns: Unrecognised value for BZR_SSH environment variable: rbssh

Re: Issue 387 in reviewboard: Error Control Characters not allowed

2011-02-02 Thread reviewboard
Comment #5 on issue 387 by spede...@gmail.com: Error Control Characters not allowed http://code.google.com/p/reviewboard/issues/detail?id=387 Using 1.5 and I too had to change diffutils.py. After that I didn't get the error anymore. -- You received this message because you are subscribed

Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository

2011-02-02 Thread reviewboard
Comment #8 on issue 1969 by apsoftw...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 I am going to have to have some detailed conversations with the IT department. They did see some errors in the log last

Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository

2011-02-02 Thread reviewboard
Comment #9 on issue 1969 by apsoftw...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 Configuration issue on my end. The solution was to have an account used that had access to the root of the project. It

Re: Issue 1719 in reviewboard: post-review should support subversion changelists.

2011-02-02 Thread reviewboard
Comment #1 on issue 1719 by joedr...@gmail.com: post-review should support subversion changelists. http://code.google.com/p/reviewboard/issues/detail?id=1719 I made this change to help a friend out recently, which reuses the --label feature. This allows the normal usage of manually listing

Re: Issue 1969 in reviewboard: API Error 207 -- The file was not found in the repository

2011-02-02 Thread reviewboard
Comment #10 on issue 1969 by chip...@gmail.com: API Error 207 -- The file was not found in the repository http://code.google.com/p/reviewboard/issues/detail?id=1969 Glad it works :) We do need more inline help. I think the docs cover what's needed to a degree. Either way, we'd need a

Re: Issue 387 in reviewboard: Error Control Characters not allowed

2011-02-02 Thread reviewboard
Updates: Status: Started Comment #6 on issue 387 by chip...@gmail.com: Error Control Characters not allowed http://code.google.com/p/reviewboard/issues/detail?id=387 Can you please submit a patch to http://reviews.reviewboard.org/? -- You received this message because you are

Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files

2011-02-02 Thread reviewboard
Updates: Status: NeedInfo Comment #5 on issue 1670 by chip...@gmail.com: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 Are you sure it's UTF-8? We see people post actual UTF-8 all the time. -- You received this message

Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files

2011-02-02 Thread reviewboard
Comment #6 on issue 1670 by chip...@gmail.com: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 If someone can give us a change to our tree that reproduces this with post-review, that will greatly help. -- You received this

Issue 1970 in reviewboard: postreview mangles repository path when protocol is part of path

2011-02-02 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1970 by henry@gmail.com: postreview mangles repository path when protocol is part of path http://code.google.com/p/reviewboard/issues/detail?id=1970 What version are you running? RBTools 0.3 on ReviewBoard 1.5.1 What