Content-Disposition is "inline" instead of "attachment" in response to Download Diff

Hi, RB 1.7.21. I've noticed that the response to Download Diff includes a Content-Disposition: inline: GET /r/1234/diff/raw/ HTTP/1.1 Content-Type: text/x-patch ... Content-Disposition: *inline*; filename=some.patch Shouldn't that be: Content-Disposition: *attachment*; filename=some.patch

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

ipx86.com > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > > On Thu, May 22, 2014 at 6:25 PM, Brett Randall > > wrote: > >> Hi, >> >> RB 1.7.21. >> >> I've noticed that the response to Download

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

can get it in for > a 2.0.x. > > Christian > > -- > Christian Hammond - chi...@chipx86.com > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > > On Thu, May 22, 2014 at 6:50 PM, Brett Randall > > wrote: > >>