Extended "Ship it" feature, Defaults for "diff base path"

2009-01-26 Thread Sebastian Kurfuerst
Hello Reviewboard Developers! We at the TYPO3 Project are currently evaluating ReviewBoard for our patch workflow. As far as I see it, I am really impressed! There are just minor details which would be nice to have: - In our workflow, we require that there are at least 2 "+1"s (or "ship it"), w

Re: Extended "Ship it" feature, Defaults for "diff base path"

2009-01-26 Thread Sebastian Kurfuerst
Hey Christian, thanks for your super-fast response! > Right now, we don't have anything in the code to enforce policies such as > requiring two "ship its" before you can close out a review request. Since > Review Board doesn't actually commit reviews, we can't enforce anything like > that. Yep,

Re: Extended "Ship it" feature, Defaults for "diff base path"

2009-01-28 Thread Sebastian Kurfuerst
Hey, thanks for your answers! > As Paul Scott mentioned, you could write something to do some of this now, > but you'd have to write custom code to use the API. That sounds already almost like what I want. It's OK for the time being. Perfect :-) > Another feature planned after 1.0 is support fo