The default reviewer regexes are run when the diffs are uploaded, which
happens rarely and has only a small number of file names to check against.
In contrast, querying after the fact would involve millions of rows (and
indexes don't help very much for regex or LIKE queries).
-David
On Sun, Oct 4,
Alright. Thought it might be reasonable since there is already such search
for default reviewers (file regex
in
https://www.reviewboard.org/docs/manual/dev/admin/configuration/default-reviewers/
)
On Monday, October 5, 2015 at 12:31:38 AM UTC+3, David Trowbridge wrote:
>
> Querying diffs by
Querying diffs by regex isn't feasible (the diff table can have tens of
millions of rows). What you can do is assign review requests to a group by
regex with a default reviewer and then query review requests by target
group.
-David
On Sun, Oct 4, 2015 at 8:43 AM Yair Yogev wrote:
> You are corre
You are correct :)
Downloading all patches and filter by them is what i do today, but it's a
lot of patches to download in vain and a concept of projects/components as
a meta field for reviews could have helped in this usecase. I guess my
usecase isn't common enough for a change this big though
I'm guessing from your other email that you're at VMware. In that case, the
branch name is parsed out of the changeset description using some custom
code (which includes the "merge to" lines). Perforce generally does not
force a //depot/branch/project layout, so it's not something that we at
Review
I'm using the jenkins-reviewbot plugin to fetch reviews of a specific
project, apply the review diff, run tests and post the result in
reviewboard.
The problem is that we can only fetch reviews by perforce server
(repository) and branch, but the project name isn't stored in any review
field.
I
