Re: Feature Request: Include changed files with review

[Nathan Auch [Sybase]]

Our organization has a similar need. We handle it by running a locally 
modified version of post-review that includes a "--patch-client" option 
which downloads the diff from the server, grabs the base revisions of 
the files from SCM, opens the files for edit and applies the patch. It 
was actually pretty easy to get working. It only works for perforce and 
I don't really want to go through the work of submitting a patch against 
the trunk post-review but I'd be willing to post the relevant code here 
if it's useful to you.

Nathan Auch

Christian Hammond wrote:
> Hi Dana,
>
> I see two ways of doing this.
>
> 1) Make an actual view that returns a zip file (or something) that 
> contains all the files, basically using existing code that we have to 
> download each one, and assemble a zip file of those files. There's a 
> little bit of processing time, but it shouldn't be too bad, really.
>
> 2) Implement more general file attachment support.
>
> There's a long-standing feature request for attaching arbitrary files. 
> See http://code.google.com/p/reviewboard/issues/detail?id=239
>
> Uploading file attachments is something we want to have in, but just 
> haven't made a priority. If someone wants to work on this, though, 
> we'd be glad to discuss it and get a change in!
>
> It would work similarly to the screenshots. Attachments would have a 
> filename and a mimetype, and they'd be accessible through, say, 
> /r//attachments/.
>
> Maybe we really want both, long-term.
>
> What are your thoughts?
>
> Christian
>
>
> -- 
> Christian Hammond - chip...@chipx86.com 
> Review Board - http://www.review-board.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Sep 10, 2009 at 4:17 PM, Lacoste, Dana (TSG Software San 
> Diego) mailto:dana.laco...@hp.com>> wrote:
>
> So, before we used Review Board we used an internal (python based,
> similar to how p4review works) tool to do the following:
>
>  
>
> 1 - Make a copy of the files in a changelist to a share
>
> 2 - Make a copy of the "baseline" version files to the same share
>
> 3 - Make a "wrapper" file specifying what the files were
>
> 4 - Send an email pointing at the files saying "I've proposed this
> change, can you review it?" to users specified by the code changer.
>
> 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we
> had a python wrapper which would launch the tool for you)
>
>  
>
> With Review Board, 1-4 are working FAR better than we had before,
> and we also get :
>
> 6 - A website which records feedback on changes
>
>  
>
> BUT
>
>  
>
> We can't do #5.  With complicated changes and large number of
> files the Review Board page can be hard to navigate (not that I
> think there's anything Review Board can do about this: some
> changes are too complicated) and the diff might not show adequate
> info (now THIS is something I think we _/can/_ do something about.)
>
>  
>
> So I'd like to propose a feature Request: I'd like to be able to
> "attach" a .zip to a review request containing the entirety of the
> changed files.  This way I could click on "Download Diff" and get
> a .tar/.zip of the modified versions of the files which I could
> view in their entirety (instead of just the .diff files)
>
>  
>
> I realize this isn't trivial, but I thought I'd ask in case
> someone else thought it would be useful too J
>
>  
>
> Thanks,
>
>  
>
> Dana Lacoste
>
>
>
>
>
> >


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Feature Request: Include changed files with review

[Christian Hammond]

Hi Dana,

I see two ways of doing this.

1) Make an actual view that returns a zip file (or something) that contains
all the files, basically using existing code that we have to download each
one, and assemble a zip file of those files. There's a little bit of
processing time, but it shouldn't be too bad, really.

2) Implement more general file attachment support.

There's a long-standing feature request for attaching arbitrary files. See
http://code.google.com/p/reviewboard/issues/detail?id=239

Uploading file attachments is something we want to have in, but just haven't
made a priority. If someone wants to work on this, though, we'd be glad to
discuss it and get a change in!

It would work similarly to the screenshots. Attachments would have a
filename and a mimetype, and they'd be accessible through, say,
/r//attachments/.

Maybe we really want both, long-term.

What are your thoughts?

Christian


-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Sep 10, 2009 at 4:17 PM, Lacoste, Dana (TSG Software San Diego) <
dana.laco...@hp.com> wrote:

>  So, before we used Review Board we used an internal (python based,
> similar to how p4review works) tool to do the following:
>
>
>
> 1 - Make a copy of the files in a changelist to a share
>
> 2 - Make a copy of the "baseline" version files to the same share
>
> 3 - Make a "wrapper" file specifying what the files were
>
> 4 - Send an email pointing at the files saying "I've proposed this change,
> can you review it?" to users specified by the code changer.
>
> 5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a
> python wrapper which would launch the tool for you)
>
>
>
> With Review Board, 1-4 are working FAR better than we had before, and we
> also get :
>
> 6 - A website which records feedback on changes
>
>
>
> BUT
>
>
>
> We can't do #5.  With complicated changes and large number of files the
> Review Board page can be hard to navigate (not that I think there's anything
> Review Board can do about this: some changes are too complicated) and the
> diff might not show adequate info (now THIS is something I think we _*can*_
> do something about.)
>
>
>
> So I'd like to propose a feature Request: I'd like to be able to "attach" a
> .zip to a review request containing the entirety of the changed files.  This
> way I could click on "Download Diff" and get a .tar/.zip of the modified
> versions of the files which I could view in their entirety (instead of just
> the .diff files)
>
>
>
> I realize this isn't trivial, but I thought I'd ask in case someone else
> thought it would be useful too J
>
>
>
> Thanks,
>
>
>
> Dana Lacoste
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Feature Request: Include changed files with review

[Lacoste, Dana (TSG Software San Diego)]

So, before we used Review Board we used an internal (python based, similar to 
how p4review works) tool to do the following:

1 - Make a copy of the files in a changelist to a share
2 - Make a copy of the "baseline" version files to the same share
3 - Make a "wrapper" file specifying what the files were
4 - Send an email pointing at the files saying "I've proposed this change, can 
you review it?" to users specified by the code changer.
5 - Run Beyond Compare/Araxis Merge/etc. against the results (we had a python 
wrapper which would launch the tool for you)

With Review Board, 1-4 are working FAR better than we had before, and we also 
get :
6 - A website which records feedback on changes

BUT

We can't do #5.  With complicated changes and large number of files the Review 
Board page can be hard to navigate (not that I think there's anything Review 
Board can do about this: some changes are too complicated) and the diff might 
not show adequate info (now THIS is something I think we _can_ do something 
about.)

So I'd like to propose a feature Request: I'd like to be able to "attach" a 
.zip to a review request containing the entirety of the changed files.  This 
way I could click on "Download Diff" and get a .tar/.zip of the modified 
versions of the files which I could view in their entirety (instead of just the 
.diff files)

I realize this isn't trivial, but I thought I'd ask in case someone else 
thought it would be useful too :)

Thanks,

Dana Lacoste

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---