Re: How to post-commit review a first time checkin?

2009-11-05 Thread Chris Clark
Christian Hammond wrote: > Actually, I wouldn't mind such a parameter. (though, --diff-filename, > as we don't use underscores in parameter names). There's actually a > patch up for review for accepting via stdin (though it's a bit stale > and isn't the design we want), so I guess there are mor

Re: How to post-commit review a first time checkin?

2009-11-05 Thread Christian Hammond
Actually, I wouldn't mind such a parameter. (though, --diff-filename, as we don't use underscores in parameter names). There's actually a patch up for review for accepting via stdin (though it's a bit stale and isn't the design we want), so I guess there are more people who want this. If you'd lik

Re: How to post-commit review a first time checkin?

2009-11-05 Thread Chris Clark
Background: We have some VMS users using postreview, observant readers may recall that process spawning under VMS is a nightmare to the point that neither CPython or the JVM have a nice portable way of doing this. This causes postreview no end of trouble under VMS whether one

Re: How to post-commit review a first time checkin?

2009-11-03 Thread Pv
Yes, I want to do a post-commit review of the new files added/created in an SVN revision without making any actual changes to the already checked in files. The diff is indeed empty (I already knew this, just thought it was obvious and didn't share). Basically, two possibilities: 1) How to get "s

Re: How to post-commit review a first time checkin?

2009-11-02 Thread Christian Hammond
It sounds like the generated diff is empty. If you add --output-diff to those parameters, you should be able to see for sure. if you don't specify a to:from, it will do, in your case, 24506:HEAD. If that's what you're wanting, then we should find out why exactly this is failing, but if that's not

How to post-commit review a first time checkin?

2009-10-29 Thread Pv
I am using the following command to do a post-commit review on a first time checkin: post-review -d --revision-range=24506 Obviously, I am not specifying a from:to range, but since this is a first time checking any earlier "from" svn rev # wouldn't exist in the newly created path. The [debug] ou