Re: How to properly close out review requests?

2010-03-02 Thread skip
Christian> You should almost never use Delete Permanently. We use it in Christian> the case of spam, but even a history of abandoned code Christian> reviews can be useful. Yeah, I sort of figured that. Christian> The proper way is to use Submitted. Where are you seeing Christ

Re: How to properly close out review requests?

2010-03-02 Thread Christian Hammond
You should almost never use Delete Permanently. We use it in the case of spam, but even a history of abandoned code reviews can be useful. The proper way is to use Submitted. Where are you seeing existing entries with "[Submitted]"? You shouldn't in the dashboard (unless it's the "My Requests," wh

How to properly close out review requests?

2010-03-02 Thread skip
So I submit a review, folks review it, then I check in the code. What's the proper protocol to dispose of the review request at that point? I see Close>Submitted Close>Discarded Close>Delete Permanently I'd like not to use the last one except for abandoned review requests. I tried