Re: Django auth backend vs. ReviewBoard custom auth

[Stephen Gallagher]

Sorry, I finally tracked down the issue. There was a bug in our auth
backend that was throwing an exception, but inside the djblets code, it
was silently catching and ignoring all exceptions from custom auth
backends. I temporarily removed that catch and I was able to track down
the cause of the original exception. We're working smoothly now.

Thank you for your help!


On 02/25/2010 12:25 AM, Christian Hammond wrote:
> I meant that it may need to be inserted into the list in some index,
> instead of just appending or prepending. It shouldn't be ignored, though.
>
> Christian
>
> -- 
> Christian Hammond - chip...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Feb 11, 2010 at 4:27 AM, Stephen Gallagher
> mailto:step...@gallagherhome.com>> wrote:
>
> On 02/10/2010 07:52 PM, Christian Hammond wrote:
> > You should be able to append to your middleware declaration in
> > conf/settings_local.py. If it must be in a specific location in the
> > list, though, you might have to do a little extra.
> >
> > Christian
> >
>
> What "little extra" do you mean? I tried adding it to the settings.py,
> but it appears to be ignored.
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Christian Hammond]

I meant that it may need to be inserted into the list in some index, instead
of just appending or prepending. It shouldn't be ignored, though.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Feb 11, 2010 at 4:27 AM, Stephen Gallagher <
step...@gallagherhome.com> wrote:

> On 02/10/2010 07:52 PM, Christian Hammond wrote:
> > You should be able to append to your middleware declaration in
> > conf/settings_local.py. If it must be in a specific location in the
> > list, though, you might have to do a little extra.
> >
> > Christian
> >
>
> What "little extra" do you mean? I tried adding it to the settings.py,
> but it appears to be ignored.
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Stephen Gallagher]

On 02/10/2010 07:52 PM, Christian Hammond wrote:
> You should be able to append to your middleware declaration in
> conf/settings_local.py. If it must be in a specific location in the
> list, though, you might have to do a little extra.
>
> Christian
>   

What "little extra" do you mean? I tried adding it to the settings.py,
but it appears to be ignored.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Christian Hammond]

You should be able to append to your middleware declaration in
conf/settings_local.py. If it must be in a specific location in the
list, though, you might have to do a little extra.

Christian


On Wednesday, February 10, 2010, Stephen Gallagher
 wrote:
> On 02/08/2010 07:38 AM, Stephen Gallagher wrote:
>>
>> On Feb 5, 6:16 pm, Christian Hammond  wrote:
>>
>>> That sounds quite ungood. Maybe try temporarily modifying your FasBackend to
>>> return None in get_or_create_user and in get_user. This *should* default it
>>> back to the built-in auth, I believe. I haven't tried it, though.
>>>
>>> How is your get_or_create_user and get_user handling not finding users in
>>> its backend? Maybe it's not allowing the default handler to be used. Is the
>>> code available to look at somewhere?
>>>
>>>
>>
>> The source code is available at
>> https://fedorahosted.org/releases/p/y/python-fedora/python-fedora-0.3.14.tar.gz
>>
>> A guide to integrating it with Django projects is here:
>> https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html
>>
>> I'm going to try out a couple of your suggestions above this morning
>> as
>> well.
>>
>>
>
> I think the real problem here is that the FAS integration requires a
> middleware plugin that handles session management that isn't being
> passed into the custom auth mechanism that ReviewBoard supports. I'm
> just not sure how to correct this.
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Stephen Gallagher]

On 02/08/2010 07:38 AM, Stephen Gallagher wrote:
>
> On Feb 5, 6:16 pm, Christian Hammond  wrote:
>   
>> That sounds quite ungood. Maybe try temporarily modifying your FasBackend to
>> return None in get_or_create_user and in get_user. This *should* default it
>> back to the built-in auth, I believe. I haven't tried it, though.
>>
>> How is your get_or_create_user and get_user handling not finding users in
>> its backend? Maybe it's not allowing the default handler to be used. Is the
>> code available to look at somewhere?
>>
>> 
>
> The source code is available at
> https://fedorahosted.org/releases/p/y/python-fedora/python-fedora-0.3.14.tar.gz
>
> A guide to integrating it with Django projects is here:
> https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html
>
> I'm going to try out a couple of your suggestions above this morning
> as
> well.
>
>   

I think the real problem here is that the FAS integration requires a
middleware plugin that handles session management that isn't being
passed into the custom auth mechanism that ReviewBoard supports. I'm
just not sure how to correct this.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Stephen Gallagher]

On Feb 5, 6:16 pm, Christian Hammond  wrote:
> That sounds quite ungood. Maybe try temporarily modifying your FasBackend to
> return None in get_or_create_user and in get_user. This *should* default it
> back to the built-in auth, I believe. I haven't tried it, though.
>
> How is your get_or_create_user and get_user handling not finding users in
> its backend? Maybe it's not allowing the default handler to be used. Is the
> code available to look at somewhere?
>


The source code is available at
https://fedorahosted.org/releases/p/y/python-fedora/python-fedora-0.3.14.tar.gz

A guide to integrating it with Django projects is here:
https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html

I'm going to try out a couple of your suggestions above this morning
as
well.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Christian Hammond]

That sounds quite ungood. Maybe try temporarily modifying your FasBackend to
return None in get_or_create_user and in get_user. This *should* default it
back to the built-in auth, I believe. I haven't tried it, though.

How is your get_or_create_user and get_user handling not finding users in
its backend? Maybe it's not allowing the default handler to be used. Is the
code available to look at somewhere?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Feb 4, 2010 at 5:13 AM, Stephen Gallagher wrote:

> I have specified 'fedora.django.auth.backends.FasBackend' in the
> custom auth field. Once I hit "Save", I can no longer log in as ANY
> user, neither from the FasBackend nor the built-in admin account.
>
> I see no errors in the Apache error_log. Any advice on how to track
> the problem? Running in 'manage.py runserver' gives no error messages
> either.
>
> On Feb 3, 4:07 pm, Christian Hammond  wrote:
> > Hi Stephen,
> >
> > Review Board can use custom Django auth backends by specifying the full
> > module path in the Custom Authentication section in General Settings in
> the
> > administration UI. Review Board will use that auth backend as the primary
> > and fall back on the built-in authentication for existing accounts (so
> that
> > your administration account will still work if your auth backend is
> broken).
> > You shouldn't need to modify any code to make this work.
> >
> > Seehttp://
> www.reviewboard.org/docs/manual/dev/admin/admin-ui/authenticat...
> >
> > Note that in 1.0.x, these are in General Settings, but in the upcoming
> 1.5
> > release, they're in their own settings page.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher  >wrote:
> >
> > > I'm trying to adapt a Django authentication backend to work with
> > > ReviewBoard (specifically
> > >https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html)
> >
> > > Is there a guide anywhere on how to convert a Django auth backend to a
> > > ReviewBoard backend? Or a guide on how to properly use a Django auth
> > > backend with ReviewBoard?
> >
> > > --
> > > Want to help the Review Board project? Donate today at
> > >http://www.reviewboard.org/donate/
> > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > -~--~~~~--~~--~--~---
> > > To unsubscribe from this group, send email to
> > > reviewboard+unsubscr...@googlegroups.com
> 
> >
> > > For more options, visit this group at
> > >http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Stephen Gallagher]

I have specified 'fedora.django.auth.backends.FasBackend' in the
custom auth field. Once I hit "Save", I can no longer log in as ANY
user, neither from the FasBackend nor the built-in admin account.

I see no errors in the Apache error_log. Any advice on how to track
the problem? Running in 'manage.py runserver' gives no error messages
either.

On Feb 3, 4:07 pm, Christian Hammond  wrote:
> Hi Stephen,
>
> Review Board can use custom Django auth backends by specifying the full
> module path in the Custom Authentication section in General Settings in the
> administration UI. Review Board will use that auth backend as the primary
> and fall back on the built-in authentication for existing accounts (so that
> your administration account will still work if your auth backend is broken).
> You shouldn't need to modify any code to make this work.
>
> Seehttp://www.reviewboard.org/docs/manual/dev/admin/admin-ui/authenticat...
>
> Note that in 1.0.x, these are in General Settings, but in the upcoming 1.5
> release, they're in their own settings page.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher wrote:
>
> > I'm trying to adapt a Django authentication backend to work with
> > ReviewBoard (specifically
> >https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html)
>
> > Is there a guide anywhere on how to convert a Django auth backend to a
> > ReviewBoard backend? Or a guide on how to properly use a Django auth
> > backend with ReviewBoard?
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Django auth backend vs. ReviewBoard custom auth

[Christian Hammond]

Hi Stephen,

Review Board can use custom Django auth backends by specifying the full
module path in the Custom Authentication section in General Settings in the
administration UI. Review Board will use that auth backend as the primary
and fall back on the built-in authentication for existing accounts (so that
your administration account will still work if your auth backend is broken).
You shouldn't need to modify any code to make this work.

See
http://www.reviewboard.org/docs/manual/dev/admin/admin-ui/authentication-settings/#custom-authentication-settings

Note that in 1.0.x, these are in General Settings, but in the upcoming 1.5
release, they're in their own settings page.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher wrote:

> I'm trying to adapt a Django authentication backend to work with
> ReviewBoard (specifically
> https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html)
>
> Is there a guide anywhere on how to convert a Django auth backend to a
> ReviewBoard backend? Or a guide on how to properly use a Django auth
> backend with ReviewBoard?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en