ard@googlegroups.com [mailto:reviewboard@googlegroups.com] On
>>
>> Behalf Of Christian Hammond
>> Sent: Tuesday, May 24, 2011 11:11 AM
>> To: reviewboard@googlegroups.com
>> Subject: Re: How to handle binary files in a review?
>>
>> I recognize that error, but
rd@googlegroups.com] On
>
> Behalf Of Christian Hammond
> Sent: Tuesday, May 24, 2011 11:11 AM
> To: reviewboard@googlegroups.com
> Subject: Re: How to handle binary files in a review?
>
> I recognize that error, but thought we had fixed that before. What
> version of R
[mailto:reviewboard@googlegroups.com] On
Behalf Of Christian Hammond
Sent: Tuesday, May 24, 2011 11:11 AM
To: reviewboard@googlegroups.com
Subject: Re: How to handle binary files in a review?
I recognize that error, but thought we had fixed that before. What
version of RBTools are you running
I recognize that error, but thought we had fixed that before. What
version of RBTools are you running?
Christian
On Monday, May 23, 2011, mohak patel wrote:
> Hi Christian,
>
> We have been using Perfoce as the source control tool; review board
> for the code review but review board throws erro
Hi Christian,
We have been using Perfoce as the source control tool; review board
for the code review but review board throws error when developers post
the binary files.
We got this kind of error:
This tool looks at the given Pending-CL# & posts it for review.
[ Version: 20100217_1023/0.8]
Argu
You shouldn't be getting an error. If the SCM is configured correctly, with
the file type being set to binary, then the diff should just basically say
"This is a binary file." The problem of course is that you can't actually
review that file, but we're adding support for actual reviewable file
atta
