Re: Review Board 2.0.16 is released, with security fixes and more
Hi Christian, It wasn't a browser cache issue as the incorrect results were visible after switch between multiple browsers (using independent browser caches), therefore the problem must have been on the server. I tried to reproduce this again today, but wasn't able to - you could take that as good news ;) When I previously saw the bug, the review was created with 2.0.15 and then continued to have more diff sets added after the server had been upgraded to 2.0.17. I don't know whether that aspect is relevant. Anyway, I'll keep an eye on this and if I can reproduce it reliably I'll let you know. In the mean time, ignore this bug report. Thanks, Paul On Saturday, June 20, 2015 at 3:16:14 AM UTC+1, Christian Hammond wrote: > > Hi Paul, > > Thanks for reporting this. I went through our caching code, and I'm not > really sure why this is happening off-hand. Were you able to fix this by > clearing your browser cache, or did you have to restart memcached? > > Christian > > -- > Christian Hammond - chri...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -Original Message- > From: Paul Fee > > Reply: revie...@googlegroups.com >> > Date: June 18, 2015 at 9:45:59 AM > To: revie...@googlegroups.com >> > Subject: Re: Review Board 2.0.16 is released, with security fixes and > more > > > Hi Christian, > > > > I'm seeing some buggy behaviour around the caching of diffs. It looks > like > > a server side problem as the buggy diff content persists even if I > reload > > with CTRL-F5 or switch browsers (e.g. firefox to chromium). > > > > Steps to reproduce: > > > > 1. Change some code, I happen to be using SVN. > > 2. Upload diff to existing review. > > $ rbt post -r XXX svn_changelist > > 3. View the draft interdiff, all it ok at this point. > > 4. Change the code some more without publishing draft changes. > > 5. Upload diff again, should change content of draft diff. > > $ rbt post -r XXX svn_changelist > > 6. View the draft interdiff - BUG - diff content on web page is from > first > > upload, changes from second "rbt post" are not displayed. > > > > From the 2.0.16 release notes, "If a diff has already been viewed once, > by > > anyone, it will be quicker to retrieve and display.". I suspect the > draft > > is being cached. A blunt fix could be to avoid caching diffs for drafts. > > A better fix would be to invalidate caches for draft diffs when a new > > diffset is uploaded. > > > > Hopefully those steps are clear enough for you to reproduce the issue. > Let > > me know if you need more information. > > > > Thanks, > > Paul > > > > -- > > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > > Happy user? Let us know! https://www.reviewboard.org/users/ > > --- > > You received this message because you are subscribed to the Google > Groups "reviewboard" > > group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard...@googlegroups.com . > > For more options, visit https://groups.google.com/d/optout. > > > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Hi Paul, Thanks for reporting this. I went through our caching code, and I'm not really sure why this is happening off-hand. Were you able to fix this by clearing your browser cache, or did you have to restart memcached? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Paul Fee Reply: reviewboard@googlegroups.com > Date: June 18, 2015 at 9:45:59 AM To: reviewboard@googlegroups.com > Subject: Re: Review Board 2.0.16 is released, with security fixes and more > Hi Christian, > > I'm seeing some buggy behaviour around the caching of diffs. It looks like > a server side problem as the buggy diff content persists even if I reload > with CTRL-F5 or switch browsers (e.g. firefox to chromium). > > Steps to reproduce: > > 1. Change some code, I happen to be using SVN. > 2. Upload diff to existing review. > $ rbt post -r XXX svn_changelist > 3. View the draft interdiff, all it ok at this point. > 4. Change the code some more without publishing draft changes. > 5. Upload diff again, should change content of draft diff. > $ rbt post -r XXX svn_changelist > 6. View the draft interdiff - BUG - diff content on web page is from first > upload, changes from second "rbt post" are not displayed. > > From the 2.0.16 release notes, "If a diff has already been viewed once, by > anyone, it will be quicker to retrieve and display.". I suspect the draft > is being cached. A blunt fix could be to avoid caching diffs for drafts. > A better fix would be to invalidate caches for draft diffs when a new > diffset is uploaded. > > Hopefully those steps are clear enough for you to reproduce the issue. Let > me know if you need more information. > > Thanks, > Paul > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" > group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Hi Christian, I'm seeing some buggy behaviour around the caching of diffs. It looks like a server side problem as the buggy diff content persists even if I reload with CTRL-F5 or switch browsers (e.g. firefox to chromium). Steps to reproduce: 1. Change some code, I happen to be using SVN. 2. Upload diff to existing review. $ rbt post -r XXX svn_changelist 3. View the draft interdiff, all it ok at this point. 4. Change the code some more without publishing draft changes. 5. Upload diff again, should change content of draft diff. $ rbt post -r XXX svn_changelist 6. View the draft interdiff - BUG - diff content on web page is from first upload, changes from second "rbt post" are not displayed. >From the 2.0.16 release notes, "If a diff has already been viewed once, by anyone, it will be quicker to retrieve and display.". I suspect the draft is being cached. A blunt fix could be to avoid caching diffs for drafts. A better fix would be to invalidate caches for draft diffs when a new diffset is uploaded. Hopefully those steps are clear enough for you to reproduce the issue. Let me know if you need more information. Thanks, Paul -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Hi Stephen, The 2.0.17 packages for EPEL7 worked as expected, karma dispensed. Thanks to all those that contributed to 2.0.16 and 2.0.17, I especially liked the fixes to the interdiff version selector as that was bugging me. The performance improvements are also nice to see. Cheers, Paul -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Thanks for the On Tue, Jun 16, 2015 at 7:03 AM Paul Fee wrote: > Hi Stephen, > > EPEL7 upgrade didn't work for me. Negative karma and details of haystack > dependency issue here. > > https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6685/ReviewBoard-2.0.16-1.el7,python-djblets-0.8.19-1.el7,python-django-evolution-0.7.5-1.el7 > > Forgive the formatting, I see bodhi doesn't preserve line endings within > the comment box. > > Thanks for the report; I missed the jump to Haystack 2.3.1. I'll get that build, update Review Board to require it and get an update out today with 2.0.17 as well. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
Hi Stephen, EPEL7 upgrade didn't work for me. Negative karma and details of haystack dependency issue here. https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6685/ReviewBoard-2.0.16-1.el7,python-djblets-0.8.19-1.el7,python-django-evolution-0.7.5-1.el7 Forgive the formatting, I see bodhi doesn't preserve line endings within the comment box. HTH, Paul On Friday, June 12, 2015 at 5:55:48 PM UTC+1, Stephen Gallagher wrote: > > > > On Fri, Jun 12, 2015 at 12:47 AM Christian Hammond > wrote: > >> Hey everyone, >> >> We just put out a release of Review Board 2.0.16. This release contains >> security fixes, so we recommend that you update! >> >> There are also some significant performance improvements across the >> entire site, especially for diff loading, along with a great many bug fixes. >> >> This is all detailed in the news post: >> https://www.reviewboard.org/news/2015/06/11/review-board-2-0-16-out-safer-faster-and-more-stable/ >> >> > Packages for Fedora 21 and RHEL/CentOS 7 are now available at > https://admin.fedoraproject.org/updates/search/ReviewBoard > > Packages for Fedora 22 and 23 (Rawhide) are available in my COPR > repository: > https://copr.fedoraproject.org/coprs/sgallagh/f22-reviewboard/ > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board 2.0.16 is released, with security fixes and more
On Fri, Jun 12, 2015 at 12:47 AM Christian Hammond wrote: > Hey everyone, > > We just put out a release of Review Board 2.0.16. This release contains > security fixes, so we recommend that you update! > > There are also some significant performance improvements across the entire > site, especially for diff loading, along with a great many bug fixes. > > This is all detailed in the news post: > https://www.reviewboard.org/news/2015/06/11/review-board-2-0-16-out-safer-faster-and-more-stable/ > > Packages for Fedora 21 and RHEL/CentOS 7 are now available at https://admin.fedoraproject.org/updates/search/ReviewBoard Packages for Fedora 22 and 23 (Rawhide) are available in my COPR repository: https://copr.fedoraproject.org/coprs/sgallagh/f22-reviewboard/ -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
