Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-18 Thread Neil Bird 


On Wednesday, 17 October 2012 21:31:37 UTC+1, Christian Hammond wrote:
>
> Yes, each ReviewBoard hardcodes a required version of Djblets. See 
> setup.py for the dependency list.
> The latest 1.6.x release introduced support for SVN properties, so I 
> suspect you'll have more luck when that release is installed.
>

OK, thanks.  I'll give them another try when I get a chance.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-17 Thread Christian Hammond 
Yes, each ReviewBoard hardcodes a required version of Djblets. See setup.py for 
the dependency list.

The latest 1.6.x release introduced support for SVN properties, so I suspect 
you'll have more luck when that release is installed.

Christian


On Oct 17, 2012, at 8:21, Neil Bird  wrote:

> 
> 
> On Tuesday, 16 October 2012 21:13:48 UTC+1, Christian Hammond  wrote:
>> 
>> That's the wrong humanize.
>> Your Djblets wasn't updated along with Review Board, which is the problem. 
>> You need to update that package too.
> 
> Not sure I follow;  is that ReviewBoard release tied to a specific version of 
> this Djblets then?  I have Djblets 0.6.22.
> 
> 
>> Can you run that post-review command but with --output-diff and show the 
>> headers of that file where it lists the filenames?
>> I imagine post-review in this case is choosing the wrong base path.
> 
> Not sure if this is what you were planning on looking for, but I've 
> discovered the basic cause of the issue, if not the  problem.  It's that 
> post-review issues svn diff --diff-cmd=diff.
> 
> This causes a change in the output (possibly a diff/patch corruption) for (at 
> least) new files with svn properties set.  If I run post-review with the 
> given diff as created by the post-review command, it fails.  If I do the 
> same, but create the diff without the --diff-cmd it works.
> 
> Example snippet of failing output (the diff that post-review would create):
> 
> +#endif /* TREE_CELLEDIT_H */
> +
> Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ===
> --- trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12566)
> +++ trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12567)
> 
> Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ___
> Added: svn:eol-style
> ## -0,0 +1 ##
> +LF
> \ No newline at end of property
> 
> Example snippet of working output:
> 
> +#endif /* TREE_CELLEDIT_H */
> +
> 
> Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ___
> Added: svn:eol-style
> ## -0,0 +1 ##
> +LF
> \ No newline at end of property
> 
> But I can't comment of the rightness or wrongness of either input or 
> processing.
> 
> I'll have to see if I can nobble my post-review to not issue that option, or 
> wrap it such that I do the diff manually & pass it in as a file.
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-17 Thread Neil Bird 


On Tuesday, 16 October 2012 21:13:48 UTC+1, Christian Hammond wrote:
>
> That's the wrong humanize.
> Your Djblets wasn't updated along with Review Board, which is the problem. 
> You need to update that package too.
>

Not sure I follow;  is that ReviewBoard release tied to a specific version 
of this Djblets then?  I have Djblets 0.6.22.


Can you run that post-review command but with --output-diff and show the 
> headers of that file where it lists the filenames?
> I imagine post-review in this case is choosing the wrong base path.
>

Not sure if this is what you were planning on looking for, but I've 
discovered the basic cause of the issue, if not the  problem.  It's that 
post-review issues svn diff --diff-cmd=diff.

This causes a change in the output (possibly a diff/patch corruption) for 
(at least) new files with svn properties set.  If I run post-review with 
the given diff as created by the post-review command, it fails.  If I do 
the same, but create the diff without the --diff-cmd it works.

Example snippet of failing output (the diff that post-review would create):

+#endif /* TREE_CELLEDIT_H */
+
Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h
===
--- trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12566)
+++ trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12567)

Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
___
Added: svn:eol-style
## -0,0 +1 ##
+LF
\ No newline at end of property

Example snippet of working output:

+#endif /* TREE_CELLEDIT_H */
+

Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h
___
Added: svn:eol-style
## -0,0 +1 ##
+LF
\ No newline at end of property

But I can't comment of the rightness or wrongness of either input or 
processing.

I'll have to see if I can nobble my post-review to not issue that option, 
or wrap it such that I do the diff manually & pass it in as a file.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-16 Thread Christian Hammond 
That's the wrong humanize.

Your Djblets wasn't updated along with Review Board, which is the problem.
You need to update that package too.

Can you run that post-review command but with --output-diff and show the
headers of that file where it lists the filenames?

I imagine post-review in this case is choosing the wrong base path.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Oct 16, 2012 at 8:22 AM, Neil Bird  wrote:

> On Tuesday, 16 October 2012 10:33:21 UTC+1, Christian Hammond wrote:
>>
>> How did you generate/upload the diff? It looks like the base path was set
>> incorrectly. If you use post-review, this should be taken care of for you.
>>
>
> Yes, I ran post-review.  The latest version of that is now printing the
> svn diff command in its debug (still fails):
>
> DEBUG:root:Running: svn diff --diff-cmd=diff
> http://localhost/repos/Framework/@12566
> http://localhost/repos/Framework/@12567
>
> .. which seems sane to me.
>
>
>
>> Also, how did you install Review Board? The humanize error indicates your
>> Djblets wasn't updated properly (which should happen automatically).
>>
>
> I downloaded the SRPM for the currently available version  (1.6.11), then
> changed it to use 1.6.13 (and used the tarball for that).  Apart from not
> having to apply one patch that has presumably gone in since, it went
> seemingly smoothly.  But I got Internal Server Error out of Apache after
> restarting, with the following logged:
>
>  mod_wsgi (pid=9820): Exception occurred processing WSGI script
> '/local/reviews-test/htdocs/reviewboard.wsgi'.
>  Traceback (most recent call last):
>File "/usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py",
> line 250, in __call__
>  self.load_middleware()
>File "/usr/lib/python2.6/site-packages/django/core/handlers/base.py",
> line 47, in load_middleware
>  raise exceptions.ImproperlyConfigured('Error importing middleware %s:
> "%s"' % (mw_module, e))
>  ImproperlyConfigured: Error importing middleware
> reviewboard.admin.middleware: "No module named humanize"
>  File does not exist: /var/www/html/errordocs
>  mod_wsgi (pid=9825): Exception occurred processing WSGI script
> '/local/reviews-test/htdocs/reviewboard.wsgi'.
>  Traceback (most recent call last):
>File "/usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py",
> line 250, in __call__
>  self.load_middleware()
>File "/usr/lib/python2.6/site-packages/django/core/handlers/base.py",
> line 47, in load_middleware
>  raise exceptions.ImproperlyConfigured('Error importing middleware %s:
> "%s"' % (mw_module, e))
>  ImproperlyConfigured: Error importing middleware
> reviewboard.admin.middleware: "No module named humanize"
>
> I didn't have a clue what to do with that, so I reverted.  I do have stuff
> (from Django) in:
>
> /usr/lib/python2.6/site-packages/django/contrib/humanize/
>
> .. but that doesn't look like it would be automatically found.
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-16 Thread Neil Bird 
On Tuesday, 16 October 2012 10:33:21 UTC+1, Christian Hammond wrote:
>
> How did you generate/upload the diff? It looks like the base path was set 
> incorrectly. If you use post-review, this should be taken care of for you.
>

Yes, I ran post-review.  The latest version of that is now printing the svn 
diff command in its debug (still fails):

DEBUG:root:Running: svn diff --diff-cmd=diff 
http://localhost/repos/Framework/@12566 
http://localhost/repos/Framework/@12567

.. which seems sane to me.

 

> Also, how did you install Review Board? The humanize error indicates your 
> Djblets wasn't updated properly (which should happen automatically).
>

I downloaded the SRPM for the currently available version  (1.6.11), then 
changed it to use 1.6.13 (and used the tarball for that).  Apart from not 
having to apply one patch that has presumably gone in since, it went 
seemingly smoothly.  But I got Internal Server Error out of Apache after 
restarting, with the following logged:

 mod_wsgi (pid=9820): Exception occurred processing WSGI script 
'/local/reviews-test/htdocs/reviewboard.wsgi'.
 Traceback (most recent call last):
   File "/usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py", 
line 250, in __call__
 self.load_middleware()
   File "/usr/lib/python2.6/site-packages/django/core/handlers/base.py", 
line 47, in load_middleware
 raise exceptions.ImproperlyConfigured('Error importing middleware %s: 
"%s"' % (mw_module, e))
 ImproperlyConfigured: Error importing middleware 
reviewboard.admin.middleware: "No module named humanize"
 File does not exist: /var/www/html/errordocs
 mod_wsgi (pid=9825): Exception occurred processing WSGI script 
'/local/reviews-test/htdocs/reviewboard.wsgi'.
 Traceback (most recent call last):
   File "/usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py", 
line 250, in __call__
 self.load_middleware()
   File "/usr/lib/python2.6/site-packages/django/core/handlers/base.py", 
line 47, in load_middleware
 raise exceptions.ImproperlyConfigured('Error importing middleware %s: 
"%s"' % (mw_module, e))
 ImproperlyConfigured: Error importing middleware 
reviewboard.admin.middleware: "No module named humanize"

I didn't have a clue what to do with that, so I reverted.  I do have stuff 
(from Django) in:

/usr/lib/python2.6/site-packages/django/contrib/humanize/

.. but that doesn't look like it would be automatically found.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: ReviewBoard not accepting Subversion diffs containing new files

2012-10-16 Thread Christian Hammond 
How did you generate/upload the diff? It looks like the base path was set
incorrectly. If you use post-review, this should be taken care of for you.

Also, how did you install Review Board? The humanize error indicates your
Djblets wasn't updated properly (which should happen automatically).

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Oct 16, 2012 at 1:08 AM, Neil Bird  wrote:

> I'm trying to set up ReviewBoard (1.6.11, on Scientific Linux 6), and am
> trying to post a diff to a review from Subversion (RBTools 0.4.2), where
> the diff contains a new file being added.
>
> It's failing with an error which implies RB is trying to fetch an old
> (non-existent) version of the file to diff:
>
> >>> Got API Error 207 (HTTP code 400): The file was not found in the
> repository
> >>> Error data: {u'stat': u'fail', u'file':
> u'//trunk/Source/Framework/Gui/Tree/TreeEdit.h', u'err': {u'msg': u'The
> file was not found in the repository', u'code': 207}, u'revision':
> u'12566'}
>
>
> The diff contains the following snippet:
>
> Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h
> ===
> --- trunk/Source/Framework/Gui/Tree/TreeEdit.h  (revision 0)
> +++ trunk/Source/Framework/Gui/Tree/TreeEdit.h  (revision 12567)
> @@ -0,0 +1,108 @@
> +#ifndef TREE_CELLEDIT_H
> +#define TREE_CELLEDIT_H
> ...
>
> Is this a config. issue or a bug?
>
> FWIW, I tried the latest 1.6.13, but that wouldn't run due to some odd
> Django error about not being able to find humanize or something.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

ReviewBoard not accepting Subversion diffs containing new files

2012-10-16 Thread Neil Bird 
I'm trying to set up ReviewBoard (1.6.11, on Scientific Linux 6), and am 
trying to post a diff to a review from Subversion (RBTools 0.4.2), where 
the diff contains a new file being added.

It's failing with an error which implies RB is trying to fetch an old 
(non-existent) version of the file to diff:

>>> Got API Error 207 (HTTP code 400): The file was not found in the 
repository 
>>> Error data: {u'stat': u'fail', u'file': 
u'//trunk/Source/Framework/Gui/Tree/TreeEdit.h', u'err': {u'msg': u'The 
file was not found in the repository', u'code': 207}, u'revision': 
u'12566'} 


The diff contains the following snippet:

Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h 
=== 
--- trunk/Source/Framework/Gui/Tree/TreeEdit.h  (revision 0) 
+++ trunk/Source/Framework/Gui/Tree/TreeEdit.h  (revision 12567) 
@@ -0,0 +1,108 @@ 
+#ifndef TREE_CELLEDIT_H 
+#define TREE_CELLEDIT_H 
...

Is this a config. issue or a bug?

FWIW, I tried the latest 1.6.13, but that wouldn't run due to some odd 
Django error about not being able to find humanize or something.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en