Re: Trouble posting reviews since 1.0.1 upgrade

2009-08-13 Thread Thilo-Alexander Ginkel
On Wed, Aug 12, 2009 at 23:53, Christian Hammondchip...@chipx86.com wrote: It sounds like it's actually using the ClearCase SCM instead of your own. Are you sure your repository entry is still mapping to your custom SCM? In 1.0, we accidentally left out the database entry for the ClearCase

Trouble posting reviews since 1.0.1 upgrade

2009-08-12 Thread Thilo-Alexander Ginkel
Hello everybody, since upgrading from 1.0rc2 to 1.0.1 I have trouble posting reviews to RB using a custom post-review implementation. The problem is that the JSON response does not contain too many error details, just: {fields: {path: [substring not found]}, stat: fail, err: {msg: One or more

Re: Trouble posting reviews since 1.0.1 upgrade

2009-08-12 Thread Thilo-Alexander Ginkel
Hello Christian, On Wednesday 12 August 2009 22:25:03 Christian Hammond wrote: There's another thread on this problem as well. Are you using ClearCase? no, this happens with a proprietary SCM, for which I added support to RB and post-review. So, I cannot rule out that my scm implementation is

Re: Trouble posting reviews since 1.0.1 upgrade

2009-08-12 Thread Christian Hammond
Given that this error has been seen on both yours and ClearCase, it's possible it's somewhere internal to Review Board. Try this... Edit reviewboard/webapi/json.py, scroll down to the new_diff function, and locate the except Exception, e: line. Remove that whole block for that exception

Re: Trouble posting reviews since 1.0.1 upgrade

2009-08-12 Thread Christian Hammond
It sounds like it's actually using the ClearCase SCM instead of your own. Are you sure your repository entry is still mapping to your custom SCM? In 1.0, we accidentally left out the database entry for the ClearCase SCM, and added it back. When you did the rb-site upgrade, it probably replaced