Re: What with state Rejected?
On 04/26/2010 02:22 AM, Christian Hammond wrote: Hi, The intended purpose of Discard is to mark it as basically rejected or abandoned in its entirety, without the intention of updating the diffs to fix the reasons for it being rejected. We don't really support any other meanings for it or any hacks to change the meaning. I don't really know if there's something you were hoping we'd change here, but I don't understand what other meaning would be needed for this. Christian What I think he's asking for (and if not, it's something I'd like to see) is a checkbox in the Review that is the opposite of "Ship It". Something like "Needs Revision". That way this could be searchable/sortable in the dashboard. The idea would be that, at a glance, you can see which patches still need reviewers vs. the patches that have been reviewed and found insufficient and are awaiting re-submission. Additionally, adding an updated diff should clear the "Needs Revision" flag. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What with state Rejected?
Hi, The intended purpose of Discard is to mark it as basically rejected or abandoned in its entirety, without the intention of updating the diffs to fix the reasons for it being rejected. We don't really support any other meanings for it or any hacks to change the meaning. I don't really know if there's something you were hoping we'd change here, but I don't understand what other meaning would be needed for this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Apr 25, 2010 at 9:59 PM, Jan Koprowski wrote: > Hi! > > I'am waiting for all the time to hear answer what with rejecting > reviews? I made proposition to put option in admin panel which allow > choose between "discarding" which mean: "discarded review is not > visible on dashboard" and "rejecting" which mean "there was a mistake, > I reject this review but it still visible in dashboard. This situation > when I must tirgger some action when review is not "ok" at first time > confuse me. Only way now is add hook to discard action and trigger > post-review with --reopen option next time. I know, the purpose of > discarded is different but maybe this is good option in this situation. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
What with state Rejected?
Hi! I'am waiting for all the time to hear answer what with rejecting reviews? I made proposition to put option in admin panel which allow choose between "discarding" which mean: "discarded review is not visible on dashboard" and "rejecting" which mean "there was a mistake, I reject this review but it still visible in dashboard. This situation when I must tirgger some action when review is not "ok" at first time confuse me. Only way now is add hook to discard action and trigger post-review with --reopen option next time. I know, the purpose of discarded is different but maybe this is good option in this situation. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
