Re: Review link in email notification is wrong on RB 3.0.1
Hi, We have a fix for this coming in the next release, which will be after the holidays. Christian On Thu, Dec 21, 2017 at 08:19 wrote: > Hi, > > I've just finished upgrading reviewboard from v2.5.16 to v3.0.1. > [installed via bitnami] > After the upgrading, email notification has the wrong review link. > Below quote is an example, application name reviewboard was added twice to > the URL. > >> This is an automatically generated e-mail. To reply, visit: >> http://192.168.0.250:8081/*reviewboard/*/reviewboard/r/107/ > > > I've checked that Server URL setting [http://192.168.0.250:8081] seems > correct in Admin > General Settings. > And it shouldn't be related to upgrading from the old one, because I > installed fresh new reviewboard v3.0.1 [via bitnami as well], and it also > has the same problem. > > If I want to fix this issue, what do I have to do? Might be > bitnami package problem? > > Thank you in advance. > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Review link in email notification is wrong on RB 3.0.1
Hi, I've just finished upgrading reviewboard from v2.5.16 to v3.0.1. [installed via bitnami] After the upgrading, email notification has the wrong review link. Below quote is an example, application name reviewboard was added twice to the URL. > This is an automatically generated e-mail. To reply, visit: > http://192.168.0.250:8081/*reviewboard/*/reviewboard/r/107/ I've checked that Server URL setting [http://192.168.0.250:8081] seems correct in Admin > General Settings. And it shouldn't be related to upgrading from the old one, because I installed fresh new reviewboard v3.0.1 [via bitnami as well], and it also has the same problem. If I want to fix this issue, what do I have to do? Might be bitnami package problem? Thank you in advance. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RB_Cannot receive email notification
Hi, Can you tell us more about what's failing? Can you also upgrade to 2.0.20? There are known e-mail problems on 2.0.18. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Mon, Nov 9, 2015 at 11:55 PM, Water Dragon wrote: > I use RB v2.0.18, authentication by AD. I configure email server with our > local mail server, use TLS port 587. But it's not work although I tried > port 25 and unclick TLS. > Please support me about this situation. Thanks! > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RB_Cannot receive email notification
I use RB v2.0.18, authentication by AD. I configure email server with our local mail server, use TLS port 587. But it's not work although I tried port 25 and unclick TLS. Please support me about this situation. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: automatic email notification to list all the outstanding review requests
Hi Madhu, There's not. Something like this can be written as an extension to Review Board (as a management command + crontab), or can be written using the RBTools Python API. We know some companies have done this, but we don't have copies of any of those scripts. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Tue, Oct 27, 2015 at 7:04 AM, madhu padikar wrote: > Hi, > > Is there a way to set an automatic email notification to list all > the outstanding review requests in Review Board 1.7.21? > > Regards > Madhu > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
automatic email notification to list all the outstanding review requests
Hi, Is there a way to set an automatic email notification to list all the outstanding review requests in Review Board 1.7.21? Regards Madhu -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Extension : Custom Email Notification
Parthiban, It's possible that the "SpiffyEmailMessage" class and some of the utility functions might be useful to you. Beyond that, everything else should just be set up for you to use Django's built-in e-mail APIs. -David On Tue, Apr 14, 2015 at 1:48 AM Parthiban wrote: > > Hi All, > > I want to send email notification as part of my extension implementation. > Is there anyway to re-use review board email notifications module? > > Kindly share your thoughts.. > > Regards, > Parthiban P. > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Review Board Extension : Custom Email Notification
Hi All, I want to send email notification as part of my extension implementation. Is there anyway to re-use review board email notifications module? Kindly share your thoughts.. Regards, Parthiban P. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Email notification not working in reviewboard 2.0.15
Hi, Please find the log attached. Test mail i.e. mail sent after saving email settings works. I get the email notification. But when i post a review request or add a new user, i dont receive any email. using port 25 and office mail server. I tried to debug and found that test mail also goes through the same set of functions and within function open() it tries to EHLO, STARTTLS and then again EHLO. And "has_extn()" call for starttls returns False. Thanks in advance -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. reviewboard.log Description: Binary data
Re: RB email notification not worked
If you can get the test e-mail, it's more likely that the mail server is filtering out the e-mails. Can you answer my prior questions about the type of mail server? Can you also verify that you are using the correct mail settings (username, password, TLS)? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Dec 16, 2014 at 10:53 PM, Jing Shao wrote: > > I can get the test email. So I think mail server works fine. > > I only need to set email config on Admin settings, no need for RB server > config, right? > > > > 在 2014年12月17日，下午2:50，Christian Hammond 写道： > > > > Hi, > > > > Most likely, the server you have set up for e-mail is not accepting > connections and it's timing out. What mail server are you using, and are > you 100% sure that the address is correct and is functioning as an SMTP > server? > > > > Christian > > > > -- > > Christian Hammond - christ...@beanbaginc.com > > Review Board - https://www.reviewboard.org > > Beanbag, Inc. - https://www.beanbaginc.com > > > > -Original Message- > > From: Shao Jing > > Reply: reviewboard@googlegroups.com > > > Date: December 16, 2014 at 9:42:26 PM > > To: reviewboard@googlegroups.com > > > Subject: RB email notification not worked > > > >> Hi, > >> > >> I configured email setting in Admin. Test email works fine. > >> > >> But when publish a review, it starts loading, and never end. > >> Without email notification enabled, it works fine. > >> > >> What config I missed? > >> > >> Thanks. > >> > >> -- > >> Get the Review Board Power Pack at > http://www.reviewboard.org/powerpack/ > >> --- > >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > >> --- > >> Happy user? Let us know at http://www.reviewboard.org/users/ > >> --- > >> You received this message because you are subscribed to the Google > Groups "reviewboard" > >> group. > >> To unsubscribe from this group and stop receiving emails from it, send > an email to reviewboard+unsubscr...@googlegroups.com. > >> For more options, visit https://groups.google.com/d/optout. > >> > > > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RB email notification not worked
I can get the test email. So I think mail server works fine. I only need to set email config on Admin settings, no need for RB server config, right? > 在 2014年12月17日，下午2:50，Christian Hammond 写道： > > Hi, > > Most likely, the server you have set up for e-mail is not accepting > connections and it's timing out. What mail server are you using, and are you > 100% sure that the address is correct and is functioning as an SMTP server? > > Christian > > -- > Christian Hammond - christ...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > -Original Message- > From: Shao Jing > Reply: reviewboard@googlegroups.com > > Date: December 16, 2014 at 9:42:26 PM > To: reviewboard@googlegroups.com > > Subject: RB email notification not worked > >> Hi, >> >> I configured email setting in Admin. Test email works fine. >> >> But when publish a review, it starts loading, and never end. >> Without email notification enabled, it works fine. >> >> What config I missed? >> >> Thanks. >> >> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" >> group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RB email notification not worked
Hi, Most likely, the server you have set up for e-mail is not accepting connections and it's timing out. What mail server are you using, and are you 100% sure that the address is correct and is functioning as an SMTP server? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Shao Jing Reply: reviewboard@googlegroups.com > Date: December 16, 2014 at 9:42:26 PM To: reviewboard@googlegroups.com > Subject: RB email notification not worked > Hi, > > I configured email setting in Admin. Test email works fine. > > But when publish a review, it starts loading, and never end. > Without email notification enabled, it works fine. > > What config I missed? > > Thanks. > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" > group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RB email notification not worked
Hi, I configured email setting in Admin. Test email works fine. But when publish a review, it starts loading, and never end. Without email notification enabled, it works fine. What config I missed? Thanks. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Email notification : test email not sent & no trace in logging file
I finally managed to make it work by changing port to 587. Thanks for your time. Fabrice Le vendredi 31 octobre 2014 09:03:22 UTC+1, fabrice...@tma-asp.com a écrit : > > Hi David, > > Thanks for the quick answer. > > We're using GMail SMTP server via TLS on port 465 to send our emails. Test > SMTP access from bash (openssl s_client -connect ...) on the same machine > works fine. Are you aware of any trouble accessing GMail SMTP via TLS from > Django and/or ReviewBoard ? > > Cheers. > Fabrice > > Le jeudi 30 octobre 2014 20:44:29 UTC+1, David Trowbridge a écrit : >> >> It sounds like it's just timing out trying to contact your mail server. I >> don't think there's any existing logging that would help here. We should >> probably add more, but a lot of the mail plumbing happens in django, where >> we can't add additional logging. >> >> -David >> >> On Thu, Oct 30, 2014 at 5:59 AM, wrote: >> >>> Hi, >>> >>> ReviewBoard version : 2.0.11 (CentOS >>> Browser : Firefox 33.0 & Chrome 38.0 >>> >>> >>> I'm trying to test email notification in Admin > System settings > >>> (checked Send a test e-mail after saving) > Save. >>> >>> After hitting the save button, I get a "Page loading..." message and a >>> spinning wheel for minutes. Then... nothing happens. No email. No >>> success/failure message. >>> >>> Looking into logs (Admin > System settings > (checked 'Enable logging') >>> > log level = Debug), nothing appears. The only logs I get are about LDAP >>> auth and cache miss... >>> >>> Any advice on configuring logging so that I get a chance to understand >>> what's happening ? >>> >>> Cheers, >>> Fabrice >>> >>> -- >>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >>> --- >>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>> --- >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Email notification : test email not sent & no trace in logging file
Hi David, Thanks for the quick answer. We're using GMail SMTP server via TLS on port 465 to send our emails. Test SMTP access from bash (openssl s_client -connect ...) on the same machine works fine. Are you aware of any trouble accessing GMail SMTP via TLS from Django and/or ReviewBoard ? Cheers. Fabrice Le jeudi 30 octobre 2014 20:44:29 UTC+1, David Trowbridge a écrit : > > It sounds like it's just timing out trying to contact your mail server. I > don't think there's any existing logging that would help here. We should > probably add more, but a lot of the mail plumbing happens in django, where > we can't add additional logging. > > -David > > On Thu, Oct 30, 2014 at 5:59 AM, > > wrote: > >> Hi, >> >> ReviewBoard version : 2.0.11 (CentOS >> Browser : Firefox 33.0 & Chrome 38.0 >> >> >> I'm trying to test email notification in Admin > System settings > >> (checked Send a test e-mail after saving) > Save. >> >> After hitting the save button, I get a "Page loading..." message and a >> spinning wheel for minutes. Then... nothing happens. No email. No >> success/failure message. >> >> Looking into logs (Admin > System settings > (checked 'Enable logging') > >> log level = Debug), nothing appears. The only logs I get are about LDAP >> auth and cache miss... >> >> Any advice on configuring logging so that I get a chance to understand >> what's happening ? >> >> Cheers, >> Fabrice >> >> -- >> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >> --- >> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >> --- >> Happy user? Let us know at http://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "reviewboard" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Email notification : test email not sent & no trace in logging file
It sounds like it's just timing out trying to contact your mail server. I don't think there's any existing logging that would help here. We should probably add more, but a lot of the mail plumbing happens in django, where we can't add additional logging. -David On Thu, Oct 30, 2014 at 5:59 AM, wrote: > Hi, > > ReviewBoard version : 2.0.11 (CentOS > Browser : Firefox 33.0 & Chrome 38.0 > > > I'm trying to test email notification in Admin > System settings > > (checked Send a test e-mail after saving) > Save. > > After hitting the save button, I get a "Page loading..." message and a > spinning wheel for minutes. Then... nothing happens. No email. No > success/failure message. > > Looking into logs (Admin > System settings > (checked 'Enable logging') > > log level = Debug), nothing appears. The only logs I get are about LDAP > auth and cache miss... > > Any advice on configuring logging so that I get a chance to understand > what's happening ? > > Cheers, > Fabrice > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Email notification : test email not sent & no trace in logging file
Hi, ReviewBoard version : 2.0.11 (CentOS Browser : Firefox 33.0 & Chrome 38.0 I'm trying to test email notification in Admin > System settings > (checked Send a test e-mail after saving) > Save. After hitting the save button, I get a "Page loading..." message and a spinning wheel for minutes. Then... nothing happens. No email. No success/failure message. Looking into logs (Admin > System settings > (checked 'Enable logging') > log level = Debug), nothing appears. The only logs I get are about LDAP auth and cache miss... Any advice on configuring logging so that I get a chance to understand what's happening ? Cheers, Fabrice -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: email notification
Okay. Thanks. On Fri, Sep 17, 2010 at 11:34 AM, Christian Hammond wrote: > Hi Madhavi, > > This is a known bug that we'll likely fix in a 1.5.x point release (and > possibly backport to 1.0.x, but we're hoping to migrate people onto 1.5.x). > See http://code.google.com/p/reviewboard/issues/detail?id=1795 > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Thu, Sep 16, 2010 at 10:11 PM, Madhavi Gupta > wrote: > >> Hi Tim, >> >> Thanks for the response. >> >> I am setting the parameter "submit-as" and giving the name of actual user >> who is committing. >> >> When the request is created, I can see the submitter as that user. The >> email body also contains that user's name as a signature. However email is >> sent from common user's account. >> >> Regards >> -Madhavi >> >> >> On Thu, Sep 16, 2010 at 10:23 PM, Timothy Pinet wrote: >> >>> Well that URL got mangled... >>> >>> >>> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review >>> >>> tim >>> >>> On Sep 16, 12:51 pm, "Tim Pinet" wrote: >>> > Trying using the "submit-as" parameter. >>> > >>> > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a. >>> .. >>> > ng-post-review >>> > >>> > I have a common "post" user account and pass the username in the >>> submit-as >>> > param. >>> > >>> > tim >>> > >>> > -Original Message- >>> > From: reviewboard@googlegroups.com [mailto: >>> reviewbo...@googlegroups.com] On >>> > >>> > Behalf Of Madhavi >>> > Sent: September-16-10 5:32 AM >>> > To: reviewboard >>> > Subject: email notification >>> > >>> > Hi, >>> > >>> > We are on ReviewBoard 1.0.9 on CentOS >>> > >>> > We are creating RB issues in post commit hook. I am calling >>> > postreview.py from the post commit hook. one of parameters to the >>> > command is --username to which I am passing a standard username say >>> > 'userxyz' other that the submitter. >>> > >>> > So when email notification is sent, it is sent by this this 'userxyz' >>> > and not by submitter user. If I want to send emails from the >>> > submitter's email id, how to I do it ? >>> > >>> > Regards >>> > -Madhavi >>> > >>> > -- >>> > Want to help the Review Board project? Donate today athttp:// >>> www.reviewboard.org/donate/ >>> > Happy user? Let us know athttp://www.reviewboard.org/users/ >>> > -~--~~~~--~~--~--~--- >>> > To unsubscribe from this group, send email to >>> > reviewboard+unsubscr...@googlegroups.com >>> > For more options, visit this group athttp:// >>> groups.google.com/group/reviewboard?hl=en >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~--~~~~--~~--~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >>> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: email notification
Hi Madhavi, This is a known bug that we'll likely fix in a 1.5.x point release (and possibly backport to 1.0.x, but we're hoping to migrate people onto 1.5.x). See http://code.google.com/p/reviewboard/issues/detail?id=1795 Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Sep 16, 2010 at 10:11 PM, Madhavi Gupta wrote: > Hi Tim, > > Thanks for the response. > > I am setting the parameter "submit-as" and giving the name of actual user > who is committing. > > When the request is created, I can see the submitter as that user. The > email body also contains that user's name as a signature. However email is > sent from common user's account. > > Regards > -Madhavi > > > On Thu, Sep 16, 2010 at 10:23 PM, Timothy Pinet wrote: > >> Well that URL got mangled... >> >> >> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review >> >> tim >> >> On Sep 16, 12:51 pm, "Tim Pinet" wrote: >> > Trying using the "submit-as" parameter. >> > >> > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a. >> .. >> > ng-post-review >> > >> > I have a common "post" user account and pass the username in the >> submit-as >> > param. >> > >> > tim >> > >> > -Original Message- >> > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] >> On >> > >> > Behalf Of Madhavi >> > Sent: September-16-10 5:32 AM >> > To: reviewboard >> > Subject: email notification >> > >> > Hi, >> > >> > We are on ReviewBoard 1.0.9 on CentOS >> > >> > We are creating RB issues in post commit hook. I am calling >> > postreview.py from the post commit hook. one of parameters to the >> > command is --username to which I am passing a standard username say >> > 'userxyz' other that the submitter. >> > >> > So when email notification is sent, it is sent by this this 'userxyz' >> > and not by submitter user. If I want to send emails from the >> > submitter's email id, how to I do it ? >> > >> > Regards >> > -Madhavi >> > >> > -- >> > Want to help the Review Board project? Donate today athttp:// >> www.reviewboard.org/donate/ >> > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > -~--~~~~--~~--~--~--- >> > To unsubscribe from this group, send email to >> > reviewboard+unsubscr...@googlegroups.com >> > For more options, visit this group athttp:// >> groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: email notification
Yeap and You can't change this behavior, unfortunately :( On Fri, Sep 17, 2010 at 7:11 AM, Madhavi Gupta wrote: > Hi Tim, > > Thanks for the response. > > I am setting the parameter "submit-as" and giving the name of actual user > who is committing. > > When the request is created, I can see the submitter as that user. The email > body also contains that user's name as a signature. However email is sent > from common user's account. > > Regards > -Madhavi > > On Thu, Sep 16, 2010 at 10:23 PM, Timothy Pinet wrote: >> >> Well that URL got mangled... >> >> >> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review >> >> tim >> >> On Sep 16, 12:51 pm, "Tim Pinet" wrote: >> > Trying using the "submit-as" parameter. >> > >> > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a... >> > ng-post-review >> > >> > I have a common "post" user account and pass the username in the >> > submit-as >> > param. >> > >> > tim >> > >> > -Original Message- >> > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] >> > On >> > >> > Behalf Of Madhavi >> > Sent: September-16-10 5:32 AM >> > To: reviewboard >> > Subject: email notification >> > >> > Hi, >> > >> > We are on ReviewBoard 1.0.9 on CentOS >> > >> > We are creating RB issues in post commit hook. I am calling >> > postreview.py from the post commit hook. one of parameters to the >> > command is --username to which I am passing a standard username say >> > 'userxyz' other that the submitter. >> > >> > So when email notification is sent, it is sent by this this 'userxyz' >> > and not by submitter user. If I want to send emails from the >> > submitter's email id, how to I do it ? >> > >> > Regards >> > -Madhavi >> > >> > -- >> > Want to help the Review Board project? Donate today >> > athttp://www.reviewboard.org/donate/ >> > Happy user? Let us know athttp://www.reviewboard.org/users/ >> > -~--~~~~--~~--~--~--- >> > To unsubscribe from this group, send email to >> > reviewboard+unsubscr...@googlegroups.com >> > For more options, visit this group >> > athttp://groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- ><> Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: email notification
Hi Tim, Thanks for the response. I am setting the parameter "submit-as" and giving the name of actual user who is committing. When the request is created, I can see the submitter as that user. The email body also contains that user's name as a signature. However email is sent from common user's account. Regards -Madhavi On Thu, Sep 16, 2010 at 10:23 PM, Timothy Pinet wrote: > Well that URL got mangled... > > > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review > > tim > > On Sep 16, 12:51 pm, "Tim Pinet" wrote: > > Trying using the "submit-as" parameter. > > > > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a... > > ng-post-review > > > > I have a common "post" user account and pass the username in the > submit-as > > param. > > > > tim > > > > -Original Message- > > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] > On > > > > Behalf Of Madhavi > > Sent: September-16-10 5:32 AM > > To: reviewboard > > Subject: email notification > > > > Hi, > > > > We are on ReviewBoard 1.0.9 on CentOS > > > > We are creating RB issues in post commit hook. I am calling > > postreview.py from the post commit hook. one of parameters to the > > command is --username to which I am passing a standard username say > > 'userxyz' other that the submitter. > > > > So when email notification is sent, it is sent by this this 'userxyz' > > and not by submitter user. If I want to send emails from the > > submitter's email id, how to I do it ? > > > > Regards > > -Madhavi > > > > -- > > Want to help the Review Board project? Donate today athttp:// > www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group athttp:// > groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: email notification
Well that URL got mangled... http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review tim On Sep 16, 12:51 pm, "Tim Pinet" wrote: > Trying using the "submit-as" parameter. > > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a... > ng-post-review > > I have a common "post" user account and pass the username in the submit-as > param. > > tim > > -Original Message- > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On > > Behalf Of Madhavi > Sent: September-16-10 5:32 AM > To: reviewboard > Subject: email notification > > Hi, > > We are on ReviewBoard 1.0.9 on CentOS > > We are creating RB issues in post commit hook. I am calling > postreview.py from the post commit hook. one of parameters to the > command is --username to which I am passing a standard username say > 'userxyz' other that the submitter. > > So when email notification is sent, it is sent by this this 'userxyz' > and not by submitter user. If I want to send emails from the > submitter's email id, how to I do it ? > > Regards > -Madhavi > > -- > Want to help the Review Board project? Donate today > athttp://www.reviewboard.org/donate/ > Happy user? Let us know athttp://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group > athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: email notification
Trying using the "submit-as" parameter. http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automati ng-post-review I have a common "post" user account and pass the username in the submit-as param. tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Madhavi Sent: September-16-10 5:32 AM To: reviewboard Subject: email notification Hi, We are on ReviewBoard 1.0.9 on CentOS We are creating RB issues in post commit hook. I am calling postreview.py from the post commit hook. one of parameters to the command is --username to which I am passing a standard username say 'userxyz' other that the submitter. So when email notification is sent, it is sent by this this 'userxyz' and not by submitter user. If I want to send emails from the submitter's email id, how to I do it ? Regards -Madhavi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
email notification
Hi, We are on ReviewBoard 1.0.9 on CentOS We are creating RB issues in post commit hook. I am calling postreview.py from the post commit hook. one of parameters to the command is --username to which I am passing a standard username say 'userxyz' other that the submitter. So when email notification is sent, it is sent by this this 'userxyz' and not by submitter user. If I want to send emails from the submitter's email id, how to I do it ? Regards -Madhavi -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: review request email notification sender address
This is a known bug. See bug http://code.google.com/p/reviewboard/issues/detail?id=1502 Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Apr 13, 2010 at 6:02 AM, Assaf Lavie wrote: > Hi. > I configured a post-commit hook to upload a review request for each > commit _as_ the author of the commit. > In the dashboard I see that the review requests submitted is indeed > the author of the revision. > However, the email message that gets sent to the default reviewers > appears "from" the web site's administrator's email address, instead > of the submitter's address.. > > Actually, it's weirded than that, because it was working as expected > for a while and at some point today it started acting like above.. I > probably messed something up, but can't figure it out myself.. > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > To unsubscribe, reply using "remove me" as the subject. > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
review request email notification sender address
Hi. I configured a post-commit hook to upload a review request for each commit _as_ the author of the commit. In the dashboard I see that the review requests submitted is indeed the author of the revision. However, the email message that gets sent to the default reviewers appears "from" the web site's administrator's email address, instead of the submitter's address.. Actually, it's weirded than that, because it was working as expected for a while and at some point today it started acting like above.. I probably messed something up, but can't figure it out myself.. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
ReviewBoard Email Notification Problem
Hi,all My ReviewBoard version is 1.0.5.1 We have enabled the Email Settings to "send e-mails for review requests and reviews" We had made reviewboard automation. We have made a special account of "submit-only" to submit reviewrequest for all CVS commits. After the generation of any new review request, The target reviewer will receive an Email, But the email head is not so accurate. I don't konw how the "Cc" part is used, But in my received email( My account is the real review requestor ), “Cc“ part shows the email account of the special account, the "submit-only" . and the email sender is also the "submit-only" . That is eccentric. In My opinion, This email should be from ReviewBoard to any ReviewRequest target reviewers, But the email has been received by me(The real ReviewRequestor), But my Email account is not in the email receiver list, nor in the "Cc" list. And the Sender, "submit-only" email, appeared in the "Cc". Can any body give me some explanation? Best Regards！ --- Return-Path: Delivered-To: my_em...@comp.com Received: (qmail 29203 invoked by uid 89); 21 Feb 2010 08:55:04 - Received: from unknown (HELO localhost.localdomain) (113.108.148.114) by 0 with SMTP; 21 Feb 2010 08:55:04 - Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Review Request: This is the test D From: =?utf-8?b?UmV2aWV3Qm9hcmQg5pyN5Yqh5Zmo?= To: =?utf-8?b?5rGfIOiUmueEtg==?= Date: Sun, 21 Feb 2010 08:55:22 - Message-ID: <20100221085522.31019.87...@localhost.localdomain> Cc: =?utf-8?b?UmV2aWV3Qm9hcmQg5pyN5Yqh5Zmo?= --- -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Email notification and webserver port?
Responding to my self. Restarting of the webserver did the trick. I think it could be worth looking into which settings that needs a webserver restart to become active, and see if we can remove the restart dependency. cheers, lars 2009/8/4 Lars Olsson > Hi, > > I am running my reviewboard server/webserver of a non standard port, 8080. > > In all email notifications send out, the port number is not included in the > URL. > I have tried to change the "Domain Name" in Admin -> Database -> Sites, to > http://my.server.com:8080 but that did not make any difference. > > In email.py I can find: > ... > context['domain'] = current_site.domain > ... > > which makes me belive that is should be enough to change the site config. > > I can't see if there are other settings to change. > > Any idea? > > Cheers, > lars > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Email notification and webserver port?
Hi, I am running my reviewboard server/webserver of a non standard port, 8080. In all email notifications send out, the port number is not included in the URL. I have tried to change the "Domain Name" in Admin -> Database -> Sites, to http://my.server.com:8080 but that did not make any difference. In email.py I can find: ... context['domain'] = current_site.domain ... which makes me belive that is should be enough to change the site config. I can't see if there are other settings to change. Any idea? Cheers, lars --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
