Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45612/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Ol

Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories

2016-04-01 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/#review126669 --- Ship it! Ship It! - Matt On April 1, 2016, 2:39 p.m., Lav Ja

Re: Review Request 45609: AMBARI-15675. Hosts page filtering: error if we filter component by Upgrade Failed state

2016-04-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45609/#review126667 --- Ship it! Ship It! - Zhe (Joe) Wang On April 1, 2016, 10:40 p

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Jonathan Hurley
> On April 1, 2016, 4:23 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 479-496 > > > > > > If the UI is passing in

Review Request 45609: AMBARI-15675. Hosts page filtering: error if we filter component by Upgrade Failed state

2016-04-01 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45609/ --- Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, and Zhe (Jo

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Alejandro Fernandez
> On April 1, 2016, 8:23 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 479-496 > > > > > > If the UI is passing in

Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories

2016-04-01 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45566/ --- (Updated April 1, 2016, 9:39 p.m.) Review request for Ambari, Andriy Babiichuk,

Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories

2016-04-01 Thread Lav Jain
> On April 1, 2016, 3:58 a.m., Matt wrote: > > ambari-web/app/views/common/configs/service_config_layout_tab_view.js, line > > 56 > > > > > > Can you please confirm if the help text is displayed when you hover > > o

Re: Review Request 45566: HAWQ config should not allow multiple Master/Segment directories

2016-04-01 Thread Lav Jain
> On April 1, 2016, 3:58 a.m., Matt wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > line 972 > > > > > > Is trailing space valid or invalid? > > > > If it is valid,

Re: Review Request 45593: AMBARI-15138 SCRIPT params should support visibility attribute

2016-04-01 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45593/#review126645 --- Ship it! Ship It! - Richard Zang On April 1, 2016, 5:41 p.m.

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/#review126644 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/#review126643 --- Ship it! Ship It! - Jonathan Hurley On April 1, 2016, 11:01

Re: Review Request 44982: AMBARI-15430: alert_group table has service info after service has been removed

2016-04-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44982/#review126642 --- Ship it! Ship It! - Jonathan Hurley On April 1, 2016, 1:15 a

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-04-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45519/#review126637 --- Ship it! Ship It! - Jayush Luniya On March 31, 2016, 10 p.m.

Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

2016-04-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41397/#review126636 --- Ship it! Ship It! - Jayush Luniya On April 1, 2016, 5:59 a.m

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/#review126635 --- Ship it! Ship It! - Jayush Luniya On April 1, 2016, 7:06 p.m

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/#review126633 --- Ship it! Ship It! - Swapan Shridhar On April 1, 2016, 7:06 p

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/#review126632 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley,

Re: Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/#review126627 --- Pushed to trunk, commit 12d19c9f82f66c2db19b72199d29a6691ae398a8

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
> On April 1, 2016, 2:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java, > > line 251 > > > > > > Do both of

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126625 --- Ship it! Decrease the timeout during the unit test and ship it

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126619 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45522/#review126611 --- Ship it! Ship It! - Alejandro Fernandez On April 1, 2016, 5:

Review Request 45593: AMBARI-15138 SCRIPT params should support visibility attribute

2016-04-01 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45593/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg Nechiporenko,

Re: Review Request 45541: AMBARI-15648 Ranger KMS server start fails due to missing JCE policies on non-kerberos cluster

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45541/#review126610 --- Ship it! Ship It! - Alejandro Fernandez On March 31, 2016, 1

Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

2016-04-01 Thread Alejandro Fernandez
> On March 31, 2016, 6:03 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py, > > line 33 > > > > > > Is this an optional component? >

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-04-01 Thread Juanjo Marron
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py, > > line 132 > > > > > > Lets just use stack_name.upper() to

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-01 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45522/ --- (Updated April 1, 2016, 5:31 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-04-01 Thread Juanjo Marron
> On March 31, 2016, 6:26 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, > > line 123 > > > > > > Rename to oozie_create_hive_tez_configs instead? R

Re: Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/#review126606 --- Ship it! Ship It! - Alejandro Fernandez On April 1, 2016, 1:

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/ --- (Updated April 1, 2016, 12:43 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
> On April 1, 2016, 12:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java, > > line 230 > > > > > > Does the schema factory close the

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126595 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/ --- (Updated ápr. 1, 2016, 3:01 du) Review request for Ambari, Jonathan Hurley, Oli

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/ --- (Updated April 1, 2016, 10:52 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 43832: AMBARI-14627: Ability to automate setup-security and setup-ldap/sync-ldap

2016-04-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43832/ --- (Updated April 1, 2016, 2:36 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 45585: ambari-agent Build Reports SUCCESS Even When Tests Fail

2016-04-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45585/#review126582 --- Ship it! Ship It! - Dmitro Lisnichenko On April 1, 2016, 3:5

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/#review126580 --- Ship it! Ship It! - Oliver Szabo On April 1, 2016, 12:07 p.m

Re: Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/#review126579 --- Ship it! Ship It! - Oliver Szabo On April 1, 2016, 1:20 p.m.

Re: Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/#review126578 --- Ship it! Ship It! - Sebastian Toader On April 1, 2016, 3:20

Review Request 45587: Upgrade to trunk fails due AuditLogger

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45587/ --- Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toad

Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 45561: Record and Expose Alert Occurrence Values

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45561/#review126577 --- Ship it! Ship It! - Nate Cole On March 31, 2016, 4:24 p.m.,

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/ --- (Updated ápr. 1, 2016, 1:01 du) Review request for Ambari, Jonathan Hurley, Nat

Review Request 45585: ambari-agent Build Reports SUCCESS Even When Tests Fail

2016-04-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45585/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sumit Mohant

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/ --- (Updated ápr. 1, 2016, 12:07 du) Review request for Ambari, Jonathan Hurley, Ol

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/ --- (Updated ápr. 1, 2016, 12:06 du) Review request for Ambari, Jonathan Hurley, Na

Re: Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/#review126575 --- Ship it! Ship It! - Sebastian Toader On April 1, 2016, 12:41

Review Request 45579: Unable to Create Cluster Fails Due To Audit Logger

2016-04-01 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45579/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sebastian Toader.

Re: Review Request 45578: Add visibility attribute into SCRIPT params

2016-04-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45578/#review126566 --- Ship it! As long as UT pass +1 - Andrew Onischuk On April 1,

Re: Review Request 45578: Add visibility attribute into SCRIPT params

2016-04-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45578/#review126565 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 1, 2016, 8

Review Request 45578: Add visibility attribute into SCRIPT params

2016-04-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45578/ --- Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. Bugs: AMBARI

Re: Review Request 45540: Alerts Using the SKIPPED State Cause Stale Alert Notification

2016-04-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45540/#review126564 --- Ship it! Ship It! - Dmitro Lisnichenko On March 31, 2016, 4:

Re: Review Request 45548: Upgrading Kerberized JournalNode requires HDFS principal to perform 'role edits' task

2016-04-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45548/#review126562 --- Ship it! Ship It! - Sebastian Toader On March 31, 2016, 6:35