Re: Review Request 52996: For rolling upgrade of Kafka 0.10.0.1, set configs for backward compatibility

2016-10-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52996/#review153239 --- Ship it! Out of curiousity, instead of providing a message

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

2016-10-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review152194 --- Ship it! Ship It! - Swapan Shridhar On Oct. 14, 2016, 11:15

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/ --- (Updated Oct. 19, 2016, 1:35 a.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/ --- (Updated Oct. 19, 2016, 1:34 a.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 52996: For rolling upgrade of Kafka 0.10.0.1, set configs for backward compatibility

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52996/#review153232 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 19, 2016,

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

2016-10-18 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review153220 --- Ship it! Ship It! - Richard Zang On Oct. 18, 2016, 11:37

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

2016-10-18 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 18, 2016, 11:37 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
> On Oct. 18, 2016, 4:50 p.m., Sid Wagle wrote: > > 1. Agree with SUmit on increasing timeout to 5 sicne we are killing the > > thread. > > 2. Instead of cryptic way of kill is there a graceful way to stop using > > separate Stoppable Thread extension which can be called from the parent ? > >

Re: Review Request 52999: Incorporate database consistency check into main Ambari process

2016-10-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/#review153199 --- Fix it, then Ship it!

Review Request 52999: Incorporate database consistency check into main Ambari process

2016-10-18 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
> On Oct. 18, 2016, 4:50 p.m., Sid Wagle wrote: > > 1. Agree with SUmit on increasing timeout to 5 sicne we are killing the > > thread. > > 2. Instead of cryptic way of kill is there a graceful way to stop using > > separate Stoppable Thread extension which can be called from the parent ? 1.

Review Request 52996: For rolling upgrade of Kafka 0.10.0.1, set configs for backward compatibility

2016-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52996/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153176 --- Fix it, then Ship it!

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153154 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 18, 2016,

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153148 --- Ship it! Ship It! - Sid Wagle On Oct. 18, 2016, 6:25 p.m.,

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
> On Oct. 18, 2016, 6:36 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 612 > > > > > > This can be really simplified

Re: Review Request 52987: Remove Unnecessary Locks Inside Of SCH Business Object Implementations

2016-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52987/#review153146 --- Ship it! Ship It! - Nate Cole On Oct. 18, 2016, 8:23 a.m.,

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Jonathan Hurley
> On Oct. 18, 2016, 2:36 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 612 > > > > > > This can be really simplified

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153135 ---

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-18 Thread Aravindan Vijayan
> On Oct. 18, 2016, 6:01 p.m., Alejandro Fernandez wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/DownSamplerUtils.java, > > line 55 > >

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/ --- (Updated Oct. 18, 2016, 6:34 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 18, 2016, 6:29 p.m.) Review request for Ambari, Alejandro

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 950-951 > > > > > > Whitespace: missing between `){`, and

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > > > > > How about using

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Alejandro Fernandez
> On Oct. 18, 2016, 1:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 623 > > > > > > Why is this a

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 2:36 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 3074-3076 > > > > > > Need a default-if-not-null here

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 2:19 p.m., Robert Levas wrote: > > Has this been tested using both models while enabling Kerberos? I've tested BP deployment of a secure cluster and Enable/Disable Kerberos, also Upgrade. Since this DEPENDENCY_ORDER execution applies only for requests marked with property

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-18 Thread Sandor Magyari
> On Oct. 17, 2016, 9:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java, > > lines 874-875 > > > > > > Why check both here? Isn't it enough

Re: Review Request 52842: AMBARI-18593 : Provide ability to use downsampling function on certain metrics like client side topN

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52842/#review153117 ---

Re: Review Request 52987: Remove Unnecessary Locks Inside Of SCH Business Object Implementations

2016-10-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52987/#review153116 --- Ship it!

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Balázs Bence Sári
> On Oct. 18, 2016, 4:41 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml, > > line 35 > > > > > > Rename to

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52989/#review153113 --- 1. Agree with SUmit on increasing timeout to 5 sicne we are

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52860/#review153111 ---

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52860/#review153109 --- Ship it! Ship It! - Jayush Luniya On Oct. 14, 2016, 10:07

Re: Review Request 49484: Remove spark.yarn.max.executor.failures configuration in Spark Ambari definition

2016-10-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49484/#review153107 --- Ship it! Ship It! - Jayush Luniya On Oct. 17, 2016, 6:40

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

2016-10-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52932/#review153102 --- Ship it! Ship It! - Jonathan Hurley On Oct. 18, 2016, 10:27

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52989/#review153097 --- ambari-agent/src/main/python/ambari_agent/ActionQueue.py (line

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52989/#review153095 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 18, 2016,

Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52989/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18629

Re: Review Request 52958: Fix Log Search User Config bug

2016-10-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52958/#review153091 --- Ship it! Ship It! - Robert Nettleton On Oct. 18, 2016,

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

2016-10-18 Thread Jonathan Hurley
> On Oct. 17, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/pom.xml, line 44 > > > > > > I think that perhaps we should now move this out of contrib and into > > resources directly since it's a

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153086 --- Ship it!

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153083 --- Ship it! Ship It! - Di Li On Oct. 18, 2016, 12:36 a.m.,

Re: Review Request 52983: Can't open Hive view in Internet explorer 11 in HDP 2.5

2016-10-18 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52983/#review153082 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 18, 2016,

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153079 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 18, 2016, 12:36

Re: Review Request 52958: Fix Log Search User Config bug

2016-10-18 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52958/ --- (Updated Oct. 18, 2016, 12:48 p.m.) Review request for Ambari, Oliver Szabo,

Review Request 52987: Remove Unnecessary Locks Inside Of SCH Business Object Implementations

2016-10-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52987/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and

Review Request 52983: Can't open Hive view in Internet explorer 11 in HDP 2.5

2016-10-18 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52983/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

2016-10-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52964/#review153069 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 18, 2016,

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/#review153064 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 18, 2016,

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

2016-10-18 Thread Dmytro Sen
> On Окт. 17, 2016, 9:10 п.п., Jonathan Hurley wrote: > > ambari-server/pom.xml, line 44 > > > > > > I think that perhaps we should now move this out of contrib and into > > resources directly since it's a

Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-18 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52979/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18623