Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

2016-11-02 Thread Jeff Zhang
> On Nov. 3, 2016, 1:21 a.m., Sumit Mohanty wrote: > > Lets have a bug open to fix it in the upgrade pack. > > > > Pls talk to Robert Levas and see if the persisted kerberos.json need to be > > modified or it will get auto modified when stack is upgraded. Thanks Sumit, create

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

2016-11-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53334/#review154666 --- Lets have a bug open to fix it in the upgrade pack. Pls talk to

Review Request 53416: AMBARI-18746: Sqoop parameter hadoop_home is pointed to incorrect path in params_linux.py

2016-11-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53416/ --- Review request for Ambari, Alejandro Fernandez and Tim Thorpe. Bugs:

Review Request 53412: AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or disabling credential store

2016-11-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53412/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert

Review Request 53404: Component actions confirmation window (from host details page) don't have the details about action to be confirmed

2016-11-02 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53404/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang,

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

2016-11-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53314/#review154631 --- Ship it!

Re: Review Request 53364: AMBARI-18767 - E2E Integration for Manage JournalNode Wizard

2016-11-02 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53364/#review154619 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 2, 2016, 1:31

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Jonathan Hurley
> On Nov. 2, 2016, 2:23 p.m., Dmitro Lisnichenko wrote: > > I see the upgrade pack for new upgrade type. Is downgrade possible? Is host > > order reversed during downgrade? Downgrades are possible, yes. Nothing is going to be "reversed" during a HOST_ORDERED downgrade. Essentially this is an

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Robert Nettleton
> On Nov. 2, 2016, 6:18 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditServiceLoadRequestQueryConverter.java, > > line 51 > > > > > >

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Oliver Szabo
> On Nov. 2, 2016, 6:18 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditServiceLoadRequestQueryConverter.java, > > line 51 > > > > > >

Review Request 53396: DB consistency check should inform user about warnings but not fail ambari-server start

2016-11-02 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53396/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-02 Thread Anita Jebaraj
> On Nov. 2, 2016, 9:18 a.m., Attila Doroszlai wrote: > > ambari-server/src/test/python/TestUtils.py, line 130 > > > > > > I think get_properties_mock was added to avoid this error: > > > > ``` > >

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-02 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Nov. 2, 2016, 6:31 p.m.) Review request for Ambari, Di Li, Tim

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154607 --- I see the upgrade pack for new upgrade type. Is downgrade

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53224/#review154603 --- Ship it! Overall, the patch looks fine to me. I have two

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/ --- (Updated Nov. 2, 2016, 2:09 p.m.) Review request for Ambari, Dmitro

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

2016-11-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/ --- (Updated Nov. 2, 2016, 10:49 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154600 --- Ship it! Ship It! - Nate Cole On Nov. 2, 2016, 12:32 p.m.,

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154595 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 2, 2016,

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Nate Cole
> On Nov. 2, 2016, 11:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 2238-2241 > > > > > > Interesting concept. I

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

2016-11-02 Thread Di Li
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Di. > > Di Li wrote: > pushed to trunk as > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=d48b4639aa6a484353e01b43797c7e304c36857d pushed to branch-2.5 as

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

2016-11-02 Thread Di Li
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Di. pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=d48b4639aa6a484353e01b43797c7e304c36857d - Di

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/ --- (Updated Nov. 2, 2016, 12:32 p.m.) Review request for Ambari, Dmitro

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Jonathan Hurley
> On Nov. 2, 2016, 11:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 1880-1881 > > > > > > Wow. Will this always be

Re: Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154557 ---

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

2016-11-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53338/#review154554 --- Ship it! Ship It! - Jonathan Hurley On Nov. 2, 2016, 10:06

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

2016-11-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53338/#review154550 --- Ship it! Ship It! - Robert Nettleton On Nov. 2, 2016, 2:06

Re: Review Request 53338: Upgrade Fails From 2.4.2 to 2.5 Due To Existing Role Authorizations

2016-11-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53338/ --- (Updated Nov. 2, 2016, 10:06 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53224/ --- (Updated Nov. 2, 2016, 12:48 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53224/#review154536 ---

Re: Review Request 53224: Logsearch metadata pattern for services

2016-11-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53224/#review154542 --- Ship it! Ship It! - Miklos Gergely On Oct. 27, 2016, 1:03

Review Request 53373: Add validations and attributes to support HOST_ORDERED upgrades

2016-11-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/ --- Review request for Ambari, Dmitro Lisnichenko and Nate Cole. Bugs:

Re: Review Request 53356: Perf: Allow running multiple Ambari Agents on the same host

2016-11-02 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53356/#review154541 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 1, 2016,

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

2016-11-02 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53314/#review154540 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 31, 2016,

Re: Review Request 53087: Log Search schema meta data loader fix

2016-11-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/ --- (Updated Nov. 2, 2016, 10:33 a.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

2016-11-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53188/#review154532 --- Ship it! Ship It! - Sebastian Toader On Oct. 29, 2016, 6:36

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154525 ---

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-02 Thread Robert Levas
> On Oct. 31, 2016, 12:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > '''