Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- (Updated Dec. 14, 2016, 7:27 a.m.) Review request for Ambari, Alejandro

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review159118 --- Ship it! Ship It! - Renjith Kamath On Dec. 14, 2016, 6:50

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/ --- (Updated Dec. 14, 2016, 6:50 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53686: Stage and Request status should be persisted in the database

> On Nov. 14, 2016, 5:03 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java, > > lines 226-230 > > > > > > Won't be performant on large numbers of tasks

Re: Review Request 53686: Stage and Request status should be persisted in the database

> On Nov. 14, 2016, 5:03 p.m., Nate Cole wrote: > > Is this effort spanning multiple jira? I was hoping we would be able to > > optimize queries against the database if we need to recalculate status. > > When tasks are completed can we compute the status of the whole based on > > just the

Re: Review Request 53686: Stage and Request status should be persisted in the database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Dec. 14, 2016, 2:11 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

> On Dec. 12, 2016, 7:25 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 237 > > > > > > Will this work with multi-level inheritence? > >

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/ --- (Updated Dec. 13, 2016, 10:38 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54721: Add common log rotation settings to YARN configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54721/#review159066 --- Ship it! Ship It! - Sumit Mohanty On Dec. 13, 2016, 10:31

Re: Review Request 54690: Remove HSI host name from UI

> On Dec. 13, 2016, 6:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml, > > line 46 > > > > > > Should we mark this

Re: Review Request 54640: LogSearch - generate default jks file on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/ --- (Updated Dec. 13, 2016, 7:23 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54704/#review159047 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 13, 2016,

Re: Review Request 54675: AMBARI-19178 HostCleanup can't list process details on RHEL7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54675/#review159046 --- Ship it! Ship It! - Tim Thorpe On Dec. 12, 2016, 9:11 p.m.,

Re: Review Request 54640: LogSearch - generate default jks file on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/ --- (Updated Dec. 13, 2016, 7:09 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 54640: LogSearch - generate default jks file on startup

> On Dec. 13, 2016, 2:44 p.m., Robert Levas wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java, > > line 171 > > > > > > Missing JavaDoc i did not

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54704/ --- (Updated Dec. 13, 2016, 6:54 p.m.) Review request for Ambari, Aleksandr

Re: Review Request 54709: Use released Helix 0.6.6 instead of 0.7.1 beta as AMS dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54709/#review159042 --- Please make sure to test kerberized cluster with this version.

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review159040 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 13, 2016,

Re: Review Request 54690: Remove HSI host name from UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54690/#review159037 ---

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54674/#review159032 --- Ship it! Ship It! - Jonathan Hurley On Dec. 12, 2016, 3:01

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 3:26 p.m., Robert Levas wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 38 > > > > > > This test suite should use mocks (example,

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159027 ---

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54704/ --- (Updated Dec. 13, 2016, 4:52 p.m.) Review request for Ambari, Aleksandr

Review Request 54709: Use released Helix 0.6.6 instead of 0.7.1 beta as AMS dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54709/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

> On Dec. 12, 2016, 9:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Re: Review Request 53686: Stage and Request status should be persisted in the database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review158848 ---

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review159015 --- Fix it, then Ship it!

Review Request 54707: Metrics Collector Move Wizard should no longer Restart All Services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54707/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19191

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159008 --- Most of this looks pretty good, however the flow seems like it

Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support for Hive2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54706/ --- (Updated Dec. 13, 2016, 3:20 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54640: LogSearch - generate default jks file on startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54640/#review159001 --- Fix it, then Ship it! Ship It!

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

> On Dec. 12, 2016, 3:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Re: Review Request 54698: Disable security hook

> On Dec. 13, 2016, 2:15 p.m., Laszlo Puskas wrote: > > ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkMigrator.java, line > > 31 > > > > > > You could use the org.apache.commons.cli framework to handle the

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159000 ---

Review Request 54695: NameNode JVM has many parameters repeated 3 or more times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54695/ --- Review request for Ambari. Bugs: AMBARI-19185

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

> On Dec. 12, 2016, 9:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

> On Dec. 12, 2016, 9:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/ --- Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Oliver Szabo, Robert

Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54704/ --- Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. Bugs:

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review158995 ---

Re: Review Request 54703: Add host component should show configs being changed in recommendation popup modal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54703/#review158994 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 13, 2016,

Review Request 54703: Add host component should show configs being changed in recommendation popup modal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54703/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19189

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

> On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > One thing I'm not clear on is how this will affect an existing > > installation. Won't Ranger have a problem if you change the name of a repo > > on an already running cluster? Reverting the logic > On Dec. 8, 2016, 2:37 p.m.,

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 13, 2016, 12:40 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review158993 --- Ship it! Ship It! - Renjith Kamath On Dec. 10, 2016, 3:13

Re: Review Request 54543: AMBARI-19140 Ambari Server symbolic links has double // when root dir is just /

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54543/#review158988 --- Ship it! Ship It! - Andrew Onischuk On Dec. 12, 2016, 7:58

Re: Review Request 54666: DB configs consistency check failed after disable kerberos or Ambari upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54666/#review158984 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 13, 2016,

Re: Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54413/#review158983 --- Ship it! Ship It! - Nitiraj Rathore On Dec. 9, 2016, 11:05

Re: Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54413/#review158982 --- Ship it! Ship It! - Pallav Kulshreshtha On Dec. 9, 2016,

Re: Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54413/#review158981 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Dec. 9, 2016, 11:05

Re: Review Request 54583: New REST API in Log Search Portal that returns the log files of the host components

> On Dec. 12, 2016, 4:01 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java, > > line 95 > > > > > > Minor spelling issue: > >

Re: Review Request 54583: New REST API in Log Search Portal that returns the log files of the host components

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54583/ --- (Updated Dec. 13, 2016, 10:19 a.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 54679: Perf: Deploy 3000 Agent cluster and find perf bugs.Part 3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54679/#review158978 --- Ship it! Ship It! - Dmytro Sen On Дек. 12, 2016, 10:43

Re: Review Request 54583: New REST API in Log Search Portal that returns the log files of the host components

> On Dec. 11, 2016, 11:15 p.m., Oliver Szabo wrote: > > ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/HostLogFilesRequestQueryConverterTest.java, > > line 54 > > > > > >