Re: Review Request 55615: Hive View 2.0: Show query logs

2017-01-19 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55615/ --- (Updated Jan. 20, 2017, 7:44 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 55729: Log Search: add snapshot feature to Tours

2017-01-19 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55729/#review162391 --- Ship it! Ship It! - Miklos Gergely On Jan. 19, 2017, 8:44

Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

2017-01-19 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55718/ --- (Updated Jan. 20, 2017, 5:55 a.m.) Review request for Ambari, belliraj hb,

Re: Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

2017-01-19 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55733/#review162380 --- Ship it! Ship It! - Xi Wang On Jan. 19, 2017, 3:26 p.m.,

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/#review162379 --- Ship it! Ship It! - Jayush Luniya On Jan. 19, 2017, 10:40

Re: Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

2017-01-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55739/#review162373 --- Ship it! Ship It! - Sumit Mohanty On Jan. 20, 2017, 1:01

Re: Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

2017-01-19 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55739/ --- (Updated Jan. 20, 2017, 1:01 a.m.) Review request for Ambari, Alejandro

Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

2017-01-19 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55739/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 55737: Improve delete logging for topology artifacts

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55737/#review162370 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 20, 2017,

Re: Review Request 55737: Improve delete logging for topology artifacts

2017-01-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55737/#review162369 --- Ship it! Ship It! - Sumit Mohanty On Jan. 20, 2017, 12:07

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 19, 2017, 11:49 p.m., Alejandro Fernandez wrote: > > Ship It! Thank you Alejandro, I don't have commit rights on trunk. Could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To

Review Request 55737: Improve delete logging for topology artifacts

2017-01-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55737/ --- Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty. Bugs:

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/#review162367 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017,

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162365 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017,

Re: Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55733/#review162364 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017,

Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

2017-01-19 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55733/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-19637

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/#review162358 --- The patches fix the problem with starting Zeppelin without Hive.

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 19, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml, > > line 75 > > > > > > This is also needed in ZK 3.4.9

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Swapan Shridhar
> On Jan. 19, 2017, 8:29 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 285 > > > > > > Please don't hard code

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/ --- (Updated Jan. 19, 2017, 10:40 p.m.) Review request for Ambari, Alejandro

Re: Review Request 55700: Ranger load balancer url needs to be updated for dependent properties during HA

2017-01-19 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55700/#review162348 --- Ship it! Ship It! - Jaimin Jetly On Jan. 19, 2017, 2:39

Re: Review Request 55729: Log Search: add snapshot feature to Tours

2017-01-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55729/#review162345 --- Ship it! Ship It! - Robert Nettleton On Jan. 19, 2017, 8:44

Review Request 55729: Log Search: add snapshot feature to Tours

2017-01-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55729/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 55728: accordion classname missed on configs page

2017-01-19 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55728/#review162343 --- Ship it! Ship It! - Denys Buzhor On Jan. 19, 2017, 8:21

Review Request 55728: accordion classname missed on configs page

2017-01-19 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55728/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19633

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55698/#review162342 --- Ship it! Ship It! - Nate Cole On Jan. 19, 2017, 2:03 p.m.,

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162341 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 8:49

Re: Review Request 53686: Stage and Request status should be persisted in the database

2017-01-19 Thread Jaimin Jetly
On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote: > > One thing I don't quite see here (and it could be due to the size of the > > patch) is what happens in these two cases: > > - Something goes wrong when trying to store a task's status. How does the > > system recover and mark it completed? >

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- (Updated Jan. 19, 2017, 7:49 p.m.) Review request for Ambari, Attila

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- (Updated Jan. 19, 2017, 7:43 p.m.) Review request for Ambari, Attila

Re: Review Request 55663: Add support for call context to the stack advisor

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55663/#review162336 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 18, 2017,

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162335 --- Fix it, then Ship it!

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55698/#review162334 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017,

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-19 Thread bikas
> On Jan. 18, 2017, 8:59 p.m., bikassaha wrote: > > Should the URL for recovery be something like > > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS > > dir seems distracting. > > Saisai Shao wrote: > It will not be in the top level HDFS dirs. It will be in

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55698/ --- (Updated Jan. 19, 2017, 2:03 p.m.) Review request for Ambari, Alejandro

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55724/#review162329 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017,

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55724/#review162328 --- Ship it! Ship It! - Jonathan Hurley On Jan. 19, 2017, 12:59

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55724/#review162326 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 6:59

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Jonathan Hurley
> On Jan. 19, 2017, 1:04 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > lines 2456-2460 > > > > > > This pattern is used at

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 18, 2017, 7:05 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml, > > line 238 > > > > > > This annotation is missing in

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- (Updated Jan. 19, 2017, 6:16 p.m.) Review request for Ambari, Di Li, Jaimin

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

2017-01-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55515/#review162323 --- Ship it! Ship It! - Nate Cole On Jan. 13, 2017, 2:03 p.m.,

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55698/#review162322 ---

Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55724/ --- Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

2017-01-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55698/ --- (Updated Jan. 19, 2017, 11:54 a.m.) Review request for Ambari, Alejandro

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/ --- (Updated Jan. 19, 2017, 3:58 p.m.) Review request for Ambari, Alejandro

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Renjith Kamath
> On Jan. 19, 2017, 1:35 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, > > line 153 > > > > > > Since the path is fixed (not a

Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

2017-01-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55720/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19615

Re: Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

2017-01-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55720/#review162298 --- Ship it! Ship It! - Tim Thorpe On Jan. 19, 2017, 3:46 p.m.,

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55680/#review162278 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 1:39

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/#review162277 ---

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- (Updated Jan. 19, 2017, 1:09 p.m.) Review request for Ambari, Miklos Gergely

Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

2017-01-19 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55718/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-19 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/#review162276 --- Ship it! Ship It! - Miklos Gergely On Jan. 19, 2017, 12:52

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/#review162275 --- Ship it! Ship It! - Prabhjyot Singh On Jan. 19, 2017, 12:41

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- (Updated Jan. 19, 2017, 12:52 p.m.) Review request for Ambari, Miklos Gergely

Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- (Updated Jan. 19, 2017, 12:41 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-19 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55680/ --- (Updated Jan. 19, 2017, 12:39 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 55716: LLAP Startup: slider dependencies are not deployed by Ambari

2017-01-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55716/#review162273 --- Ship it! Ship It! - Dmitro Lisnichenko On Jan. 19, 2017,

Review Request 55716: LLAP Startup: slider dependencies are not deployed by Ambari

2017-01-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55716/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19626

Re: Review Request 55615: Hive View 2.0: Show query logs

2017-01-19 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55615/#review162270 ---

Re: Review Request 55615: Hive View 2.0: Show query logs

2017-01-19 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55615/ --- (Updated Jan. 19, 2017, 11:24 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 55711: Admin View: add spinners for tables in loading state

2017-01-19 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55711/#review162268 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 19, 2017,

Review Request 55711: Admin View: add spinners for tables in loading state

2017-01-19 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55711/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-19625

Re: Review Request 55707: AMBARI-19622: Need abilities to add a custom action node and import a workflow xml with custom action

2017-01-19 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55707/#review162262 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 19, 2017, 6:54

Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

2017-01-19 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review162259 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 17, 2017, 9:45

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/#review162255 ---

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162254 --- Fix it, then Ship it!