Re: Review Request 57515: Zeppelin: Spark2 and Livy2 interpreter config disappear during stack upgrade

2017-03-10 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57515/#review168702 --- Ship it! Ship It! - Prabhjyot Singh On March 10, 2017, 11:17

Re: Review Request 57523: AMBARI-20403 : Yarn Container metrics are not being collected by AMS

2017-03-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57523/#review168697 --- Ship it! Ship It! - Sid Wagle On March 10, 2017, 11:51 p.m.,

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57521/ --- (Updated March 10, 2017, 8:29 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57526/#review168695 --- Ship it! Ship It! - Jaimin Jetly On March 11, 2017, 12:48 a.

Re: Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57526/#review168692 --- Ship it! Ship It! - Richard Zang On March 11, 2017, 12:48 a.

Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57526/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. Bugs: A

Review Request 57525: Assign Slaves and Clients page displays incorrect configuration unless a change is made in Assign Masters page

2017-03-10 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57525/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-20402

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57521/#review168687 --- Ship it! Ship It! - Robert Levas On March 10, 2017, 5:09 p.m

Review Request 57523: AMBARI-20403 : Yarn Container metrics are not being collected by AMS

2017-03-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57523/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57521/#review168682 --- Ship it! Ship It! - Alejandro Fernandez On March 10, 2017, 1

Review Request 57521: HOU wizard wrongly shows hosts with only client components at the start of 'Upgrade Hosts' group

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57521/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, and Robert Leva

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley
> On March 10, 2017, 10:40 a.m., Jonathan Hurley wrote: > > Ship It! > > Anita Jebaraj wrote: > Thank you Jonathan for reviewing, I had to update the patch since there > was an unnecessarily check lingering around in the patch, > +if(propertiesToHideInResponse != null) { >

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/#review168672 --- Ship it! Ship It! - Jonathan Hurley On March 10, 2017, 2:59

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- (Updated March 10, 2017, 7:59 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- (Updated March 10, 2017, 7:58 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-10 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57461/ --- (Updated March 10, 2017, 7:38 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley
> On March 10, 2017, 1:47 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > > Lines 200-202 (patched) > > > > > > Shouldn't all metadata be refreshed in th

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan
> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > > Lines 198 (patched) > > > > > > This log statement isn't very helpful (since

Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/#review168646 --- ambari-server/src/main/java/org/apache/ambari/server/events/liste

Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters

2017-03-10 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty. B

Re: Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57509/#review168644 --- Ship it! Ship It! - Sumit Mohanty On March 10, 2017, 4:34 p.

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-10 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57463/#review168639 --- Ship it! Ship It! - Tim Thorpe On March 10, 2017, 4:44 p.m.,

Review Request 57515: Zeppelin: Spark2 and Livy2 interpreter config disappear during stack upgrade

2017-03-10 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57515/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMI

Re: Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57509/#review168634 --- Ship it! Ship It! - Sid Wagle On March 10, 2017, 4:34 p.m.,

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-10 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57463/ --- (Updated March 10, 2017, 4:44 p.m.) Review request for Ambari and Tim Thorpe.

Review Request 57509: Few Ambari Metrics configs don't have `property_value_attributes.type`

2017-03-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57509/ --- Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi Brodetsky

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57461/#review168628 --- Fix it, then Ship it! Overall, the patch looks fine to me. I h

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj
> On March 10, 2017, 3:40 p.m., Jonathan Hurley wrote: > > Ship It! Thank you Jonathan for reviewing, I had to update the patch since there was an unnecessarily check lingering around in the patch, +if(propertiesToHideInResponse != null) { this wont be required now since its assigned

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168626 --- Ship it! Ship It! - Jonathan Hurley On March 10, 2017, 10:34

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj
> On March 8, 2017, 6:44 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 4314-4336 (patched) > > > > > > This reads from the stream on

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj
> On March 10, 2017, 2:05 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 4356 (patched) > > > > > > Can you initialize this on the fi

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/ --- (Updated March 10, 2017, 3:34 p.m.) Review request for Ambari, Di Li, Jaimin Je

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/#review168620 --- Ship it! Ship It! - Robert Levas On March 10, 2017, 8:53 a.m

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

2017-03-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168610 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/ --- (Updated March 10, 2017, 1:53 p.m.) Review request for Ambari, Balázs Bence Sár

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/#review168609 --- Ship it! Ship It! - Balázs Bence Sári On March 10, 2017, 12:

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/#review168608 --- Ship it! Ship It! - Sebastian Toader On March 10, 2017, 1:36

Re: Review Request 57508: AMBARI-20383.Not able to view the error log details on UI

2017-03-10 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57508/#review168604 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 12:42 p.m

Review Request 57508: AMBARI-20383.Not able to view the error log details on UI

2017-03-10 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57508/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pall

Re: Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/ --- (Updated March 10, 2017, 12:36 p.m.) Review request for Ambari, Balázs Bence Sá

Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/ --- Review request for Ambari and Jaimin Jetly. Bugs: ambari-20388 https://issu

Review Request 57506: Penetration test: Missing Content-Type header of woff/ttf files

2017-03-10 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57506/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and S

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57504/#review168601 --- Ship it! Ship It! - Miklos Gergely On March 10, 2017, 11:34

Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168600 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 10, 2017, 11:4

Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168599 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 11:44 a.m

Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures

2017-03-10 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pall

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57504/#review168598 --- Ship it! Ship It! - Attila Magyar On March 10, 2017, 11:34 a

Re: Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57504/#review168597 --- Ship it! Ship It! - Attila Doroszlai On March 10, 2017, 12:3

Review Request 57504: Fix typo in alert-definitions doc file

2017-03-10 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57504/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, and Miklos Gergely.

Re: Review Request 57465: RU: Slider service check failed during rolling upgrade

2017-03-10 Thread Dmitro Lisnichenko
> On March 9, 2017, 9:16 p.m., Jonathan Hurley wrote: > > I saw you removed `export HADOOP_CONF_DIR={{hadoop_conf_dir}}`. I'm > > guessing that since you moved SLIDER in the upgrade packs, it wasn't needed > > anymore. Still, seems like it should have it, no? If Slider is restarted before serv

Re: Review Request 57465: RU: Slider service check failed during rolling upgrade

2017-03-10 Thread Dmitro Lisnichenko
> On March 9, 2017, 11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > > Line 463 (original) > > > > > > Is this because Slider has dependencies on Stor