Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Madhuvanthi Radhakrishnan
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > > Lines 219 (patched) > > > > > > We should not

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 12, 2017, 4:54 a.m.) Review request for Ambari, Jonathan

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-11 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58228/ --- (Updated Квітень 12, 2017, 1:14 до полудня) Review request for Ambari,

Re: Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line

2017-04-11 Thread yao lei
> On 四月 11, 2017, 5:37 p.m., Alejandro Fernandez wrote: > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > > Line 170 (original), 175 (patched) > > > > > > Insert a space after the

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

2017-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58363/ --- (Updated April 11, 2017, 8:55 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

2017-04-11 Thread Jonathan Hurley
> On April 11, 2017, 2:05 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > > Lines 31 (patched) > > > > > > Can we shorten this to

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171651 ---

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171649 ---

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171648 ---

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

2017-04-11 Thread Nate Cole
> On April 11, 2017, 2:05 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > > Lines 31 (patched) > > > > > > Can we shorten this to

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
> On April 11, 2017, 10:14 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 45 (patched) > > > > > > Can this be None as opposed to

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171643 ---

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171639 ---

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 11, 2017, 9:50 p.m.) Review request for Ambari, Jonathan

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 49 (patched) > > > > > > This should actually be False by

Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View

2017-04-11 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58371/ --- Review request for Ambari, Jaimin Jetly, Sangeeta Ravindran, and Tim Thorpe.

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > > Lines 219 (patched) > > > > > > We should not

Re: Review Request 58264: hive maybe not rely on slider

2017-04-11 Thread Jaimin Jetly
> On April 11, 2017, 2:51 a.m., Jaimin Jetly wrote: > > Enabling interactive query for Hive which installs HiveServer2 interactive > > host component and deploys LLAP requires slider service. > > That's the reason for slider being as a dependency for Hive. > > > > I doubt hive service check

Re: Review Request 58260: AMBARI-20700 - UI should use the URL as-given by the backend

2017-04-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58260/#review171626 --- Ship it! Ship It! - Xi Wang On April 6, 2017, 11 p.m.,

Review Request 58367: Allow Potentially Long Running Restart Commands To Have Their Own Timeout

2017-04-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58367/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/#review171616 --- Fix it, then Ship it!

Re: Review Request 58322: Small fixes in Log Search

2017-04-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58322/#review171612 --- Ship it! Ship It! - Robert Nettleton On April 10, 2017,

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

2017-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/#review171605 --- Ping. Can this review be closed? - Jonathan Hurley On March

Re: Review Request 58297: Add stab registering and heartbeating routine via stomp async calls.

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58297/#review171604 --- Fix it, then Ship it! Fix It and Ship It

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/#review171602 ---

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58228/#review171599 --- Ship it! Ship It! - Alejandro Fernandez On April 11, 2017,

Re: Review Request 58264: hive maybe not rely on slider

2017-04-11 Thread Alejandro Fernandez
> On April 10, 2017, 5:09 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml > > Line 495 (original) > > > > > > Let's also make the same change for

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/#review171595 ---

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/#review171594 ---

Re: Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58363/#review171591 ---

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review171588 --- Pushed to trunk, commit 69c55935a57252e3490bfed6905b1bb2fb8ce86d

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review171587 --- Ship it! Ship It! - Alejandro Fernandez On April 9, 2017,

Re: Review Request 58256: Support creating/editing alert dispatch targets for script-based alert dispatchers by web wizard instead of command line

2017-04-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58256/#review171586 --- Fix it, then Ship it!

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

2017-04-11 Thread Jayush Luniya
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 49 (patched) > > > > > > This should actually be False by

Review Request 58363: Upgrade Catalog 2.5.1 Changes For HRC Background Task

2017-04-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58363/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-20714

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-11 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58228/ --- (Updated Квітень 11, 2017, 3:41 після полудня) Review request for Ambari,

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/ --- (Updated April 11, 2017, 6:22 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/ --- (Updated April 11, 2017, 6:21 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/ --- (Updated April 11, 2017, 6:21 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 57945: Log Search Configuration API

2017-04-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 11, 2017, 3:18 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 58237: Add Stomp client adapter

2017-04-11 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58237/#review171564 --- Ship it! Ship It! - Aleksandr Kovalenko On Апрель 6, 2017,

Re: Review Request 58354: Handle caching of topologies, configs and metadata

2017-04-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58354/#review171562 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 11,

Re: Review Request 57945: Log Search Configuration API

2017-04-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 11, 2017, 2:08 p.m.) Review request for Ambari, Oliver Szabo

Review Request 58354: Handle caching of topologies, configs and metadata

2017-04-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58354/ --- Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58346/#review171558 --- Ship it! Ship It! - Dmitro Lisnichenko On April 11, 2017,

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-11 Thread zhangxiaolu zhangxiaolu
> On 三月 20, 2017, 5:31 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > > Lines 59 (patched) > > > > > > Python unit tests are failing.

Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-11 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58346/ --- Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi

Re: Review Request 58345: Remove duplicate condition from route

2017-04-11 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58345/#review171553 --- Ship it! Ship It! - Denys Buzhor On April 11, 2017, 10:59

Review Request 58345: Remove duplicate condition from route

2017-04-11 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58345/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20732

Re: Review Request 58297: Add stab registering and heartbeating routine via stomp async calls.

2017-04-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58297/ --- (Updated April 11, 2017, 10:57 a.m.) Review request for Ambari, Alejandro

Re: Review Request 58341: Issue while adding custom job.properties

2017-04-11 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/#review171549 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 10:10

Re: Review Request 58341: Issue while adding custom job.properties

2017-04-11 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/#review171548 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 10:10

Review Request 58341: Issue while adding custom job.properties

2017-04-11 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav

Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

2017-04-11 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58335/#review171547 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 7:23

Re: Review Request 58339: Need way to explicitly ask for workflow name

2017-04-11 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58339/#review171546 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 9:52

Re: Review Request 58339: Need way to explicitly ask for workflow name

2017-04-11 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58339/#review171545 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 9:52

Review Request 58339: Need way to explicitly ask for workflow name

2017-04-11 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58339/ --- Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.

Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

2017-04-11 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58335/#review171534 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 7:23

Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes

2017-04-11 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58335/ --- Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary.

Re: Review Request 58293: Need a way to indicate the action node type in workflow manager

2017-04-11 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58293/#review171523 --- Ship it! Ship It! - Padma Priya N On April 10, 2017, 11:06