(patched)
<https://reviews.apache.org/r/58840/#comment246368>
Why introduce a dependency on perl?
Can't this be done with shell script or python so it's consistent with the
rest of Ambari?
- Alejandro Fernandez
On April 28, 2017, 4:21 p.m., Attila
/DatabaseConsistencyCheckHelper.java
Lines 563 (patched)
<https://reviews.apache.org/r/58802/#comment246303>
Use ==
- Alejandro Fernandez
On April 27, 2017, 4:16 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58802/#review173264
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58814/#review173263
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 27, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58815/#review173262
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 27, 2017
> On April 26, 2017, 6:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
> > Lines 510 (patched)
> > <https://reviews.apache.org/r/58497/diff/2-3/?file=1699268#file1699268line510>
&g
--
Total run:1169
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
:1169
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
> On April 26, 2017, 5:59 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
> > Lines 170 (patched)
> > <https://reviews.apache.org/r/58411/diff/2/?file=1700639#file1700639
unit tests passed,
Ran 272 tests in 6.935s
OK
--
Total run:1169
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58480/#review173091
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 26, 2017
/0.5.0.2.3/package/scripts/kms.py
Lines 510 (patched)
<https://reviews.apache.org/r/58497/#comment246144>
I think you still need has_hdfs_client_on_node
- Alejandro Fernandez
On April 26, 2017, 9:56 a.m., Mugdha Varadkar
/configuration/gateway-site.xml
Line 61 (original), 61 (patched)
<https://reviews.apache.org/r/58735/#comment246143>
Does this value have to change for existing clusters?
If so, should an Ambari Upgrade modify the property if unkerberized.
- Alejandro Fernandez
On April 26, 2017
AlertState.java
- Alejandro Fernandez
On April 26, 2017, 5:45 p.m., Qin Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
t, and only
then run the commands.
Also, add a comment as to why this is needed
- Alejandro Fernandez
On April 25, 2017, 12:12 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172964
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2017
/metainfo.xml
Line 495 (original)
<https://reviews.apache.org/r/58264/#comment245997>
-1
Right now HDP 3.0 in its current form does require Slider for LLAP.
- Alejandro Fernandez
On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58699/#review172958
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172957
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2017
-DDL-Oracle-CREATE.sql
Lines 387 (patched)
<https://reviews.apache.org/r/58590/#comment245908>
VARCHAR2
- Alejandro Fernandez
On April 24, 2017, 11:35 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58685/#review172863
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58675/#review172855
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172854
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58679/#review172837
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
rvices/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
Lines 304 (patched)
<https://reviews.apache.org/r/58497/#comment245321>
Let's check > 0
- Alejandro Fernandez
On April 18, 2017, 7:51 a.m., Mugdha Varadkar wrote:
>
> --
/ambari_agent/Controller.py
Lines 611 (patched)
<https://reviews.apache.org/r/58665/#comment245862>
This would fail with a version that contains more than 1 digit between dots.
Change to [\d+.]+
- Alejandro Fernandez
On April 24, 2017, 12:41 p.m., Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58674/#review172817
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java
Lines 43 (patched)
<https://reviews.apache.org/r/58578/#comment245854>
Add Javadoc.
- Alejandro Fernandez
On April 20, 2017, 4:21 p.m., Miklos Gergely
197 (patched)
<https://reviews.apache.org/r/58667/#comment245851>
instead of raising the exception, just log the message.
- Alejandro Fernandez
On April 24, 2017, 2:45 p.m., Eugene Chekanskiy wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58668/#review172806
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58671/#review172805
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017
ATION
Diff: https://reviews.apache.org/r/58634/diff/2/
Changes: https://reviews.apache.org/r/58634/diff/1-2/
Testing
---
Verified UI showed HBase in HDP 3.0
Thanks,
Alejandro Fernandez
iff/1/
Testing
---
Verified UI showed HBase in HDP 3.0
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58629/#review172710
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 21, 2017
> On April 20, 2017, 9:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/58590/diff/1/?file=1695868#file1695868line72>
> >
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58617/#review172688
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 21, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/#review172552
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 20, 2017
nction
in python, which is not necessarily very human readable.
- Alejandro Fernandez
On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/AmbariContext.java
Lines 430 (patched)
<https://reviews.apache.org/r/58568/#comment245637>
Why does core-site need special handling?
- Alejandro Fernandez
On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58576/#review172527
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 20, 2017
/package/scripts/service_check.py
Lines 30 (patched)
<https://reviews.apache.org/r/58562/#comment245635>
Is Logsearch Server an optional component?
How is it possible to have the LogSearch service but not the server?
- Alejandro Fernandez
On April 20, 2017, 11:51 a.m., Miklos G
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58555/#review172524
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 20, 2017
/ClusterDAO.java
Lines 380 (patched)
<https://reviews.apache.org/r/58577/#comment245625>
+1 for version tag
- Alejandro Fernandez
On April 20, 2017, 3:41 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically g
Verified on a live cluster (except Spark which is still not ready from the RPM
perspective)
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58492/#review172395
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 19, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58538/#review172379
---
Ship it!
Good find!
- Alejandro Fernandez
On April 19, 2017
e should be added to this file.
- Alejandro Fernandez
On April 19, 2017, 5:25 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
/functions/stack_tools.py
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/58489/#comment245266>
Why would service_name be the string "null"?
- Alejandro Fernandez
On April 18, 2017, 12:31 a.m., Madhuvanthi Rad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172158
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 17, 2017
ent245238>
Technically, 3rd argument is the version instead of the repo
- Alejandro Fernandez
On April 17, 2017, 9:22 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
- Alejandro Fernandez
On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/0.96.0.2.0/package/scripts/hbase.py
Line 115 (original)
<https://reviews.apache.org/r/57451/#comment245174>
Just curious, did someone from the Hbase project confirm this change?
- Alejandro Fernandez
On April 14, 2017, 4:52 a.m., zhangxiaolu zhangxiaolu
/stack_advisor.py
Lines 253 (patched)
<https://reviews.apache.org/r/58438/#comment245173>
Same comments, doc needs to be updated.
Also, the Code Review title should say 3.0
- Alejandro Fernandez
On April 13, 2017, 11:08 p.m., Swapan Shridhar
> On April 17, 2017, 4:39 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
> > Lines 28 (patched)
> > <https://reviews.apache.org/r/58437/diff/2/?file=1692483#file1692483line28>
> >
s is allowed to
return None.
- Alejandro Fernandez
On April 13, 2017, 11:08 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171944
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 13, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review171943
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 13, 2017
un:1192
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171753
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 12, 2017
t;
> >
> > `` should be closed by ``, not ``.
>
> Alejandro Fernandez wrote:
> I read this too quickly, you're right.
> Masahiro, can you submit a patch to fix this. I will revert it for now.
Actually, looks like already reverted in commit
To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
>
> (Updated April 9, 2017, 7:03 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku
> Sako.
>
>
> Bugs: AM
/0.96.0.2.0/package/scripts/hbase.py
Lines 67 (patched)
<https://reviews.apache.org/r/57451/#comment244764>
I've actually never seen this, so perhaps a more appropriate fix would be
in HDFS Client instead.
HDFS Client itself should ensure that the hadoop conf dir exists.
- Alejandro Fer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58256/#review171745
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 12, 2017
/functions/stack_tools.py
Lines 45 (patched)
<https://reviews.apache.org/r/58277/#comment244619>
Can this be None as opposed to the String "None"
- Alejandro Fernandez
On April 11, 2017, 9:50 p.m., Madhuvanthi Rad
s/functions/version_select_util.py
Lines 102 (patched)
<https://reviews.apache.org/r/58277/#comment244612>
Perhaps check that code is 0 and file length is non-zero before getting
file contents.
- Alejandro Fernandez
On April 11, 2017, 9:50 p.m., Madhuvanthi Ra
/main/python/ambari_agent/HeartbeatThread.py
Lines 48 (patched)
<https://reviews.apache.org/r/58297/#comment244550>
Generally, add documentation to all classes and functions.
- Alejandro Fernandez
On April 11, 2017, 10:57 a.m., Andrew Onischuk
ario
OR
2. look for a fix in HDFS Client so that it doesn't fail if hadoop conf dir
doesn't exist.
I prefer option #2 since components should all be idempotent.
How frequently does this happen? Is it only during UI, or BP installs?
- Alejandro Fernandez
On Apr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58228/#review171599
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 11, 2017
ent/src/main/python/ambari_agent/listeners/__init__.py
Lines 26 (patched)
<https://reviews.apache.org/r/58354/#comment244543>
Add doc
- Alejandro Fernandez
On April 11, 2017, 2:04 p.m., Andrew Onischuk wrote:
>
> ---
&g
> On April 10, 2017, 5:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml
> > Line 495 (original)
> > <https://reviews.apache.org/r/58264/diff/1/?file=1686482#file1686482line495>
> >
> >
he.org/r/58208/#comment244538>
Should we have a hard limit, if more than say 5 mins, then abort so we can
avoid an infinite loop.
- Alejandro Fernandez
On April 11, 2017, 3:22 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an
/script/script.py
Lines 323 (patched)
<https://reviews.apache.org/r/58208/#comment244536>
Nevermind, I see you meant prefix or suffix.
- Alejandro Fernandez
On April 11, 2017, 3:22 p.m., Dmitro Lisnichenko wrote:
>
> ---
>
Add some doc.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
Line 24 (original), 24 (patched)
<https://reviews.apache.org/r/58208/#comment244533>
Can we remove this import *?
- Alejandro Fernandez
On April 11, 2017, 3:22 p.
/UpgradeCatalog251.java
Lines 31 (patched)
<https://reviews.apache.org/r/58363/#comment244531>
Can we shorten this to "is_background"?
- Alejandro Fernandez
On April 11, 2017, 4:52 p.m., Jonathan Hurley wrote:
>
> --
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49>
> >
> &g
- Alejandro Fernandez
On April 9, 2017, 7:03 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171587
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 9, 2017, 7
/manage_alert_notifications_controller.js
Line 170 (original), 175 (patched)
<https://reviews.apache.org/r/58256/#comment244527>
Insert a space after the comma
- Alejandro Fernandez
On April 7, 2017, 2:16 a.m., yao lei
issing, throw an error.
Right now, this will pass if stay stack_selector_path is non null but
component_name is null
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/58277/#co
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review171446
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 7, 2017, 4
-services/HIVE/2.1.0.3.0/metainfo.xml
Line 495 (original)
<https://reviews.apache.org/r/58264/#comment244383>
Let's also make the same change for Hive 3.0
- Alejandro Fernandez
On April 7, 2017, 3:07 p.m., zhangxiaolu zhangx
/configuration/hive-env.xml
Line 97 (original), 97 (patched)
<https://reviews.apache.org/r/57687/#comment244177>
Let's keep the property then, but mark it as deleted.
true
Also, perform the same change for Hive 3.0.0 in common-services
- Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171283
---
Pushed to trunk
- Alejandro Fernandez
On April 5, 2017, 11:45
> On April 6, 2017, 11:06 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
> > Lines 306 (patched)
> > <https://reviews.apache.org/r/58228/diff/2/?file=1685791#file1685791line308>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171274
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 5, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58240/#review171273
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 6, 2017, 6
ual clusters deployed via BP and that have
undergone EU/RU?
- Alejandro Fernandez
On April 6, 2017, 11:05 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/#review171258
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 6, 2017, 8
ng.format
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExecutionCommandDAO.java
Lines 64 (patched)
<https://reviews.apache.org/r/58228/#comment244072>
Does this need a limit with a WHERE clause?
- Alejandro Fernandez
On April 6, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58218/#review171173
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 5, 2017
/internal/UpgradeItemResourceProvider.java
Lines 264 (patched)
<https://reviews.apache.org/r/58218/#comment244046>
Let's remove dead code
- Alejandro Fernandez
On April 5, 2017, 8:40 p.m., Jonathan Hurley wrote:
>
> ---
/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 525 (patched)
<https://reviews.apache.org/r/58122/#comment244037>
Missing spaces after the periods
- Alejandro Fernandez
On April 5, 2017, 4:58 p.m., Amruta Borkar
Does it make sense to also call this function during any restart command?
- Alejandro Fernandez
On April 5, 2017, 12:27 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
/package/scripts/hdfs.py
Line 132 (original)
<https://reviews.apache.org/r/58198/#comment244034>
If it does have to be removed, same should be done fo r HDFS 3.0
- Alejandro Fernandez
On April 5, 2017, 5:52 a.m., zhangxiaolu zhangxiaolu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58180/#review170991
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 4, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58148/#review170951
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 3, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58002/#review170950
---
Ship it!
Ship It!
- Alejandro Fernandez
On March 28, 2017
/internal/BlueprintConfigurationProcessor.java
Lines 523 (patched)
<https://reviews.apache.org/r/58122/#comment243784>
Warnings are going to be ignored. Let's change logger level to error
- Alejandro Fernandez
On April 3, 2017, 10:42 p.m., Amruta B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58149/#review170936
---
Ship it!
Ship It!
- Alejandro Fernandez
On April 3, 2017, 2
, 11:50 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58129/
> ---
>
> (Updated March 31, 2017, 11:50 p.m.)
>
>
> Rev
301 - 400 of 1678 matches
Mail list logo
